i18n-cocoa 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cf33f6d55b0323e9fc5c980f82f3e59515ac2a50
-  data.tar.gz: c00f49d7b1c616a240b2885827389361f238837c
+  metadata.gz: 5fb89f4fc53709c2d624e976a3284b20e6946387
+  data.tar.gz: 4dc100da833def9078cc5f3ff16bd166dfcf1ec1
 SHA512:
-  metadata.gz: eb33bc5501a7feb7ba5c11d68cdb76fec4d95864bc5a67af5a0eb72d87c828bc524978a77874be78892f23e1f0d04122d01312788585c800ae32284ac6ab430d
-  data.tar.gz: 7c092cad942b9e6825af738ab9c745b3b991ead3e28ab53d6a8b93553035579733a2d7739d2ab33ae4159f6cbcfa7011ae89a296b656297ce9f1152bd5427a15
+  metadata.gz: 5d5a4582799d1018027ca73f2c0807cebf7c80c76803109d2ecd9f3efbfe6172e4a51651650e5a0e008c2ba49fb46399934595e2188e0b2537d7bc462f362230
+  data.tar.gz: 3520e52f7973b64a405ae2780de1eff0737d728828bd803aa8294d7e980f863dfb6a8dea1fcf5fa55aace35cf69f9df0f444e95f27f6f0e5b2ef5d6393b94b45

data/lib/i18n/cocoa/finder.rb

@@ -1,34 +1,31 @@
 # encoding: utf-8
-require 'pp'
 
 module I18n
   module Cocoa
 
     class Finder
 
-      def initialize localized_macro_string='NSLocalizedString'
-        @localized_macro_string = localized_macro_string
+      def initialize attributes
+        @localized_macro_string = attributes[:localized_macro_string]
         @method_file_paths = []
         @localized_file_paths = []
 
-        _search_file_paths File.absolute_path(".")
+        _search_file_paths File.absolute_path(attributes[:search_path])
       end
 
       def ensure_localization
         failure_issues = []
 
         # use variable key for localization
-        lines_with_variable_and_logic = _find_lines_using_variable_key_in_method_files
-        lines_with_variable_and_logic.each do |l|
-          failure_issues << Utils.create_issue("found to set varible keys with logic", l)
-        end
+        lines = _find_lines_using_variable_key_in_method_files
+        failure_issues << Utils.create_issue("found to set varible keys with logic", lines) if lines.count > 0
 
         # use localized key but key doesnt exist in strings file
         used_keys = _get_used_localized_keys_from_method_files
         localized_keys = _get_localized_keys_from_strings_files
 
         forgot_keys = _contain_keys_in_localized_keys used_keys, localized_keys
-        failure_issues << Utils.create_issue("found to forget keys", forgot_keys.join(", ")) if forgot_keys.count > 0
+        failure_issues << Utils.create_issue("found to forget keys", forgot_keys) if forgot_keys.count > 0
 
         [failure_issues.count == 0, failure_issues]
       end

data/lib/i18n/cocoa/utils.rb

@@ -1,6 +1,15 @@
 module I18n
   module Cocoa
 
+    class Issue
+      attr_reader :description, :values
+
+      def initialize description, values
+        @description = description
+        @values = values
+      end
+    end
+
     module Utils
 
       def self.encode string
@@ -14,8 +23,8 @@ module I18n
         string.encode(temporal_encoding, string.encoding, replace_options).encode(string.encoding)
       end
 
-      def self.create_issue title, description
-        "#{title}: #{description}"
+      def self.create_issue description, values
+        Issue.new description, values
       end
     end
   end

data/lib/i18n/cocoa/version.rb

@@ -2,6 +2,6 @@
 
 module I18n
   module Cocoa
-    VERSION = "0.0.2"
+    VERSION = "0.0.3"
   end
 end

data/lib/i18n/cocoa.rb

@@ -7,10 +7,17 @@ require "i18n/cocoa/finder"
 module I18n
   module Cocoa
 
-    def self.health localized_macro_string='NSLocalizedString'
-      finder = Finder.new localized_macro_string
+    def self.health attributes = {}
+      finder = Finder.new(config.update attributes)
       finder.ensure_localization
     end
 
+    def self.config
+      {
+        :localized_macro_string => 'NSLocalizedString',
+        :search_path            => '.'
+      }
+    end
+
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: i18n-cocoa
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Hirohisa Kawasaki