hyperclient 0.8.2 → 0.8.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1bde74927d1e402d1db9cfd3860e36d692bcba2b
-  data.tar.gz: f65e61030043163822906124088bfba6ff47b72e
+  metadata.gz: bed16cb9c2392b30c87a860e6ec535b6d3fc7be8
+  data.tar.gz: 5ac012a05c90ba7972bb4bf438a02059fb42ca49
 SHA512:
-  metadata.gz: 5b4716aad58beaeb9566564ba214afc7d69e31f8ea080ae12c26e10d3322e602d72c552e66bcd5d5653dc2c683499178fc34e0802b47c019848b97c6f35be617
-  data.tar.gz: c1cd3c5ecbf2ed9112da1a7a6a4cea0f11abcdbb51c0473bed46c15b5f3be299456c7675b10fe9b51dba6c3fbb690b5517331ef4c05e5a8c9302fbd866107075
+  metadata.gz: 3a71056f91a8b0748fe4a381cec303d48f452090a05a4bacad87f1f36c51a302e85876e91a6241e7030b1e8f3e6fdd99beb7cb79796b88f96f84cd8c453c51c5
+  data.tar.gz: 2f8cf4720cd00317c958a4947b41bb3562f8df4727141f5575ebf37ba3c28d8da27a7517b88879f2baceb016234d39ec8d4858f2aad3c8d599c194147118fa26

data/.rubocop_todo.yml

@@ -25,7 +25,7 @@ Metrics/MethodLength:
 # Offense count: 3
 # Configuration parameters: CountComments.
 Metrics/ModuleLength:
-  Max: 391
+  Max: 398
 
 # Offense count: 1
 Style/AsciiComments:

data/.travis.yml

@@ -10,13 +10,18 @@ matrix:
     - rvm: 2.3.1
     - rvm: 2.3.0
     - rvm: 2.2.5
+    - rvm: 2.4.0
     - rvm: rbx-2
     - rvm: ruby-head
     - rvm: jruby-head
-    - rvm: jruby-9.1.6.0
+    - rvm: jruby-9.1.7.0
   allow_failures:
     - rvm: ruby-head
     - rvm: jruby-head
     - rvm: rbx-2
 
+before_install:
+  - gem update --system
+  - gem install bundler
+
 bundler_args: --without development

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+### 0.8.3 (March 30, 2017)
+
+* [#115](https://github.com/codegram/hyperclient/pull/115): Fix dropped values from queries by using FlatParamsEncoder - [@ivoanjo](https://github.com/ivoanjo).
+
 ### 0.8.2 (December 31, 2016)
 
 #### This version is no longer tested with Ruby < 2.2.

data/Rakefile

@@ -20,8 +20,6 @@ YARD::Rake::YardocTask.new do |t|
   t.options = %w(-r README.md)
 end
 
-Bundler::GemHelper.install_tasks
-
 require 'rake/testtask'
 
 Rake::TestTask.new(:test) do |t|

data/features/api_navigation.feature

@@ -12,6 +12,11 @@ Feature: API navigation
     When I search for a post with a templated link
     Then the API should receive the request with all the params
 
+  Scenario: Templated links with multiple values
+    Given I connect to the API
+    When I search for posts by tag with a templated link
+    Then the API should receive the request for posts by tag with all the params
+
   Scenario: Attributes
     Given I connect to the API
     When I load a single post

data/features/steps/api_navigation.rb

@@ -17,6 +17,14 @@ class Spinach::Features::ApiNavigation < Spinach::FeatureSteps
     assert_requested :get, 'http://api.example.org/search?q=something'
   end
 
+  step 'I search for posts by tag with a templated link' do
+    api._links.tagged._expand(tags: %w(foo bar))._resource
+  end
+
+  step 'the API should receive the request for posts by tag with all the params' do
+    assert_requested :get, 'http://api.example.org/search?tags=foo&tags=bar'
+  end
+
   step 'I load a single post' do
     @post = api._links.posts._links.last_post
   end

data/features/support/api.rb

@@ -5,6 +5,8 @@ module API
   include Spinach::Fixtures
 
   before do
+    WebMock::Config.instance.query_values_notation = :flat_array
+
     stub_request(:any, %r{api.example.org*}).to_return(body: root_response, headers: { 'Content-Type' => 'application/hal+json' })
     stub_request(:get, 'api.example.org/posts').to_return(body: posts_response, headers: { 'Content-Type' => 'application/hal+json' })
     stub_request(:get, 'api.example.org/posts/1').to_return(body: post_response, headers: { 'Content-Type' => 'application/hal+json' })

data/features/support/fixtures.rb

@@ -8,6 +8,7 @@ module Spinach
               "self": { "href": "/" },
               "posts": { "href": "/posts" },
               "search": { "href": "/search{?q}", "templated": true },
+              "tagged": { "href": "/search{?tags*}", "templated": true },
               "api:authors": { "href": "/authors" },
               "next": { "href": "/page2" }
           }

data/lib/hyperclient/entry_point.rb

@@ -40,6 +40,7 @@ module Hyperclient
       @entry_point = self
       @options = { async: true }
       @connection = nil
+      @resource = nil
       yield self if block_given?
     end
 
@@ -138,6 +139,7 @@ module Hyperclient
         connection.request :hal_json
         connection.response :hal_json, content_type: /\bjson$/
         connection.adapter :net_http
+        connection.options.params_encoder = Faraday::FlatParamsEncoder
       end
     end
 

data/lib/hyperclient/version.rb

@@ -1,3 +1,3 @@
 module Hyperclient
-  VERSION = '0.8.2'.freeze
+  VERSION = '0.8.3'.freeze
 end

data/test/hyperclient/entry_point_test.rb

@@ -33,11 +33,14 @@ module Hyperclient
 
         it 'creates a Faraday connection with the default block' do
           handlers = entry_point.connection.builder.handlers
+
           handlers.must_include Faraday::Response::RaiseError
           handlers.must_include FaradayMiddleware::FollowRedirects
           handlers.must_include FaradayMiddleware::EncodeHalJson
           handlers.must_include FaradayMiddleware::ParseHalJson
           handlers.must_include Faraday::Adapter::NetHttp
+
+          entry_point.connection.options.params_encoder.must_equal Faraday::FlatParamsEncoder
         end
 
         it 'raises a  ConnectionAlreadyInitializedError if attempting to modify headers' do
@@ -172,12 +175,15 @@ module Hyperclient
 
         it 'creates a Faraday connection with the default block plus any additional handlers' do
           handlers = entry_point.connection.builder.handlers
+
           handlers.must_include Faraday::Request::OAuth
           handlers.must_include Faraday::Response::RaiseError
           handlers.must_include FaradayMiddleware::FollowRedirects
           handlers.must_include FaradayMiddleware::EncodeHalJson
           handlers.must_include FaradayMiddleware::ParseHalJson
           handlers.must_include Faraday::Adapter::NetHttp
+
+          entry_point.connection.options.params_encoder.must_equal Faraday::FlatParamsEncoder
         end
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hyperclient
 version: !ruby/object:Gem::Version
-  version: 0.8.2
+  version: 0.8.3
 platform: ruby
 authors:
 - Oriol Gual
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-31 00:00:00.000000000 Z
+date: 2017-03-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -183,29 +183,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: ''
-test_files:
-- features/api_navigation.feature
-- features/default_config.feature
-- features/steps/api_navigation.rb
-- features/steps/default_config.rb
-- features/support/api.rb
-- features/support/env.rb
-- features/support/fixtures.rb
-- test/faraday/connection_test.rb
-- test/fixtures/collection.json
-- test/fixtures/element.json
-- test/fixtures/root.json
-- test/hyperclient/attributes_test.rb
-- test/hyperclient/collection_test.rb
-- test/hyperclient/curie_test.rb
-- test/hyperclient/entry_point_test.rb
-- test/hyperclient/link_collection_test.rb
-- test/hyperclient/link_test.rb
-- test/hyperclient/resource_collection_test.rb
-- test/hyperclient/resource_test.rb
-- test/hyperclient_test.rb
-- test/test_helper.rb
+test_files: []