hyper-model 1.0.alpha1.2 → 1.0.alpha1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 87c3f5488b0d7290f9fd974234351fae079e3830db6e57e953b54f9063ae41ab
-  data.tar.gz: cfd1b544e23337620f978df7bb625503bfd2b6cdaa832f874e4dd94a15f02e34
+  metadata.gz: 071e8cc562ebddf1c0a260587a123d91db9f2a7c52d43b06fcf063079d66129f
+  data.tar.gz: 4cb7539129b7367f3156c0726ac3ed164e1db391f7806457253d303e9940941c
 SHA512:
-  metadata.gz: e17c81b272167cd39b48b1c63fb7c451100966ede28e886ad2a8e0ddf328a961cb01dd63af6341fc166e8095fed23d0d13e98d589e873fd39d205168851e5cac
-  data.tar.gz: bb7a6021e96284469580667b58304e3aaa41ae3fdae4196f14123a09d44be53908dbf4ea0165d5edd903132f84a9f8d144629d6292eea55063681a814e8e908b
+  metadata.gz: 2c1bcd8fee396593e2f31d072f35cbf88467be2b02c198d523c052b67a211d9fea4501ca86c4f0a388cee35bc34f4ac9156147a13aac9aec4842616a5c3c1772
+  data.tar.gz: c226e31b1882e96c8a7a080114aea90aacdb0bb77331fc36854f79fe118fabd119f278bc20b94d3693bcc69d7382bc6e4d2f1e91c042b41eb660d2214e75c45d

data/Gemfile.lock

@@ -1,11 +1,11 @@
 PATH
   remote: ../hyper-component
   specs:
-    hyper-component (1.0.alpha1.1)
-      hyper-state (= 1.0.alpha1.1)
-      hyperstack-config (= 1.0.alpha1.1)
-      libv8 (~> 6.3.0)
-      mini_racer (~> 0.1.15)
+    hyper-component (1.0.alpha1.3)
+      hyper-state (= 1.0.alpha1.3)
+      hyperstack-config (= 1.0.alpha1.3)
+      libv8 (~> 6.7.0)
+      mini_racer (~> 0.2.4)
       opal (>= 0.11.0, < 0.12.0)
       opal-activesupport (~> 0.3.1)
       react-rails (>= 2.4.0, < 2.5.0)
@@ -13,26 +13,26 @@ PATH
 PATH
   remote: ../hyper-operation
   specs:
-    hyper-operation (1.0.alpha1.1)
+    hyper-operation (1.0.alpha1.3)
       activerecord (>= 4.0.0)
-      hyper-component (= 1.0.alpha1.1)
+      hyper-component (= 1.0.alpha1.3)
       mutations
       opal-activesupport (~> 0.3.1)
+      tty-table
 
 PATH
   remote: ../hyper-state
   specs:
-    hyper-state (1.0.alpha1.1)
-      hyperstack-config (= 1.0.alpha1.1)
+    hyper-state (1.0.alpha1.3)
+      hyperstack-config (= 1.0.alpha1.3)
       opal (>= 0.11.0, < 0.12.0)
 
 PATH
   remote: ../hyperstack-config
   specs:
-    hyperstack-config (1.0.alpha1.1)
-      libv8 (~> 6.3.0)
+    hyperstack-config (1.0.alpha1.3)
       listen (~> 3.0)
-      mini_racer (~> 0.1.15)
+      mini_racer (~> 0.2.4)
       opal (>= 0.11.0, < 0.12.0)
       opal-browser (~> 0.2.0)
       uglifier
@@ -41,11 +41,11 @@ PATH
 PATH
   remote: .
   specs:
-    hyper-model (1.0.alpha1.1)
+    hyper-model (1.0.alpha1.3)
       activemodel
       activerecord (>= 4.0.0)
-      hyper-component (= 1.0.alpha1.1)
-      hyper-operation (= 1.0.alpha1.1)
+      hyper-component (= 1.0.alpha1.3)
+      hyper-operation (= 1.0.alpha1.3)
 
 GEM
   remote: https://rubygems.org/
@@ -141,6 +141,7 @@ GEM
       eventmachine (>= 0.12.9)
       http_parser.rb (~> 0.6.0)
     equalizer (0.0.11)
+    equatable (0.5.0)
     erubi (1.7.1)
     eventmachine (1.2.7)
     execjs (2.7.0)
@@ -164,7 +165,7 @@ GEM
       rails-dom-testing (>= 1, < 3)
       railties (>= 4.2.0)
       thor (>= 0.14, < 2.0)
-    libv8 (6.3.292.48.1)
+    libv8 (6.7.288.46.1)
     listen (3.1.5)
       rb-fsevent (~> 0.9, >= 0.9.4)
       rb-inotify (~> 0.9, >= 0.9.7)
@@ -182,13 +183,14 @@ GEM
     mimemagic (0.3.2)
     mini_mime (1.0.1)
     mini_portile2 (2.3.0)
-    mini_racer (0.1.15)
-      libv8 (~> 6.3)
+    mini_racer (0.2.4)
+      libv8 (>= 6.3)
     minitest (5.11.3)
     multi_json (1.13.1)
     mutations (0.8.3)
       activesupport
     mysql2 (0.5.2)
+    necromancer (0.4.0)
     nio4r (2.3.1)
     nokogiri (1.8.4)
       mini_portile2 (~> 2.3.0)
@@ -220,6 +222,9 @@ GEM
     parallel (1.12.1)
     parser (2.3.3.1)
       ast (~> 2.2)
+    pastel (0.7.2)
+      equatable (~> 0.5.0)
+      tty-color (~> 0.4.0)
     powerpack (0.1.2)
     procto (0.0.3)
     pry (0.11.3)
@@ -271,8 +276,8 @@ GEM
       rake
     rake (12.3.1)
     rb-fsevent (0.10.3)
-    rb-inotify (0.9.10)
-      ffi (>= 0.5.0, < 2)
+    rb-inotify (0.10.0)
+      ffi (~> 1.0)
     react-rails (2.4.7)
       babel-transpiler (>= 0.7.0)
       connection_pool
@@ -343,6 +348,11 @@ GEM
       activesupport (>= 4.0)
       sprockets (>= 3.0.0)
     sqlite3 (1.3.13)
+    strings (0.1.4)
+      strings-ansi (~> 0.1.0)
+      unicode-display_width (~> 1.4.0)
+      unicode_utils (~> 1.4.0)
+    strings-ansi (0.1.0)
     thin (1.7.2)
       daemons (~> 1.0, >= 1.0.9)
       eventmachine (~> 1.0, >= 1.0.4)
@@ -351,11 +361,20 @@ GEM
     thread_safe (0.3.6)
     tilt (2.0.8)
     timecop (0.8.1)
+    tty-color (0.4.3)
+    tty-screen (0.6.5)
+    tty-table (0.10.0)
+      equatable (~> 0.5.0)
+      necromancer (~> 0.4.0)
+      pastel (~> 0.7.2)
+      strings (~> 0.1.0)
+      tty-screen (~> 0.6.4)
     tzinfo (1.2.5)
       thread_safe (~> 0.1)
-    uglifier (4.1.19)
+    uglifier (4.1.20)
       execjs (>= 0.3.0, < 3)
     unicode-display_width (1.4.0)
+    unicode_utils (1.4.0)
     unparser (0.2.8)
       abstract_type (~> 0.0.7)
       adamantium (~> 0.2.0)
@@ -375,7 +394,7 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
-  bundler
+  bundler (>= 1.17.3, < 2.1)
   capybara
   chromedriver-helper (= 1.2.0)
   database_cleaner
@@ -385,8 +404,8 @@ DEPENDENCIES
   hyper-operation!
   hyper-state!
   hyperstack-config!
-  libv8 (~> 6.3.0)
-  mini_racer (~> 0.1.15)
+  libv8
+  mini_racer (~> 0.2.4)
   mysql2
   opal-activesupport (~> 0.3.1)
   opal-browser (~> 0.2.0)
@@ -418,4 +437,4 @@ DEPENDENCIES
   unparser
 
 BUNDLED WITH
-   1.16.1
+   2.0.1

data/Rakefile

@@ -1,6 +1,18 @@
 require "bundler/gem_tasks"
 require "rspec/core/rake_task"
 
+task :part1 do
+  (1..2).each { |batch| Rake::Task["spec:batch#{batch}"].invoke rescue nil }
+end
+
+task :part2 do
+  (3..4).each { |batch| Rake::Task["spec:batch#{batch}"].invoke rescue nil }
+end
+
+task :part3 do
+  (5..7).each { |batch| Rake::Task["spec:batch#{batch}"].invoke rescue nil }
+end
+
 task :spec do
   (1..7).each { |batch| Rake::Task["spec:batch#{batch}"].invoke rescue nil }
 end

data/hyper-model.gemspec

@@ -29,11 +29,11 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'activerecord', '>= 4.0.0'
   spec.add_dependency 'hyper-component', HyperModel::VERSION
   spec.add_dependency 'hyper-operation', HyperModel::VERSION
-  spec.add_development_dependency 'bundler'
+  spec.add_development_dependency 'bundler', ['>= 1.17.3', '< 2.1']
   spec.add_development_dependency 'capybara'
   spec.add_development_dependency 'chromedriver-helper', '1.2.0'
-  spec.add_development_dependency 'libv8', '~> 6.3.0' # see https://github.com/discourse/mini_racer/issues/92
-  spec.add_development_dependency 'mini_racer', '~> 0.1.15'
+  spec.add_development_dependency 'libv8'
+  spec.add_development_dependency 'mini_racer', '~> 0.2.4'
   spec.add_development_dependency 'selenium-webdriver'
   spec.add_development_dependency 'database_cleaner'
   spec.add_development_dependency 'factory_bot_rails'

data/lib/active_record_base.rb

@@ -29,7 +29,7 @@ module ActiveRecord
     class ReactiveRecordPsuedoRelationArray < Array
       attr_accessor :__synchromesh_permission_granted
       attr_accessor :acting_user
-      def __secure_collection_check(_acting_user)
+      def __secure_collection_check(*)
         self
       end
     end
@@ -39,11 +39,13 @@ module ActiveRecord
     class Relation
       attr_accessor :__synchromesh_permission_granted
       attr_accessor :acting_user
-      def __secure_collection_check(acting_user)
+
+      def __secure_collection_check(cache_item)
         return self if __synchromesh_permission_granted
-        return self if __secure_remote_access_to_all(self, acting_user).__synchromesh_permission_granted
-        return self if __secure_remote_access_to_unscoped(self, acting_user).__synchromesh_permission_granted
-        Hyperstack::InternalPolicy.raise_operation_access_violation(:scoped_permission_not_granted, "Last relation: #{self}, acting_user: #{acting_user}")
+        return self if __secure_remote_access_to_all(self, cache_item.acting_user).__synchromesh_permission_granted
+        return self if __secure_remote_access_to_unscoped(self, cache_item.acting_user).__synchromesh_permission_granted
+        Hyperstack::InternalPolicy.raise_operation_access_violation(
+          :scoped_permission_not_granted, "Access denied for #{cache_item}")
       end
     end
     # Monkey patches and extensions to base
@@ -90,6 +92,9 @@ module ActiveRecord
               this.acting_user = old
             end
           end
+          singleton_class.send(:define_method, "_#{name}") do |*args|
+            all.instance_exec(*args, &block)
+          end
           singleton_class.send(:define_method, name) do |*args|
             all.instance_exec(*args, &block)
           end

data/lib/hyper_model/version.rb

@@ -1,3 +1,3 @@
 module HyperModel
-  VERSION = '1.0.alpha1.2'
+  VERSION = '1.0.alpha1.3'
 end

data/lib/reactive_record/active_record/associations.rb

@@ -44,7 +44,7 @@ module ActiveRecord
         @owner_class = owner_class
         @macro =       macro
         @options =     options
-        @klass_name =  options[:class_name] || (collection? && name.camelize.sub(/s$/, '')) || name.camelize
+        @klass_name =  options[:class_name] || (collection? && name.camelize.singularize) || name.camelize
         @association_foreign_key = options[:foreign_key] || (macro == :belongs_to && "#{name}_id") || "#{@owner_class.name.underscore}_id"
         @source = options[:source] || @klass_name.underscore if options[:through]
         @attribute = name
@@ -97,9 +97,15 @@ module ActiveRecord
           next if association.attribute == attribute
           return association if klass == association.owner_class
         end
-        raise "Association #{@owner_class}.#{attribute} "\
-              "(foreign_key: #{@association_foreign_key}) "\
-              "has no inverse in #{@klass_name}"
+        # instead of raising an error go ahead and create the inverse relationship if it does not exist.
+        # https://github.com/hyperstack-org/hyperstack/issues/89
+        if macro == :belongs_to
+          Hyperstack::Component::IsomorphicHelpers.log "**** warning dynamically adding relationship: #{klass}.has_many :#{@owner_class.name.underscore.pluralize}, foreign_key: #{@association_foreign_key}", :warning
+          klass.has_many @owner_class.name.underscore.pluralize, foreign_key: @association_foreign_key
+        else
+          Hyperstack::Component::IsomorphicHelpers.log "**** warning dynamically adding relationship: #{klass}.belongs_to :#{@owner_class.name.underscore}, foreign_key: #{@association_foreign_key}", :warning
+          klass.belongs_to @owner_class.name.underscore, foreign_key: @association_foreign_key
+        end
       end
 
       def klass

data/lib/reactive_record/active_record/class_methods.rb

@@ -261,10 +261,10 @@ module ActiveRecord
     end
 
     def finder_method(name)
-      ReactiveRecord::ScopeDescription.new(self, "_#{name}", {})
+      ReactiveRecord::ScopeDescription.new(self, "_#{name}", {}) # was adding _ to front
       [name, "#{name}!"].each do |method|
         singleton_class.send(:define_method, method) do |*vargs|
-          all.apply_scope("_#{method}", *vargs).first
+          all.apply_scope("_#{method}", *vargs).first # was adding _ to front
         end
       end
     end

data/lib/reactive_record/active_record/reactive_record/collection.rb

@@ -52,6 +52,9 @@ module ReactiveRecord
     def all
       observed
       @dummy_collection.notify if @dummy_collection
+      # unless false && @collection # this fixes https://github.com/hyperstack-org/hyperstack/issues/82 in very limited cases, and breaks otherthings
+      #   sync_collection_with_parent
+      # end
       unless @collection
         @collection = []
         if ids = ReactiveRecord::Base.fetch_from_db([*@vector, "*all"])
@@ -80,8 +83,15 @@ module ReactiveRecord
 
     def ==(other_collection)
       observed
-      return !@collection unless other_collection.is_a? Collection
+      # handle special case of other_collection NOT being a collection (typically nil)
+      return (@collection || []) == other_collection unless other_collection.is_a? Collection
       other_collection.observed
+      # if either collection has not been created then compare the vectors
+      # https://github.com/hyperstack-org/hyperstack/issues/81
+      # TODO: if this works then remove the || [] below (2 of them)
+      if !@collection || !other_collection.collection
+        return @vector == other_collection.vector && unsaved_children == other_collection.unsaved_children
+      end
       my_children = (@collection || []).select { |target| target != @dummy_record }
       if other_collection
         other_children = (other_collection.collection || []).select { |target| target != other_collection.dummy_record }
@@ -261,11 +271,15 @@ To determine this sync_scopes first asks if the record being changed is in the s
     end
 
     def link_to_parent
-      return if @linked
+      # puts "#{self}.link_to_parent @linked = #{!!@linked}, collection? #{!!@collection}"
+      # always check that parent is synced  - fixes issue https://github.com/hyperstack-org/hyperstack/issues/82
+      # note that sync_collection_with_parent checks to make sure that is NOT a collection and that there IS a parent
+
+      return sync_collection_with_parent if @linked
       @linked = true
       if @parent
         @parent.link_child self
-        sync_collection_with_parent unless collection
+        sync_collection_with_parent
       else
         ReactiveRecord::Base.add_to_outer_scopes self
       end
@@ -278,14 +292,23 @@ To determine this sync_scopes first asks if the record being changed is in the s
     end
 
     def sync_collection_with_parent
+      # puts "#{self}.sync_collection_with_parent"
+      return if @collection || !@parent || @parent.dummy_collection # fixes issue https://github.com/hyperstack-org/hyperstack/issues/78 and supports /82
       if @parent.collection
+        # puts ">>> @parent.collection present"
         if @parent.collection.empty?
+          # puts ">>>>> @parent.collection is empty!"
           @collection = []
         elsif filter?
-          @collection = filter_records(@parent.collection)
+          # puts "#{self}.sync_collection_with_parent (@parent = #{@parent}) calling filter records on (#{@parent.collection})"
+          @collection = filter_records(@parent.collection) # .tap { |rr| puts "returns #{rr} #{rr.to_a}" }
         end
-      elsif @parent._count_internal(false).zero?  # just changed this from count.zero?
+      elsif !@linked && @parent._count_internal(false).zero?
+        # don't check _count_internal if already linked as this cause an unnecessary rendering cycle
+        # puts ">>> @parent._count_internal(false).zero? is true!"
         @count = 0
+      else
+        # puts ">>> NOP"
       end
     end
 
@@ -327,7 +350,9 @@ To determine this sync_scopes first asks if the record being changed is in the s
       # when count is called on a leaf, count_internal is called for each
       # ancestor.  Only the outermost count has load_from_client == true
       observed
-      if @collection
+      if @count && @dummy_collection
+        @count # fixes https://github.com/hyperstack-org/hyperstack/issues/79
+      elsif @collection
         @collection.count
       elsif @count ||= ReactiveRecord::Base.fetch_from_db([*@vector, "*count"])
         @count

data/lib/reactive_record/active_record/reactive_record/isomorphic_base.rb

@@ -10,6 +10,7 @@ module ReactiveRecord
       if RUBY_ENGINE != 'opal'
         @server_data_cache = ReactiveRecord::ServerDataCache.new(context.controller.acting_user, {})
       else
+        Hyperstack::Internal::State::Variable.set(WhileLoading, :quiet, true)
         @public_columns_hash = get_public_columns_hash
         define_attribute_methods
         @outer_scopes = Set.new
@@ -242,7 +243,7 @@ module ReactiveRecord
           end if record.new? || record.changed? || (record == record_being_saved && force)
           record_index += 1
         end
-        [models, associations, backing_records]
+        [models.sort_by { |model| model[:id] }, associations, backing_records]
       end
 
       def save_or_validate(save, validate, force, &block)
@@ -316,21 +317,23 @@ module ReactiveRecord
 
     else
 
-      def self.find_record(model, id, vector, save)
+      def self.find_record(model, id, acting_user, vector, save)
         if !save
           found = vector[1..-1].inject(vector[0]) do |object, method|
             if object.nil? # happens if you try to do an all on empty scope followed by more scopes
               object
-            elsif method.is_a? Array
+            elsif method.is_a? Array #__secure_remote_access_to_
               if method[0] == 'new'
                 object.new
-              else
+              elsif method[0] == 'find_by'
                 object.send(*method)
+              else
+                object.send(:"__secure_remote_access_to_#{method[0]}", object, acting_user, *method[1..-1])
               end
-            elsif method.is_a? String and method[0] == '*'
+            elsif method.is_a?(String) && method[0] == '*'
               object[method.gsub(/^\*/,'').to_i]
             else
-              object.send(method)
+              object.send(:"__secure_remote_access_to_#{method}", object, acting_user)
             end
           end
           if id and (found.nil? or !(found.class <= model) or (found.id and found.id.to_s != id.to_s))
@@ -362,13 +365,13 @@ module ReactiveRecord
           id = attributes.delete(model.primary_key) if model.respond_to? :primary_key # if we are saving existing model primary key value will be present
           vector = model_to_save[:vector]
           vector = [vector[0].constantize] + vector[1..-1].collect do |method|
-            if method.is_a?(Array) and method.first == "find_by_id"
+            if method.is_a?(Array) && method.first == "find_by_id"
               ["find", method.last]
             else
               method
             end
           end
-          reactive_records[model_to_save[:id]] = vectors[vector] = record = find_record(model, id, vector, save) # ??? || validate ???
+          reactive_records[model_to_save[:id]] = vectors[vector] = record = find_record(model, id, acting_user, vector, save) # ??? || validate ???
           next unless record
           if attributes.empty?
             dont_save_list << record unless save
@@ -507,7 +510,7 @@ module ReactiveRecord
         if save || validate
           {success: false, saved_models: saved_models, message: e}
         else
-          {}
+          raise e # was returning {} TODO verify that just raising the error at least reports the error
         end
       end
 

data/lib/reactive_record/active_record/reactive_record/operations.rb

@@ -65,8 +65,9 @@ module ReactiveRecord
         ]
       end
       failed do |e|
-        # AccessViolations are already sent to on_error
-        Hyperstack.on_error(e, :fetch_error, params.to_h) unless e.is_a? Hyperstack::AccessViolation
+        e.define_singleton_method(:__hyperstack_on_error) do |operation, params, fmted_message|
+          Hyperstack.on_error(operation, self, params, fmted_message)
+        end
         raise e
       end
     end

data/lib/reactive_record/active_record/reactive_record/scoped_collection.rb

@@ -9,7 +9,10 @@ module ReactiveRecord
     def set_pre_sync_related_records(related_records, _record = nil)
       @pre_sync_related_records = nil
       ReactiveRecord::Base.catch_db_requests do
+        puts "#{self}.set_pre_sync_related_records filter_records(#{related_records})"
+
         @pre_sync_related_records = filter_records(related_records)
+        puts "returns #{@pre_sync_related_records}"
         live_scopes.each do |scope|
           scope.set_pre_sync_related_records(@pre_sync_related_records)
         end
@@ -32,7 +35,9 @@ module ReactiveRecord
       if collector?
         update_collector_scope(related_records)
       else
+        puts "#{self}.update_collection calling filter_records(#{related_records})"
         related_records = filter_records(related_records)
+        puts "returns #{related_records}"
         update_filter_scope(@pre_sync_related_records, related_records)
       end
     end
@@ -41,7 +46,8 @@ module ReactiveRecord
       current = Set.new([*@collection])
       (related_records - @pre_sync_related_records).each { |r| current << r }
       (@pre_sync_related_records - related_records).each { |r| current.delete(r) }
-      replace(filter_records(current))
+      puts "#{self}.update_collector_scope calling replace(filter_records(#{current}))"
+      replace(filter_records(current).tap { |rr| puts "returns #{rr}" })
       Set.new([*@collection])
     end
 

data/lib/reactive_record/active_record/reactive_record/while_loading.rb

@@ -74,6 +74,191 @@ module ReactiveRecord
   # To notify React that something is loading use React::WhileLoading.loading!
   # once everything is loaded then do React::WhileLoading.loaded_at message (typically a time stamp just for debug purposes)
 
+  #   class WhileLoading
+  #
+  #     include Hyperstack::Component::IsomorphicHelpers
+  #
+  #     before_first_mount do
+  #       @css_to_preload = ""
+  #       @while_loading_counter = 0
+  #     end
+  #
+  #     def self.get_next_while_loading_counter
+  #       @while_loading_counter += 1
+  #     end
+  #
+  #     def self.preload_css(css)
+  #       @css_to_preload += "#{css}\n"
+  #     end
+  #
+  #     def self.has_observers?
+  #       Hyperstack::Internal::State::Variable.observed?(self, :loaded_at)
+  #     end
+  #
+  #     class << self
+  #       alias :observed? :has_observers?
+  #     end
+  #
+  #     prerender_footer do
+  #       "<style>\n#{@css_to_preload}\n</style>".tap { @css_to_preload = ""}
+  #     end
+  #
+  #     if RUBY_ENGINE == 'opal'
+  #
+  #       # +: I DONT THINK WE USE opal-jquery in this module anymore - require 'opal-jquery' if opal_client?
+  #       # -: You think wrong. add_style_sheet uses the jQuery $, after_mount too, others too
+  #       # -: I removed those references. Now you think right.
+  #
+  #       include Hyperstack::Component
+  #
+  #       param :render_original_child
+  #       param :loading
+  #
+  #       class << self
+  #
+  #         def loading?
+  #           @is_loading
+  #         end
+  #
+  #         def loading!
+  #           Hyperstack::Internal::Component::RenderingContext.waiting_on_resources = true
+  #           Hyperstack::Internal::State::Variable.get(self, :loaded_at)
+  #           # this was moved to where the fetch is actually pushed on to the fetch array in isomorphic base
+  #           # Hyperstack::Internal::State::Variable.set(self, :quiet, false)
+  #           @is_loading = true
+  #         end
+  #
+  #         def loaded_at(loaded_at)
+  #           Hyperstack::Internal::State::Variable.set(self, :loaded_at, loaded_at)
+  #           @is_loading = false
+  #         end
+  #
+  #         def quiet?
+  #           Hyperstack::Internal::State::Variable.get(self, :quiet)
+  #         end
+  #
+  #         def page_loaded?
+  #           Hyperstack::Internal::State::Variable.get(self, :page_loaded)
+  #         end
+  #
+  #         def quiet!
+  #           Hyperstack::Internal::State::Variable.set(self, :quiet, true)
+  #           after(1) { Hyperstack::Internal::State::Variable.set(self, :page_loaded, true) } unless on_opal_server? or @page_loaded
+  #           @page_loaded = true
+  #         end
+  #
+  #         def add_style_sheet
+  #           # directly assigning the code to the variable triggers a opal 0.10.5 compiler bug.
+  #           unless @style_sheet_added
+  #             %x{
+  #               var style_el = document.createElement("style");
+  #               style_el.setAttribute("type", "text/css");
+  #               style_el.innerHTML = ".reactive_record_is_loading > .reactive_record_show_when_loaded { display: none !important; }\n" +
+  #                                    ".reactive_record_is_loaded > .reactive_record_show_while_loading { display: none !important; }";
+  #               document.head.append(style_el);
+  #             }
+  #             @style_sheet_added = true
+  #           end
+  #         end
+  #
+  #       end
+  #
+  #       def after_mount_and_update
+  #         @waiting_on_resources = @Loading
+  #         node = dom_node
+  #         %x{
+  #           Array.from(node.children).forEach(
+  #             function(current_node, current_index, list_obj) {
+  #               if (current_index > 0 && current_node.className.indexOf('reactive_record_show_when_loaded') === -1) {
+  #                 current_node.className = current_node.className + ' reactive_record_show_when_loaded';
+  #               } else if (current_index == 0 && current_node.className.indexOf('reactive_record_show_while_loading') === -1) {
+  #                 current_node.className = current_node.className + ' reactive_record_show_while_loading';
+  #               }
+  #             }
+  #           );
+  #         }
+  #         nil
+  #       end
+  #
+  #       before_mount do
+  #         @uniq_id = WhileLoading.get_next_while_loading_counter
+  #         WhileLoading.preload_css(
+  #           ":not(.reactive_record_is_loading).reactive_record_while_loading_container_#{@uniq_id} > :nth-child(1) {\n"+
+  #           "  display: none;\n"+
+  #           "}\n"
+  #         )
+  #       end
+  #
+  #       after_mount do
+  #         WhileLoading.add_style_sheet
+  #         after_mount_and_update
+  #       end
+  #
+  #       after_update :after_mount_and_update
+  #
+  #       render do
+  #         @RenderOriginalChild.call(@uniq_id)
+  #       end
+  #
+  #     end
+  #
+  #   end
+  #
+  # end
+  #
+  # module Hyperstack
+  #   module Component
+  #
+  #     class Element
+  #
+  #       def while_loading(display = "", &loading_display_block)
+  #         original_block = block || -> () {}
+  #
+  #         if display.respond_to? :as_node
+  #           display = display.as_node
+  #           block = lambda { display.render; instance_eval(&original_block) }
+  #         elsif !loading_display_block
+  #           block = lambda { display; instance_eval(&original_block) }
+  #         else
+  #           block = ->() { instance_eval(&loading_display_block); instance_eval(&original_block) }
+  #         end
+  #          loading_child = Internal::Component::RenderingContext.build do |buffer|
+  #            Hyperstack::Internal::Component::RenderingContext.render(:span, key: 1, &loading_display_block) #{ to_s }
+  #            buffer.dup
+  #          end
+  #         children = `#{@native}.props.children.slice(0)`
+  #         children.unshift(loading_child[0].instance_eval { @native })
+  #         @native = `React.cloneElement(#{@native}, #{@properties.shallow_to_n}, #{children})`
+  #        render_original_child = lambda do |uniq_id|
+  #          classes = [
+  #            @properties[:class], @properties[:className],
+  #            "reactive_record_while_loading_container_#{uniq_id}"
+  #          ].compact.join(' ')
+  #          @properties.merge!({
+  #            "data-reactive_record_while_loading_container_id" => uniq_id,
+  #            "data-reactive_record_enclosing_while_loading_container_id" => uniq_id,
+  #            className: classes
+  #          })
+  #          @native = `React.cloneElement(#{@native}, #{@properties.shallow_to_n})`
+  #          render
+  #        end
+  #        delete
+  #        ReactAPI.create_element(
+  #           ReactiveRecord::WhileLoading,
+  #           loading: waiting_on_resources,
+  #           render_original_child: render_original_child)
+  #       end
+  #
+  #       def hide_while_loading
+  #         while_loading
+  #       end
+  #
+  #     end
+  #   end
+  # end
+  #
+
+
   class WhileLoading
 
     include Hyperstack::Component::IsomorphicHelpers
@@ -116,6 +301,7 @@ module ReactiveRecord
       param :loading_children
       param :element_type
       param :element_props
+      others :other_props
       param :display, default: ''
 
       class << self
@@ -157,8 +343,8 @@ module ReactiveRecord
             %x{
               var style_el = document.createElement("style");
               style_el.setAttribute("type", "text/css");
-              style_el.innerHTML = ".reactive_record_is_loading > .reactive_record_show_when_loaded { display: none; }\n" +
-                                   ".reactive_record_is_loaded > .reactive_record_show_while_loading { display: none; }";
+              style_el.innerHTML = ".reactive_record_is_loading > .reactive_record_show_when_loaded { display: none !important; }\n" +
+                                   ".reactive_record_is_loaded > .reactive_record_show_while_loading { display: none !important; }";
               document.head.append(style_el);
             }
             @style_sheet_added = true
@@ -167,53 +353,57 @@ module ReactiveRecord
 
       end
 
-      before_mount do
-        @uniq_id = WhileLoading.get_next_while_loading_counter
-        WhileLoading.preload_css(
-          ".reactive_record_while_loading_container_#{@uniq_id} > :nth-child(1n+#{@LoadedChildren.count+1}) {\n"+
-          "  display: none;\n"+
-          "}\n"
-        )
-      end
-
-      after_mount do
+      def after_mount_and_update
         @waiting_on_resources = @Loading
-        WhileLoading.add_style_sheet
         node = dom_node
         %x{
-          var nodes = node.querySelectorAll(':nth-child(-1n+'+#{@LoadedChildren.count}+')');
-          nodes.forEach(
+          Array.from(node.children).forEach(
             function(current_node, current_index, list_obj) {
-              if (current_node.className.indexOf('reactive_record_show_when_loaded') === -1) {
+              if (current_index > 0 && current_node.className.indexOf('reactive_record_show_when_loaded') === -1) {
                 current_node.className = current_node.className + ' reactive_record_show_when_loaded';
-              }
-            }
-          );
-          nodes = node.querySelectorAll(':nth-child(1n+'+#{@LoadedChildren.count+1}+')');
-          nodes.forEach(
-            function(current_node, current_index, list_obj) {
-              if (current_node.className.indexOf('reactive_record_show_while_loading') === -1) {
+              } else if (current_index == 0 && current_node.className.indexOf('reactive_record_show_while_loading') === -1) {
                 current_node.className = current_node.className + ' reactive_record_show_while_loading';
               }
             }
           );
         }
+        nil
       end
 
-      after_update do
-        @waiting_on_resources = @Loading
+      before_mount do
+        @uniq_id = WhileLoading.get_next_while_loading_counter
+        WhileLoading.preload_css(
+          ":not(.reactive_record_is_loading).reactive_record_while_loading_container_#{@uniq_id} > :nth-child(1) {\n"+
+          "  display: none;\n"+
+          "}\n"
+        )
+      end
+
+      after_mount do
+        WhileLoading.add_style_sheet
+        after_mount_and_update
       end
 
+      after_update :after_mount_and_update
+
       render do
+        # return ReactAPI.create_element(@ElementType[0], @ElementProps.dup) do
+        #   @LoadedChildren
+        # end
         props = @ElementProps.dup
-        classes = [props[:class], props[:className], "reactive_record_while_loading_container_#{@uniq_id}"].compact.join(" ")
+        classes = [
+          props[:class], props[:className],
+          @OtherProps.delete(:class), @OtherProps.delete(:className),
+          "reactive_record_while_loading_container_#{@uniq_id}"
+        ].compact.join(" ")
         props.merge!({
           "data-reactive_record_while_loading_container_id" => @uniq_id,
           "data-reactive_record_enclosing_while_loading_container_id" => @uniq_id,
           class: classes
         })
+        props.merge!(@OtherProps)
         ReactAPI.create_element(@ElementType[0], props) do
-          @LoadedChildren + @LoadingChildren
+          @LoadingChildren + @LoadedChildren
         end.tap { |e| e.waiting_on_resources = @Loading }
       end
 
@@ -231,6 +421,10 @@ module Hyperstack
       def while_loading(display = "", &loading_display_block)
         loaded_children = []
         loaded_children = block.call.dup if block
+        if loaded_children.last.is_a? String
+          loaded_children <<
+            Hyperstack::Internal::Component::ReactWrapper.create_element(:span) { loaded_children.pop }
+        end
         if display.respond_to? :as_node
           display = display.as_node
           loading_display_block = lambda { display.render }
@@ -238,12 +432,10 @@ module Hyperstack
           loading_display_block = lambda { display }
         end
         loading_children = Internal::Component::RenderingContext.build do |buffer|
-          result = loading_display_block.call
-          result = result.to_s if result.try :acts_as_string?
-          result.span.tap { |e| e.waiting_on_resources = Internal::Component::RenderingContext.waiting_on_resources } if result.is_a? String
+          Hyperstack::Internal::Component::RenderingContext.render(:span, &loading_display_block) #{ to_s }
           buffer.dup
         end
-
+       as_node
        new_element = ReactAPI.create_element(
           ReactiveRecord::WhileLoading,
           loading: waiting_on_resources,
@@ -252,7 +444,7 @@ module Hyperstack
           element_type: [type],
           element_props: properties)
 
-        Internal::Component::RenderingContext.replace(self, new_element)
+        #Internal::Component::RenderingContext.replace(self, new_element)
       end
 
       def hide_while_loading
@@ -267,6 +459,10 @@ if RUBY_ENGINE == 'opal'
   module Hyperstack
     module Component
 
+      def quiet?
+        Hyperstack::Internal::State::Variable.get(ReactiveRecord::WhileLoading, :quiet)
+      end
+
       alias_method :original_component_did_mount, :component_did_mount
 
       def component_did_mount(*args)

data/lib/reactive_record/broadcast.rb

@@ -2,9 +2,12 @@ module ReactiveRecord
   class Broadcast
 
     def self.after_commit(operation, model)
+      # Calling public_columns_hash once insures all policies are loaded
+      # before the first broadcast.
+      @public_columns_hash ||= ActiveRecord::Base.public_columns_hash
       Hyperstack::InternalPolicy.regulate_broadcast(model) do |data|
         if !Hyperstack.on_server? && Hyperstack::Connection.root_path
-          send_to_server(operation, data) rescue nil # server no longer running so ignore
+          send_to_server(operation, data) rescue nil # fails if server no longer running so ignore
         else
           SendPacket.run(data, operation: operation)
         end

data/lib/reactive_record/permissions.rb

@@ -90,7 +90,7 @@ class ActiveRecord::Base
     def belongs_to(attr_name, *args)
       belongs_to_without_reactive_record_add_is_method(attr_name, *args).tap do
         define_method "#{attr_name}_is?".to_sym do |model|
-          self.class.reflections[attr_name].foreign_key == model.id
+          self.class.reflections[attr_name.to_s].foreign_key == model.id
         end
       end
     end
@@ -103,7 +103,19 @@ class ActiveRecord::Base
       self.acting_user = old
       self
     else
-      Hyperstack::InternalPolicy.raise_operation_access_violation(:crud_access_violation, "for #{self} - #{permission}(#{args}) acting_user: #{user}")
+      acting_user_string =
+        if acting_user
+          id = user.respond_to?(:id) ? user.id : user
+          "not allowed for acting_user: <##{user.class} id: #{user}>"
+        else
+          "not allowed without acting_user (acting_user = nil)"
+        end
+
+      message = "CRUD access violation: <##{self.class} id: #{self.id}> - #{permission}(#{args}) #{acting_user_string}"
+      if permission == :view_permitted?
+        details = Hyperstack::PolicyDiagnostics.policy_dump_for(self, user)
+      end
+      Hyperstack::InternalPolicy.raise_operation_access_violation(message, details || '')
     end
   end
 

data/lib/reactive_record/server_data_cache.rb

@@ -229,6 +229,26 @@ module ReactiveRecord
             @db_cache.add_item_to_cache self
           end
 
+          def to_s
+            acting_user_string =
+              if acting_user
+                " - with acting user: <#{acting_user.class.name} id: #{acting_user.id}>"
+              else
+                ' - with no acting user'
+              end
+            vector.collect do |e|
+              if e.is_a? String
+                e
+              elsif e.is_a? Array
+                e.length > 1 ? "#{e.first}(#{e[1..-1].join(', ')})" : e.first
+              else
+                e.name
+              end
+            end.join('.') + acting_user_string
+          rescue
+            vector.to_s + acting_user_string
+          end
+
           def start_timing(&block)
             ServerDataCache.class.start_timing(&block)
           end
@@ -245,11 +265,11 @@ module ReactiveRecord
                   cache_item.apply_star || representative
                 elsif method == "*all"
                   # if we secure the collection then we assume its okay to read the ids
-                  secured_value = cache_item.value.__secure_collection_check(@acting_user)
+                  secured_value = cache_item.value.__secure_collection_check(cache_item)
                   cache_item.build_new_cache_item(timing(:active_record) { secured_value.collect { |record| record.id } }, method, method)
                 elsif method == "*count"
-                  secured_value = cache_item.value.__secure_collection_check(@acting_user)
-                  cache_item.build_new_cache_item(timing(:active_record) { cache_item.value.__secure_collection_check(@acting_user).count }, method, method)
+                  secured_value = cache_item.value.__secure_collection_check(cache_item)
+                  cache_item.build_new_cache_item(timing(:active_record) { cache_item.value.__secure_collection_check(cache_item).count }, method, method)
                 elsif preloaded_value = @preloaded_records[cache_item.absolute_vector + [method]]
                   # no security check needed since we already evaluated this
                   cache_item.build_new_cache_item(preloaded_value, method, method)
@@ -273,10 +293,10 @@ module ReactiveRecord
                       else
                         raise "method missing"
                       end
-                    rescue Exception => e # this check may no longer be needed as we are quite explicit now on which methods we apply
-                      # ReactiveRecord::Pry::rescued(e)
-                      ::Rails.logger.debug "\033[0;31;1mERROR: HyperModel exception caught when applying #{method} to db object #{cache_item.value}: #{e}\033[0;30;21m"
-                      raise e, "HyperModel fetching records failed, exception caught when applying #{method} to db object #{cache_item.value}: #{e}", e.backtrace
+                    # rescue Exception => e # this check may no longer be needed as we are quite explicit now on which methods we apply
+                    #   # ReactiveRecord::Pry::rescued(e)
+                    #   #::Rails.logger.debug "\033[0;31;1mERROR: HyperModel exception caught when applying #{method} to db object #{cache_item.value}: #{e}\033[0;30;21m"
+                    #   raise e, "HyperModel fetching records failed, exception caught when applying #{method} to db object #{cache_item.value}: #{e}", e.backtrace
                     end
                   end
                 end
@@ -296,7 +316,7 @@ module ReactiveRecord
           end
 
           def apply_star
-            if @value && @value.__secure_collection_check(@acting_user) && @value.length > 0
+            if @value && @value.__secure_collection_check(self) && @value.length > 0
               i = -1
               @value.inject(nil) do |representative, current_value|
                 i += 1

data/spec_fails.txt

@@ -0,0 +1,3 @@
+rspec ./spec/batch5/save_while_loading_spec.rb:28 # save while loading with push
+rspec ./spec/batch4/default_value_spec.rb:40 # defaultValue special handling will not use the defaultValue param until data is loaded - unit test
+rspec ./spec/batch3/revert_spec.rb:39 # reverting records adds the todo to adam's todos and expects adam to change

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hyper-model
 version: !ruby/object:Gem::Version
-  version: 1.0.alpha1.2
+  version: 1.0.alpha1.3
 platform: ruby
 authors:
 - Mitch VanDuyn
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-16 00:00:00.000000000 Z
+date: 2019-01-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -45,42 +45,48 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.alpha1.2
+        version: 1.0.alpha1.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.alpha1.2
+        version: 1.0.alpha1.3
 - !ruby/object:Gem::Dependency
   name: hyper-operation
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.alpha1.2
+        version: 1.0.alpha1.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.alpha1.2
+        version: 1.0.alpha1.3
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.17.3
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.17.3
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2.1'
 - !ruby/object:Gem::Dependency
   name: capybara
   requirement: !ruby/object:Gem::Requirement
@@ -113,30 +119,30 @@ dependencies:
   name: libv8
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 6.3.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 6.3.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: mini_racer
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.15
+        version: 0.2.4
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.15
+        version: 0.2.4
 - !ruby/object:Gem::Dependency
   name: selenium-webdriver
   requirement: !ruby/object:Gem::Requirement
@@ -642,6 +648,7 @@ files:
 - lib/reactive_record/scope_description.rb
 - lib/reactive_record/serializers.rb
 - lib/reactive_record/server_data_cache.rb
+- spec_fails.txt
 homepage: http://ruby-hyperstack.org
 licenses:
 - MIT
@@ -661,8 +668,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.3.1
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.8
+rubygems_version: 3.0.2
 signing_key: 
 specification_version: 4
 summary: React based CRUD access and Synchronization of active record models across