hyper-component 0.99.1 → 0.99.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 033e8c3a738c41b433d8e8ba054dabca724eec598e5b6e2b5dbad51619ebeb8c
-  data.tar.gz: 8567e34a9e6bc8511d586f2f21bfd11a86f789f8833ab0335e4314647319d338
+  metadata.gz: 3eec3dbc742574274ae1bea9af9f6767412ccb1a2aebbf6e737cb247bfad64f1
+  data.tar.gz: e7ff055c0db0ceb8944513be3f1fb3205d9af3435453c1e02a817df3a2077381
 SHA512:
-  metadata.gz: 7c9cae251636743fbdaf9078703f5c040188f1bc664c384617f9021950ce1a928443bd4a7aaa44f75dd35c6da3be04e4e3d6fbd7a6cfc85da95c5824d35ab4d8
-  data.tar.gz: 412568d1fc5e3f46dfa3b47003c37921bcd75b336be1b5295bf8611d162c459379274db715a493bed8fb735f8207a4d49df444aa8d43393d76c54c556c3d725a
+  metadata.gz: 87180a8fbd5e0594cf66324ea67b4d4e383530613fa882191e14fd7cc9abcd81736400b511aec134037b6b72465e46889cad70d6033618157b8dfc28e4f59ead
+  data.tar.gz: 8ee1c764de8b086c01e81f46211158187efb7c298a2b26d4fb9f009f375f515cde96504cc3528185c0d25d56861f3f3f0f20d2f5f6067d554c0293bb78beb44c

data/Gemfile.lock

@@ -1,17 +1,9 @@
-GIT
-  remote: https://github.com/opal/opal-jquery.git
-  revision: 6249dfaf406ecd7199079b4f4d9dc67cfdf4d602
-  branch: master
-  specs:
-    opal-jquery (0.4.3)
-      opal (>= 0.10.0, < 0.12.0)
-
 PATH
   remote: ../hyper-spec
   specs:
-    hyper-spec (1.0.0.lap28)
+    hyper-spec (0.99.1)
       capybara
-      chromedriver-helper
+      chromedriver-helper (= 1.2.0)
       libv8 (~> 6.3.0)
       method_source
       mini_racer (~> 0.1.15)
@@ -28,14 +20,14 @@ PATH
 PATH
   remote: ../hyper-store
   specs:
-    hyper-store (1.0.0.lap28)
-      hyperloop-config (= 1.0.0.lap28)
+    hyper-store (0.99.1)
+      hyperloop-config (= 0.99.1)
       opal (>= 0.11.0, < 0.12.0)
 
 PATH
   remote: ../hyperloop-config
   specs:
-    hyperloop-config (1.0.0.lap28)
+    hyperloop-config (0.99.1)
       libv8 (~> 6.3.0)
       mini_racer (~> 0.1.15)
       opal (>= 0.11.0, < 0.12.0)
@@ -45,9 +37,9 @@ PATH
 PATH
   remote: .
   specs:
-    hyper-component (1.0.0.lap28)
-      hyper-store (= 1.0.0.lap28)
-      hyperloop-config (= 1.0.0.lap28)
+    hyper-component (0.99.1)
+      hyper-store (= 0.99.1)
+      hyperloop-config (= 0.99.1)
       libv8 (~> 6.3.0)
       mini_racer (~> 0.1.15)
       opal (>= 0.11.0, < 0.12.0)
@@ -113,7 +105,7 @@ GEM
       babel-source (>= 4.0, < 6)
       execjs (~> 2.0)
     builder (3.2.3)
-    capybara (3.7.2)
+    capybara (3.8.2)
       addressable
       mini_mime (>= 0.1.3)
       nokogiri (~> 1.8)
@@ -148,7 +140,7 @@ GEM
       rails-dom-testing (>= 1, < 3)
       railties (>= 4.2.0)
       thor (>= 0.14, < 2.0)
-    libv8 (6.3.292.48.1)
+    libv8 (6.3.292.48.1-x86_64-darwin-15)
     listen (3.1.5)
       rb-fsevent (~> 0.9, >= 0.9.4)
       rb-inotify (~> 0.9, >= 0.9.7)
@@ -185,6 +177,8 @@ GEM
     opal-browser (0.2.0)
       opal
       paggio
+    opal-jquery (0.4.3)
+      opal (>= 0.10.0, < 0.12.0)
     opal-rails (0.9.5)
       jquery-rails
       opal (>= 0.11.0, < 0.12)
@@ -309,7 +303,7 @@ GEM
       equalizer (~> 0.0.9)
       parser (>= 2.3.1.2, < 2.6)
       procto (~> 0.0.2)
-    webdrivers (3.4.0)
+    webdrivers (3.4.1)
       nokogiri (~> 1.6)
       rubyzip (~> 1.0)
       selenium-webdriver (~> 3.0)
@@ -333,7 +327,7 @@ DEPENDENCIES
   listen
   mime-types
   nokogiri
-  opal-jquery!
+  opal-jquery
   opal-rails (~> 0.9.4)
   opal-rspec
   pry

data/lib/hyper-component.rb

@@ -25,7 +25,7 @@ if RUBY_ENGINE == 'opal'
   require 'react/state'
   require 'react/object'
   require 'react/to_key'
-  require 'react/ext/opal-jquery/element'
+  #require 'react/ext/opal-jquery/element' # now have to manually require this
   require 'reactive-ruby/isomorphic_helpers'
   require 'react/top_level'
   require 'react/top_level_render'

data/lib/react/api.rb

@@ -238,7 +238,9 @@ module React
         elsif key == "key"
           props["key"] = value.to_key
 
-        elsif key == 'ref' && value.is_a?(Proc)
+        elsif key == 'ref' && value.respond_to?(:call)
+          # currently react still accepts the syntax ref: :foo meaning set refs.foo to the ref.
+          # in hyperstack release 0.1 we can put this behavior on a switch or use the notation `ref_key: :foo` for old school
           props[key] = %x{
                           function(dom_node){
                             if (dom_node !== null && dom_node.__opalInstance !== undefined && dom_node.__opalInstance !== null) {

data/lib/react/ext/opal-jquery/element.rb

@@ -13,15 +13,21 @@ Element.instance_eval do
   end
 
   define_method :render do |container = nil, params = {}, &block|
+    # create an invisible component class and hang it off the DOM element
     if `#{self.to_n}._reactrb_component_class === undefined`
-      `#{self.to_n}._reactrb_component_class = #{Class.new(Hyperloop::Component)}`
+      klass = Class.new(Hyperloop::Component) do
+        # react won't rerender the components unless it sees some params
+        # changing, so we just copy them all in, but we still just reuse
+        # the render macro to define the action
+        others :all_the_params
+      end
+      `#{self.to_n}._reactrb_component_class = #{klass}`
+    else
+      klass = `#{self.to_n}._reactrb_component_class`
     end
-    klass = `#{self.to_n}._reactrb_component_class`
-    klass.class_eval do
-      render(container, params, &block)
-    end
-
-    React.render(React.create_element(`#{self.to_n}._reactrb_component_class`), self)
+    # define / redefine the render method
+    klass.render(container, params, &block)
+    React.render(React.create_element(klass, {container: container, params: params, block: block}), self)
   end
 
   # mount_components is useful for dynamically generated page segments for example
@@ -34,4 +40,4 @@ Element.instance_eval do
     }
   }
   Element.expose :mount_components
-end if Object.const_defined?('Element')
+end

data/lib/react/top_level_render.rb

@@ -16,7 +16,9 @@ module React
     else
       native = `ReactDOM.render(#{element.to_n}, container)`
     end
-    
+
+    return unless `#{native} !== null`
+
     if `#{native}.__opalInstance !== undefined && #{native}.__opalInstance !== null`
       `#{native}.__opalInstance`
     elsif `ReactDOM.findDOMNode !== undefined && #{native}.nodeType === undefined`

data/lib/reactive-ruby/version.rb

@@ -1,5 +1,5 @@
 module Hyperloop
   class Component
-    VERSION = '0.99.1'
+    VERSION = '0.99.2'
   end
 end

data/misc/generators/reactive_ruby/test_app/test_app_generator.rb

@@ -1,5 +1,5 @@
 # Although we are not using this it would be good to move back to this model in future.
-# For one thing it would be a good way to test the hyperloop/hyperstack rails installer
+# For one thing it would be a good way to test the hyperloop/Hyperloop rails installer
 # so for now keep these files here as a template
 
 require 'rails/generators/rails/app/app_generator'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hyper-component
 version: !ruby/object:Gem::Version
-  version: 0.99.1
+  version: 0.99.2
 platform: ruby
 authors:
 - David Chang
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-25 00:00:00.000000000 Z
+date: 2018-10-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: hyper-store
@@ -20,28 +20,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.99.1
+        version: 0.99.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.99.1
+        version: 0.99.2
 - !ruby/object:Gem::Dependency
   name: hyperloop-config
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.99.1
+        version: 0.99.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.99.1
+        version: 0.99.2
 - !ruby/object:Gem::Dependency
   name: libv8
   requirement: !ruby/object:Gem::Requirement
@@ -158,14 +158,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.99.1
+        version: 0.99.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.99.1
+        version: 0.99.2
 - !ruby/object:Gem::Dependency
   name: jquery-rails
   requirement: !ruby/object:Gem::Requirement