hydra-remote_identifier 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3ab26b285d7aa330263fb086b0bc280448b9e7b0
-  data.tar.gz: cbcd41fd1cf8a074c30a1a7c5ff1c48028b8aef6
+  metadata.gz: f98bb8113e7148bed0364b4a49a438d70a21ed83
+  data.tar.gz: ae8a740d87e58916eb53df0a5bf3897ade3dd7bc
 SHA512:
-  metadata.gz: 36d568e724f9b87055c8ac453f64d25b57b0c221d478fce22ef03468b797d6758ed5ca0c571f627993eef923006b1d62a525e8a63f254c0a76a91dfd0914a20a
-  data.tar.gz: 46403c9ec84143ec5ae66c3ba072a582858d9b493281ff502b208d8c72a30230205b40dd7e5d3e55e87341d3aaabc6674523a139debfe6fd5d1f7d96f4fb8945
+  metadata.gz: 8c2e8a60049fddab49d180ee6e9f142553f0b113b0669dae6acc9e84ba0e6ae8f9c8427d8840cab30bf08496efe77cb4de0bf169a0b240151c30e5372530e4c7
+  data.tar.gz: 1a354e9bd6b9d793b621c607bf9f0d2eb1c045a94f3cd534f1bd369beb4c19d69a0093047ea279bec8a61afce4c7351280cfbb6502ab4e32d6d81a0b2fb55ffb

data/lib/hydra/remote_identifier.rb

@@ -38,18 +38,18 @@ module Hydra::RemoteIdentifier
     def with_registered_remote_service(remote_service_name, target)
       # @TODO - the registered remote identifier is more than a bit off;
       # but it continues to work
-      target.registered_remote_identifier_minters.each {|minter|
-        if minter.remote_service.name.to_s == remote_service_name.to_s
-          yield(minter.remote_service)
+      target.registered_remote_identifier_minters.each {|coordinator|
+        if coordinator.remote_service.name.to_s == remote_service_name.to_s
+          yield(coordinator.remote_service)
         end
       }
     end
 
-    def mint_if_applicable(remote_service_name, target)
-      remote_service = configuration.find_remote_service(remote_service_name)
-      if target.public_send(remote_service.accessor_name).to_i != 0
-        target.registered_remote_identifier_minters.each do |minter|
-          minter.call(target) if minter.remote_service == remote_service
+    def requested_remote_identifiers_for(target)
+      target.registered_remote_identifier_minters.each do |coordinator|
+        remote_service = coordinator.remote_service
+        if target.public_send(remote_service.accessor_name).to_i != 0
+          yield(remote_service.name)
         end
       end
     end
@@ -67,8 +67,8 @@ module Hydra::RemoteIdentifier
     def mint(remote_service_name, target)
       # @TODO - there is a better way to do this but this is "complete/correct"
       remote_service = configuration.find_remote_service(remote_service_name)
-      target.registered_remote_identifier_minters.each do |minter|
-        minter.call(target) if minter.remote_service == remote_service
+      target.registered_remote_identifier_minters.each do |coordinator|
+        coordinator.call(target) if coordinator.remote_service == remote_service
       end
     end
 

data/lib/hydra/remote_identifier/remote_service.rb

@@ -12,14 +12,6 @@ module Hydra::RemoteIdentifier
       self.class.to_s.demodulize.underscore.to_sym
     end
 
-    def mint(target)
-      Hydra::RemoteIdentifier.mint(name, target)
-    end
-
-    def mint_if_applicable(target)
-      Hydra::RemoteIdentifier.mint_if_applicable(name, target)
-    end
-
     def accessor_name
       "mint_#{name}".to_sym
     end

data/lib/hydra/remote_identifier/version.rb

@@ -1,5 +1,5 @@
 module Hydra
   module RemoteIdentifier
-    VERSION = "0.3.0"
+    VERSION = "0.4.0"
   end
 end

data/spec/lib/hydra/remote_identifier/remote_service_spec.rb

@@ -18,20 +18,6 @@ module Hydra::RemoteIdentifier
       it { expect { subject.valid_attribute?(:attribute_name) }.to raise_error NotImplementedError }
     end
 
-    context '#mint' do
-      it {
-        Hydra::RemoteIdentifier.should_receive(:mint).with(:remote_service, :target)
-        subject.mint(:target)
-      }
-    end
-
-    context '#mint_if_applicable' do
-      it {
-        Hydra::RemoteIdentifier.should_receive(:mint_if_applicable).with(:remote_service, :target)
-        subject.mint_if_applicable(:target)
-      }
-    end
-
   end
 
 end

data/spec/lib/hydra/remote_identifier_spec.rb

@@ -71,20 +71,20 @@ module Hydra::RemoteIdentifier
 
     end
 
-    describe '.mint_if_applicable' do
+    describe '.requested_remote_identifiers_for' do
 
-      it 'does not mint if accessor is not set' do
-        target.mint_doi = '0'
-        expect {
-          Hydra::RemoteIdentifier.mint_if_applicable(:doi, target)
-        }.to_not change(target, :set_identifier)
+      it 'should yield when the remote identifier was requested' do
+        target.mint_doi = '1'
+        expect { |block|
+          Hydra::RemoteIdentifier.requested_remote_identifiers_for(target, &block)
+        }.to yield_with_args(:doi)
       end
 
-      it 'mints if accessor is set to non-zero', VCR::SpecSupport.merge(record: :new_episodes, cassette_name: 'doi-integration') do
-        target.mint_doi = '1'
-        expect {
-          Hydra::RemoteIdentifier.mint_if_applicable(:doi, target)
-        }.to change(target, :set_identifier).from(nil).to(expected_doi)
+      it 'should not yield when the remote identifier was not requested' do
+        target.mint_doi = '0'
+        expect { |block|
+          Hydra::RemoteIdentifier.requested_remote_identifiers_for(target, &block)
+        }.to_not yield_control
       end
 
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hydra-remote_identifier
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Jeremy Friesen