hydra-remote_identifier 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c555e2e358d784219f8aeae86457d9a456410470
-  data.tar.gz: 1e6e8f346332a2692a6c04001837cb18ca3ef6db
+  metadata.gz: 10836a31b160f5f0061cb2d18a6ccce899434f52
+  data.tar.gz: feb33ac8e38e21c1bc001207d17ce834ef4c620e
 SHA512:
-  metadata.gz: 8ce31c0525b6c307bcebc30f9a227a87d047ad76da1a872c3a5454b900d2081f5aeedd67a0126bed876cba6337d0ec1efee78086f487c5a9377198b7fd68bd54
-  data.tar.gz: 8379665c7d8f1a022a3e09bf3f7ef4ed4fa126caebda959325f2585c437e3e4eb68ddb4c149e004f8c7b813997f404ee670ee56fa120d4e1b9b41e4f8bfc0c79
+  metadata.gz: b7cc709cba8c837303e438c6b71d369a49eb995ba17023dbef89f9814be236f59de0aa7decbf930541590cc6283da0781b9952267bcab1e8d5b21f4ff24d03ae
+  data.tar.gz: e7181ea4930d62f5c83c6886d49903c2566ead86ac600b615d8040749347bb809de0edf95673d053f38fb2125e9071c5a15d3e58f43c3b9989a7a27b1ed94153

data/README.md

@@ -1,5 +1,7 @@
 # Hydra::RemoteIdentifier
 
+[![Gem Version](https://badge.fury.io/rb/hydra-remote_identifier.png)](http://badge.fury.io/rb/hydra-remote_identifier)
+
 Coordinate the registration and minting of remote identifiers for persisted
 objects.
 
@@ -23,8 +25,8 @@ Configure your remote identifiers with credentials and what have you:
 
     doi_credentials = Psych.load('/path/to/doi_credentials.yml')
     Hydra::RemoteIdentifier.configure do |config|
-      config.configure_remote_service(:doi, doi_credentials) do |doi|
-        doi.register(target_class) do |map|
+      config.remote_service(:doi, doi_credentials) do |doi|
+        doi.register(Book, Page) do |map|
           map.target :url
           map.creator :creator
           map.title :title

data/lib/hydra/remote_identifier.rb

@@ -12,7 +12,7 @@ module Hydra::RemoteIdentifier
     #
     # @example
     #     Hydra::RemoteIdentifier.configure do |config|
-    #       config.configure_remote_service(:doi, doi_credentials) do |doi|
+    #       config.remote_service(:doi, doi_credentials) do |doi|
     #         doi.register(target_class) do |map|
     #           map.target :url
     #           map.creator :creator
@@ -31,6 +31,24 @@ module Hydra::RemoteIdentifier
       yield(configuration)
     end
 
+    # Using the RemoteService mint the corresponding remote identifier for
+    # the target. You must first configure the RemoteService and target's class
+    # to define the attribute map. See Hydra::RemoteIdentifier.configure
+    #
+    #
+    # @example
+    #     Hydra::RemoteIdentifier.mint(:doi, book)
+    #
+    # @param remote_service_name [#to_s]
+    # @param target [#registered_remote_identifier_minters]
+    def mint(remote_service_name, target)
+      # @TODO - there is a better way to do this but this is "complete/correct"
+      remote_service = configuration.find_remote_service(remote_service_name)
+      target.registered_remote_identifier_minters.each do |minter|
+        minter.call(target) if minter.remote_service == remote_service
+      end
+    end
+
   end
 
 end

data/lib/hydra/remote_identifier/configuration.rb

@@ -1,4 +1,5 @@
 require File.expand_path('../remote_services', __FILE__)
+require File.expand_path('../registration', __FILE__)
 
 module Hydra::RemoteIdentifier
 
@@ -7,25 +8,23 @@ module Hydra::RemoteIdentifier
   class Configuration
 
     def initialize(options = {})
-      @remote_service_namespace_container = options.fetch(:remote_service_namespace_container, Hydra::RemoteIdentifier::RemoteServices)
+      @remote_service_namespace_container = options.fetch(:remote_service_namespace_container, RemoteServices)
+      @registration_builder = options.fetch(:registration_builder, Registration)
       @remote_services = {}
     end
-    attr_reader :remote_service_namespace_container
-    private :remote_service_namespace_container
+    attr_reader :remote_service_namespace_container, :registration_builder
+    private :remote_service_namespace_container, :registration_builder
     attr_reader :remote_services
 
     def find_remote_service(service_name)
-      remote_services.fetch(service_name, remote_service_class_lookup(service_name).new)
+      remote_services.fetch(service_name)
     end
 
-    def remote_service(service_name, *args, &block)
-      remote_service_class_lookup(service_name).configure(*args, &block)
-    end
-
-    def configure_remote_service(service_name, *args, &block)
+    def remote_service(service_name, *args)
       remote_service = remote_service_class_lookup(service_name).new(*args)
-      remote_services[service_name]
-      yield(Registration.new(remote_service))
+      remote_services[service_name] = remote_service
+      registration = registration_builder.new(remote_service)
+      yield(registration)
       remote_service
     end
 

data/lib/hydra/remote_identifier/version.rb

@@ -1,5 +1,5 @@
 module Hydra
   module RemoteIdentifier
-    VERSION = "0.2.0"
+    VERSION = "0.2.1"
   end
 end

data/spec/lib/hydra/remote_identifier/configuration_spec.rb

@@ -6,11 +6,9 @@ module Hydra::RemoteIdentifier
     around do |example|
       module RemoteServices
         class MyRemoteService
-          class << self
-            attr_reader :options
-            def configure(*args, &block)
-              @options = [args, block]
-            end
+          attr_reader :options
+          def initialize(*options)
+            @options = options
           end
         end
       end
@@ -18,15 +16,19 @@ module Hydra::RemoteIdentifier
       RemoteServices.send(:remove_const, :MyRemoteService)
     end
 
-    subject { Configuration.new }
-
-    context 'with a missing service' do
-      specify do
-        expect { subject.remote_service(:obviously_missing_service) }.to raise_error(NotImplementedError)
+    subject { Configuration.new(registration_builder: registration_builder) }
+    let(:registration_builder) {
+      Class.new do
+        attr_reader :remote_service
+        def initialize(remote_service)
+          @remote_service = remote_service
+        end
       end
+    }
+    context 'with a missing service' do
       specify do
         expect {
-          subject.find_remote_service(:obviously_missing_service)
+          subject.remote_service(:obviously_missing_service)
         }.to raise_error(NotImplementedError)
       end
     end
@@ -34,15 +36,11 @@ module Hydra::RemoteIdentifier
     context 'with an existing service' do
       let(:block) { lambda {} }
       specify do
-        expect {
-          subject.remote_service(:my_remote_service, :arg, &block)
-        }.to change(RemoteServices::MyRemoteService, :options).from(nil).to([[:arg], block])
-      end
-      specify do
-        expect(subject.find_remote_service(:my_remote_service)).to be_an_instance_of(RemoteServices::MyRemoteService)
+        expect {|reg|
+          subject.remote_service(:my_remote_service, &reg)
+        }.to yield_with_args(registration_builder)
       end
     end
-
   end
 
 end

data/spec/lib/hydra/remote_identifier/registration_spec.rb

@@ -14,7 +14,7 @@ module Hydra::RemoteIdentifier
         subject.register(target_class, &map)
       }.to change{ target_class.respond_to?(:registered_remote_identifier_minters) }.from(false).to(true)
     end
-    it 'adds a .registered_remote_identifier_minters method' do
+    it 'registers the minting coordinator on the target class' do
       subject.register(target_class, &map)
       expect(target_class.registered_remote_identifier_minters).to eq [:minting_coordinator]
     end

data/spec/lib/hydra/remote_identifier/remote_service_spec.rb

@@ -4,12 +4,17 @@ module Hydra::RemoteIdentifier
 
   describe RemoteService do
 
-    describe 'instance methods' do
-      let(:payload) { 'abc' }
-      subject { RemoteService.new }
+    let(:payload) { 'abc' }
+    subject { RemoteService.new }
+
+    context '#call' do
       it { expect { subject.call(payload) }.to raise_error NotImplementedError }
+    end
+
+    context '#valid_attribute?' do
       it { expect { subject.valid_attribute?(:attribute_name) }.to raise_error NotImplementedError }
     end
+
   end
 
-end
+end

data/spec/lib/hydra/remote_identifier_spec.rb

@@ -1,3 +1,4 @@
+require 'spec_helper'
 require File.expand_path('../../../../lib/hydra/remote_identifier', __FILE__)
 module Hydra::RemoteIdentifier
 
@@ -34,7 +35,7 @@ module Hydra::RemoteIdentifier
 
       before(:each) do
         Hydra::RemoteIdentifier.configure do |config|
-          config.configure_remote_service(:doi, doi_options) do |doi|
+          config.remote_service(:doi, doi_options) do |doi|
             doi.register(target_class) do |map|
               map.target :url
               map.creator :creator
@@ -49,9 +50,7 @@ module Hydra::RemoteIdentifier
 
       it 'works!', VCR::SpecSupport.merge(record: :new_episodes, cassette_name: 'doi-integration') do
         expect {
-          target_class.registered_remote_identifier_minters.each do |minter|
-            minter.call(target)
-          end
+          Hydra::RemoteIdentifier.mint(:doi, target)
         }.to change(target, :set_identifier).from(nil).to(expected_doi)
       end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hydra-remote_identifier
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Jeremy Friesen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-03 00:00:00.000000000 Z
+date: 2013-10-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -145,7 +145,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.0.7
 signing_key: 
 specification_version: 4
 summary: Handles the registration and minting of remote identifiers (i.e. DOI, ARK,