hydra-batch-edit 1.1.1 → 2.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 79fb47a9472e45137f813ca99cc4b0d1ab5cd42e
-  data.tar.gz: ab0608ea60d01e4dbe0e2f1b3b3dd9957979c95d
+  metadata.gz: 69ea091b00ff503bd8818b9a8aee327d4e830b63
+  data.tar.gz: dd061b36c841a8143150dac1ea9da388e491b0e5
 SHA512:
-  metadata.gz: 530d8a2f8ba67235d59270901a683bec9dcaee20e1734a57b9d19844e81e7d26a01df776e882fd985014538965c3d7d658094a2368196a74a7f465b15357be8e
-  data.tar.gz: f7abaf0bdd6f51966014287156d25ab7ca9d2a257fdcdd43e997b1f7cbf671159d23bb788fc3b957e183b3c7fe94a92de46c1b967f44659392d8d971a677cdc7
+  metadata.gz: bd47ffb0ad55b19d8b8bfc66dd5593f88e679c2283082a8967d01f84c5776e3fb29f569610c76d8096f4a1eec265a175f7c2ec2ca0c710c12c81aa27b75a8c74
+  data.tar.gz: 4e0251902312a7ed1808b4c638861762612ea1f8662f524920b0b045e58d1090a599c10192dd03f80d986ef266644d19ec20434a0f9f1c25c50b31c0a652cbcc

data/.gitignore

@@ -25,3 +25,5 @@ doc/
 
 *.swp
 *.swo
+
+.internal_test_app

data/.rubocop.yml

@@ -0,0 +1,21 @@
+require: rubocop-rspec
+inherit_from: .rubocop_todo.yml
+
+AllCops:
+  DisplayCopNames: true
+  Include:
+    - '**/Rakefile'
+    - '**/config.ru'
+  Exclude:
+    - 'script/**/*'
+    - 'spec/test_app_templates/**/*'
+    - 'vendor/**/*'
+
+Metrics/AbcSize:
+  Max: 16
+
+Metrics/LineLength:
+  Max: 220
+
+RSpec/InstanceVariable:
+  Enabled: false

data/.rubocop_todo.yml

@@ -0,0 +1,278 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2016-04-20 07:34:46 -0700 using RuboCop version 0.39.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AlignWith, SupportedStyles, AutoCorrect.
+# SupportedStyles: start_of_line, def
+Lint/DefEndAlignment:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AlignWith, SupportedStyles, AutoCorrect.
+# SupportedStyles: keyword, variable, start_of_line
+Lint/EndAlignment:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Lint/StringConversionInInterpolation:
+  Exclude:
+    - 'spec/support/app/models/sample.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: IgnoreEmptyBlocks.
+Lint/UnusedBlockArgument:
+  Exclude:
+    - 'app/controllers/concerns/hydra/batch_edit_behavior.rb'
+    - 'lib/hydra/batch_edit/routes.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
+Lint/UnusedMethodArgument:
+  Exclude:
+    - 'lib/hydra/batch_edit/search_service.rb'
+    - 'spec/support/app/models/sample.rb'
+
+# Offense count: 4
+Lint/Void:
+  Exclude:
+    - 'spec/controllers/batch_edits_controller_spec.rb'
+    - 'spec/support/lib/generators/test_app_generator.rb'
+
+# Offense count: 2
+# Configuration parameters: CountComments.
+Metrics/MethodLength:
+  Max: 17
+
+# Offense count: 1
+RSpec/AnyInstance:
+  Exclude:
+    - 'spec/controllers/batch_edits_controller_spec.rb'
+
+# Offense count: 1
+RSpec/DescribeClass:
+  Exclude:
+    - 'spec/routing/batch_edit_routes_spec.rb'
+
+# Offense count: 2
+RSpec/DescribedClass:
+  Exclude:
+    - 'spec/lib/search_service_spec.rb'
+
+# Offense count: 26
+# Configuration parameters: CustomTransform, IgnoredWords.
+RSpec/ExampleWording:
+  Exclude:
+    - 'spec/controllers/batch_edits_controller_spec.rb'
+    - 'spec/helpers/batch_edit_helper_spec.rb'
+    - 'spec/lib/search_service_spec.rb'
+    - 'spec/routing/batch_edit_routes_spec.rb'
+
+# Offense count: 1
+# Configuration parameters: CustomTransform.
+RSpec/FilePath:
+  Exclude:
+    - 'spec/lib/search_service_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/DefWithParentheses:
+  Exclude:
+    - 'spec/support/app/models/sample.rb'
+
+# Offense count: 6
+Style/Documentation:
+  Exclude:
+    - 'spec/**/*'
+    - 'test/**/*'
+    - 'app/controllers/batch_edits_controller.rb'
+    - 'app/controllers/concerns/hydra/batch_edit_behavior.rb'
+    - 'lib/hydra/batch_edit.rb'
+    - 'lib/hydra/batch_edit/routes.rb'
+    - 'lib/hydra/batch_edit/search_service.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+Style/EmptyLines:
+  Exclude:
+    - 'spec/controllers/batch_edits_controller_spec.rb'
+    - 'spec/routing/batch_edit_routes_spec.rb'
+    - 'spec/spec_helper.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: empty_lines, no_empty_lines
+Style/EmptyLinesAroundBlockBody:
+  Exclude:
+    - 'spec/controllers/batch_edits_controller_spec.rb'
+    - 'spec/routing/batch_edit_routes_spec.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: empty_lines, no_empty_lines
+Style/EmptyLinesAroundClassBody:
+  Exclude:
+    - 'lib/hydra/batch_edit/routes.rb'
+    - 'spec/support/app/models/solr_document.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
+Style/ExtraSpacing:
+  Exclude:
+    - 'spec/support/db/migrate/20111101221803_create_searches.rb'
+
+# Offense count: 1
+# Configuration parameters: ExpectMatchingDefinition, Regex, IgnoreExecutableScripts.
+Style/FileName:
+  Exclude:
+    - 'lib/hydra-batch-edit.rb'
+
+# Offense count: 1
+# Configuration parameters: MinBodyLength.
+Style/GuardClause:
+  Exclude:
+    - 'app/controllers/concerns/hydra/batch_edit_behavior.rb'
+
+# Offense count: 61
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, UseHashRocketsWithSymbolValues.
+# SupportedStyles: ruby19, ruby19_no_mixed_keys, hash_rockets
+Style/HashSyntax:
+  Enabled: false
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: Width.
+Style/IndentationWidth:
+  Exclude:
+    - 'app/controllers/concerns/hydra/batch_edit_behavior.rb'
+    - 'lib/hydra/batch_edit.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+Style/LeadingCommentSpace:
+  Exclude:
+    - 'app/controllers/concerns/hydra/batch_edit_behavior.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: require_parentheses, require_no_parentheses, require_no_parentheses_except_multiline
+Style/MethodDefParentheses:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/MutableConstant:
+  Exclude:
+    - 'lib/hydra/batch_edit/version.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AllowMultipleReturnValues.
+Style/RedundantReturn:
+  Exclude:
+    - 'app/helpers/batch_edit_helper.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: space, no_space
+Style/SpaceAroundEqualsInParameterDefault:
+  Enabled: false
+
+# Offense count: 36
+# Cop supports --auto-correct.
+# Configuration parameters: AllowForAlignment.
+Style/SpaceAroundOperators:
+  Exclude:
+    - 'app/controllers/concerns/hydra/batch_edit_behavior.rb'
+    - 'app/helpers/batch_edit_helper.rb'
+    - 'lib/hydra/batch_edit/routes.rb'
+    - 'lib/hydra/batch_edit/search_service.rb'
+    - 'spec/controllers/batch_edits_controller_spec.rb'
+    - 'spec/lib/search_service_spec.rb'
+    - 'spec/routing/batch_edit_routes_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: space, no_space
+Style/SpaceBeforeBlockBraces:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AllowForAlignment.
+Style/SpaceBeforeFirstArg:
+  Exclude:
+    - 'spec/support/db/migrate/20111101221803_create_searches.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
+# SupportedStyles: space, no_space
+Style/SpaceInsideBlockBraces:
+  Enabled: false
+
+# Offense count: 18
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SupportedStyles.
+# SupportedStyles: space, no_space
+Style/SpaceInsideHashLiteralBraces:
+  Enabled: false
+
+# Offense count: 11
+# Cop supports --auto-correct.
+Style/SpaceInsideParens:
+  Exclude:
+    - 'spec/controllers/batch_edits_controller_spec.rb'
+    - 'spec/routing/batch_edit_routes_spec.rb'
+
+# Offense count: 90
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, ConsistentQuotesInMultiline.
+# SupportedStyles: single_quotes, double_quotes
+Style/StringLiterals:
+  Enabled: false
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: final_newline, final_blank_line
+Style/TrailingBlankLines:
+  Exclude:
+    - 'app/controllers/batch_edits_controller.rb'
+    - 'lib/hydra/batch_edit/routes.rb'
+    - 'lib/hydra/batch_edit/search_service.rb'
+
+# Offense count: 37
+# Cop supports --auto-correct.
+Style/TrailingWhitespace:
+  Exclude:
+    - 'app/controllers/concerns/hydra/batch_edit_behavior.rb'
+    - 'app/helpers/batch_edit_helper.rb'
+    - 'spec/controllers/batch_edits_controller_spec.rb'
+    - 'spec/routing/batch_edit_routes_spec.rb'
+    - 'spec/support/app/models/sample.rb'
+    - 'spec/support/app/models/solr_document.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
+# Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
+Style/TrivialAccessors:
+  Exclude:
+    - 'spec/support/app/models/sample.rb'

data/.travis.yml

@@ -1,9 +1,5 @@
 rvm:
-  - 2.0.0
-
-gemfile:
-  - gemfiles/rails3.gemfile
-  - gemfiles/rails4.gemfile
+  - 2.2.4
 
 notifications:
   irc: "irc.freenode.org#projecthydra"

data/Gemfile

@@ -2,3 +2,38 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in hydra-batch-edit.gemspec
 gemspec
+
+# BEGIN ENGINE_CART BLOCK
+# engine_cart: 0.8.2
+# engine_cart stanza: 0.8.0
+# the below comes from engine_cart, a gem used to test this Rails engine gem in the context of a Rails app.
+file = File.expand_path("Gemfile", ENV['ENGINE_CART_DESTINATION'] || ENV['RAILS_ROOT'] || File.expand_path(".internal_test_app", File.dirname(__FILE__)))
+if File.exist?(file)
+  begin
+    eval_gemfile file
+  rescue Bundler::GemfileError => e
+    Bundler.ui.warn '[EngineCart] Skipping Rails application dependencies:'
+    Bundler.ui.warn e.message
+  end
+else
+  Bundler.ui.warn "[EngineCart] Unable to find test application dependencies in #{file}, using placeholder dependencies"
+
+  if ENV['RAILS_VERSION']
+    if ENV['RAILS_VERSION'] == 'edge'
+      gem 'rails', github: 'rails/rails'
+      ENV['ENGINE_CART_RAILS_OPTIONS']= "--edge --skip-turbolinks"
+    else
+      gem 'rails', ENV['RAILS_VERSION']
+    end
+  end
+
+  if ENV['RAILS_VERSION'].nil? || ENV['RAILS_VERSION'] =~ /^4.2/
+    gem 'responders', "~> 2.0"
+    gem 'sass-rails', ">= 5.0"
+  elsif ENV['RAILS_VERSION'] =~ /^5.0/ || ENV['RAILS_VERSION'] == 'edge'
+    # nop
+  else
+    gem 'sass-rails', "< 5.0"
+  end
+end
+# END ENGINE_CART BLOCK

data/README.textile

@@ -1,6 +1,6 @@
 h1. hydra-batch-edit
 
-!https://travis-ci.org/projecthydra/hydra-batch-edit.png!:https://travis-ci.org/projecthydra/hydra-batch-edit !https://badge.fury.io/rb/hydra-batch-edit.png!:http://badge.fury.io/rb/hydra-batch-edit
+!https://travis-ci.org/projecthydra-labs/hydra-batch-edit.png!:https://travis-ci.org/projecthydra-labs/hydra-batch-edit !https://badge.fury.io/rb/hydra-batch-edit.png!:http://badge.fury.io/rb/hydra-batch-edit
 
 Batch Editing Functionality for Hydra Heads
 
@@ -33,31 +33,21 @@ In your Gemfile, add
 
 <pre>gem 'hydra-batch-edit'</pre> 
 
-# Call batch_edit_tools view helper in your search result page template.  We recommend putting it in catalog/_sort_and_per_page.html.erb
-# Call batch_edit_continue in the search result page template.  We put it in catalog/index.html
-# Call batch_edit_select(document) [passing in the solr document] on the index partial that's rendered for each search result
-# Add routes to config/routes.rb 
-<pre>
-  Hydra::BatchEdit.add_routes(self)
-</pre>
-# Add javascript to app/assets/javascripts/application.js
-<pre>
-  //= require batch_edit
-</pre>
-# Add css to app/assets/stylesheets/application.css
+# Run the install generator
 <pre>
-  *= require batch_edit
+  $ rails g hydra_batch_edit:install
 </pre>
-  
-
 
+# Call batch_edit_tools view helper in your search result page template.  We recommend putting it in catalog/_sort_and_per_page.html.erb
+# Call batch_edit_continue in the search result page template.  We put it in catalog/index.html
+# Call batch_edit_select(document) [passing in the solr document] on the index partial that's rendered for each search result
 
 h2. Dependencies
 
 hydra-head
-hydra-collections
+curation_concerns
 bootstrap
-blacklight.js
+blacklight
 coffeescript & scss
 
   

data/Rakefile

@@ -1,58 +1,27 @@
 #!/usr/bin/env rake
-require "bundler/gem_tasks"
-require 'rspec/core/rake_task'
-
-ENV["RAILS_ROOT"] ||= 'spec/internal'
-
-desc 'Default: run specs.'
-task :default => :spec
-
-
-task :spec => [:generate] do |t|
-  focused_spec = ENV['SPEC'] ? " SPEC=#{File.join(GEM_ROOT, ENV['SPEC'])}" : ''
-  within_test_app do
-    system "rake myspec#{focused_spec}"
-    abort "Error running hydra-batch-edit" unless $?.success?
-  end
+begin
+  require 'bundler/setup'
+rescue LoadError
+  puts 'You must `gem install bundler` and `bundle install` to run rake tasks'
 end
 
+Bundler::GemHelper.install_tasks
 
+task default: [:ci]
 
-desc "Create the test rails app"
-task :generate do
-  unless File.exists?('spec/internal/Rakefile')
-    puts "Generating rails app"
-    `rails new spec/internal`
-    puts "Updating gemfile"
-    `echo "gem 'hydra-batch-edit', :path=>'../../../hydra-batch-edit'
-gem 'rspec-rails'
-    " >> spec/internal/Gemfile`
-    puts "Copying generator"
-    `cp -r spec/support/lib/generators spec/internal/lib`
-
-    within_test_app do
-      puts "Bundle install"
-      puts `bundle install`
-      puts "running generator"
-      puts `rails generate test_app`
+require 'rspec/core/rake_task'
+require 'engine_cart/rake_task'
+require 'rubocop/rake_task'
 
-      puts "running migrations"
-      puts `rake db:migrate db:test:prepare`
-    end
-  end
-  puts "Running specs"
+desc 'Run style checker'
+RuboCop::RakeTask.new(:rubocop) do |task|
+  task.requires << 'rubocop-rspec'
+  task.fail_on_error = true
 end
 
-desc "Clean out the test rails app"
-task :clean do
-  puts "Removing sample rails app"
-  `rm -rf spec/internal`
-end
+RSpec::Core::RakeTask.new(:spec)
 
-def within_test_app
-  FileUtils.cd('spec/internal')
-  Bundler.with_clean_env do
-    yield
-  end
-  FileUtils.cd('../..')
+desc 'Start solr, fcrepo, and run specs'
+task ci: ['rubocop', 'engine_cart:generate'] do
+  Rake::Task['spec'].invoke
 end