hydra-batch-edit 0.0.5 → 0.0.6

data/lib/hydra/batch_edit/version.rb

@@ -1,5 +1,5 @@
 module Hydra
   module BatchEdit
-    VERSION = "0.0.5"
+    VERSION = "0.0.6"
   end
 end

data/lib/hydra/batch_edit_behavior.rb

@@ -58,7 +58,7 @@ module Hydra::BatchEditBehavior
     batch.each do |doc_id|
       obj = ActiveFedora::Base.find(doc_id, :cast=>true)
       type = obj.class.to_s.underscore.to_sym
-      obj.update_attributes(params[type])
+      obj.update_attributes(params[type].reject{|k, v| v.blank?})
       obj.save
     end
     flash[:notice] = "Batch update complete"

data/spec/controllers/batch_edits_controller_spec.rb

@@ -98,17 +98,24 @@ describe BatchEditsController do
         @two.save
         put :add, :id =>@one.pid
         put :add, :id => @two.pid
-      end
-      it "should update all the field" do
         controller.should_receive(:can?).with(:edit, @one.pid).and_return(true)
         controller.should_receive(:can?).with(:edit, @two.pid).and_return(true)
         ActiveFedora::Base.should_receive(:find).with( @one.pid, :cast=>true).and_return(@one)
         ActiveFedora::Base.should_receive(:find).with( @two.pid, :cast=>true).and_return(@two)
+      end
+      it "should update all the field" do
         put :update, :sample=>{:titleSet_display=>'My title' } 
         response.should redirect_to '/catalog'
         flash[:notice].should == "Batch update complete"
         Sample.find(@one.pid).titleSet_display.should == "My title"
       end
+      it "should not update blank values" do
+        @one.titleSet_display = 'Original value'
+        put :update, :sample=>{:titleSet_display=>'' } 
+        response.should redirect_to '/catalog'
+        flash[:notice].should == "Batch update complete"
+        Sample.find(@one.pid).titleSet_display.should == "Original value"
+      end
     end
   end
 

data/spec/support/app/models/sample.rb

@@ -16,11 +16,10 @@ class Sample
   end
 
   def update_attributes(attributes)
-    metaclass = class << self; self; end
     attributes.each do |k, v|
-      metaclass.send(:define_method, k) do
-        v
-      end
+      instance_variable_set "@#{k.to_s}".to_sym, v
+      
+      self.class.send :attr_accessor, k
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hydra-batch-edit
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
   prerelease: 
 platform: ruby
 authors:
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-06-19 00:00:00.000000000 Z
+date: 2012-06-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: blacklight
@@ -153,3 +153,4 @@ test_files:
 - spec/support/app/models/solr_document.rb
 - spec/support/db/migrate/20111101221803_create_searches.rb
 - spec/support/lib/generators/test_app_generator.rb
+has_rdoc: