hudson-remote-api 0.3.1 → 0.3.2

data/Rakefile

@@ -17,4 +17,12 @@ rescue LoadError
   puts "Jeweler not available. Install it with: sudo gem install jeweler -s http://gemcutter.org"
 end
 
+namespace :test do
+   desc "Run all tests"
+   task :all do
+      test_files = Dir.glob("test/*.rb")
+      test_files.each{|f| require f}
+   end
+end
+
 Dir["#{File.dirname(__FILE__)}/tasks/*.rake"].sort.each { |ext| load ext }

data/VERSION

@@ -1 +1 @@
-0.3.1
+0.3.2

data/hudson-remote-api.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{hudson-remote-api}
-  s.version = "0.3.1"
+  s.version = "0.3.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = [%q{Dru Ibarra}]
-  s.date = %q{2011-10-05}
+  s.date = %q{2011-10-10}
   s.description = %q{Connect to Hudson's remote web API}
   s.email = %q{Druwerd@gmail.com}
   s.extra_rdoc_files = [
@@ -35,8 +35,7 @@ Gem::Specification.new do |s|
      "test/test_hudson_build_queue.rb",
      "test/test_hudson_config.rb",
      "test/test_hudson_job.rb",
-     "test/test_hudson_multicast.rb",
-     "test/test_hudson_remote_api.rb"
+     "test/test_hudson_multicast.rb"
   ]
   s.homepage = %q{http://github.com/Druwerd/hudson-remote-api}
   s.rdoc_options = [%q{--charset=UTF-8}]
@@ -49,8 +48,7 @@ Gem::Specification.new do |s|
      "test/test_hudson_build_queue.rb",
      "test/test_hudson_config.rb",
      "test/test_hudson_job.rb",
-     "test/test_hudson_multicast.rb",
-     "test/test_hudson_remote_api.rb"
+     "test/test_hudson_multicast.rb"
   ]
 
   if s.respond_to? :specification_version then

data/lib/hudson-remote-api.rb

@@ -15,6 +15,16 @@ module Hudson
   # Base class for all Hudson objects
   class HudsonObject
     
+    def self.hudson_request(uri,request)
+       Net::HTTP.start(uri.host, uri.port) do |http| 
+        http = Net::HTTP.new(uri.host, uri.port)
+        if uri.scheme == 'https'
+          http.use_ssl = true
+          http.verify_mode = OpenSSL::SSL::VERIFY_NONE
+        end
+        http.request(request)
+      end
+    end
     
     def self.load_xml_api
       @@hudson_xml_api_path = File.join(Hudson[:url], "api/xml")
@@ -28,21 +38,14 @@ module Hudson
     end
 
     def self.get_xml(url)
-      uri = URI.parse(url)
+      uri = URI.parse(URI.encode(url))
       host = uri.host
       port = uri.port
       path = uri.path
       request = Net::HTTP::Get.new(path)
       request.basic_auth(Hudson[:user], Hudson[:password]) if Hudson[:user] and Hudson[:password]
       request['Content-Type'] = "text/xml"
-      response = Net::HTTP.start(host, port) do |http| 
-        http = Net::HTTP.new(uri.host, uri.port)
-        if uri.scheme == 'https'
-          http.use_ssl = true
-          http.verify_mode = OpenSSL::SSL::VERIFY_NONE
-        end
-        http.request(request)
-      end
+      response = hudson_request(uri,request)
 
       if response.is_a?(Net::HTTPSuccess) or response.is_a?(Net::HTTPRedirection)
         encoding = response.get_fields("Content-Encoding")
@@ -52,7 +55,7 @@ module Hudson
           return response.body
         end
       else
-        puts response
+        $stderr.puts response.body
         raise APIError, "Error retrieving #{path}"
       end
     end
@@ -62,7 +65,7 @@ module Hudson
     end
 
     def self.send_post_request(url, data={})
-      uri = URI.parse(url)
+      uri = URI.parse(URI.encode(url))
       host = uri.host
       port = uri.port
       path = uri.path
@@ -70,7 +73,7 @@ module Hudson
       request.basic_auth(Hudson[:user], Hudson[:password]) if Hudson[:user] and Hudson[:password]
       request.set_form_data(data)
       request.add_field(crumb.name, crumb.value) if crumb
-      Net::HTTP.new(host, port).start{|http| http.request(request)}
+      hudson_request(uri,request)
     end
     
     def send_post_request(url, data={})
@@ -78,7 +81,7 @@ module Hudson
     end
 
     def self.send_xml_post_request(url, xml, data=nil)
-      uri = URI.parse(url)
+      uri = URI.parse(URI.encode(url))
       host = uri.host
       port = uri.port
       path = uri.path
@@ -88,7 +91,7 @@ module Hudson
       request.set_form_data(data) if data
       request.add_field(crumb.name, crumb.value) if crumb
       request.body = xml
-      Net::HTTP.new(host, port).start{|http| http.request(request)}
+      hudson_request(uri,request)
     end
     
     def send_xml_post_request(url, xml, data=nil)

data/test/test_hudson_job.rb

@@ -59,4 +59,11 @@ class TestHudsonJob < Test::Unit::TestCase
     job = Hudson::Job.get("test_job")
     assert_equal(job.url, "http://localhost:8080/job/#{job.name}/")
   end
+  
+  def test_job_with_spaces
+    job = Hudson::Job.create('test job with spaces')
+    assert job
+    assert job.name
+    assert job.delete
+  end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: hudson-remote-api
 version: !ruby/object:Gem::Version 
-  hash: 17
+  hash: 23
   prerelease: 
   segments: 
   - 0
   - 3
-  - 1
-  version: 0.3.1
+  - 2
+  version: 0.3.2
 platform: ruby
 authors: 
 - Dru Ibarra
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-10-05 00:00:00 Z
+date: 2011-10-10 00:00:00 Z
 dependencies: []
 
 description: Connect to Hudson's remote web API
@@ -47,7 +47,6 @@ files:
 - test/test_hudson_config.rb
 - test/test_hudson_job.rb
 - test/test_hudson_multicast.rb
-- test/test_hudson_remote_api.rb
 homepage: http://github.com/Druwerd/hudson-remote-api
 licenses: []
 
@@ -87,4 +86,3 @@ test_files:
 - test/test_hudson_config.rb
 - test/test_hudson_job.rb
 - test/test_hudson_multicast.rb
-- test/test_hudson_remote_api.rb

data/test/test_hudson_remote_api.rb

@@ -1,2 +0,0 @@
-test_files = Dir.glob("*.rb")
-test_files.each{|f| require f}