hubstats 0.12.1 → 0.12.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a0ead1316136280de22c765e00d40f8b0ef89ccd
-  data.tar.gz: 760e93ad92c0ca58768a9c7d7e6fe64379ee5932
+  metadata.gz: 5c64060494a5b0519e55a8baaa92e0275adfec5f
+  data.tar.gz: 32d75bfb93d1eaa5b2923832fe5b177d17364ce8
 SHA512:
-  metadata.gz: 41727a4a51bc98b10e12971bf9cbc34036d346d8c0abc2a49a58d2590cbb5d9c135bb88e7986b334eacd4329b9a4e44ace76977ec8345e443574776f61322095
-  data.tar.gz: 6793ad8af6fee4ae2d6ff99e19e00ca7a742a2f7428e967a82aeb288195553161c617fa256f33d7368d0873adcd0f99c9d64fa504a87b9ab9db0365422bee902
+  metadata.gz: dedcad39ebd8266563d7ebe10ada5d9a1fbf78fb990abc21d9cfff5d3b7f7aa05af4b0e47544df274b497cf21332e5cf8c940163e5b1fb690a98461759825d99
+  data.tar.gz: a5ead0f76dd1b3679795dc1dc7fd250ac864e0245f6c46954eac361e38f5075b88e7a04add615b2e8859eb38d58764536924329997c4013c2cf41037437dfa5b

data/CHANGELOG.markdown

@@ -1,3 +1,8 @@
+#### v0.12.2
+* Fix bug that results in comments never being saved
+
+  > Emma Sax: production-status-check[bot]: https://github.com/sportngin/hubstats/pull/134
+
 #### v0.12.1
 * Show 50 items in detailed show pages
 

data/app/models/hubstats/comment.rb

@@ -32,7 +32,7 @@ module Hubstats
     def self.create_or_update(github_comment)
       github_comment = github_comment.to_h.with_indifferent_access if github_comment.respond_to? :to_h
 
-      unless github_comment[:user_id]
+      unless github_comment[:user]
         Rails.logger.warn "Found comment with no user, ignoring. GitHub comment ID: #{github_comment[:id]}"
         return nil
       end

data/hubstats.gemspec

@@ -16,7 +16,7 @@ Gem::Specification.new do |s|
   s.files         = `git ls-files -z`.split("\x0")
   s.test_files    = s.files.grep(%r{^(test|spec|features)/})
 
-  s.add_dependency "rails", "~> 4.2"
+  s.add_dependency "rails", "~> 4.2.10"
   s.add_dependency "octokit", "~> 4.2"
   s.add_dependency "will_paginate-bootstrap", "~> 1.0"
   s.add_dependency "select2-rails", "~> 3.0"

data/lib/hubstats/version.rb

@@ -1,3 +1,3 @@
 module Hubstats
-  VERSION = "0.12.1"
+  VERSION = "0.12.2"
 end

data/spec/lib/hubstats/events_handler_spec.rb

@@ -63,20 +63,34 @@ module Hubstats
 
       it 'should successfully creates_or_updates the event' do
         ehandler = Hubstats::EventsHandler.new()
-        payload = build(:comment_payload_hash, :user => {:login=>"hermina", :id=>0, :role=>"User"},
-                                               :comment => {"id"=>194761, "body"=>"Quidem ea minus ut odio optio.",
-                                                            "kind"=>"Issue", "user_id"=>0, "repo_id"=>101010,
-                                                            "created_at" => Date.today, "updated_at" => Date.today})
+        payload = build(:comment_payload_hash,
+          :user => {:login=>"hermina", :id=>0, :role=>"User"},
+          :comment => {
+            "id"=>194761, 
+            "body"=>"Quidem ea minus ut odio optio.",
+            "kind"=>"Issue",
+            "user"=>{},
+            "created_at" => Date.today,
+            "updated_at" => Date.today
+          }
+        )
         allow(Hubstats::User).to receive_message_chain(:create_or_update).and_return(user)
         expect(ehandler.route(payload, payload[:type]).class).to eq(Hubstats::Comment)
       end
 
-      it 'should successfully creates_or_updates the event even if the user_id is missing' do
+      it 'should successfully creates_or_updates the event even if the user is missing' do
         ehandler = Hubstats::EventsHandler.new()
-        payload = build(:comment_payload_hash, :user => {:login=>"hermina", :id=>0, :role=>"User"},
-                        :comment => {"id"=>194761, "body"=>"Quidem ea minus ut odio optio.",
-                                     "kind"=>"Issue", "repo_id"=>101010,
-                                     "created_at" => Date.today, "updated_at" => Date.today})
+        payload = build(:comment_payload_hash,
+          :user => {:login=>"hermina", :id=>0, :role=>"User"},
+          :comment => {
+            "id"=>194761, 
+            "body"=>"Quidem ea minus ut odio optio.",
+            "kind"=>"Issue", 
+            "user"=>nil,
+            "created_at" => Date.today, 
+            "updated_at" => Date.today
+          }
+        )
         allow(Hubstats::User).to receive_message_chain(:create_or_update).and_return(user)
         expect(ehandler.route(payload, payload[:type])).to be_nil
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hubstats
 version: !ruby/object:Gem::Version
-  version: 0.12.1
+  version: 0.12.2
 platform: ruby
 authors:
 - Elliot Hursh
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-06-08 00:00:00.000000000 Z
+date: 2018-08-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -17,14 +17,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: 4.2.10
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: 4.2.10
 - !ruby/object:Gem::Dependency
   name: octokit
   requirement: !ruby/object:Gem::Requirement