hubssolib 3.2.0 → 3.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c6df4bbfdb7389a9ae74fd974f9aec00f80caccf38a9702514bea230563c8abf
-  data.tar.gz: 6714640777624dc0a90744f125218375c42ff322401bcf65dc2d730df2de4a0c
+  metadata.gz: ff87f5cf7f12fbe119c62700a1967efe14365bd60ac1a9c4be277825320e62eb
+  data.tar.gz: 91a60374a009856c6090365fd711a0ad4a3e1b2d5deceaa845e10d215717fd43
 SHA512:
-  metadata.gz: 52375b875cda94de7b2823a1b718a5588f27c0c093d4f0010373670ffc4b54da4c5211e627719a56f10179cb3a91b86403a31f955b07348f7bfdaa25906de410
-  data.tar.gz: 5ef7b400a85299a3925994bba59d8c6ff1b1ded612541affd288413955eee935971e7d0bb8e61855fef42955baa3b6b2331333b720de82f1cdfcfff0f4a5eb94
+  metadata.gz: c77c64ac36ca1ddb3b31fd96b0061cb8bb63e4ca512c9ef59fe010fb4917310dcabf1bff99a5b404b7105d6607bd81adfaece9803d4b0f48aa57e861d1084864
+  data.tar.gz: ff31f8a5fb859f35f1c0e777c49127ed02692e00056ef3dd7bfdd74e034066096b89358cc2e834850a84d33d64b7d020edcc0d400648307ad92c6f28f910e682

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 3.2.1, 16-Feb-2025
+
+The conditional login return-via-referrer mechanism never really worked, so instead have the login status indicator link generate a return-to URL in the query string instead and forward that, if present, in preference.
+
 ## 3.2.0, 15-Feb-2025
 
 Introduces the user change handler mechanism, a scheme whereby an external application tells Hub about a Rake task that the application has implemented, through which Hub can inform if of changes to a user's e-mail address or "real" name. See the gem's `README.md` for details, under "Applications with an existing user model".

data/README.md

@@ -166,7 +166,7 @@ To solve these problems, external applications integrated with Hub can participa
 ```ruby
 module Foo
   class Application < Rails::Application
-    require HubSsoLib::Core
+    include HubSsoLib::Core
 
     hubssolib_register_user_change_handler(
       app_name: Rails.application.name,
@@ -187,12 +187,19 @@ For example, `lib/tasks/hub.rake` might look like this:
 namespace :hub do
   desc 'Update a user with details sent from Hub'
   task :update_user, [:old_email, :old_name, :new_email, :new_name] => :environment do | t, args |
-    user = User.find_by_email_address(old_email)
-    user&.update!(email_address: new_email, display_name: new_name)
+    user = User.find_by_email_address(args[:old_email])
+
+    # ...or use "user&.update_columns" for speed and to bypass validations, as
+    # Hub's validations may not be as strict as yours but it doesn't matter if
+    # you're happy syncing Hub data in general.
+    #
+    user&.update!(email_address: args[:new_email], display_name: args[:new_name])
   end
 end
 ```
 
+The four arguments are guaranteed to be present and non-empty, with leading or trailing white space already stripped. You don't need to waste time checking for `nil` or blank values. The upper/lower case **is preserved**, as entered by the user, for all arguments - so e-mail addresses in particular might contain a mixture of upper and lower case letters. If this matters to your application, be sure to apply whatever normalisation you previously used when your user record was originally created with the old Hub-sourced e-mail and/or name.
+
 
 
 ## Hub library API

data/hubssolib.gemspec

@@ -4,7 +4,7 @@ spec = Gem::Specification.new do |s|
   s.platform = Gem::Platform::RUBY
   s.name     = 'hubssolib'
 
-  s.version  = '3.2.0'
+  s.version  = '3.2.1'
   s.author   = 'Andrew Hodgkinson and others'
   s.email    = 'ahodgkin@rowing.org.uk'
   s.homepage = 'http://pond.org.uk/'

data/lib/hub_sso_lib.rb

@@ -555,6 +555,15 @@ module HubSsoLib
       noscript_img_src = "#{HUB_PATH_PREFIX}/account/login_indication.png"
       noscript_img_tag = helpers.image_tag(noscript_img_src, size: '90x22', border: '0', alt: 'Log in or out')
 
+      if self.respond_to?(:request)
+        return_to_url = self.request.try(:original_url)
+
+        if return_to_url.present?
+          return_query = URI.encode_www_form({ return_to_url: return_to_url.to_s })
+          ui_href << "?#{return_query}"
+        end
+      end
+
       logged_in_link   = helpers.link_to('Account',        ui_href, id: 'hubssolib_logged_in_link')
       logged_out_link  = helpers.link_to('Log in',         ui_href, id: 'hubssolib_logged_out_link')
       noscript_link    = helpers.link_to(noscript_img_tag, ui_href, id: 'hubssolib_login_noscript')

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: hubssolib
 version: !ruby/object:Gem::Version
-  version: 3.2.0
+  version: 3.2.1
 platform: ruby
 authors:
 - Andrew Hodgkinson and others
 bindir: bin
 cert_chain: []
-date: 2025-02-15 00:00:00.000000000 Z
+date: 2025-02-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: drb