httpx 0.15.1 → 0.15.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 71d64789176a94e104957666f409c327a17827e4384e1387c14c2471e1b98994
-  data.tar.gz: 0a516128ac747a041ae8e5d86da78c7687d124f830850484ed372c83d67e4745
+  metadata.gz: 63059d2ae3e913d077850d4a95fc5aa4a9f0691aa92834ddf6898d38b8ec0913
+  data.tar.gz: a9f689d038c7ee258ce2a2dd68d56fd21104be96b8f12c20a240cd024eea6576
 SHA512:
-  metadata.gz: 83f6d5041140e1670e7175db3d9a3269a3766a5b8b29076ba7ee4025ef035411a4458c5df25cce4d70a10fd34fdc1cbda30fa315b3a77c585d58672ec35f737d
-  data.tar.gz: '05298bf9e3fc41c8fe7315558a6842af2dbe915c8f5cfb119ca019cc8e83dbde93a9d57222bbf0098603b3fde00a5e8f1de05f4d62cf5fe81a6f7213a8c8107d'
+  metadata.gz: 940075fbe22ed29a3a0b5a6a85f69ef25bab2dac876eed6779b840b761dd8c7cff09a43f861fd2e39a42b82652d01bcf4aa0384afc1d4d253b9eb82d4f2adb21
+  data.tar.gz: 8efa63c8c6c7c5c8869e507e64932167082f27c85d2c3bd026a9bc29d8c052d8e26612e35c06f046b2c9b5c8b6dd102d20a29d7ef67a7babc4c0ad0f990f471b

data/doc/release_notes/0_15_2.md

@@ -0,0 +1,9 @@
+# 0.15.2
+
+## Bugfixes
+
+* Fixed cookie management for same-keys: before the fix, cookies with same-key, same-domain and same-path were all being sent in subsequent requests, which violates  RFC 6265 - 5.4 . As of now, only the last valid cookie for a given key/domain/path will be kept, evicting the others.
+
+## Chore
+
+* debug logs were inserting ASCII code string wrappers, even when no color was set. It nonw only sends the plain string.

data/lib/httpx/loggable.rb

@@ -20,7 +20,7 @@ module HTTPX
       debug_stream = @options.debug
 
       message = (+"" << msg.call << "\n")
-      message = "\e[#{COLORS[color]}m#{message}\e[0m" if debug_stream.respond_to?(:isatty) && debug_stream.isatty
+      message = "\e[#{COLORS[color]}m#{message}\e[0m" if color && debug_stream.respond_to?(:isatty) && debug_stream.isatty
       debug_stream << message
     end
 

data/lib/httpx/options.rb

@@ -144,7 +144,7 @@ module HTTPX
       Array(value)
     OUT
 
-    %w[
+    %i[
       params form json body ssl http2_settings
       request_class response_class headers_class request_body_class response_body_class connection_class
       io fallback_protocol debug debug_level transport_options resolver_class resolver_options
@@ -171,6 +171,8 @@ module HTTPX
     end
 
     def merge(other)
+      raise ArgumentError, "#{other.inspect} is not a valid set of options" unless other.respond_to?(:to_hash)
+
       h2 = other.to_hash
       return self if h2.empty?
 

data/lib/httpx/plugins/cookies/cookie.rb

@@ -43,8 +43,7 @@ module HTTPX
         # Precedence: 1. longer path  2. older creation
         (@name <=> other.name).nonzero? ||
           (other.path.length <=> @path.length).nonzero? ||
-          (@created_at <=> other.created_at).nonzero? ||
-          @value <=> other.value
+          (@created_at <=> other.created_at).nonzero?
       end
 
       class << self

data/lib/httpx/plugins/cookies/jar.rb

@@ -43,6 +43,10 @@ module HTTPX
 
         c.path = path if path && c.path == "/"
 
+        # If the user agent receives a new cookie with the same cookie-name, domain-value, and path-value
+        # as a cookie that it has already stored, the existing cookie is evicted and replaced with the new cookie.
+        @cookies.delete_if { |ck| ck.name == c.name && ck.domain == c.domain && ck.path == c.path }
+
         @cookies << c
       end
 

data/lib/httpx/selector.rb

@@ -95,14 +95,18 @@ class HTTPX::Selector
       retry
     end
 
-    readers.each do |io|
-      yield io
+    if writers
+      readers.each do |io|
+        yield io
 
-      # so that we don't yield 2 times
-      writers.delete(io)
-    end if readers
+        # so that we don't yield 2 times
+        writers.delete(io)
+      end if readers
 
-    writers.each(&block) if writers
+      writers.each(&block)
+    else
+      readers.each(&block) if readers
+    end
   end
 
   def select_one(interval)

data/lib/httpx/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module HTTPX
-  VERSION = "0.15.1"
+  VERSION = "0.15.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: httpx
 version: !ruby/object:Gem::Version
-  version: 0.15.1
+  version: 0.15.2
 platform: ruby
 authors:
 - Tiago Cardoso
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-06-24 00:00:00.000000000 Z
+date: 2021-07-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: http-2-next
@@ -70,6 +70,7 @@ extra_rdoc_files:
 - doc/release_notes/0_14_5.md
 - doc/release_notes/0_15_0.md
 - doc/release_notes/0_15_1.md
+- doc/release_notes/0_15_2.md
 - doc/release_notes/0_1_0.md
 - doc/release_notes/0_2_0.md
 - doc/release_notes/0_2_1.md
@@ -119,6 +120,7 @@ files:
 - doc/release_notes/0_14_5.md
 - doc/release_notes/0_15_0.md
 - doc/release_notes/0_15_1.md
+- doc/release_notes/0_15_2.md
 - doc/release_notes/0_1_0.md
 - doc/release_notes/0_2_0.md
 - doc/release_notes/0_2_1.md
@@ -292,6 +294,7 @@ metadata:
   changelog_uri: https://honeyryderchuck.gitlab.io/httpx/#release-notes
   documentation_uri: https://honeyryderchuck.gitlab.io/httpx/rdoc/
   source_code_uri: https://gitlab.com/honeyryderchuck/httpx
+  homepage_uri: https://honeyryderchuck.gitlab.io/httpx/
 post_install_message:
 rdoc_options: []
 require_paths: