httpi 0.7.6 → 0.7.7

data/lib/httpi/response.rb

@@ -43,10 +43,13 @@ module HTTPI
   private
 
     def decode_body
+      return @body = "" if !raw_body || raw_body.empty?
+      
       body = gzipped_response? ? decoded_gzip_body : raw_body
       @body = dime_response? ? decoded_dime_body(body) : body
     end
 
+
     # Returns whether the response is gzipped.
     def gzipped_response?
       headers["Content-Encoding"] == "gzip" || raw_body[0..1] == "\x1f\x8b"
@@ -54,7 +57,7 @@ module HTTPI
 
     # Returns whether this is a DIME response.
     def dime_response?
-      headers['Content-Type'] == 'application/dime'
+      headers["Content-Type"] == "application/dime"
     end
 
     # Returns the gzip decoded response body.

data/lib/httpi/version.rb

@@ -1,5 +1,5 @@
 module HTTPI
 
-  VERSION = "0.7.6"
+  VERSION = "0.7.7"
 
 end

data/spec/httpi/response_spec.rb

@@ -2,68 +2,101 @@ require "spec_helper"
 require "httpi/response"
 
 describe HTTPI::Response do
-  let(:response) { HTTPI::Response.new 200, { "Content-Encoding" => "gzip" }, Fixture.xml }
 
-  describe "#code" do
-    it "should return the HTTP response code" do
-      response.code.should == 200
-    end
+  context "normal" do
+    let(:response) { HTTPI::Response.new 200, {}, Fixture.xml }
 
-    it "should always return an Integer" do
-      response = HTTPI::Response.new "200", {}, ""
-      response.code.should == 200
+    describe "#error?" do
+      it "should return false" do
+        response.should_not be_an_error
+      end
     end
-  end
 
-end
+    describe "#headers" do
+      it "should return the HTTP response headers" do
+        response.headers.should == {}
+      end
+    end
 
-describe HTTPI::Response, "gzip" do
-  let(:response) { HTTPI::Response.new 200, { "Content-Encoding" => "gzip" }, Fixture.gzip }
+    describe "#code" do
+      it "should return the HTTP response code" do
+        response.code.should == 200
+      end
 
-  describe "#headers" do
-    it "should return the HTTP response headers" do
-      response.headers.should == { "Content-Encoding" => "gzip" }
+      it "should always return an Integer" do
+        response = HTTPI::Response.new "200", {}, ""
+        response.code.should == 200
+      end
     end
   end
 
-  describe "#body" do
-    it "should return the (gzip decoded) HTTP response body" do
-      response.body.should == Fixture.xml
+  context "empty" do
+    let(:response) { HTTPI::Response.new 204, {}, nil }
+
+    describe "#body" do
+      it "should return an empty String" do
+        response.body.should == ""
+      end
     end
   end
 
-  describe "#raw_body" do
-    it "should return the raw HTML response body" do
-      response.raw_body.should == Fixture.gzip
+  context "error" do
+    let(:response) { HTTPI::Response.new 404, {}, "" }
+
+    describe "#error?" do
+      it "should return true" do
+        response.should be_an_error
+      end
     end
   end
 
-end
+  context "gzipped" do
+    let(:response) { HTTPI::Response.new 200, { "Content-Encoding" => "gzip" }, Fixture.gzip }
 
-describe HTTPI::Response, "DIME" do
-  let(:response) { HTTPI::Response.new 200, { "Content-Type" => "application/dime" }, Fixture.dime }
+    describe "#headers" do
+      it "should return the HTTP response headers" do
+        response.headers.should == { "Content-Encoding" => "gzip" }
+      end
+    end
 
-  describe "#headers" do
-    it "should return the HTTP response headers" do
-      response.headers.should == { "Content-Type" => "application/dime" }
+    describe "#body" do
+      it "should return the (gzip decoded) HTTP response body" do
+        response.body.should == Fixture.xml
+      end
     end
-  end
 
-  describe "#body" do
-    it "should return the (dime decoded) HTTP response body" do
-      response.body.should == Fixture.xml_dime
+    describe "#raw_body" do
+      it "should return the raw HTML response body" do
+        response.raw_body.should == Fixture.gzip
+      end
     end
   end
 
-  describe "#raw_body" do
-    it "should return the raw HTML response body" do
-      response.raw_body.should == Fixture.dime
+  context "DIME" do
+    let(:response) { HTTPI::Response.new 200, { "Content-Type" => "application/dime" }, Fixture.dime }
+
+    describe "#headers" do
+      it "should return the HTTP response headers" do
+        response.headers.should == { "Content-Type" => "application/dime" }
+      end
+    end
+
+    describe "#body" do
+      it "should return the (dime decoded) HTTP response body" do
+        response.body.should == Fixture.xml_dime
+      end
+    end
+
+    describe "#raw_body" do
+      it "should return the raw HTML response body" do
+        response.raw_body.should == Fixture.dime
+      end
     end
-  end
 
-  describe "#attachments" do
-    it "should return proper attachment when given a dime response" do
-      response.attachments.first.data == File.read(File.expand_path("../../fixtures/attachment.gif", __FILE__))
+    describe "#attachments" do
+      it "should return proper attachment when given a dime response" do
+        response.attachments.first.data == File.read(File.expand_path("../../fixtures/attachment.gif", __FILE__))
+      end
     end
   end
 

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: httpi
 version: !ruby/object:Gem::Version 
-  hash: 15
+  hash: 13
   prerelease: 
   segments: 
   - 0
   - 7
-  - 6
-  version: 0.7.6
+  - 7
+  version: 0.7.7
 platform: ruby
 authors: 
 - Daniel Harrington
@@ -16,7 +16,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-01-03 00:00:00 +01:00
+date: 2011-01-05 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency