httparty 0.15.4 → 0.15.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 719a35806296e11c532ef8d283a1e8548da74cc6
-  data.tar.gz: 3f4b75c1eb74d848567010da60fe02cf12d6eeeb
+  metadata.gz: 3abfd0d8679e4054bc591215e90d767d5024cbf6
+  data.tar.gz: 38fa4872a3e9cef824a947443b5d7eb3bb04a709
 SHA512:
-  metadata.gz: f37c05926db73533186f453bd7b1b258b7e1da0bd6ec11baf7a46f56a5679ca34e3d2645837747a5343c12c2dfbb036e86b8ef33a4f59544657a98ab362ac6fe
-  data.tar.gz: 1fe1275d5477089a7c501ca6dbb15cf2db55f85ca92b49d2fa3ceb7d35429d764a9bdd3b1cff66ec20a6d79901bb8c91dde5f9ded3abf0fa1c2f23047f6fe969
+  metadata.gz: b398852558384d98d88f73c750e9e41ec93ae631b7f7de00f382d11087b70eae9ccf620a3cd99513f8b926caa97af5f7f3d6ec319b984c004759fad2a3cd22fe
+  data.tar.gz: bb01e3e75b9cf968aa6196843e66366679b0242833a89e488e6d589f67083cd4fde486bfeef56fd32386da214107e8dc9e10b3d482f8dca0496257e9b5e388ca

data/Changelog.md

@@ -1,3 +1,9 @@
+## 0.15.5
+
+Fixed
+
+* [Use non-destructive gsub](https://github.com/jnunemaker/httparty/pull/540)
+
 ## 0.15.4
 
 Fixed

data/lib/httparty/parser.rb

@@ -102,7 +102,7 @@ module HTTParty
       return nil if body == "null"
       return nil if body.valid_encoding? && body.strip.empty?
       if body.valid_encoding? && body.encoding == Encoding::UTF_8
-        body.gsub!(/\A#{UTF8_BOM}/, '')
+        @body = body.gsub(/\A#{UTF8_BOM}/, '')
       end
       if supports_format?
         parse_supported_format

data/lib/httparty/version.rb

@@ -1,3 +1,3 @@
 module HTTParty
-  VERSION = "0.15.4"
+  VERSION = "0.15.5"
 end

data/spec/httparty/parser_spec.rb

@@ -63,57 +63,62 @@ RSpec.describe HTTParty::Parser do
   end
 
   describe "#parse" do
-    before do
-      @parser = HTTParty::Parser.new('body', :json)
-    end
-
     it "attempts to parse supported formats" do
-      allow(@parser).to receive_messages(supports_format?: true)
-      expect(@parser).to receive(:parse_supported_format)
-      @parser.parse
+      parser = HTTParty::Parser.new('body', :json)
+      allow(parser).to receive_messages(supports_format?: true)
+
+      expect(parser).to receive(:parse_supported_format)
+      parser.parse
     end
 
     it "returns the unparsed body when the format is unsupported" do
-      allow(@parser).to receive_messages(supports_format?: false)
-      expect(@parser.parse).to eq(@parser.body)
+      parser = HTTParty::Parser.new('body', :json)
+      allow(parser).to receive_messages(supports_format?: false)
+
+      expect(parser.parse).to eq(parser.body)
     end
 
     it "returns nil for an empty body" do
-      allow(@parser).to receive_messages(body: '')
-      expect(@parser.parse).to be_nil
+      parser = HTTParty::Parser.new('', :json)
+      expect(parser.parse).to be_nil
     end
 
     it "returns nil for a nil body" do
-      allow(@parser).to receive_messages(body: nil)
-      expect(@parser.parse).to be_nil
+      parser = HTTParty::Parser.new(nil, :json)
+      expect(parser.parse).to be_nil
     end
 
     it "returns nil for a 'null' body" do
-      allow(@parser).to receive_messages(body: "null")
-      expect(@parser.parse).to be_nil
+      parser = HTTParty::Parser.new("null", :json)
+      expect(parser.parse).to be_nil
     end
 
     it "returns nil for a body with spaces only" do
-      allow(@parser).to receive_messages(body: "   ")
-      expect(@parser.parse).to be_nil
+      parser = HTTParty::Parser.new("   ", :json)
+      expect(parser.parse).to be_nil
     end
 
     it "does not raise exceptions for bodies with invalid encodings" do
-      allow(@parser).to receive_messages(body: "\x80")
-      allow(@parser).to receive_messages(supports_format?: false)
-      expect(@parser.parse).to_not be_nil
+      parser = HTTParty::Parser.new("\x80", :invalid_format)
+      expect(parser.parse).to_not be_nil
     end
 
     it "ignores utf-8 bom" do
-      allow(@parser).to receive_messages(body: "\xEF\xBB\xBF\{\"hi\":\"yo\"\}")
-      expect(@parser.parse).to eq({"hi"=>"yo"})
+      parser = HTTParty::Parser.new("\xEF\xBB\xBF\{\"hi\":\"yo\"\}", :json)
+      expect(parser.parse).to eq({"hi"=>"yo"})
     end
 
     it "parses ascii 8bit encoding" do
-      allow(@parser).to receive_messages(
-        body: "{\"currency\":\"\xE2\x82\xAC\"}".force_encoding('ASCII-8BIT')
+      parser = HTTParty::Parser.new(
+        "{\"currency\":\"\xE2\x82\xAC\"}".force_encoding('ASCII-8BIT'),
+        :json
       )
-      expect(@parser.parse).to eq({"currency" => "€"})
+      expect(parser.parse).to eq({"currency" => "€"})
+    end
+
+    it "parses frozen strings" do
+      parser = HTTParty::Parser.new('{"a":1}'.freeze, :json)
+      expect(parser.parse).to eq("a" => 1)
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: httparty
 version: !ruby/object:Gem::Version
-  version: 0.15.4
+  version: 0.15.5
 platform: ruby
 authors:
 - John Nunemaker
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-17 00:00:00.000000000 Z
+date: 2017-05-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_xml