http_stub 0.8.0 → 0.8.1

data/lib/http_stub/configurer/request/stub.rb

@@ -13,9 +13,9 @@ module HttpStub
               "headers" => HttpStub::Configurer::Request::Regexpable.format(options[:headers] || {}),
               "parameters" => HttpStub::Configurer::Request::Regexpable.format(options[:parameters] || {}),
               "response" => {
-                  "status" => options[:response][:status] || 200,
+                  "status" => options[:response][:status] || "",
                   "body" => options[:response][:body],
-                  "delay_in_seconds" => options[:response][:delay_in_seconds]
+                  "delay_in_seconds" => options[:response][:delay_in_seconds] || ""
               }
           }.to_json
         end

data/lib/http_stub/models/request_pipeline.rb

@@ -1,10 +1,13 @@
 module HttpStub
   module Models
+
     class RequestPipeline
 
       def self.before_halt(response)
-        sleep response.delay_in_seconds if response.delay_in_seconds
+        sleep response.delay_in_seconds
       end
+
     end
+
   end
-end
+end

data/lib/http_stub/models/response.rb

@@ -3,8 +3,20 @@ module HttpStub
 
     class Response
 
+      private
+
+      DEFAULT_OPTIONS = { "status" => 200, "delay_in_seconds" => 0 }
+
+      def establish_defaults_in(options)
+        DEFAULT_OPTIONS.each { |key, value| options[key] = value if !options[key] || options[key] == "" }
+      end
+
+      public
+
       def initialize(options = {})
-        @response_options = options || {}
+        @original_options = options
+        @response_options = options.clone
+        establish_defaults_in(@response_options)
       end
 
       SUCCESS = HttpStub::Models::Response.new("status" => 200, "body" => "OK")
@@ -24,8 +36,9 @@ module HttpStub
       end
 
       def empty?
-        @response_options.empty?
+        @original_options.empty?
       end
+
     end
 
   end

data/lib/http_stub/version.rb

@@ -1,3 +1,3 @@
 module HttpStub
-  VERSION = "0.8.0"
+  VERSION = "0.8.1"
 end

data/spec/lib/http_stub/configurer/request/stub_spec.rb

@@ -2,7 +2,7 @@ describe HttpStub::Configurer::Request::Stub do
 
   describe "#initialize" do
 
-    describe "when provided a uri and stub options" do
+    context "when provided a uri and stub options" do
 
       let(:uri) { "/some/uri" }
       let(:stub_method) { "Some Method" }
@@ -10,6 +10,7 @@ describe HttpStub::Configurer::Request::Stub do
       let(:parameters) { { "parameter_name" => "value" } }
       let(:response_status) { 500 }
       let(:response_body) { "Some body" }
+      let(:response_delay_in_seconds) { 7 }
 
       let(:stub_options) do
         {
@@ -18,7 +19,8 @@ describe HttpStub::Configurer::Request::Stub do
             parameters: parameters,
             response: {
                 status: response_status,
-                body: response_body
+                body: response_body,
+                delay_in_seconds: response_delay_in_seconds
             }
         }
       end
@@ -40,7 +42,7 @@ describe HttpStub::Configurer::Request::Stub do
         request.content_type.should eql("application/json")
       end
 
-      describe "when a header option is provided" do
+      context "when a header option is provided" do
 
         it "should format the headers with regexp support" do
           HttpStub::Configurer::Request::Regexpable.should_receive(:format).with(headers)
@@ -50,7 +52,7 @@ describe HttpStub::Configurer::Request::Stub do
 
       end
 
-      describe "when no header is provided" do
+      context "when no header is provided" do
 
         let(:headers) { nil }
 
@@ -62,7 +64,7 @@ describe HttpStub::Configurer::Request::Stub do
 
       end
 
-      describe "when a parameter option is provided" do
+      context "when a parameter option is provided" do
 
         it "should format the parameters with regexp support" do
           HttpStub::Configurer::Request::Regexpable.should_receive(:format).with(parameters)
@@ -72,7 +74,7 @@ describe HttpStub::Configurer::Request::Stub do
 
       end
 
-      describe "when no parameter option is provided" do
+      context "when no parameter option is provided" do
 
         let(:parameters) { nil }
 
@@ -84,52 +86,70 @@ describe HttpStub::Configurer::Request::Stub do
 
       end
 
-      describe "generates a JSON body which" do
+      context "generates a JSON body which" do
 
         it "should have an entry containing the regexpable representation of the uri" do
           HttpStub::Configurer::Request::Regexpable.should_receive(:format).with(uri).and_return("uri as a string")
 
-          request_body.should include({ "uri" => "uri as a string" })
+          request_body.should include("uri" => "uri as a string")
         end
 
         it "should have an entry for the method option" do
-          request_body.should include({ "method" => stub_method })
+          request_body.should include("method" => stub_method)
         end
 
         it "should have an entry containing the string representation of the headers" do
           HttpStub::Configurer::Request::Regexpable.should_receive(:format)
             .with(headers).and_return("headers as string")
 
-          request_body.should include({ "headers" => "headers as string" })
+          request_body.should include("headers" => "headers as string")
         end
 
         it "should have an entry containing the string representation of the parameters" do
           HttpStub::Configurer::Request::Regexpable.should_receive(:format)
             .with(parameters).and_return("parameters as string")
 
-          request_body.should include({ "parameters" => "parameters as string" })
+          request_body.should include("parameters" => "parameters as string")
         end
 
-        describe "when a status response option is provided" do
+        context "when a status response option is provided" do
 
           it "should have a response entry for the option" do
-            request_body["response"].should include({ "status" => response_status })
+            request_body["response"].should include("status" => response_status)
           end
 
         end
 
-        describe "when no status response option is provided" do
+        context "when no status response option is provided" do
 
           let(:response_status) { nil }
 
-          it "should have a response entry with status code of 200" do
-            request_body["response"].should include({ "status" => 200 })
+          it "should have a response entry with an empty status code" do
+            request_body["response"].should include("status" => "")
           end
 
         end
 
         it "should have an entry for the response body option" do
-          request_body["response"].should include({ "body" => response_body })
+          request_body["response"].should include("body" => response_body)
+        end
+
+        context "when a delay option is provided" do
+
+          it "should have a response entry for the option" do
+            request_body["response"].should include("delay_in_seconds" => response_delay_in_seconds)
+          end
+
+        end
+
+        context "when a delay option is not provided" do
+
+          let(:response_delay_in_seconds) { nil }
+
+          it "should have a response entry with an empty delay" do
+            request_body["response"].should include("delay_in_seconds" => "")
+          end
+
         end
 
       end

data/spec/lib/http_stub/models/request_pipeline_spec.rb

@@ -1,24 +1,17 @@
 describe HttpStub::Models::RequestPipeline do
 
-  describe '.before_halt' do
+  let(:request_pipeline) { HttpStub::Models::RequestPipeline }
 
-    let(:response) { double(HttpStub::Models::Response) }
-    let(:request_pipeline) { HttpStub::Models::RequestPipeline }
+  describe ".before_halt" do
 
-    before(:each) do
-      request_pipeline.stub(:sleep)
-      response.stub(:delay_in_seconds).and_return(5)
-    end
+    let(:response) { double(HttpStub::Models::Response, delay_in_seconds: 5) }
 
-    it 'should sleep for specified duration' do
+    it "should sleep for specified duration" do
       request_pipeline.should_receive(:sleep).with(5)
-      request_pipeline.before_halt(response)
-    end
 
-    it 'should skip sleep if not specified' do
-      request_pipeline.should_not_receive(:sleep)
-      response.stub(:delay_in_seconds).and_return(nil)
       request_pipeline.before_halt(response)
     end
+
   end
-end
+
+end

data/spec/lib/http_stub/models/response_spec.rb

@@ -1,6 +1,12 @@
 describe HttpStub::Models::Response do
 
-  let(:response) { HttpStub::Models::Response.new("status" => 202, "body" => "A response body")}
+  let(:status) { 202 }
+  let(:body) { "A response body" }
+  let(:delay_in_seconds) { 18 }
+
+  let(:response) do
+    HttpStub::Models::Response.new("status" => status, "body" => body, "delay_in_seconds" => delay_in_seconds)
+  end
 
   describe "::SUCCESS" do
 
@@ -30,24 +36,38 @@ describe HttpStub::Models::Response do
 
   end
 
-  describe "::EMPTY" do
+  describe "#status" do
 
-    let(:response) { HttpStub::Models::Response::EMPTY }
+    context "when a value is provided in the options" do
 
-    it "should have a nil status" do
-      response.status.should be_nil
-    end
+      context "that is an integer" do
+
+        it "should return the value provided" do
+          response.status.should eql(status)
+        end
+
+      end
+
+      context "that is an empty string" do
+
+        let(:status) { "" }
+
+        it "should return 200" do
+          response.status.should eql(200)
+        end
+
+      end
 
-    it "should have a nil body" do
-      response.body.should be_nil
     end
 
-  end
+    context "when the status is not provided in the options" do
 
-  describe "#status" do
+      let(:response) { HttpStub::Models::Response.new("body" => body, "delay_in_seconds" => delay_in_seconds) }
+
+      it "should return 200" do
+        response.status.should eql(200)
+      end
 
-    it "should return the value provided in the options" do
-      response.status.should eql(202)
     end
 
   end
@@ -60,6 +80,42 @@ describe HttpStub::Models::Response do
 
   end
 
+  describe "#delay_in_seconds" do
+
+    context "when a value is provided in the options" do
+
+      context "that is an integer" do
+
+        it "should return the value" do
+          response.delay_in_seconds.should eql(delay_in_seconds)
+        end
+
+      end
+
+      context "that is an empty string" do
+
+        let(:delay_in_seconds) { "" }
+
+        it "should return 0" do
+          response.delay_in_seconds.should eql(0)
+        end
+
+      end
+
+    end
+
+    context "when a value is not provided in the options" do
+
+      let(:response) { HttpStub::Models::Response.new("status" => status, "body" => body) }
+
+      it "should return 0" do
+        response.delay_in_seconds.should eql(0)
+      end
+
+    end
+
+  end
+
   describe "#empty?" do
 
     describe "when the response is EMPTY" do

data/spec/spec_helper.rb

@@ -2,7 +2,7 @@ require 'simplecov'
 SimpleCov.start do
   add_filter "/spec/"
   add_filter "/vendor/"
-  minimum_coverage 98.28
+  minimum_coverage 98.3
   refuse_coverage_drop
 end if ENV["coverage"]
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: http_stub
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.8.1
   prerelease: 
 platform: ruby
 authors:
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-16 00:00:00.000000000 Z
+date: 2013-09-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sinatra
@@ -323,7 +323,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2870927875364426759
+      hash: -2719492474227436530
 requirements: []
 rubyforge_project: http_stub
 rubygems_version: 1.8.25