http_signatures 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c5c7339b04086bd5daa91dc6b18f3b81533f968b
-  data.tar.gz: 7795f49a0a2163902cb11b9d4a6c3c96cd445f82
+  metadata.gz: 4a264bdc74bd252c38f2327f6152b7ac67ddac76
+  data.tar.gz: 86193ad941a2f492e16ce8a20a9938e6e561442b
 SHA512:
-  metadata.gz: 1643e2f919c5da1fe6f80ed9eef7e6ebfd4443474228c9c92c6f7dcdb6c986232670d6aed3c251196012e8a50d2e84ab3d57d3a1674bfd7d5754e0167f0f913b
-  data.tar.gz: 6f710a1ae21aed1b2fea9e303541116305b0dc57c565f24c233c9364f0e74c8c0bf01a7c41350b006847877c8b665a513c0a13af7c4c8f054e20a628e36ac30d
+  metadata.gz: 80e1dd75f46c8dd1c82b878a893c9b94bee453c2ef33fdfb170ee34fc52151a8e61004dbdecf208c28197af76ff337db7a1dc4a76d39feead2b03b2b5f9bcb45
+  data.tar.gz: 3df85e7bcd62cba2167211a7379f77662238b4a8ea87a7b64e933e8a77a580e40ce3c536d48a1286e68d9995086642734db2b6922805590f9fd0f25d1731fc93

data/lib/http_signatures.rb

@@ -1,6 +1,5 @@
 require "http_signatures/algorithm"
 require "http_signatures/algorithm/hmac"
-require "http_signatures/algorithm/null"
 require "http_signatures/context"
 require "http_signatures/header_list"
 require "http_signatures/key"

data/lib/http_signatures/algorithm.rb

@@ -3,7 +3,6 @@ module HttpSignatures
 
     def self.create(name)
       case name
-      when "null" then Null.new
       when "hmac-sha1" then Hmac.new("sha1")
       when "hmac-sha256" then Hmac.new("sha256")
       else raise UnknownAlgorithm.new(name)

data/lib/http_signatures/version.rb

@@ -1,3 +1,3 @@
 module HttpSignatures
-  VERSION = "1.0.1"
+  VERSION = "1.0.2"
 end

data/spec/algorithm_spec.rb

@@ -6,7 +6,6 @@ RSpec.describe HttpSignatures::Algorithm do
   let(:input) { "the string\nto sign" }
 
   {
-    "null" => "bnVsbA==", # "null"
     "hmac-sha1" => "bXPeVc5ySIyeUapN7mpMsJRnxVg=",
     "hmac-sha256" => "hRQ5zpbGudR1hokS4PqeAkveKmz2dd8SCgV8OHcramI=",
   }.each do |name, base64_signature|

data/spec/context_spec.rb

@@ -8,7 +8,7 @@ RSpec.describe HttpSignatures::Context do
     subject(:context) do
       HttpSignatures::Context.new(
         keys: {"hello" => "world"},
-        algorithm: "null",
+        algorithm: "hmac-sha256",
         headers: %w{(request-target) date content-length},
       )
     end
@@ -17,7 +17,7 @@ RSpec.describe HttpSignatures::Context do
       it "instantiates Signer with key, algorithm, headers" do
         expect(HttpSignatures::Signer).to receive(:new) do |args|
           expect(args[:key]).to eq(HttpSignatures::Key.new(id: "hello", secret: "world"))
-          expect(args[:algorithm].name).to eq("null")
+          expect(args[:algorithm].name).to eq("hmac-sha256")
           expect(args[:header_list].to_a).to eq(%w{(request-target) date content-length})
         end
         context.signer
@@ -40,7 +40,7 @@ RSpec.describe HttpSignatures::Context do
       HttpSignatures::Context.new(
         keys: {"hello" => "world", "another" => "key"},
         signing_key_id: "another",
-        algorithm: "null",
+        algorithm: "hmac-sha256",
         headers: %w{(request-target) date content-length},
       )
     end
@@ -49,7 +49,7 @@ RSpec.describe HttpSignatures::Context do
       it "instantiates Signer with key, algorithm, headers" do
         expect(HttpSignatures::Signer).to receive(:new) do |args|
           expect(args[:key]).to eq(HttpSignatures::Key.new(id: "another", secret: "key"))
-          expect(args[:algorithm].name).to eq("null")
+          expect(args[:algorithm].name).to eq("hmac-sha256")
           expect(args[:header_list].to_a).to eq(%w{(request-target) date content-length})
         end
         context.signer

data/spec/signer_spec.rb

@@ -8,7 +8,7 @@ RSpec.describe HttpSignatures::Signer do
     HttpSignatures::Signer.new(key: key, algorithm: algorithm, header_list: header_list)
   end
   let(:key) { HttpSignatures::Key.new(id: "pda", secret: "sh") }
-  let(:algorithm) { HttpSignatures::Algorithm::Null.new }
+  let(:algorithm) { HttpSignatures::Algorithm::Hmac.new("sha256") }
   let(:header_list) { HttpSignatures::HeaderList.new(["date", "content-type"]) }
 
   let(:message) do
@@ -49,7 +49,7 @@ RSpec.describe HttpSignatures::Signer do
       expect(algorithm).to receive(:sign).with(
         "sh",
         ["date: #{EXAMPLE_DATE}", "content-type: text/plain"].join("\n")
-      ).at_least(:once).and_return("null")
+      ).at_least(:once).and_return("static")
       signer.sign(message)
     end
     it "returns reference to the mutated input" do
@@ -67,14 +67,14 @@ RSpec.describe HttpSignatures::Signer do
     end
     it "matches expected Authorization header" do
       expect(message["Authorization"]).to eq(
-        'Signature keyId="pda",algorithm="null",' +
-          'headers="date content-type",signature="bnVsbA=="'
+        'Signature keyId="pda",algorithm="hmac-sha256",' +
+          'headers="date content-type",signature="0ZoJq6cxYZRXe+TN85whSuQgJsam1tRyIal7ni+RMXA="'
       )
     end
     it "matches expected Signature header" do
       expect(message["Signature"]).to eq(
-        'keyId="pda",algorithm="null",' +
-          'headers="date content-type",signature="bnVsbA=="'
+        'keyId="pda",algorithm="hmac-sha256",' +
+          'headers="date content-type",signature="0ZoJq6cxYZRXe+TN85whSuQgJsam1tRyIal7ni+RMXA="'
       )
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: http_signatures
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Paul Annesley
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-24 00:00:00.000000000 Z
+date: 2014-10-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -70,7 +70,6 @@ files:
 - lib/http_signatures.rb
 - lib/http_signatures/algorithm.rb
 - lib/http_signatures/algorithm/hmac.rb
-- lib/http_signatures/algorithm/null.rb
 - lib/http_signatures/context.rb
 - lib/http_signatures/header_list.rb
 - lib/http_signatures/key.rb

data/lib/http_signatures/algorithm/null.rb

@@ -1,15 +0,0 @@
-module HttpSignatures
-  module Algorithm
-    class Null
-
-      def name
-        "null"
-      end
-
-      def sign(key, data)
-        "null"
-      end
-
-    end
-  end
-end