http_session 0.2.1 → 0.3.0

data/VERSION

@@ -1 +1 @@
-0.2.1
+0.3.0

data/http_session.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{http_session}
-  s.version = "0.2.1"
+  s.version = "0.3.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = [%q{David Burry}]
-  s.date = %q{2011-09-07}
+  s.date = %q{2011-11-06}
   s.description = %q{A useful yet still extremely light-weight web client built on top of Ruby Net::HTTP.  Keeps certain information internally in a session for each host/port used.  Great for simple web page scraping or web service API usage.}
   s.email = %q{dburry@falcon}
   s.extra_rdoc_files = [

data/lib/http_session.rb

@@ -114,8 +114,12 @@ class HttpSession
   # Session initialization and basic handling
   # 
   
-  # place to store references to all currently-known session instances, for singleton method usage
-  @@sessions = {}
+  # Simplest thread-safe pooling mechanism is to make a separate session store for every thread.
+  # Each thread makes its own connection(s), the way you'd expect that way.
+  # Just don't try to share http_session instances between separate threads, and it will work fine.
+  def self.session_store
+    Thread.current['http_session_sessions'] ||= {}
+  end
   
   # storage for open session handle, for instance method usage
   attr_accessor :handle
@@ -144,18 +148,19 @@ class HttpSession
   
   # check if a session exists yet ot not
   def self.exists?(host, use_ssl=false, port=nil)
-    @@sessions.has_key?(key(host, use_ssl, port))
+    session_store.has_key?(key(host, use_ssl, port))
   end
   
   # get the session for the given host and port, nil if there isn't one yet
   def self.get(host, use_ssl=false, port=nil)
-    @@sessions[key(host, use_ssl, port)]
+    session_store[key(host, use_ssl, port)]
   end
   
   # get the session for the given host and port, creating a new one if it doesn't exist
   def self.use(host, use_ssl=false, port=nil)
-    key = key(host, use_ssl, port)
-    @@sessions.has_key?(key) ? @@sessions[key] : (@@sessions[key] = new(host, use_ssl, port_or_default(port, use_ssl)))
+    exists?(host, use_ssl, port) ?
+      get(host, use_ssl, port) :
+      (session_store[key(host, use_ssl, port)] = new(host, use_ssl, port_or_default(port, use_ssl)))
   end
   
   # done with this session, close and reset it
@@ -167,8 +172,9 @@ class HttpSession
   
   # delete session from session storage (you should probably call close on it too, and set all references to nil so it gets garbage collected)
   def delete
-    key = self.class.key(handle.address, handle.use_ssl?, handle.port)
-    @@sessions.delete(key) if @@sessions.has_key?(key)
+    if self.class.exists?(handle.address, handle.use_ssl?, handle.port)
+      self.class.session_store.delete(self.class.key(handle.address, handle.use_ssl?, handle.port))
+    end
   end
   
   # return the given port, or defaults for ssl setting if it's nil

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: http_session
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.3.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-09-07 00:00:00.000000000Z
+date: 2011-11-06 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70215141077800 !ruby/object:Gem::Requirement
+  requirement: &70196754286760 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - =
@@ -21,10 +21,10 @@ dependencies:
         version: 0.8.7
   type: :development
   prerelease: false
-  version_requirements: *70215141077800
+  version_requirements: *70196754286760
 - !ruby/object:Gem::Dependency
   name: shoulda
-  requirement: &70215141075260 !ruby/object:Gem::Requirement
+  requirement: &70196754285420 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70215141075260
+  version_requirements: *70196754285420
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &70215141072300 !ruby/object:Gem::Requirement
+  requirement: &70196754284000 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +43,10 @@ dependencies:
         version: 1.0.0
   type: :development
   prerelease: false
-  version_requirements: *70215141072300
+  version_requirements: *70196754284000
 - !ruby/object:Gem::Dependency
   name: jeweler
-  requirement: &70215141070340 !ruby/object:Gem::Requirement
+  requirement: &70196754282040 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -54,10 +54,10 @@ dependencies:
         version: 1.6.2
   type: :development
   prerelease: false
-  version_requirements: *70215141070340
+  version_requirements: *70196754282040
 - !ruby/object:Gem::Dependency
   name: rcov
-  requirement: &70215141069020 !ruby/object:Gem::Requirement
+  requirement: &70196754280780 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +65,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70215141069020
+  version_requirements: *70196754280780
 - !ruby/object:Gem::Dependency
   name: simplecov
-  requirement: &70215141067160 !ruby/object:Gem::Requirement
+  requirement: &70196754279500 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,10 +76,10 @@ dependencies:
         version: 0.4.0
   type: :development
   prerelease: false
-  version_requirements: *70215141067160
+  version_requirements: *70196754279500
 - !ruby/object:Gem::Dependency
   name: rdoc
-  requirement: &70215141053640 !ruby/object:Gem::Requirement
+  requirement: &70196754278100 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -87,7 +87,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70215141053640
+  version_requirements: *70196754278100
 description: A useful yet still extremely light-weight web client built on top of
   Ruby Net::HTTP.  Keeps certain information internally in a session for each host/port
   used.  Great for simple web page scraping or web service API usage.