http_api_client 0.2.2 → 0.2.3

checksums.yaml

@@ -0,0 +1,15 @@
+---
+!binary "U0hBMQ==":
+  metadata.gz: !binary |-
+    YTliMDAwZWQ2Y2ZjMzMwNWIxMGQzN2U1ZDQ1YjM1YTQ1NWQwMzNjOQ==
+  data.tar.gz: !binary |-
+    MzIwMWJiNjQ4MDMxZDVhZDJlYzEyZTllNTFmNWUzMTkxZmRlOGY4Mg==
+SHA512:
+  metadata.gz: !binary |-
+    YjMyNjQ0N2QxMjY2MDRkYzM3MjQxYzM4ODc3Y2YzMmEyZTBlYzNlMGZmOTgw
+    ZTk5OTg2NzMwYmU2NDgzMjY5YjViNzAyNDBkM2E4YzJiMThkODZkYWJhZTFj
+    MTJiN2M4OTgxM2MwMjA2M2JjMDY1OWVhMTQzYjk4OGQzN2FiNDI=
+  data.tar.gz: !binary |-
+    MzkzNTQwMjBkNzdkZjA0OGIyNjQ1MjExOWQwZWI2ZWQ4NjAxZmEwNzUxNmFm
+    NWIyZDk1NGNiMWZjMDhhY2EzMWRkZGRkNDA1MTc3MmQ3ZThkMzZlMGE3YTE0
+    MDhhZTIzMWEyMDQ2YmJhYmFkN2Y5NWJiMmExYzhiMjlhOThhNmI=

data/LICENSE.txt

@@ -1,4 +1,4 @@
-Copyright (c) 2014 Rob Monie
+Copyright (c) 2014 Hooroo
 
 MIT License
 

data/README.md

@@ -170,3 +170,7 @@ This will install `/usr/local/opt/curl-ca-bundle/share/ca-bundle.crt`
 
 ### 0.2.2 - 2014-04-08
 * TimedResult class is now no longer in the global namespace. It is in the HttpApiClient namespace now. Fixes problems with name collisions
+
+### 0.2.3 - 2014-05-05
+* Add logging for json parsing failures
+* Remove unused timed result

data/Rakefile

@@ -1 +1,5 @@
 require "bundler/gem_tasks"
+require "bundler/gem_tasks"
+require 'rspec/core/rake_task'
+task :default => :spec
+RSpec::Core::RakeTask.new

data/http_api_client.gemspec

@@ -19,6 +19,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_development_dependency 'bundler', '~> 1.3'
+  spec.add_development_dependency "rake"
   spec.add_development_dependency 'rspec', '~> 2.14'
   spec.add_development_dependency 'pry', '~> 0.9'
   spec.add_development_dependency 'pry-debugger', '~> 0.2'
@@ -28,6 +29,4 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'net-http-persistent', '~> 2.9'
   spec.add_dependency 'oj', '~> 2.7'
 
-
-
 end

data/lib/http_api_client/client.rb

@@ -7,7 +7,6 @@ require 'oj'
 require 'http_api_client'
 require 'http_api_client/errors'
 require 'http_api_client/connection_factory'
-require 'http_api_client/timed_result'
 
 module HttpApiClient
   class Client
@@ -90,15 +89,28 @@ module HttpApiClient
     def handle_response(response, method, path)
       if ok?(response)
         if response.body
-          #Don't use regular load method - any strings starting with ':' ( :-)  from example) will be interpreted as a symbol
-          Oj.strict_load(response.body)
+          begin
+            #Don't use regular load method - any strings starting with ':' ( :-)  from example) will be interpreted as a symbol
+            Oj.strict_load(response.body)
+
+          rescue Oj::ParseError => e
+
+            HttpApiClient.logger.error(
+              error_class: 'OJ::ParseError',
+              message: e.message,
+              backtrace: e.backtrace,
+              json: response.body
+              )
+
+            raise e
+          end
         else
           true
         end
       else
         error_class = error_for_status(response.status)
         message = "#{response.status} #{method}: #{path}"
-        HttpApiClient.logger.warn("Http Client #{error_class}: #{message}")
+        HttpApiClient.logger.info("Http Client #{error_class}: #{message}")
         raise error_class.new(message, response.body)
       end
     end

data/lib/http_api_client/version.rb

@@ -1,5 +1,5 @@
 # encoding: utf-8
 
 module HttpApiClient
-  VERSION = "0.2.2"
+  VERSION = "0.2.3"
 end

data/spec/http_client/client_spec.rb

@@ -138,7 +138,7 @@ module HttpApiClient
     describe "response status code handling" do
 
       context "with a response with a status code in the 200 range" do
-        let(:response) { double('response', :body => '{"id": 1}', status: 200) }
+        let(:get_response) { double('response', :body => '{"id": 1}', status: 200) }
 
         describe "response" do
           it "returns expected response body as hash" do
@@ -170,6 +170,34 @@ module HttpApiClient
 
     end
 
+   describe 'response parsing' do
+
+    let(:get_response) { double('response', :body => json, status: 200) }
+
+    context 'with a valid json response' do
+
+      let(:json) { '{"id": 1}' }
+
+      it 'returns the json as a ruby hash' do
+        response = client.find('/path', 1)
+        expect(response['id']).to eq 1
+      end
+
+    end
+
+    context 'with and invalid json response' do
+
+      let(:json) { 'invalid json' }
+
+      it 'logs and re-raises error' do
+        HttpApiClient.logger.should_receive(:error)
+        lambda { client.find('/path', 1) }.should raise_error(Oj::ParseError)
+      end
+
+    end
+
+   end
+
     context 'without request id tracking configured' do
       it "does not add the Request-Id header to the request" do
         connection.should_receive(:get).with('/test-base-uri/path/1', {}, base_get_headers)

metadata

@@ -1,8 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: http_api_client
 version: !ruby/object:Gem::Version
-  version: 0.2.2
-  prerelease: 
+  version: 0.2.3
 platform: ruby
 authors:
 - Rob Monie
@@ -12,12 +11,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-14 00:00:00.000000000 Z
+date: 2014-05-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -25,15 +23,27 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '1.3'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -41,7 +51,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -49,7 +58,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -57,7 +65,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -65,7 +72,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: pry-debugger
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -73,7 +79,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -81,7 +86,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -89,7 +93,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -97,7 +100,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -105,7 +107,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -113,7 +114,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: net-http-persistent
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -121,7 +121,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -129,7 +128,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: oj
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -137,7 +135,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -162,7 +159,6 @@ files:
 - lib/http_api_client/connection_factory.rb
 - lib/http_api_client/errors.rb
 - lib/http_api_client/rails_params_encoder.rb
-- lib/http_api_client/timed_result.rb
 - lib/http_api_client/version.rb
 - spec/config/http_api_clients.yml
 - spec/config/http_api_clients_with_basic_auth.yml
@@ -174,31 +170,29 @@ files:
 - spec/http_client/config_spec.rb
 - spec/http_client/connection_factory_spec.rb
 - spec/http_client/errors_spec.rb
-- spec/http_client/timed_result_spec.rb
 homepage: ''
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.2.2
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: ''
 test_files:
 - spec/config/http_api_clients.yml
@@ -211,4 +205,3 @@ test_files:
 - spec/http_client/config_spec.rb
 - spec/http_client/connection_factory_spec.rb
 - spec/http_client/errors_spec.rb
-- spec/http_client/timed_result_spec.rb

data/lib/http_api_client/timed_result.rb

@@ -1,32 +0,0 @@
-# encoding: utf-8
-module HttpApiClient
-  class TimedResult
-
-    def self.time(event, log_data = {})
-      start_time = Time.now
-      yield
-    ensure
-
-      time = millis_since(start_time)
-
-      log_entries = ["event_name=#{event}"]
-      log_entries << "request_id=#{Thread.current[:request_id]}" if Thread.current[:request_id]
-      log_entries << "timing=#{time}"
-      log_entries.concat(as_log_entries(log_data))
-
-      HttpApiClient.logger.info(log_entries.join(", "))
-
-    end
-
-    def self.millis_since(start_time)
-      (Time.now - start_time) * 1000
-    end
-
-    def self.as_log_entries(hash)
-      hash.inject [] do |result, entry|
-        result << "#{entry[0]}=#{entry[1]}"
-      end
-    end
-
-  end
-end

data/spec/http_client/timed_result_spec.rb

@@ -1,31 +0,0 @@
-# encoding: utf-8
-
-require 'http_api_client'
-
-module HttpApiClient
-
-  describe TimedResult do
-
-    context 'without extra log data' do
-
-      let(:request_id) { 'abc-123' }
-      let(:logger) { HttpApiClient.logger }
-
-      before do
-        TimedResult.stub(:millis_since).and_return 1000
-        Thread.current[:request_id] = request_id
-      end
-
-      it 'logs event with base data' do
-        logger.should_receive(:info).with("event_name=my_event, request_id=#{request_id}, timing=#{1000}")
-        TimedResult.time('my_event') {  }
-      end
-
-      it 'logs event with extra data' do
-        logger.should_receive(:info).with("event_name=my_event, request_id=#{request_id}, timing=#{1000}, foo=bar")
-        TimedResult.time('my_event', { foo: 'bar' }) {  }
-      end
-
-    end
-  end
-end