http_api_client 0.1.5 → 0.2.0

data/README.md

@@ -159,3 +159,6 @@ This will install `/usr/local/opt/curl-ca-bundle/share/ca-bundle.crt`
 ### 0.1.4 - 2014-04-07
 * Don't url encode log values
 
+### 0.1.5 - 2014-04-08
+* Logging and metrics are separate concerns and both are injectable
+

data/http_api_client.gemspec

@@ -6,7 +6,7 @@ require 'http_api_client/version'
 Gem::Specification.new do |spec|
   spec.name          = 'http_api_client'
   spec.version       = HttpApiClient::VERSION
-  spec.authors       = ['Rob Monie', 'Andrei Miulescu', 'Stuart Liston', 'Chris Rhode']
+  spec.authors       = ['Rob Monie', 'Andrei Miulescu', 'Stuart Liston', 'Chris Rode']
   spec.email         = ['robmonie@gmail.com']
   spec.description   = %q{Http client wrapper for simplified api access}
   spec.summary       = %q{}

data/lib/http_api_client/client.rb

@@ -88,7 +88,7 @@ module HttpApiClient
     end
 
     def handle_response(response, method, path)
-      if ok?(response) || validation_failed?(response)
+      if ok?(response)
         if response.body
           #Don't use regular load method - any strings starting with ':' ( :-)  from example) will be interpreted as a symbol
           Oj.strict_load(response.body)

data/lib/http_api_client/errors.rb

@@ -1,4 +1,5 @@
-require 'http_api_client'
+# encoding: utf-8
+require 'oj'
 
 module HttpApiClient
 
@@ -19,7 +20,7 @@ module HttpApiClient
         messages = [@message]
         messages << nested_error.message if nested_error
         messages << response_body
-        messages.join("\n\n")
+        messages.join(", ")
       end
 
     end
@@ -33,7 +34,11 @@ module HttpApiClient
     class NotAcceptable < BaseError ; end
     class RequestTimeout < BaseError ; end
     class UnknownStatus < BaseError ; end
-    class UnprocessableEntity < BaseError ; end
+    class UnprocessableEntity < BaseError
+      def as_json
+        Oj.load(response_body)
+      end
+    end
     class TooManyRequests < BaseError ; end
 
     #500 Range

data/lib/http_api_client/version.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 module HttpApiClient
-  VERSION = "0.1.5"
+  VERSION = "0.2.0"
 end

data/spec/http_client/client_spec.rb

@@ -54,6 +54,50 @@ module HttpApiClient
 
     describe "#create" do
 
+      shared_examples "#create" do
+        let(:response_double) {double('post response', body: response_json, status: status)}
+        let(:response_json) {{'this' => 'that'}.to_json}
+        context "when the post returns a valid response" do
+          let(:status) {200}
+          it "calls http connection with post and correct url and post data" do
+            connection.should_receive(:post).with('/test-base-uri/path', JSON.fast_generate(payload), base_update_headers).and_return(response_double)
+            expect(client.create('/path', payload)).to eq(JSON.parse(response_json))
+          end
+        end
+        context "when the post returns a 422 response" do
+          let(:status) {422}
+          before do
+            connection.should_receive(:post).with('/test-base-uri/path', JSON.fast_generate(payload), base_update_headers).and_return(response_double)
+          end
+          it "returns a UnprocessableEntity exception" do
+            expect{client.create('/path', payload)}.to raise_error(Errors::UnprocessableEntity)
+          end
+          it "has the correct response data" do
+            begin
+              client.create('/path', payload)
+            rescue Errors::BaseError => e
+              expect(e.response_body).to eq(response_json)
+            end
+          end
+        end
+        context "when the post returns an error response" do
+          let(:status) {500}
+          before do
+            connection.should_receive(:post).with('/test-base-uri/path', JSON.fast_generate(payload), base_update_headers).and_return(response_double)
+          end
+          it "returns a InternalServerError exception" do
+            expect{client.create('/path', payload)}.to raise_error(Errors::InternalServerError)
+          end
+          it "has the correct response data" do
+            begin
+              client.create('/path', payload)
+            rescue Errors::BaseError => e
+              expect(e.response_body).to eq(response_json)
+            end
+          end
+        end
+      end
+
       context "with auth params" do
         let(:client) do
           klass = Class.new(Client) do
@@ -63,18 +107,15 @@ module HttpApiClient
           end
           klass.new(:my_client, 'spec/config/http_api_clients_with_basic_auth.yml')
         end
-
-        it "calls http connection with post and correct url and post data" do
-          payload = { text: "hello", :key => 'one' }
-          connection.should_receive(:post).with('/test-base-uri/path', JSON.fast_generate(payload), base_update_headers)
-          client.create('/path', payload)
+        it_behaves_like "#create" do
+          let(:payload) {{ text: "hello", :key => "one"}}
         end
       end
 
-      it "calls http connection with post and correct url and post data" do
-        payload = { text: "hello"}
-        connection.should_receive(:post).with('/test-base-uri/path', JSON.fast_generate(payload), base_update_headers)
-        client.create('/path', payload)
+      context "without auth params" do
+        it_behaves_like "#create" do
+          let(:payload) {{ text: "hello"}}
+        end
       end
 
     end

data/spec/http_client/errors_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 
 require 'http_api_client/errors'
 
@@ -31,5 +33,19 @@ module HttpApiClient
       end
 
     end
+    describe UnprocessableEntity do
+      let(:exception) {described_class.new(message,Oj.dump(response_body))}
+      let(:response_body) {{'some' => 'json thing'}}
+      let(:message) { 'this is a message that is really informative and stuff and junk'}
+
+      it "is a BaseError" do
+        expect(exception).to be_a_kind_of(BaseError)
+      end
+      describe "#as_json" do
+        it "returns the response_body parsed" do
+          expect(exception.as_json).to eq(response_body)
+        end
+      end
+    end
   end
 end

metadata

@@ -1,21 +1,23 @@
 --- !ruby/object:Gem::Specification
 name: http_api_client
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.2.0
+  prerelease: 
 platform: ruby
 authors:
 - Rob Monie
 - Andrei Miulescu
 - Stuart Liston
-- Chris Rhode
+- Chris Rode
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-08 00:00:00.000000000 Z
+date: 2014-04-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -23,6 +25,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -30,6 +33,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -37,6 +41,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -44,6 +49,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -51,6 +57,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -58,6 +65,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: pry-debugger
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -65,6 +73,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -72,6 +81,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -79,6 +89,7 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -86,6 +97,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -93,6 +105,7 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -100,6 +113,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: net-http-persistent
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -107,6 +121,7 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -114,6 +129,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: oj
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -121,6 +137,7 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -161,26 +178,27 @@ files:
 homepage: ''
 licenses:
 - MIT
-metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 1.8.23
 signing_key: 
-specification_version: 4
+specification_version: 3
 summary: ''
 test_files:
 - spec/config/http_api_clients.yml

checksums.yaml

@@ -1,15 +0,0 @@
----
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    MWRkMGU2ZjI2YjVjMTA1ODJhMjhiYjI0ZDQxMGRlZjRhMDYwY2FjYg==
-  data.tar.gz: !binary |-
-    NDFjZjk2NjlkYmY5MjUxMzk5MzFkNGZiNTQxNWI5Yzc4YzFlYjFlMQ==
-SHA512:
-  metadata.gz: !binary |-
-    NzNiZmQ5M2Y2OGVlZDQwYjkyYTcwNDE5ZWJjMTA1NzM3NzJiNThlZjBkZWJm
-    NmFmNWUwNjIzMzUyNmY0ODU3NTY0Y2I2Y2VkZmI3MTU3MGM1YTllNmUxOGIx
-    NWFlYjIwYTI0MmY5ODQ1OTNhOWNkMDVjZWZlYzcwZDhmYWVjNzc=
-  data.tar.gz: !binary |-
-    MmQwMzk0ZTFhN2JlNzA4ZTFhOGRjMjZkMGEzZjE4YTBlYjQ3NjYyNmNhZDBk
-    ODhhNGIyNmJmZTViYzA0YmM4NTE5NjBmM2M5ZTVkMDJiZDhiMWEzM2RhNzEx
-    YjQwMjRkMWNhNjVkN2Q3ZmE4NjRiZmMxMWFiZGY5ZWVkNzc4Yjc=