http2 0.0.35 → 0.0.36

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ff94aecdfbfa493bb62b38edeef5a2bf49f9b5fb16ce5f023e6928ed77cb21c7
-  data.tar.gz: d8858f9e7daf39ed428311db9af0d561c971780d249cf0d0932a36962c921884
+  metadata.gz: aaaa3b5476a0d9233f4ef5977f64d0368f009021f92bd821280058f518463bca
+  data.tar.gz: 24942b90af076019fc755a6abdc61ae049ec2a7178dcad6f6df5c0aba9c5a945
 SHA512:
-  metadata.gz: 04205c61f20290a3dec42a1c7a78b380ac749e0245ea53ba13f1a65cc983140e486a73fd26bf1e8a6ad808cde9a97d98ab9ba982f984726386d0b6db201da8d3
-  data.tar.gz: 413150d064f99e448cfcb0cca6380a6677b8e525ffcbbdaebfd957b5b7a6c263aeb105562ffcb6e8584603fd097a7fcfbda13327a662d7ba9927ad2e0d077afa
+  metadata.gz: eb01eb1aab89764bcaa356f5c89341e926ef0ebe5818aa5b22be70e64dd0e926f6ab9807723ae15b0f33d125397be759c89d5e896ab3b25d486b312bd44e252c
+  data.tar.gz: 7ff240f8d775175b3b5f9fdbfe1f8a4d380c83c26729c3c31730672d5e3dbea1e8d3ccc8899f39c06f27199799243c87b8de9c6483d00ff8335fb1c279a024e5

data/lib/http2/connection.rb

@@ -132,7 +132,7 @@ class Http2::Connection
     @sock_plain.write(@nl)
 
     res = @sock_plain.gets.to_s
-    raise "Couldn't connect through proxy: #{res}" unless res.match(/^http\/1\.(0|1)\s+200/i)
+    raise "Couldn't connect through proxy: #{res}" unless res.match?(/^http\/1\.(0|1)\s+200/i)
 
     @sock_plain.gets
 

data/lib/http2/response_reader.rb

@@ -103,15 +103,17 @@ private
     @url ||= response.header("location")
   end
 
+  SSL_AND_PORT_KEYS = [:ssl, :port].freeze
+
   def url_and_args_from_location
     uri = URI.parse(url)
 
     url = uri.path
     url << "?#{uri.query}" unless uri.query.to_s.empty?
-    url = url.gsub(/\A\//, "")
+    url = url.delete_prefix("/")
 
     args = @http2.args
-      .reject { |k, _v| [:ssl, :port].include? k }
+      .reject { |k, _v| SSL_AND_PORT_KEYS.include?(k) }
       .merge(host: uri.host)
 
     args[:ssl] = true if uri.scheme == "https"

data/spec/http2/cookies_spec.rb

@@ -1,9 +1,9 @@
 require "spec_helper"
 
-describe Http2 do
+describe Http2::Cookie do
   include Helpers
 
-  it "should parse cookies and let them be read" do
+  it "parses cookies and let them be read" do
     with_http do |http|
       http.get("cookie_test.rhtml")
       expect(http.cookies.length).to eq 2

data/spec/http2/post_data_generator_spec.rb

@@ -1,7 +1,7 @@
 require "spec_helper"
 
 describe Http2::PostDataGenerator do
-  it "should be able to recursively parse post-data-hashes." do
+  it "recursively parses post-data-hashes." do
     res = Http2::PostDataGenerator.new(
       "test1" => "test2"
     ).generate

data/spec/http2/response_spec.rb

@@ -25,14 +25,14 @@ describe Http2::Response do
       end
     end
 
-    it "returns true for 'application/json'" do
+    it "returns true for 'application/json' and getting" do
       with_http do |http|
         res = http.get("json_test.rhtml")
         expect(res.json?).to eq true
       end
     end
 
-    it "returns true for 'application/json'" do
+    it "returns true for 'application/json' and posting" do
       with_http do |http|
         res = http.post(url: "json_test.rhtml", post: {test: "test2"})
 

data/spec/http2/url_builder_spec.rb

@@ -1,7 +1,7 @@
 require "spec_helper"
 
 describe Http2::UrlBuilder do
-  context "#build" do
+  describe "#build" do
     it "builds correctly" do
       ub = Http2::UrlBuilder.new
       ub.protocol = "https"

data/spec/http2_spec.rb

@@ -2,7 +2,7 @@ require "spec_helper"
 require "json"
 
 describe "Http2" do
-  it "should be able to do normal post-requests." do
+  it "does normal post-requests" do
     # Test posting keep-alive and advanced post-data.
     with_http do |http|
       0.upto(5) do
@@ -44,17 +44,19 @@ describe "Http2" do
     end
   end
 
-  it "#reconnect" do
-    with_http(follow_redirects: false, encoding_gzip: false) do |http|
-      resp1 = http.get("multipart_test.rhtml")
-      http.reconnect
-      resp2 = http.get("multipart_test.rhtml")
+  describe "#reconnect" do
+    it "reconnects" do
+      with_http(follow_redirects: false, encoding_gzip: false) do |http|
+        resp1 = http.get("multipart_test.rhtml")
+        http.reconnect
+        resp2 = http.get("multipart_test.rhtml")
 
-      expect(resp1.body).to eq resp2.body
+        expect(resp1.body).to eq resp2.body
+      end
     end
   end
 
-  it "should be able to do multipart-requests and keep-alive when using multipart." do
+  it "handles multipart-requests and keep-alive when using multipart." do
     with_http(follow_redirects: false) do |http|
       0.upto(5) do
         fpath = File.realpath(__FILE__)
@@ -84,7 +86,7 @@ describe "Http2" do
     end
   end
 
-  it "it should be able to handle keep-alive correctly" do
+  it "handles keep-alive correctly" do
     urls = [
       "content_type_test.rhtml",
       "json_test.rhtml"
@@ -100,13 +102,13 @@ describe "Http2" do
     end
   end
 
-  it "should raise exception when something is not found" do
+  it "raises an error when something is not found" do
     with_http do |http|
       expect { http.get("something_that_does_not_exist.rhtml") }.to raise_error(::Http2::Errors::Notfound)
     end
   end
 
-  it "should be able to post json" do
+  it "posts json" do
     with_http do |http|
       res = http.post(
         url: "json_test.rhtml",
@@ -126,7 +128,7 @@ describe "Http2" do
     end
   end
 
-  it "should be able to post custom content types" do
+  it "posts custom content types" do
     with_http do |http|
       res = http.post(
         url: "content_type_test.rhtml",
@@ -142,7 +144,7 @@ describe "Http2" do
     end
   end
 
-  it "should set various timeouts" do
+  it "sets various timeouts" do
     with_http do |http|
       http.get("content_type_test.rhtml")
       expect(http.keepalive_timeout).to eq 15
@@ -150,7 +152,7 @@ describe "Http2" do
     end
   end
 
-  it "should follow redirects" do
+  it "follows redirects" do
     with_http(follow_redirects: true) do |http|
       resp = http.get("redirect_test.rhtml")
       expect(resp.code).to eq "200"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: http2
 version: !ruby/object:Gem::Version
-  version: 0.0.35
+  version: 0.0.36
 platform: ruby
 authors:
 - Kasper Johansen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-10-04 00:00:00.000000000 Z
+date: 2021-11-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: string-cases
@@ -136,6 +136,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
@@ -218,21 +246,21 @@ specification_version: 4
 summary: A lightweight framework for doing http-connections in Ruby. Supports cookies,
   keep-alive, compressing and much more.
 test_files:
+- spec/http2/post_multipart_request_spec.rb
+- spec/http2/response_reader_spec.rb
+- spec/http2/get_request_spec.rb
+- spec/http2/url_builder_spec.rb
+- spec/http2/cookies_spec.rb
+- spec/http2/post_data_generator_spec.rb
+- spec/http2/post_request_spec.rb
+- spec/http2/response_spec.rb
 - spec/helpers.rb
 - spec/http2_spec.rb
-- spec/spec_root/unauthorized.rhtml
+- spec/spec_helper.rb
 - spec/spec_root/json_test.rhtml
-- spec/spec_root/content_type_test.rhtml
+- spec/spec_root/unauthorized.rhtml
 - spec/spec_root/redirect_test.rhtml
-- spec/spec_root/multipart_test.rhtml
 - spec/spec_root/cookie_test.rhtml
+- spec/spec_root/content_type_test.rhtml
+- spec/spec_root/multipart_test.rhtml
 - spec/spec_root/unsupported_media_type.rhtml
-- spec/spec_helper.rb
-- spec/http2/cookies_spec.rb
-- spec/http2/get_request_spec.rb
-- spec/http2/url_builder_spec.rb
-- spec/http2/post_multipart_request_spec.rb
-- spec/http2/post_data_generator_spec.rb
-- spec/http2/post_request_spec.rb
-- spec/http2/response_reader_spec.rb
-- spec/http2/response_spec.rb