html_tables 0.2.5 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dbf40283b4ce2fbdbb5ca057c2b4bf3349923dbd
-  data.tar.gz: d404bf3592c6ae0d822fd2883804a6582094c50b
+  metadata.gz: da6917c300db6b44403b55d789ad03e9bf299482
+  data.tar.gz: 1642d7d645efd7d2217d9855213711f38d826b9f
 SHA512:
-  metadata.gz: d28ca4ed5255a12775f76c0dc8afd771b06d8949c7a466c548053cf921e4448cf016a1a2f52c5617c8b9b54ac665c1868b3219a7e6b5c5be18f19db86948a097
-  data.tar.gz: 7397b0c680a3aef4fe255c7e4f29c08250258363f6a3568ba53758850e010f9951e9028e6bc7fd29dc454649ce993be8d77af1ac0b94e3e102b4c23ac0574d17
+  metadata.gz: 8fd7b08e2b9d68f69a4c63dfac12d5852262fc3ce5b72b53b4f87bc96cf610afa0f077bd7170b1c5c518189412890c73f00f5e7543608d8ccb9f693b73020405
+  data.tar.gz: b07fc7793e2ef30305d54eb7ab434be41b91bf7c9ffe3b7c2de648250fe3492b4e466773c6b9e8a1387e976d3780af169f8f4e09580035edc426d88042952b10

data/.gitignore

@@ -0,0 +1,14 @@
+*.gem
+*.rbc
+Gemfile.lock
+InstalledFiles
+_yardoc
+coverage
+doc/
+lib/bundler/man
+pkg
+rdoc
+spec/reports
+test/tmp
+test/version_tmp
+tmp

data/.rspec

@@ -0,0 +1,2 @@
+--color
+--require spec_helper

data/.travis.yml

@@ -0,0 +1,14 @@
+language: ruby
+rvm:
+  - 2.2
+  - 2.1
+  - ruby-head
+before_install:
+  - gem update --system
+  - gem install bundler
+script:
+  - bundle exec rspec
+#gemfile:
+#  - gemfiles/rails41.gemfile
+#  - gemfiles/rails42.gemfile
+#  - gemfiles/rails50.gemfile

data/README.md

@@ -1,5 +1,7 @@
 # html_tables
 
+[![Build Status](https://travis-ci.org/elementar/html_tables.svg?branch=master)](https://travis-ci.org/elementar/html_tables)
+
 This gem was extracted from some projects on my company. Everyone is welcome to use and improve upon.
 
 ## Installation

data/Rakefile

@@ -1,2 +1,5 @@
 #!/usr/bin/env rake
-require "bundler/gem_tasks"
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
+
+RSpec::Core::RakeTask.new('spec')

data/html_tables.gemspec

@@ -18,4 +18,11 @@ Gem::Specification.new do |gem|
   gem.add_dependency 'i18n'
   gem.add_dependency 'actionpack'
   gem.add_dependency 'railties'
+
+  gem.add_development_dependency 'rspec', '~> 3.0'
+  gem.add_development_dependency 'rspec-html-matchers'
+  gem.add_development_dependency 'symbolize'
+  gem.add_development_dependency 'enumerize'
+  gem.add_development_dependency 'activerecord', '~> 4.1.0'
+  gem.add_development_dependency 'sqlite3'
 end

data/lib/html_tables.rb

@@ -1,5 +1,8 @@
 # -*- coding: utf-8 -*-
 
+require 'active_support'
+require 'action_view'
+
 require 'html_tables/version'
 require 'html_tables/config'
 

data/lib/html_tables/config.rb

@@ -11,7 +11,7 @@ module HtmlTables
     attr_accessor :use_entity_shortcuts, :url_generator_proc, :default_table_classes
 
     def initialize
-      @use_entity_shortcuts = ::Rails.env.development?
+      @use_entity_shortcuts = ENV['RAILS_ENV'] == 'development'
       @url_generator_proc = -> obj { url_for(obj) }
       @default_table_classes = %w(table table-striped table-bordered)
     end

data/lib/html_tables/data_table.rb

@@ -14,6 +14,8 @@ module HtmlTables
     end
 
     def auto_generate_columns!
+      raise 'Could not auto generate columns' unless model.respond_to? :accessible_attributes
+
       model.accessible_attributes.each do |attr|
         col = model_columns[attr]
         object_to_yield.column col.name unless col.nil?
@@ -23,7 +25,7 @@ module HtmlTables
     def model
       @model ||= begin
         n = collection.model_name.constantize if collection.respond_to?(:model_name)
-        n = n.name if n.is_a?(ActiveModel::Name)
+        n = n.name if (defined? ActiveModel) && n.is_a?(ActiveModel::Name)
         n
       end
       @model ||= collection.first.try(:class)
@@ -84,15 +86,20 @@ module HtmlTables
       h
     end
 
-    def group_by(column_or_lambda, &block)
-      options[:group] = { block: block, proc: case column_or_lambda
-        when String, Symbol
-          ->(obj) { obj.public_send(column_or_lambda) }
-        when Proc
-          column_or_lambda
-        else
-          raise ArgumentError.new "group_by first argument must be a String, Symbol or Proc"
-      end }
+    # Groups records on the table.
+    # @param [Symbol,Proc] field_or_proc The field name (or +Proc+) which will be used to group the records.
+    # @param [Proc] block Specifies the block to render on each group. It will be rendered as a full-width row.
+    def group_by(field_or_proc, &block)
+      proc = case field_or_proc
+               when String, Symbol
+                 lambda { |obj| obj.public_send(field_or_proc) }
+               when Proc
+                 field_or_proc
+               else
+                 raise ArgumentError, 'group_by first argument must be a String, Symbol or Proc'
+             end
+
+      options[:group] = { block: block, proc: proc }
       self
     end
 

data/lib/html_tables/renderer.rb

@@ -138,6 +138,8 @@ module HtmlTables
           elsif item.class.respond_to?(:human_enum_name) # simple_enum
             tmp = item.class.human_enum_name(column, tmp)
           end
+        elsif tmp.class.name == 'Enumerize::Value' # enumerize
+          tmp = tmp.text
         end
         tmp
       end

data/lib/html_tables/version.rb

@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 module HtmlTables
-  VERSION = '0.2.5'
+  VERSION = '1.1.0'
 end

data/spec/locales/pt.yml

@@ -0,0 +1,12 @@
+pt:
+  activerecord:
+    symbolizes:
+      user:
+        role:
+          manager: Gerente
+          admin: Administrador
+  enumerize:
+    user:
+      sex:
+        male: Masculino
+        female: Feminino

data/spec/main_spec.rb

@@ -0,0 +1,134 @@
+require 'spec_helper'
+require 'ostruct'
+
+ActiveRecord::Base.connection.instance_eval do
+  create_table :users do |t|
+    t.string :sex
+    t.string :role
+  end
+end
+
+class User < ActiveRecord::Base
+  extend Enumerize
+
+  enumerize :sex, :in => [:male, :female]
+  symbolize :role, :in => [:manager, :admin]
+end
+
+class FakeBuilder < ActionView::Base
+  include HtmlTables::DataTableHelper
+end
+
+RSpec.describe HtmlTables::DataTable do
+
+  before do
+    User.create(sex: :female, role: :manager)
+  end
+
+  let(:col0) { [] }
+  let(:col1) { [{ id: 1, name: 'Record One', enabled: true },
+                { id: 2, name: 'Record Two', enabled: false }].map &OpenStruct.method(:new) }
+  let(:builder) { FakeBuilder.new }
+  let(:user_collection) { User.all }
+
+  describe 'basic usage' do
+    it 'should render nicely when empty' do
+      html = builder.data_table_for col0 do |t|
+        t.column :id
+        t.column :name
+        t.nodata 'No records found'
+      end
+
+      expect(html).to have_tag :tbody do
+        with_tag :tr, count: 1
+        with_tag :td, count: 1, text: 'No records found', with: { colspan: 2 }
+      end
+    end
+
+    it 'should render nicely with records and explicit columns' do
+      html = builder.data_table_for col1 do |t|
+        t.column :id
+        t.column :name
+        t.nodata 'No records found'
+      end
+
+      expect(html).not_to have_tag :td, text: 'No records found'
+      expect(html).to have_tag :tbody do
+        with_tag :tr, text: 'Record One'
+        with_tag :tr, text: 'Record Two'
+      end
+    end
+
+    it 'should translate values from enumerize' do
+      html = builder.data_table_for user_collection do |t|
+        t.column :sex
+        t.nodata 'No records found'
+      end
+
+      expect(html).to have_tag :tbody do
+        with_tag :td, text: 'Feminino'
+      end
+    end
+
+    it 'should show empty cell for empty enumerize field' do
+      user_collection.first.update(sex: nil)
+      updated_collection = user_collection
+      html = builder.data_table_for updated_collection do |t|
+        t.column :sex
+        t.nodata 'No records found'
+      end
+
+      expect(html).to have_tag :tbody do
+        with_tag :td, text: ''
+      end
+    end
+
+    it 'should translate values from symbolize' do
+      html = builder.data_table_for user_collection do |t|
+        t.column :role
+        t.nodata 'No records found'
+      end
+
+      expect(html).to have_tag :tbody do
+        with_tag :td, text: 'Gerente'
+      end
+    end
+  end
+
+  describe 'row class' do
+    it 'should add the row class on the correct rows' do
+      html = builder.data_table_for col1 do |t|
+        t.row_class :disabled, if: -> rec { !rec.enabled }
+        t.column :id
+        t.column :name
+      end
+
+      expect(html).to have_tag :tbody do
+        with_tag :tr, without: { class: 'disabled' }, text: 'Record One'
+        with_tag :tr, with: { class: 'disabled' }, text: 'Record Two'
+      end
+    end
+  end
+
+  describe 'totals' do
+    it 'should calculate totals correctly'
+  end
+
+  describe 'grouping' do
+    it 'should group records correctly'
+  end
+
+  describe 'column definition' do
+    it 'should auto-detect columns from ActiveModel compatible models'
+    it 'should allow custom columns'
+  end
+
+  describe 'alignment' do
+    it 'should apply the correct classes when aligning columns'
+  end
+
+  describe 'headers' do
+    it 'should allow overriding the header text'
+    it 'should allow overriding the header style'
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,40 @@
+require 'html_tables'
+require 'rspec-html-matchers'
+require 'active_record'
+require 'enumerize'
+require 'symbolize'
+
+I18n.load_path += Dir[File.join(File.dirname(__FILE__), 'locales', '*.{rb,yml}')]
+I18n.available_locales = ["pt"]
+I18n.default_locale = :"pt"
+
+ActiveRecord::Base.send :include, Symbolize::ActiveRecord
+
+silence_warnings do
+  ActiveRecord::Migration.verbose = false
+  ActiveRecord::Base.logger = Logger.new(nil)
+  ActiveRecord::Base.establish_connection(:adapter => "sqlite3", :database => ":memory:")
+end
+
+# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
+RSpec.configure do |config|
+  config.include RSpecHtmlMatchers
+
+  config.expect_with :rspec do |expectations|
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+  end
+
+  config.mock_with :rspec do |mocks|
+    mocks.verify_partial_doubles = true
+  end
+
+  config.filter_run :focus
+  config.run_all_when_everything_filtered = true
+
+  config.disable_monkey_patching!
+
+  config.default_formatter = 'doc' if config.files_to_run.one?
+
+  config.order = :random
+  Kernel.srand config.seed
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: html_tables
 version: !ruby/object:Gem::Version
-  version: 0.2.5
+  version: 1.1.0
 platform: ruby
 authors:
 - Fábio David Batista
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-12 00:00:00.000000000 Z
+date: 2016-02-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n
@@ -52,6 +52,90 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: rspec-html-matchers
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: symbolize
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: enumerize
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: activerecord
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 4.1.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 4.1.0
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Simple DSL for HTML data tables
 email:
 - fabio@elementarsistemas.com.br
@@ -60,6 +144,8 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rspec"
+- ".travis.yml"
 - CHANGELOG
 - Gemfile
 - LICENSE
@@ -76,6 +162,9 @@ files:
 - lib/html_tables/to_label.rb
 - lib/html_tables/version.rb
 - lib/html_tables/yielded_object.rb
+- spec/locales/pt.yml
+- spec/main_spec.rb
+- spec/spec_helper.rb
 homepage: http://elementarsistemas.com.br/
 licenses: []
 metadata: {}
@@ -95,9 +184,12 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: This gem was extracted from some projects on my company. Everyone is welcome
   to use and improve upon.
-test_files: []
+test_files:
+- spec/locales/pt.yml
+- spec/main_spec.rb
+- spec/spec_helper.rb