html-proofer 3.15.1 → 3.15.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9517668b83d7e09665e775b58869aad3688ffa0edf579cb3d9e9c519ca88ceb2
-  data.tar.gz: c63e8d6bab0e5513f95b1315cee1d0f55a6326815a70105a115d8629d97dc0a8
+  metadata.gz: d96b191b03d99b1d4fac61814a324dc0e46d69073318591fce74077dd484b512
+  data.tar.gz: 35bb1cd3d4ab1666c699b144afca8c20860db957156610a78d83f1f25154fde2
 SHA512:
-  metadata.gz: efeffe5729c11c5bf129bf37c46388f4942158c0079fe36458d25719bb3264ef8421b54c1cafd458f41497756306de1fe0b663e903a6fec9480243f37aea3edf
-  data.tar.gz: 69cd979675e246ba566393bae545e58205e6241d46031a69665c96d3ce84b8cce77acf622e544f238079b249a430935485a7cfd29d615c312c587e879233ba1f
+  metadata.gz: c1e3e8e502e52aff8e11aa917232cf288be5afcfea255b5b5bdfef61ef327e8d2899a4c394ba529fc13f6e246fa1523650d3689205f68c9f4cfd005077c4f2a4
+  data.tar.gz: d33bacd4efe1d0f6fee8eeb4d3491738b7d82a840e43fac77374a019319dc099e75d7e4d6440e3ed0dcba6b2c42d78178dd18351289fb2f8f4a9d32cad185353

data/bin/htmlproofer

@@ -41,6 +41,8 @@ Mercenary.program(:htmlproofer) do |p|
   p.option 'report_missing_names', '--report-missing-names', 'When `check_html` is enabled, HTML markup that are missing entity names are reported as errors (default: `false`)'
   p.option 'report_script_embeds', '--report-script-embeds', 'When `check_html` is enabled, `script` tags containing markup are reported as errors (default: `false`)'
   p.option 'report_missing_doctype', '--report-missing-doctype', 'When `check_html` is enabled, HTML markup with missing or out-of-order `DOCTYPE` are reported as errors (default: `false`)'
+  p.option 'report_eof_tags', '--report-eof-tags', 'When `check_html` is enabled, HTML markup with tags that are malformed are reported as errors (default: `false`)'
+  p.option 'report_mismatched_tags', '--report-mismatched-tags', 'When `check_html` is enabled, HTML markup with mismatched tags are reported as errors (default: `false`)'
   p.option 'log_level', '--log-level <level>', String, 'Sets the logging level, as determined by Yell. One of `:debug`, `:info`, `:warn`, `:error`, or `:fatal`. (default: `:info`)'
   p.option 'only_4xx', '--only-4xx', 'Only reports errors for links that fall within the 4xx status code range'
   p.option 'storage_dir', '--storage-dir PATH', String, 'Directory where to store the cache log (default: "tmp/.htmlproofer")'
@@ -82,6 +84,8 @@ Mercenary.program(:htmlproofer) do |p|
     options[:validation][:report_missing_names] = opts['report_missing_names'] unless opts['report_missing_names'].nil?
     options[:validation][:report_invalid_tags] = opts['report_invalid_tags'] unless opts['report_invalid_tags'].nil?
     options[:validation][:report_missing_doctype] = opts['report_missing_doctype'] unless opts['report_missing_doctype'].nil?
+    options[:validation][:report_eof_tags] = opts['report_eof_tags'] unless opts['report_eof_tags'].nil?
+    options[:validation][:report_mismatched_tags] = opts['report_mismatched_tags'] unless opts['report_mismatched_tags'].nil?
 
     options[:typhoeus] = HTMLProofer::Configuration.parse_json_option('typhoeus_config', opts['typhoeus_config']) unless opts['typhoeus_config'].nil?
 

data/lib/html-proofer/check.rb

@@ -5,10 +5,11 @@ module HTMLProofer
   class Check
     attr_reader :node, :html, :element, :src, :path, :options, :issues, :external_urls
 
-    def initialize(src, path, html, options)
+    def initialize(src, path, html, logger, options)
       @src    = src
       @path   = path
       @html   = remove_ignored(html)
+      @logger = logger
       @options = options
       @issues = []
       @external_urls = {}
@@ -16,7 +17,7 @@ module HTMLProofer
 
     def create_element(node)
       @node = node
-      Element.new(node, self)
+      Element.new(node, self, @logger)
     end
 
     def run

data/lib/html-proofer/check/html.rb

@@ -6,7 +6,9 @@ class HtmlCheck < ::HTMLProofer::Check
   INVALID_TAG_MSG = /Tag ([\w\-:]+) invalid/.freeze
   INVALID_PREFIX = /Namespace prefix/.freeze
   PARSE_ENTITY_REF = /htmlParseEntityRef: no name/.freeze
-  DOCTYPE_MSG = /The doctype must be the first token in the document/.freeze
+  DOCTYPE_MSG = /Expected a doctype token/.freeze
+  EOF_IN_TAG = /End of input in tag/.freeze
+  MISMATCHED_TAGS = /That tag isn't allowed here/.freeze
 
   def run
     @html.errors.each do |error|
@@ -24,6 +26,10 @@ class HtmlCheck < ::HTMLProofer::Check
       options[:validation][:report_missing_names]
     when DOCTYPE_MSG
       options[:validation][:report_missing_doctype]
+    when EOF_IN_TAG
+      options[:validation][:report_eof_tags]
+    when MISMATCHED_TAGS
+      options[:validation][:report_mismatched_tags]
     else
       true
     end

data/lib/html-proofer/check/opengraph.rb

@@ -3,8 +3,8 @@
 class OpenGraphElement < ::HTMLProofer::Element
   attr_reader :src
 
-  def initialize(obj, check)
-    super(obj, check)
+  def initialize(obj, check, logger)
+    super(obj, check, logger)
     # Fake up src from the content attribute
     instance_variable_set('@src', @content)
 
@@ -23,7 +23,7 @@ class OpenGraphCheck < ::HTMLProofer::Check
 
   def run
     @html.css('meta[property="og:url"], meta[property="og:image"]').each do |m|
-      @opengraph = OpenGraphElement.new(m, self)
+      @opengraph = OpenGraphElement.new(m, self, @logger)
 
       next if @opengraph.ignore?
 

data/lib/html-proofer/configuration.rb

@@ -52,7 +52,9 @@ module HTMLProofer
       report_script_embeds: false,
       report_missing_names: false,
       report_invalid_tags: false,
-      report_missing_doctype: false
+      report_missing_doctype: false,
+      report_eof_tags: false,
+      report_mismatched_tags: false
     }.freeze
 
     CACHE_DEFAULTS = {}.freeze

data/lib/html-proofer/element.rb

@@ -10,12 +10,18 @@ module HTMLProofer
 
     attr_reader :id, :name, :alt, :href, :link, :src, :line, :data_proofer_ignore
 
-    def initialize(obj, check)
+    def initialize(obj, check, logger)
+      @logger = logger
       # Construct readable ivars for every element
-      obj.attributes.each_pair do |attribute, value|
-        name = attribute.tr('-:.', '_').to_s.to_sym
-        (class << self; self; end).send(:attr_reader, name)
-        instance_variable_set("@#{name}", value.value)
+      begin
+        obj.attributes.each_pair do |attribute, value|
+          name = attribute.tr('-:.;', '_').to_s.to_sym
+          (class << self; self; end).send(:attr_reader, name)
+          instance_variable_set("@#{name}", value.value)
+        end
+      rescue NameError => e
+        @logger.log :error, "Attribute set `#{obj}` contains an error!"
+        raise e
       end
 
       @aria_hidden = defined?(@aria_hidden) && @aria_hidden == 'true' ? true : false

data/lib/html-proofer/middleware.rb

@@ -21,7 +21,8 @@ module HTMLProofer
         allow_hash_href: true,
         check_external_hash: true,
         check_html: true,
-        url_ignore: [/.*/] # Don't try to check local files exist
+        url_ignore: [/.*/], # Don't try to check if local files exist
+        validation: { report_eof_tags: true }
       }
     end
 

data/lib/html-proofer/runner.rb

@@ -100,7 +100,7 @@ module HTMLProofer
       @src.each do |src|
         checks.each do |klass|
           @logger.log :debug, "Checking #{klass.to_s.downcase} on #{path} ..."
-          check = Object.const_get(klass).new(src, path, html, @options)
+          check = Object.const_get(klass).new(src, path, html, @logger, @options)
           check.run
           external_urls = check.external_urls
           external_urls = Hash[check.external_urls.map { |url, file| [swap(url, @options[:url_swap]), file] }] if @options[:url_swap]
@@ -147,6 +147,8 @@ module HTMLProofer
     def checks
       return @checks if defined?(@checks) && !@checks.nil?
 
+      return (@checks = ['LinkCheck']) if @type == :links
+
       @checks = HTMLProofer::Check.subchecks.map(&:name)
       @checks.delete('FaviconCheck') unless @options[:check_favicon]
       @checks.delete('HtmlCheck') unless @options[:check_html]

data/lib/html-proofer/utils.rb

@@ -15,7 +15,7 @@ module HTMLProofer
                   path
                 end
 
-      Nokogiri::HTML5(content)
+      Nokogiri::HTML5(content, max_errors: -1)
     end
 
     def swap(href, replacement)

data/lib/html-proofer/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module HTMLProofer
-  VERSION = '3.15.1'
+  VERSION = '3.15.2'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: html-proofer
 version: !ruby/object:Gem::Version
-  version: 3.15.1
+  version: 3.15.2
 platform: ruby
 authors:
 - Garen Torikian
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-20 00:00:00.000000000 Z
+date: 2020-03-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -308,7 +308,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: A set of tests to validate your HTML output. These tests check if your image