html-proofer 1.3.2 → 1.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6d5b14b6178908b17570a31f33037c49877be42c
-  data.tar.gz: faafb22c69d987e04243461750f272b22636d890
+  metadata.gz: 2ec0386b90eb4e6cd4488cc9c05a51f9bb4618b9
+  data.tar.gz: 131403625ac57dc2efbae4799f6925151457f0d5
 SHA512:
-  metadata.gz: b7434cb92b9bb07a453dc455505276f47866b8d4659427b101218a925fd2374321539f6ccda3ba81f93c1449e59c5a20410c439e5e8e08a4ad851a92dfcb055f
-  data.tar.gz: 7dca51e17a8033609e76988aa5d0a46d15e5790b6d11807b2db32d8bffb15f46baf5f784f9ac473a65c8c644bb718a0cc21a1eac55e3664778856a8c7d925abc
+  metadata.gz: 8574ae57e7f490f393d0031f054d3f00b5e2ab8a530bfa9bf4188328186c29aefc4508db03422a520febdd15149a13aadf8f5f6d5a910ae6ea6856962085c8f3
+  data.tar.gz: 56ebf1b4e835f97aca351f4c76eef0000198f09b555f155ba1510faf719b0c423cae7377d411478276c431342ae5854fcd77afe12952b89f4631c61e15ef8df1

data/html-proofer.gemspec

@@ -3,7 +3,7 @@ $:.push File.expand_path("../lib", __FILE__)
 
 Gem::Specification.new do |gem|
   gem.name          = "html-proofer"
-  gem.version       = "1.3.2"
+  gem.version       = "1.3.3"
   gem.authors       = ["Garen Torikian"]
   gem.email         = ["gjtorikian@gmail.com"]
   gem.description   = %q{Test your rendered HTML files to make sure they're accurate.}

data/lib/html/proofer/checks/links.rb

@@ -3,11 +3,29 @@
 class Link < ::HTML::Proofer::Checkable
 
   def href
-    @href unless @href.nil? || @href.empty?
+    real_attr @href
+  end
+
+  def id
+    real_attr @id
+  end
+
+  def name
+    real_attr @name
   end
 
   def missing_href?
-    href.nil? and @name.nil? and @id.nil?
+    href.nil? and name.nil? and id.nil?
+  end
+
+  def placeholder?
+    (id || name) && href.nil?
+  end
+
+  private
+
+  def real_attr(attr)
+    attr unless attr.nil? || attr.empty?
   end
 
 end
@@ -20,6 +38,7 @@ class Links < ::HTML::Proofer::Checks::Check
 
       next if link.ignore?
       next if link.href =~ /^javascript:/ # can't put this in ignore? because the URI does not parse
+      next if link.placeholder?
 
       # is it even a valid URL?
       unless link.valid?
@@ -40,7 +59,7 @@ class Links < ::HTML::Proofer::Checks::Check
         self.add_issue "internally linking to #{link.href}, which does not exist" unless link.exists?
       end
 
-      # has the local directory a trailing slash?
+      # does the local directory have a trailing slash?
       if link.unslashed_directory? link.absolute_path
         self.add_issue("internally linking to a directory #{link.absolute_path} without trailing slash")
         next

data/spec/html/proofer/fixtures/links/link_pointing_to_directory.html

@@ -1 +1 @@
-<a href="folder/">Directory</a>
+<a href="folder-php/">Directory</a>

data/spec/html/proofer/fixtures/links/placeholder_with_empty_id.html

@@ -0,0 +1 @@
+<a id=""></a>

data/spec/html/proofer/fixtures/links/placeholder_with_id.html

@@ -0,0 +1 @@
+<a id="placeholder"></a>

data/spec/html/proofer/fixtures/links/placeholder_with_name.html

@@ -0,0 +1 @@
+<a name="placeholder"></a>

data/spec/html/proofer/links_spec.rb

@@ -210,12 +210,19 @@ describe "Links test" do
   end
 
   it "works for directory index file" do
-    options = { :directory_index => "index.php" }
+    options = { :directory_index_file => "index.php" }
     link_pointing_to_directory = "#{FIXTURES_DIR}/links/link_pointing_to_directory.html"
     output = capture_stderr { HTML::Proofer.new(link_pointing_to_directory, options).run }
     output.should == ""
   end
 
+  it "fails if directory index file doesn't exist" do
+    options = { :directory_index_file => "README.md" }
+    link_pointing_to_directory = "#{FIXTURES_DIR}/links/link_pointing_to_directory.html"
+    output = capture_stderr { HTML::Proofer.new(link_pointing_to_directory, options).run }
+    output.should match "internally linking to folder-php/, which does not exist"
+  end
+
   it "ensures Typhoeus options are passed" do
     options = { ssl_verifypeer: false }
     typhoeus_options_link = "#{FIXTURES_DIR}/links/ensure_typhoeus_options.html"
@@ -234,4 +241,22 @@ describe "Links test" do
     output = capture_stderr { HTML::Proofer.new(hashReferringToSelf).run }
     output.should == ""
   end
+
+  it "ignores placeholder with name" do
+    placeholder_with_name = "#{FIXTURES_DIR}/links/placeholder_with_name.html"
+    output = capture_stderr { HTML::Proofer.new(placeholder_with_name).run }
+    output.should == ""
+  end
+
+  it "ignores placeholder with id" do
+    placeholder_with_id = "#{FIXTURES_DIR}/links/placeholder_with_id.html"
+    output = capture_stderr { HTML::Proofer.new(placeholder_with_id).run }
+    output.should == ""
+  end
+
+  it "fails for placeholder with empty id" do
+    empty_id = "#{FIXTURES_DIR}/links/placeholder_with_empty_id.html"
+    output = capture_stderr { HTML::Proofer.new(empty_id).run }
+    output.should match /anchor has no href attribute/
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: html-proofer
 version: !ruby/object:Gem::Version
-  version: 1.3.2
+  version: 1.3.3
 platform: ruby
 authors:
 - Garen Torikian
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-26 00:00:00.000000000 Z
+date: 2014-08-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mercenary
@@ -198,10 +198,10 @@ files:
 - spec/html/proofer/fixtures/links/checkSSLLinks.html
 - spec/html/proofer/fixtures/links/ensure_typhoeus_options.html
 - spec/html/proofer/fixtures/links/escape_pipes.html
+- spec/html/proofer/fixtures/links/folder-php/index.php
 - spec/html/proofer/fixtures/links/folder/anchorLink.html
 - spec/html/proofer/fixtures/links/folder/assets/barrel.png
 - spec/html/proofer/fixtures/links/folder/index.html
-- spec/html/proofer/fixtures/links/folder/index.php
 - spec/html/proofer/fixtures/links/folder/relativeImage.html
 - spec/html/proofer/fixtures/links/gpl.png
 - spec/html/proofer/fixtures/links/hashReferringToSelf.html
@@ -224,6 +224,9 @@ files:
 - spec/html/proofer/fixtures/links/missingLinkHref.html
 - spec/html/proofer/fixtures/links/multipleProblems.html
 - spec/html/proofer/fixtures/links/notarealhash.html
+- spec/html/proofer/fixtures/links/placeholder_with_empty_id.html
+- spec/html/proofer/fixtures/links/placeholder_with_id.html
+- spec/html/proofer/fixtures/links/placeholder_with_name.html
 - spec/html/proofer/fixtures/links/relativeLinks.html
 - spec/html/proofer/fixtures/links/rootLink/folder/index.html
 - spec/html/proofer/fixtures/links/rootLink/index.html
@@ -311,10 +314,10 @@ test_files:
 - spec/html/proofer/fixtures/links/checkSSLLinks.html
 - spec/html/proofer/fixtures/links/ensure_typhoeus_options.html
 - spec/html/proofer/fixtures/links/escape_pipes.html
+- spec/html/proofer/fixtures/links/folder-php/index.php
 - spec/html/proofer/fixtures/links/folder/anchorLink.html
 - spec/html/proofer/fixtures/links/folder/assets/barrel.png
 - spec/html/proofer/fixtures/links/folder/index.html
-- spec/html/proofer/fixtures/links/folder/index.php
 - spec/html/proofer/fixtures/links/folder/relativeImage.html
 - spec/html/proofer/fixtures/links/gpl.png
 - spec/html/proofer/fixtures/links/hashReferringToSelf.html
@@ -337,6 +340,9 @@ test_files:
 - spec/html/proofer/fixtures/links/missingLinkHref.html
 - spec/html/proofer/fixtures/links/multipleProblems.html
 - spec/html/proofer/fixtures/links/notarealhash.html
+- spec/html/proofer/fixtures/links/placeholder_with_empty_id.html
+- spec/html/proofer/fixtures/links/placeholder_with_id.html
+- spec/html/proofer/fixtures/links/placeholder_with_name.html
 - spec/html/proofer/fixtures/links/relativeLinks.html
 - spec/html/proofer/fixtures/links/rootLink/folder/index.html
 - spec/html/proofer/fixtures/links/rootLink/index.html