html-proofer 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e6fdca322142a45bad728b408d6e00e155fe01ce
-  data.tar.gz: 288123bd8384f03768178f352a90729e85101b89
+  metadata.gz: c29174a0c6d66b27477dfa875f55ddaaf5233703
+  data.tar.gz: 53abcd611dd9bea328900554a44e2480c061056d
 SHA512:
-  metadata.gz: 997be4ed93329ceb98a5fd2aa6caf7b1e664d78fc9c65057c4c76e766ada8851f4c4edb1756a80c5f54313f97048ce867bf5337d1266b62a3831d514ede33856
-  data.tar.gz: 88defb2fc1bda8ffa7a15f8fda61efcdb943074513eb73738613b556c84c75b33f4d35fa8debbd79d8fb0b33fbbe1c7a858dca396770cf4c97ef63b0655c0ee5
+  metadata.gz: 56af59c05d01d8401ff70cab45f46960afd81b03588ba5054f8f5b97dc5f68564ccefddd79aafce0c94f74b1b1b8a2441621970e38dea84c708a8488b1a0af0f
+  data.tar.gz: b9402d34ea0c1f5ffe9e5ba9b6657b557a9ed86d73f6cee8a741034ffba39b1f82d042eec40d20cdf0ec8570ec15a31a6c51291d62c35aa6e98c052c3c20f2f4

data/html-proofer.gemspec

@@ -3,7 +3,7 @@ $:.push File.expand_path("../lib", __FILE__)
 
 Gem::Specification.new do |gem|
   gem.name          = "html-proofer"
-  gem.version       = "1.1.0"
+  gem.version       = "1.1.1"
   gem.authors       = ["Garen Torikian"]
   gem.email         = ["gjtorikian@gmail.com"]
   gem.description   = %q{Test your rendered HTML files to make sure they're accurate.}

data/lib/html/proofer/checks/favicon.rb

@@ -11,7 +11,7 @@ class Favicons < ::HTML::Proofer::Checks::Check
   def run
     return unless @options[:favicon]
 
-    @html.css("link").each do |favicon|
+    @html.xpath("//link[not(ancestor::pre or ancestor::code)]").each do |favicon|
       favicon = Favicon.new favicon, "favicon", self
       return if favicon.rel.split(" ").last.eql? "icon"
     end

data/lib/html/proofer/checks/images.rb

@@ -24,7 +24,7 @@ end
 
 class Images < ::HTML::Proofer::Checks::Check
   def run
-    @html.css('img').each do |i|
+    @html.xpath('//img[not(ancestor::pre or ancestor::code)]').each do |i|
       img = Image.new i, "image", self
 
       next if img.ignore?

data/lib/html/proofer/checks/links.rb

@@ -19,7 +19,7 @@ end
 class Links < ::HTML::Proofer::Checks::Check
 
   def run
-    @html.css('a, link').each do |l|
+    @html.xpath('//a[not(ancestor::pre or ancestor::code)]', '//link[not(ancestor::pre or ancestor::code)]').each do |l|
       link = Link.new l, "link", self
 
       next if link.ignore?

data/lib/html/proofer/checks/scripts.rb

@@ -18,7 +18,7 @@ end
 
 class Scripts < ::HTML::Proofer::Checks::Check
   def run
-    @html.css('script').each do |s|
+    @html.xpath('//script[not(ancestor::pre or ancestor::code)]').each do |s|
       script = Script.new s, "script", self
 
       next if script.ignore?

data/spec/html/proofer/fixtures/links/anchors_in_pre.html

@@ -0,0 +1,12 @@
+<pre>
+
+  <a href="http://www.asdo3IRJ395295jsingrkrg4.com">broken link!</a>
+</pre>
+
+
+<code>
+
+
+  <a href="http://www.asdo3IRJ395295jsingrkrg4.com">broken link!</a>
+
+</code>

data/spec/html/proofer/fixtures/links/links_in_pre.html

@@ -0,0 +1,13 @@
+
+<pre>
+
+  <link rel="icon" href="">
+</pre>
+
+
+<code>
+
+
+  <link rel="icon" href="">
+
+</code>

data/spec/html/proofer/fixtures/scripts/script_in_pre.html

@@ -0,0 +1,5 @@
+<pre lang="html"><code><script src="https://embed.github.com/view/geojson/<username>/<repo>/<ref>/<path_to_file>"></script>
+</code></pre>
+
+<code><script src="https://embed.github.com/view/geojson/<username>/<repo>/<ref>/<path_to_file>"></script>
+</code>

data/spec/html/proofer/links_spec.rb

@@ -171,4 +171,16 @@ describe "Links test" do
     output = capture_stderr { HTML::Proofer.new(["www.github.com", "foofoofoo.biz"], options).run }
     output.should match /foofoo.biz\/? failed: 0 Couldn't resolve host name/
   end
+
+  it "works for broken anchors within pre" do
+    anchor_pre = "#{FIXTURES_DIR}/links/anchors_in_pre.html"
+    output = capture_stderr { HTML::Proofer.new(anchor_pre).run }
+    output.should == ""
+  end
+
+  it "works for broken link within pre" do
+    link_pre = "#{FIXTURES_DIR}/links/links_in_pre.html"
+    output = capture_stderr { HTML::Proofer.new(link_pre).run }
+    output.should == ""
+  end
 end

data/spec/html/proofer/scripts_spec.rb

@@ -32,4 +32,10 @@ describe "Scripts test" do
     output.should match /script is empty and has no src attribute/
   end
 
+  it "works for broken script within pre" do
+    script_pre = "#{FIXTURES_DIR}/scripts/script_in_pre.html"
+    output = capture_stderr { HTML::Proofer.new(script_pre).run }
+    output.should == ""
+  end
+
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: html-proofer
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Garen Torikian
@@ -182,6 +182,7 @@ files:
 - spec/html/proofer/fixtures/images/rootRelativeImages.html
 - spec/html/proofer/fixtures/images/terribleImageName.html
 - spec/html/proofer/fixtures/images/workingDataURIImage.html
+- spec/html/proofer/fixtures/links/anchors_in_pre.html
 - spec/html/proofer/fixtures/links/blank_mailto_link.html
 - spec/html/proofer/fixtures/links/blank_tel_link.html
 - spec/html/proofer/fixtures/links/brokenHashExternal.html
@@ -209,6 +210,7 @@ files:
 - spec/html/proofer/fixtures/links/link_directory_without_slash.html
 - spec/html/proofer/fixtures/links/link_missing_protocol_invalid.html
 - spec/html/proofer/fixtures/links/link_missing_protocol_valid.html
+- spec/html/proofer/fixtures/links/links_in_pre.html
 - spec/html/proofer/fixtures/links/mailto_link.html
 - spec/html/proofer/fixtures/links/missingLinkHref.html
 - spec/html/proofer/fixtures/links/multipleProblems.html
@@ -226,6 +228,7 @@ files:
 - spec/html/proofer/fixtures/scripts/script_broken_external.html
 - spec/html/proofer/fixtures/scripts/script_content.html
 - spec/html/proofer/fixtures/scripts/script_content_absent.html
+- spec/html/proofer/fixtures/scripts/script_in_pre.html
 - spec/html/proofer/fixtures/scripts/script_missing_internal.html
 - spec/html/proofer/fixtures/scripts/script_valid_internal.html
 - spec/html/proofer/images_spec.rb
@@ -282,6 +285,7 @@ test_files:
 - spec/html/proofer/fixtures/images/rootRelativeImages.html
 - spec/html/proofer/fixtures/images/terribleImageName.html
 - spec/html/proofer/fixtures/images/workingDataURIImage.html
+- spec/html/proofer/fixtures/links/anchors_in_pre.html
 - spec/html/proofer/fixtures/links/blank_mailto_link.html
 - spec/html/proofer/fixtures/links/blank_tel_link.html
 - spec/html/proofer/fixtures/links/brokenHashExternal.html
@@ -309,6 +313,7 @@ test_files:
 - spec/html/proofer/fixtures/links/link_directory_without_slash.html
 - spec/html/proofer/fixtures/links/link_missing_protocol_invalid.html
 - spec/html/proofer/fixtures/links/link_missing_protocol_valid.html
+- spec/html/proofer/fixtures/links/links_in_pre.html
 - spec/html/proofer/fixtures/links/mailto_link.html
 - spec/html/proofer/fixtures/links/missingLinkHref.html
 - spec/html/proofer/fixtures/links/multipleProblems.html
@@ -326,6 +331,7 @@ test_files:
 - spec/html/proofer/fixtures/scripts/script_broken_external.html
 - spec/html/proofer/fixtures/scripts/script_content.html
 - spec/html/proofer/fixtures/scripts/script_content_absent.html
+- spec/html/proofer/fixtures/scripts/script_in_pre.html
 - spec/html/proofer/fixtures/scripts/script_missing_internal.html
 - spec/html/proofer/fixtures/scripts/script_valid_internal.html
 - spec/html/proofer/images_spec.rb