html-proofer 0.4.1 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 59729987eddc86b73a5542fe3def694fb034fa0a
-  data.tar.gz: 8a80c231b5e22970b8ca08b6d632c71c86f970ad
+  metadata.gz: 0d99f984fc2f22c8190888bbef42ddcbc6eb311f
+  data.tar.gz: a9a5b78b906cc5602bcdf352c63590bd58bcce07
 SHA512:
-  metadata.gz: 97b8b71c017a4b188cb3c4275f9c8f94e0337142d90f0e395460e7335c205bff28d38602049e77eaab0d8e8901c2651eeca907be29c37d4b71c593b9b04e3187
-  data.tar.gz: e98f82d67408b22c19ac87ebb10c02a4649b95acf38b2867cc343bb7b809fae5d8d44828b9a888498650298333176fdab8c64215d0be95a42fe7aa3c60aa7166
+  metadata.gz: 09a1bd824416b1c5331e0fbf20c3fa6b56f71b9ef8e423ffa42efb368b6834d687fe003e2a9d368ccc9f1126cdfbaea542c56c391d99f66e3623404cb0a7050b
+  data.tar.gz: cc1c3a8d29756c4149ac2ac11696c176762934ca6117eb46ce0c98e6662e8be1291da2ead0ec46f258b355b233229b4637ad22510ab058ef0d436151fcdd6506

data/.gitignore

@@ -12,6 +12,7 @@ test/tmp
 test/version_tmp
 tmp
 
+Gemfile.lock
 out/
 sample.rb
 run_sample.rb

data/lib/html/proofer.rb

@@ -77,17 +77,16 @@ module HTML
         # continue with no op
       elsif response.timed_out?
          @failed_tests << "#{filenames.join(' ').blue}: External link #{href} failed: got a time out"
-      # hey here's a funny bug: sometimes HEAD requests return a 404, even on legitimate pages! The
-      # bug seems to affect curl; try `curl -I -X HEAD https://help.github.com/changing-author-info`
-      # so in these cases, try a regular `GET`. if it fails, it fails.
-      elsif response_code == 404 && method == :head
-        next_response = Typhoeus.get(href, @options)
-        response_handler(next_response, filenames)
       elsif (response_code == 405 || response_code == 420 || response_code == 503) && method == :head
         # 420s usually come from rate limiting; let's ignore the query and try just the path with a GET
         uri = URI(href)
         next_response = Typhoeus.get(uri.scheme + "://" + uri.host + uri.path, @options)
         response_handler(next_response, filenames)
+      # just be lazy; perform an explicit get request. some servers are apparently not configured to
+      # intercept HTTP HEAD
+      elsif method == :head
+        next_response = Typhoeus.get(href, @options)
+        response_handler(next_response, filenames)
       else
         # Received a non-successful http response.
         @failed_tests << "#{filenames.join(' ').blue}: External link #{href} failed: #{response_code} #{response.return_message}"

data/lib/html/proofer/checkable.rb

@@ -1,7 +1,7 @@
 module HTML
   class Proofer
     class Checkable
-      def initialize(obj, check)
+      def initialize(obj, type, check)
         @src = obj['src']
         @href = obj['href']
         @alt = obj['alt']
@@ -10,6 +10,7 @@ module HTML
         @data_ignore_proofer = obj['data-proofer-ignore']
         @check = check
         @checked_paths = {}
+        @type = type
 
         if @href && @check.options[:href_swap]
           @check.options[:href_swap].each do |link, replace|
@@ -50,12 +51,18 @@ module HTML
       rescue URI::BadURIError
         false
       rescue URI::InvalidURIError
+        if @type == "image"
+          @ignored = true
+          return true if url.match(/^data:image/)
+        end
+
         false
       end
 
       def ignore?
+        return true if @ignored || @data_ignore_proofer || @check.additional_href_ignores.include?(url)
         uri = URI.parse url
-        @data_ignore_proofer || %w( mailto ).include?(uri.scheme) || @check.additional_href_ignores.include?(url)
+        %w( mailto ).include?(uri.scheme)
       rescue URI::BadURIError
         false
       rescue URI::InvalidURIError

data/lib/html/proofer/checks/images.rb

@@ -25,7 +25,7 @@ end
 class Images < ::HTML::Proofer::Checks::Check
   def run
     @html.css('img').each do |i|
-      img = Image.new i, self
+      img = Image.new i, "image", self
 
       # screenshot filenames should return because of terrible names
       return self.add_issue "image has a terrible filename (#{img.src})" if img.terrible_filename?

data/lib/html/proofer/checks/links.rb

@@ -16,7 +16,7 @@ class Links < ::HTML::Proofer::Checks::Check
 
   def run
     @html.css('a').each do |l|
-      link = Link.new l, self
+      link = Link.new l, "link", self
       return if link.ignore?
 
       # is there even a href?

data/lib/html/proofer/version.rb

@@ -1,5 +1,5 @@
 module HTML
   class Proofer
-    VERSION = "0.4.1"
+    VERSION = "0.5.0"
   end
 end

data/spec/html/proofer/fixtures/checkSSLLinks.html

@@ -0,0 +1 @@
+<a href="https://developers.google.com/university">Some link</a>

data/spec/html/proofer/fixtures/workingDataURIImage.html

@@ -0,0 +1,3 @@
+<img src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAUA
+AAAFCAYAAACNbyblAAAAHElEQVQI12P4//8/w38GIAXDIBKE0DHxgljNBAAO
+9TXL0Y4OHwAAAABJRU5ErkJggg==" alt="Red dot" />

data/spec/html/proofer/images_spec.rb

@@ -58,4 +58,10 @@ describe "Image tests" do
     output = capture_stderr { HTML::Proofer.new(relativeImages).run }
     output.should == ""
   end
+
+  it 'properly checks data URI images' do
+    dataURIImage = "#{FIXTURES_DIR}/workingDataURIImage.html"
+    output = capture_stderr { HTML::Proofer.new(dataURIImage).run }
+    output.should == ""
+  end
 end

data/spec/html/proofer/links_spec.rb

@@ -68,6 +68,12 @@ describe "Links tests" do
     output.should == ""
   end
 
+  it 'properly checks ssl links' do
+    checkSSLLinks = "#{FIXTURES_DIR}/checkSSLLinks.html"
+    output = capture_stderr { HTML::Proofer.new(checkSSLLinks).run }
+    output.should == ""
+  end
+
   it 'ignores links marked as ignore data-proofer-ignore' do
     ignorableLinks = "#{FIXTURES_DIR}/ignorableLinks.html"
     output = capture_stderr { HTML::Proofer.new(ignorableLinks).run }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: html-proofer
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.5.0
 platform: ruby
 authors:
 - Garen Torikian
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-31 00:00:00.000000000 Z
+date: 2014-01-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mercenary
@@ -118,7 +118,6 @@ files:
 - .gitignore
 - .travis.yml
 - Gemfile
-- Gemfile.lock
 - LICENSE.txt
 - README.md
 - Rakefile
@@ -138,6 +137,7 @@ files:
 - spec/html/proofer/fixtures/brokenLinkExternal.html
 - spec/html/proofer/fixtures/brokenLinkInternal.html
 - spec/html/proofer/fixtures/brokenLinkWithNumber.html
+- spec/html/proofer/fixtures/checkSSLLinks.html
 - spec/html/proofer/fixtures/existingImageExternal.html
 - spec/html/proofer/fixtures/folder/anchorLink.html
 - spec/html/proofer/fixtures/folder/assets/barrel.png
@@ -166,6 +166,7 @@ files:
 - spec/html/proofer/fixtures/rootLink.html
 - spec/html/proofer/fixtures/rootRelativeImages.html
 - spec/html/proofer/fixtures/terribleImageName.html
+- spec/html/proofer/fixtures/workingDataURIImage.html
 - spec/html/proofer/images_spec.rb
 - spec/html/proofer/links_spec.rb
 - spec/html/proofer/version_spec.rb
@@ -204,6 +205,7 @@ test_files:
 - spec/html/proofer/fixtures/brokenLinkExternal.html
 - spec/html/proofer/fixtures/brokenLinkInternal.html
 - spec/html/proofer/fixtures/brokenLinkWithNumber.html
+- spec/html/proofer/fixtures/checkSSLLinks.html
 - spec/html/proofer/fixtures/existingImageExternal.html
 - spec/html/proofer/fixtures/folder/anchorLink.html
 - spec/html/proofer/fixtures/folder/assets/barrel.png
@@ -232,6 +234,7 @@ test_files:
 - spec/html/proofer/fixtures/rootLink.html
 - spec/html/proofer/fixtures/rootRelativeImages.html
 - spec/html/proofer/fixtures/terribleImageName.html
+- spec/html/proofer/fixtures/workingDataURIImage.html
 - spec/html/proofer/images_spec.rb
 - spec/html/proofer/links_spec.rb
 - spec/html/proofer/version_spec.rb

data/Gemfile.lock

@@ -1,70 +0,0 @@
-PATH
-  remote: .
-  specs:
-    html-proofer (0.3.0)
-      colored (~> 1.2)
-      mercenary (~> 0.2.0)
-      nokogiri (~> 1.6.0)
-      typhoeus (~> 0.6.7)
-
-GEM
-  remote: http://rubygems.org/
-  specs:
-    activesupport (4.0.0)
-      i18n (~> 0.6, >= 0.6.4)
-      minitest (~> 4.2)
-      multi_json (~> 1.3)
-      thread_safe (~> 0.1)
-      tzinfo (~> 0.3.37)
-    atomic (1.1.14)
-    colored (1.2)
-    diff-lcs (1.2.4)
-    escape_utils (0.3.2)
-    ethon (0.6.2)
-      ffi (>= 1.3.0)
-      mime-types (~> 1.18)
-    ffi (1.9.3)
-    gemoji (1.4.0)
-    github-markdown (0.5.5)
-    html-pipeline (0.0.14)
-      activesupport (>= 2)
-      escape_utils (~> 0.3)
-      gemoji (~> 1.0)
-      github-markdown (~> 0.5)
-      nokogiri (~> 1.4)
-      rinku (~> 1.7)
-      sanitize (~> 2.0)
-    i18n (0.6.5)
-    mercenary (0.2.0)
-    mime-types (1.25.1)
-    mini_portile (0.5.1)
-    minitest (4.7.5)
-    multi_json (1.8.1)
-    nokogiri (1.6.0)
-      mini_portile (~> 0.5.0)
-    rake (10.1.0)
-    rinku (1.7.3)
-    rspec (2.13.0)
-      rspec-core (~> 2.13.0)
-      rspec-expectations (~> 2.13.0)
-      rspec-mocks (~> 2.13.0)
-    rspec-core (2.13.1)
-    rspec-expectations (2.13.0)
-      diff-lcs (>= 1.1.3, < 2.0)
-    rspec-mocks (2.13.1)
-    sanitize (2.0.6)
-      nokogiri (>= 1.4.4)
-    thread_safe (0.1.3)
-      atomic
-    typhoeus (0.6.7)
-      ethon (~> 0.6.2)
-    tzinfo (0.3.38)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  html-pipeline (~> 0.0.12)
-  html-proofer!
-  rake
-  rspec (~> 2.13.0)