html-pipeline 2.4.0 → 2.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ed15fa4f3c355b07e08e89afa43a22255c991707
-  data.tar.gz: 0ae30d5bb58a6e147cabe6c4544d91924baa57ce
+  metadata.gz: 35aa83bb8902a72b012f930cafe924e7177a6d80
+  data.tar.gz: 808e09472fdeaf1cf294bf4715e6754b38b0157b
 SHA512:
-  metadata.gz: 9e288b4a1bacea79b17470dbbc5c87c681df180f32c944082670830a9c9fe61790c2e6e86ff0867e4398de10b7968d6bfe17e073261eb62dd1878b02dba7dbe9
-  data.tar.gz: 22009dc61f3647e40a23bff646020dfae75fc9acc1aee68d24d29abf23045365c630b8f95a90b0a71daa3656379ba6ac35e9bb76963ad9ac900cb2080b46ad36
+  metadata.gz: 214b479a825e9b5199e2e0c38a3d73519c56df8950786f12b2c5a35107081ffdec9a3fedcdbe1903428e276bfb2b893f353462e0acdf116f7fb2bfb53dd7c4bd
+  data.tar.gz: b0868ef474821065d9f4feb9c3769e66ccded085435931f2cbcdb03ddf66f42a4b469f60f8cd5719580f368a9d04316780581a157d481eca0a1d60dd0af51e35

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.4.1
+
+* Regression in EmailReplyPipeline: unfiltered content is being ommitted [#253](https://github.com/jch/html-pipeline/pull/253)
+
 ## 2.4.0
 
 * Optionally filter email addresses [#247](https://github.com/jch/html-pipeline/pull/247)

data/README.md

@@ -250,6 +250,9 @@ Here are some extensions people have built:
 * [html-pipeline-vimeo](https://github.com/dlackty/html-pipeline-vimeo) - An HTML::Pipeline filter for Vimeo links
 * [html-pipeline-hashtag](https://github.com/mr-dxdy/html-pipeline-hashtag) - An HTML::Pipeline filter for hashtags
 * [html-pipeline-linkify_github](https://github.com/jollygoodcode/html-pipeline-linkify_github) - An HTML::Pipeline filter to autolink GitHub urls
+* [html-pipeline-redcarpet_filter](https://github.com/bmikol/html-pipeline-redcarpet_filter) - Render Markdown source text into Markdown HTML using Redcarpet
+* [html-pipeline-typogruby_filter](https://github.com/bmikol/html-pipeline-typogruby_filter) - Add Typogruby text filters to your HTML::Pipeline
+
 
 ## Instrumenting
 

data/lib/html/pipeline/email_reply_filter.rb

@@ -49,7 +49,7 @@ module HTML
           if fragment.quoted?
             if context[:hide_quoted_email_addresses]
               pieces.map! do |piece|
-                piece.gsub!(EMAIL_REGEX, HIDDEN_EMAIL_PATTERN)
+                piece.gsub(EMAIL_REGEX, HIDDEN_EMAIL_PATTERN)
               end
             end
             pieces.unshift EMAIL_QUOTED_HEADER

data/lib/html/pipeline/version.rb

@@ -1,5 +1,5 @@
 module HTML
   class Pipeline
-    VERSION = "2.4.0"
+    VERSION = "2.4.1"
   end
 end

data/test/html/pipeline/email_reply_filter_test.rb

@@ -29,4 +29,38 @@ EMAIL
     refute_match %r(boatymcboatface@example.com), doc
     refute_match %r(alreadyleaked@example.com), doc
   end
+
+  def test_preserves_non_email_content_while_filtering
+    str = <<-EMAIL
+> Thank you! I have some thoughts on this pull request.
+>
+>  *  acme provides cmake and a wrapper for it. Please use '$(TARGET)-cmake' instead of cmake -DCMAKE_TOOLCHAIN_FILE='$(CMAKE_TOOLCHAIN_FILE)' -DCMAKE_BUILD_TYPE=Release.
+
+Okay -- I'm afraid I just blindly copied the eigen3.mk file, since that's a library I'm familiar with :-)
+
+>  *  Do you need -DCMAKE_SYSTEM_PROCESSOR=x86?
+
+Yes, this is a bit dumb, but vc checks for that (or amd) to determine that it's not being built on ARM.
+
+--
+Boaty McBoatface | http://example.org
+EMAIL
+
+    filter = EmailReplyFilter.new(str, :hide_quoted_email_addresses => true)
+    doc = filter.call.to_s
+
+    expected = <<-EXPECTED
+<div class="email-quoted-reply"> Thank you! I have some thoughts on this pull request.
+
+  *  acme provides cmake and a wrapper for it. Please use &#39;$(TARGET)-cmake&#39; instead of cmake -DCMAKE_TOOLCHAIN_FILE=&#39;$(CMAKE_TOOLCHAIN_FILE)&#39; -DCMAKE_BUILD_TYPE=Release.</div>
+<div class="email-fragment">Okay -- I&#39;m afraid I just blindly copied the eigen3.mk file, since that&#39;s a library I&#39;m familiar with :-)</div>
+<div class="email-quoted-reply">  *  Do you need -DCMAKE_SYSTEM_PROCESSOR=x86?</div>
+<div class="email-fragment">Yes, this is a bit dumb, but vc checks for that (or amd) to determine that it&#39;s not being built on ARM.</div>
+<span class="email-hidden-toggle"><a href="#">&hellip;</a></span><div class="email-hidden-reply" style="display:none"><div class="email-signature-reply">--
+Boaty McBoatface | http:&#47;&#47;example.org</div>
+</div>
+EXPECTED
+
+    assert_equal(expected.chomp, doc)
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: html-pipeline
 version: !ruby/object:Gem::Version
-  version: 2.4.0
+  version: 2.4.1
 platform: ruby
 authors:
 - Ryan Tomayko
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-11 00:00:00.000000000 Z
+date: 2016-05-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri