house_style 3.0.0 → 3.1.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (11) hide show
  1. checksums.yaml +4 -4
  2. data/CHANGELOG.md +8 -0
  3. data/features/rubocop.yml +0 -3
  4. data/house_style.gemspec +1 -1
  5. data/lib/generators/house_style/templates/rspec_rubocop.yml +0 -1
  6. data/rails/db_migrate.yml +0 -2
  7. data/rails/rubocop.yml +0 -2
  8. data/rspec/rubocop.yml +0 -3
  9. data/ruby/configuration.yml +1 -0
  10. data/ruby/rubocop.yml +2 -16
  11. metadata +2 -2
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: 4c7d73723e1623f63dc207e459d60607779a0337f292376ea84994364c8ebaad
4
- data.tar.gz: bff167b4593dfe8050a119e77b8faec1b1f852718151610dd21aa6e765d2e488
3
+ metadata.gz: 0c947968f6d0fc33d002800803ef43964505d6612eb4ae0b5b77b22f69930c8e
4
+ data.tar.gz: 0f2ffa40cba2c8c601918a1293860df3b4057193a91660c7bf53adffd15f1b02
5
5
  SHA512:
6
- metadata.gz: e0007ffa7833fef6f6c04b51c0e5ae92b4ef986aa5d56a8998553af189d6a438fc5d7d1aba7d32b85f56cee2b807bd36933c48a2c2de0391f29232ca042f7ed3
7
- data.tar.gz: 7c72f7a747f8702aa44f71910e41791d26b4573bd89c3eabce9954e7ddd6769e2b6c9d7e724915f31949c78e14eaf667d85aba544b8e0ad563e5a83429470571
6
+ metadata.gz: e630442c72620678ede86e122641eb7bf77a7d68d5bac6af010b3715b37570414350efb177c22603b9e8ceff70f2de05d2d9019b5bd88820f069509dfdc3e7c8
7
+ data.tar.gz: d3929cb712e7fcdf91937c0281bfbd3dc1eb54ce0730983a01c48ee96b1797a31102b628a5d0dc9e96b903ea8383dcba8b70041ded132f04a0d476eeccffe109
data/CHANGELOG.md CHANGED
@@ -1,5 +1,13 @@
1
1
  # CHANGELOG
2
2
 
3
+ ## 3.1.0
4
+ ### Changes
5
+ - Do not suggest extensions
6
+ - Remove Rails/FindById (it isn't safe if you're using MongoId in a project depending on your configuration)
7
+ - Use `braces_for_chaining` for `Style/BlockDelimiters`. As a team, we've agreed to use this more general extended approach among the community. It also simplifies configuration for specs, fixtures, migrations... etc.
8
+ ## Bug fixes
9
+ - In RSpec template, do not inherit the root configuration, as the rspec .rubocop.yml file already inherits the ruby configuration itself.
10
+
3
11
  ## 3.0.0
4
12
  ### Bug fixes
5
13
  - Change the Rails template so the require for the rspec plugin is done in the main .rubocop.yml file. Otherwise generating the TODO doesn't work properly.
data/features/rubocop.yml CHANGED
@@ -2,6 +2,3 @@ inherit_from: ../ruby/rubocop.yml
2
2
 
3
3
  Layout/LineLength:
4
4
  Enabled: false
5
- Style/BlockDelimiters:
6
- Exclude:
7
- - factories/**/*
data/house_style.gemspec CHANGED
@@ -3,7 +3,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
3
3
 
4
4
  Gem::Specification.new do |spec|
5
5
  spec.name = 'house_style'
6
- spec.version = '3.0.0'
6
+ spec.version = '3.1.0'
7
7
  spec.authors = ['Altmetric', 'Scott Matthewman']
8
8
  spec.email = ['engineering@altmetric.com', 'scott.matthewman@gmail.com']
9
9
 
data/lib/generators/house_style/templates/rspec_rubocop.yml CHANGED
@@ -1,3 +1,2 @@
1
- inherit_from: ../.rubocop.yml
2
1
  inherit_gem:
3
2
  house_style: rspec/rubocop.yml
data/rails/db_migrate.yml CHANGED
@@ -2,7 +2,5 @@ Layout/EmptyLineBetweenDefs:
2
2
  Enabled: false
3
3
  Layout/LineLength:
4
4
  Enabled: false
5
- Style/BlockDelimiters:
6
- Enabled: false
7
5
  Style/StringLiterals:
8
6
  Enabled: false
data/rails/rubocop.yml CHANGED
@@ -45,8 +45,6 @@ Rails/ExpandedDateRange:
45
45
  Enabled: true
46
46
  Rails/FindBy:
47
47
  Enabled: true
48
- Rails/FindById:
49
- Enabled: true
50
48
  Rails/FindEach:
51
49
  Enabled: true
52
50
  Rails/HttpPositionalArguments:
data/rspec/rubocop.yml CHANGED
@@ -106,6 +106,3 @@ RSpec/VoidExpect:
106
106
  Enabled: true
107
107
  RSpec/Yield:
108
108
  Enabled: true
109
-
110
- Style/BlockDelimiters:
111
- Enabled: false
data/ruby/configuration.yml CHANGED
@@ -7,6 +7,7 @@ AllCops:
7
7
  # RuboCop has a bunch of cops enabled by default. This setting tells RuboCop
8
8
  # to ignore them, so only the ones explicitly set in this file are enabled.
9
9
  DisabledByDefault: true
10
+ SuggestExtensions: false
10
11
 
11
12
  Exclude:
12
13
  - bin/**/*
data/ruby/rubocop.yml CHANGED
@@ -457,22 +457,8 @@ Style/BisectedAttrAccessor:
457
457
  Style/BlockComments:
458
458
  Enabled: true
459
459
  Style/BlockDelimiters:
460
- EnforcedStyle: semantic
461
- FunctionalMethods:
462
- - before
463
- - given
464
- - given!
465
- - watch
466
- - times
467
- - try
468
- - debug
469
- - error
470
- - info
471
- - warning
472
- - let
473
- - let!
474
- - subject
475
- - watch
460
+ Enabled: true
461
+ EnforcedStyle: braces_for_chaining
476
462
  Style/CharacterLiteral:
477
463
  Enabled: true
478
464
  Style/ClassMethods:
metadata CHANGED
@@ -1,7 +1,7 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: house_style
3
3
  version: !ruby/object:Gem::Version
4
- version: 3.0.0
4
+ version: 3.1.0
5
5
  platform: ruby
6
6
  authors:
7
7
  - Altmetric
@@ -9,7 +9,7 @@ authors:
9
9
  autorequire:
10
10
  bindir: bin
11
11
  cert_chain: []
12
- date: 2022-08-04 00:00:00.000000000 Z
12
+ date: 2022-08-16 00:00:00.000000000 Z
13
13
  dependencies:
14
14
  - !ruby/object:Gem::Dependency
15
15
  name: rubocop