house_style 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 95d2d734013eac78dd85fa204f113c669c57c5ea
-  data.tar.gz: ac316b7c54461412bece3b4b79bce33fcce5bb2f
+  metadata.gz: 19abb33473a8588b70fc5840ae216fee7a5e6b21
+  data.tar.gz: 6578948af32ea270be3580f4400bad01530896a6
 SHA512:
-  metadata.gz: c56037fa21bffbe8cb809d957b0d0dbfc4911759eb3541f3566ba203b7da68d776b880836653947d918696bda673aabbd99847604add23da10fb5c5c198470d6
-  data.tar.gz: cfbad3cf9fa1595b8f3c19a11cef60cdbcf25b4af7b9ed6916e15fa76c669af0aca0fa60949e2f3c6b29457dad2ee892ab6aa0c612f5b219881c3dc6ef679eb3
+  metadata.gz: 4e22d50ce4fc6fff035a3b4b84f2b120dec15666c6c0c9d3852d2db90d686ce3ddaf3bff5f08ee3ffb1ff4bfcf0266fbe9e8e0679b62bc8c5cd426858479acc8
+  data.tar.gz: a899492697b23ef304cfeb4bab80250f0f00386617139cff5130ca8db69278adca37a476b1f4d55ce98e930d418689cdee2a672df1f81b4845dfd0ae000303bc

data/.hound.yml

@@ -0,0 +1,2 @@
+ruby:
+  config_file: .rubocop.yml

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # CHANGELOG
 
+## 1.1.0
+
+- Hound-CI uses the default rubocop configuration. It will now comment on pull requests only if code is committed that conflicts with the house style. [#11]
+- The generator will no longer create `db/migrate/.rubocop.yml` if the Rails `db/` is not present. [#10]
+- Updated rubocop to 0.41.2 and rubocop-rspec to 1.5. This has some consequences:
+    - a `TargetRubyVersion` is no longer needed, as rubocop defaults to using `.ruby-version` for identifying which version of ruby to parse against. When upgrading, it is safe to remove those lines from the host application's `.rubocop.yml` file.
+    - a new `RSpec/ExampleLength` cop is disabled for now. Nice idea, but if it's a choice between long examples and not being able to deploy because of a style issue, we should take the long examples.
+
 ## 1.0.0
 
 - Increases dependency to Rubocop 0.37.2, which changes how to specify Rails cops and introduces the requirement of a Ruby version in each project's `.rubocop.yml` file. A working value for this value will be inserted when `rails generate house_style:install` is run.

data/house_style.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'house_style'
-  spec.version       = '1.0.0'
+  spec.version       = '1.1.0'
   spec.authors       = ['Scott Matthewman']
   spec.email         = ['scott@altmetric.com']
 
@@ -13,11 +13,18 @@ Gem::Specification.new do |spec|
   spec.homepage      = 'https://github.com/altmetric/house_style'
   spec.license       = 'MIT'
 
+  spec.post_install_message = <<-ENDOFMESSAGE
+If you are updating house_style from version 1.0.0 or older, note that you can
+now remove any reference to TargetRubyVersion in your project's .rubocop.yml
+file. You should specify a .ruby-version file for your entire project, and that
+will be taken into account by rubocop also.
+  ENDOFMESSAGE
+
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'rubocop', '~> 0.37.2'
-  spec.add_dependency 'rubocop-rspec', '~> 1.4'
+  spec.add_dependency 'rubocop', '~> 0.41.2'
+  spec.add_dependency 'rubocop-rspec', '~> 1.5'
 
   spec.add_development_dependency 'bundler', '~> 1.10'
   spec.add_development_dependency 'rake', '~> 10.0'

data/lib/generators/house_style/install_generator.rb

@@ -8,7 +8,7 @@ module HouseStyle
     end
 
     def create_root_rubocop_yml
-      template 'rubocop.yml', '.rubocop.yml', assigns: { ruby_version: ruby_version }
+      template 'rubocop.yml', '.rubocop.yml'
     end
 
     def create_rspec_rubocop_yml
@@ -16,14 +16,13 @@ module HouseStyle
     end
 
     def create_db_migrate_rubocop_yml
-      template 'db_migrate_rubocop.yml', 'db/migrate/.rubocop.yml'
+      template 'db_migrate_rubocop.yml', 'db/migrate/.rubocop.yml' if Dir.exist?(db_path)
     end
 
     private
 
-    def ruby_version
-      major, minor, _ = RUBY_VERSION.split('.')
-      "#{major}.#{minor}"
+    def db_path
+      File.join(Rails.root, 'db')
     end
   end
 end

data/lib/generators/house_style/templates/rubocop.yml

@@ -1,5 +1,2 @@
-AllCops:
-  TargetRubyVersion: <%= ruby_version %>
-
 inherit_gem:
   house_style: rails/rubocop.yml

data/rspec/rubocop.yml

@@ -6,8 +6,10 @@ Metrics/LineLength:
   Enabled: false
 Metrics/ModuleLength:
   Enabled: false
+RSpec/ExampleLength:
+  Enabled: false
 RSpec/NotToNot:
-  AcceptedMethod: to_not
+  EnforcedStyle: to_not
 Style/BlockDelimiters:
   Exclude:
     - spec/factories/**/*.rb

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: house_style
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Scott Matthewman
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-26 00:00:00.000000000 Z
+date: 2016-07-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.37.2
+        version: 0.41.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.37.2
+        version: 0.41.2
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.4'
+        version: '1.5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.4'
+        version: '1.5'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -75,6 +75,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".hound.yml"
 - ".rubocop.yml"
 - ".travis.yml"
 - CHANGELOG.md
@@ -102,7 +103,11 @@ homepage: https://github.com/altmetric/house_style
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message: |
+  If you are updating house_style from version 1.0.0 or older, note that you can
+  now remove any reference to TargetRubyVersion in your project's .rubocop.yml
+  file. You should specify a .ruby-version file for your entire project, and that
+  will be taken into account by rubocop also.
 rdoc_options: []
 require_paths:
 - lib