hotspots 0.3.0 → 1.0.0

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+v1.0.0
+------
+
+* Drop older compatibility methods, modules and classes
+
 v0.3.0
 ------
 

data/TODO.md

@@ -1,3 +1,2 @@
 * Allow better use as a library - add documentation
 * Reduce conditionals
-* Remove compatibility layers in a major release

data/bin/hotspots

@@ -2,4 +2,6 @@
 
 require 'hotspots'
 
-Hotspots::Main.new.output
+options = Hotspots::OptionsParser.new.parse(*ARGV)
+
+Hotspots::Main.new(options).output

data/lib/hotspots.rb

@@ -10,10 +10,8 @@ module Hotspots
                 :exit_strategy, :driver, :parser, :store,
                 :time, :message_filters, :file_filter, :cutoff
 
-    # TODO : change this signature - this method should get resolved options as parameters
-    # initialize is not responsible for invoking option parsing
-    def initialize(opts = nil)
-      options          = opts.nil? ? Hotspots::OptionsParser.new.parse(*ARGV) : Hotspots::OptionsParser.default_options.merge(opts)
+    def initialize(opts)
+      options          = Hotspots::OptionsParser.default_options.merge(opts)
 
       @logger          = Hotspots::Logger.new
       @repository      = options[:repository]
@@ -33,32 +31,23 @@ module Hotspots
       run
     end
 
-    # TODO : this method should be private
+    private
+
     def validate #:nodoc:
       exit_if_options_are_for_help
       exit_if_not_git_repository
     end
 
-    # TODO : this method should be private
     def set #:nodoc:
       configure_logger
       set_path
       assign
     end
 
-    # TODO : this method should be private
     def run #:nodoc:
       puts store.to_s
     end
 
-    # TODO : these methods should be private
-    # compatibility begin
-    alias_method :execute!, :output
-    alias_method :validate!, :validate
-    # compatibility end
-
-    private
-
     def exit_if_options_are_for_help
       exit_strategy.perform
     end

data/lib/hotspots/logger.rb

@@ -48,16 +48,11 @@ module Hotspots
       sink << format(message, options)
     end
 
-    # Make this method private
+    private
+
     # Time stampimg should be part of log level
     def format(message, options = {})
       colour.as(options[:as] || "black", "[#{Time.now}] #{message}\n")
     end
-
-    # compatibility begin
-    alias_method :set_console, :as_console
-    Console = Sink::Console
-    Null = Sink::Null
-    # compatibility end
   end
 end

data/lib/hotspots/option_based_exit.rb

@@ -41,7 +41,3 @@ module Hotspots
     end
   end
 end
-
-# compatibility begin
-require 'hotspots/exit_strategy'
-# compatibility end

data/lib/hotspots/repository/driver/git.rb

@@ -8,13 +8,11 @@ module Hotspots
           @logger = logger
         end
 
-        # Input and output should be optionally coloured
         def pretty_log(options)
           command = log_with_tag("Input", :as => :green) { Command::Git::Log.new(:since_days => options[:since_days], :message_filter => options[:message_filter]).build }
           log_with_tag("Output", :as => :red) { %x(#{command}) }
         end
 
-        # Input and output should be optionally coloured
         def show_one_line_names(options)
           command = log_with_tag("Input", :as => :green) { Command::Git::Show.new(:commit_hash => options[:commit_hash]).build }
           log_with_tag("Output", :as => :red) { %x(#{command}) }

data/lib/hotspots/version.rb

@@ -1,3 +1,3 @@
 module Hotspots
-  VERSION = "0.3.0"
+  VERSION = "1.0.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hotspots
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 1.0.0
   prerelease: 
 platform: ruby
 authors:
@@ -91,7 +91,6 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
-- lib/hotspots/exit_strategy.rb
 - lib/hotspots/logger.rb
 - lib/hotspots/option_based_exit.rb
 - lib/hotspots/options_parser.rb
@@ -129,7 +128,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2901882375356969213
+      hash: 684827185202909371
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -138,7 +137,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2901882375356969213
+      hash: 684827185202909371
 requirements: []
 rubyforge_project: hotspots
 rubygems_version: 1.8.24

data/lib/hotspots/exit_strategy.rb

@@ -1,13 +0,0 @@
-# compatibility begin
-module Hotspots
-  module OptionBasedExit #:nodoc: all
-    class Error; end
-    class Safe; end
-    class Noop; end
-
-    ExitStrategy = Error
-    ExitStrategy::Safe = Safe
-    ExitStrategy::Null = Noop
-  end
-end
-# compatibility end