horza 0.5.2 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b318ca1842f3970fd598173331fcb64dd25a8ca3
-  data.tar.gz: eaec7a6ca3ed1c0a84d9068fbed0095d9f1c469f
+  metadata.gz: 85e3c731e1151f920c9079e120808d32ebc1a2d2
+  data.tar.gz: 862ba540a13154564bbe845c89ee03d752db4ca6
 SHA512:
-  metadata.gz: 6c20cb9a7ed5123c9946b758156a0f59b49ba4a823f421c6df7e111d0147e49a343d78ad6b2acb4cb13f5a03b4b0427a855a814188d981480741655bcb3a1d7c
-  data.tar.gz: b0b4ab6f0d3be707e1b9578685a9215e739378e988c3d0228ced9f94a66387aa997a8c78c2b9572dbc2b0a67e7738d7ee2a23c7647b43f9e1934ad4c998518de
+  metadata.gz: dac65236a361da1124d08ee528c49410f3434da8f197038827b8c374d226f269ca1190d8558905128744e64acaf4585fcd8888c6894a37cd101e914dc9595048
+  data.tar.gz: cd2bd65854ef303f73743c6fd797d87b8acdfc2d10f44281efa8e4bab382083ac389bfbb78d52cdf4481f67d85f7ce311ca5f5a9108dbe6223c93f7d7baf013c

data/README.md

@@ -2,21 +2,9 @@
 
 Horza is a library for decoupling your application from the ORM you have implemented.
 
-## Inputs
-
-Horza uses ORM-specific adapters to decouple Ruby apps from their ORMS.
-
-**Configure Adapter**
+**ActiveRecord Example**
 ```ruby
-Horza.configure do |config|
-  config.adapter = :active_record
-end
-```
-
-**Get Adapter for your ORM Object**
-```ruby
-# ActiveRecord Example
-# Don't worry, We don't actually call things horza_users in our codebase, this is just for emphasis
+# Get Adapter for your ORM Object
 horza_user = Horza.adapt(User)
 
 # Examples
@@ -153,3 +141,66 @@ end
 The returned entity for ActiveRecord adapter now include ActiveModel semantics. This type of
 entity SingleWithActiveModel can work with rails form helper and the submitted params will be
 grouped under params[:horza_entities_single_with_active_model].
+
+
+## Config
+
+Horza uses ORM-specific adapters to decouple Ruby apps from their ORMS.
+Currently only the ActiveRecord  adapter is supported.
+
+**Configure Adapter**
+```ruby
+Horza.configure do |config|
+  config.adapter = :active_record
+end
+```
+
+**Constant paths**
+Some of the operations in Horza involve resolving constants from the given options. 
+Consider the following snippet from above: 
+```ruby
+user.create_as_child(id: parent_id, klass: :employer, options)
+```
+Horza by default will return the <tt>Employer</tt> class if it has already been loaded.    
+In environments where constants are lazy-loaded - such as in Rails -  you would need to explicitly configure paths that Horza should look up when trying to resolve constants.
+
+For instance in a Rails app your models are typically found in the ```app/models``` directory,
+so you would need to add it to the constant_paths.
+
+```ruby
+# config/initializers/horza.rb
+Horza.configure do |config|
+ # config.adapter = :active_record
+  config.constant_paths += [Rails.root.join("app/models").to_s]
+end
+```
+**Note** The file paths added to _constant_paths_ would also need to be added to your app's _autoload_paths_ for the constants to be loaded dynamically. 
+
+**Model Namespaces**
+
+Horza will attempt to resolve namespaced constants where possibble provided the following caveats are met:
+
+- The file names added to the constant_paths and the constants defined in them follow the Rails naming conventions.
+- There aren't multiple files with the same base name in a given directory in the constant paths.
+
+To illustrate the second point consider the following directory structure:
+```ruby
+# app/models/employer.rb
+class Employer < ActiveRecord::Base
+  has_many :users
+end
+
+# app/models/my_namespace/employer.rb
+module MyNamespace
+  class Employer < ActiveRecord::Base
+    has_many :users
+  end
+end
+
+# In this case Horza will load the top level <tt>Employer</tt> model.
+```
+
+**Resetting config** _(At runtime or on app boot)_
+```ruby
+Horza.reset
+```

data/lib/horza/adapters/abstract_adapter.rb

@@ -3,7 +3,6 @@ module Horza
     class AbstractAdapter
       extend ::Horza::Adapters::ClassMethods
       include ::Horza::Adapters::InstanceMethods
-      extend ActiveSupport::DescendantsTracker
 
       attr_reader :context
 
@@ -11,10 +10,6 @@ module Horza
         def expected_errors_map
           not_implemented_error
         end
-
-        def entity_context_map
-          not_implemented_error
-        end
       end
 
       def get!(id)

data/lib/horza/adapters/active_record/active_record.rb

@@ -1,3 +1,5 @@
+require 'active_record'
+
 module Horza
   module Adapters
     class ActiveRecord < AbstractAdapter
@@ -9,12 +11,6 @@ module Horza
           ::Horza::Entities::SingleWithActiveModel
         end
 
-        def entity_context_map
-          # Rails doesn't preload classes in development mode, caching doesn't make sense
-          return ::Horza.descendants_map(CONTEXT_NAMESPACE) if ::Horza.configuration.development_mode
-          @map ||= ::Horza.descendants_map(CONTEXT_NAMESPACE)
-        end
-
         def expected_errors_map
           {
             ::ActiveRecord::RecordNotFound => Horza::Errors::RecordNotFound,
@@ -84,7 +80,7 @@ module Horza
           base = base.find(options.id)
 
           result = walk_family_tree(base, options)
-          return nil unless result
+          return nil if result.nil?
 
           options.target.to_s.plural? ? entity(query(options, result)) : entity(result.attributes)
         end
@@ -117,6 +113,7 @@ module Horza
         via = options.via || []
 
         via.push(options.target).reduce(object) do |object, relation|
+          return nil if object.nil?
           raise ::Horza::Errors::InvalidAncestry.new(INVALID_ANCESTRY_MSG) unless object.respond_to? relation
           object.send(relation)
         end

data/lib/horza/adapters/class_methods.rb

@@ -14,25 +14,7 @@ module Horza
       end
 
       def context_for_entity(entity)
-        context = entity_context_map[entity]
-        return context if context
-
-        lazy_load_model(entity)
-      end
-
-      def lazy_load_model(entity)
-        #raise Horza::Errors::NoContextForEntity.new unless Horza.configuration.development_mode
-        lazy_const = entity.to_s.camelize
-
-        [Object].concat(Horza.configuration.namespaces).each do |namespace|
-          begin
-            return namespace.const_get(lazy_const) if (namespace.const_get(lazy_const) < Horza.adapter::CONTEXT_NAMESPACE)
-          rescue NameError
-            next
-          end
-        end
-
-        raise Horza::Errors::NoContextForEntity.new
+        DependencyLoading.resolve_dependency(entity.to_s)
       end
 
       def not_implemented_error

data/lib/horza/configuration.rb

@@ -1,35 +1,24 @@
 module Horza
-  module Configuration
-    String.send(:include, ::Horza::CoreExtensions::String)
+  class Configuration 
+    attr_accessor :constant_paths
 
-    def configuration
-      @configuration ||= Config.new
+    def initialize
+      @constant_paths = []
     end
 
-    def reset
-      @configuration = Config.new
-      @adapter, @adapter_map = nil, nil # Class-level cache clear
-    end
-
-    def configure
-      yield(configuration)
+    def clear_constant_paths
+      constant_paths.clear
     end
 
     def adapter
-      raise ::Horza::Errors::AdapterNotConfigured.new unless configuration.adapter
-      @adapter ||= adapter_map[configuration.adapter]
-    end
-
-    def adapter_map
-      @adapter_map ||= ::Horza.descendants_map(::Horza::Adapters::AbstractAdapter)
+      @adapter || raise(::Horza::Errors::AdapterError.new("No adapter configured"))
     end
-  end
-
-  class Config
-    attr_accessor :adapter, :development_mode, :namespaces
 
-    def namespaces
-      return @namespaces || []
+    def adapter=(name)
+      @adapter = "Horza::Adapters::#{name.to_s.camelize}".constantize if name
+    rescue NameError
+      raise ::Horza::Errors::AdapterError.new("No adapter found for: #{name}")
+      @adapter = nil
     end
   end
 end

data/lib/horza/core_extensions/string.rb

@@ -12,14 +12,8 @@ module Horza
       def symbolize
         underscore.to_sym
       end
-
-      def underscore
-        gsub(/::/, '/')
-        .gsub(/([A-Z]+)([A-Z][a-z])/, '\1_\2')
-        .gsub(/([a-z\d])([A-Z])/, '\1_\2')
-        .tr('-', '_')
-        .downcase
-      end
     end
   end
 end
+
+String.send(:include, ::Horza::CoreExtensions::String)

data/lib/horza/dependency_loading.rb

@@ -0,0 +1,68 @@
+module Horza
+  module DependencyLoading
+    extend self
+
+    Error = Class.new(StandardError)
+    MissingFile = Class.new(Error)
+
+    def resolve_dependency(entity_name)
+      file_name = entity_name.to_s.underscore
+      # Return already loaded constant from memory if possible,
+      # otherwise search for a matching filename and try to load that.
+      constant = get_loaded_constant(file_name)
+      return constant if !constant.nil?
+
+      resolve_from_file_paths(file_name)
+    end
+
+    def resolve_from_file_paths(entity_name)
+      raise ArgumentError.new("No file paths configured to lookup constants") if Horza.constant_paths.empty?
+
+      file_path = search_for_file(entity_name)
+
+      resolved_name = constant_name_for_path(file_path).first
+
+      if resolved_name.nil?
+        Error.new("No constant found for: #{entity_name.inspect}")
+      else
+        ActiveSupport::Dependencies::Reference.safe_get(resolved_name)
+      end
+    end
+
+
+    def constant_name_for_path(file_path)
+      ActiveSupport::Dependencies.loadable_constants_for_path(file_path, Horza.constant_paths).tap do |loadables|
+        if loadables.many?
+          raise "It seems that your registered constant file paths are not setup correctly " +
+                 "and would cause Horza to try and load the following constants:\n\n #{loadables.map(&:inspect).join(', ')}"
+        end
+      end
+    end
+
+     # Search for a file matching the provided suffix.
+     # This recursively checks directories in the #Horza.constant_paths for matches.
+    def search_for_file(path_suffix)
+      path_suffix = path_suffix.sub(/(\.rb)?$/, ".rb")
+
+      Horza.constant_paths.each do |root|
+        Dir.glob(File.join(root, "**/")).each do |dir|      
+          path = File.join(dir, path_suffix)
+          return path if File.file? path
+        end
+      end
+      
+      raise MissingFile.new(
+        "No matching file found for: '#{path_suffix.sub(/(\.rb)?$/, "")}'\n" +
+        "Searched in: (#{Horza.constant_paths.map(&:inspect).join(', ')})"
+      )
+    end
+
+    def get_loaded_constant(entity_name)
+      constant_name = entity_name.camelize
+      if ActiveSupport::Dependencies.qualified_const_defined?(constant_name)
+        return ActiveSupport::Dependencies::Reference.get(constant_name)
+      end
+    end
+
+  end
+end

data/lib/horza/entities/collection.rb

@@ -1,6 +1,8 @@
 module Horza
   module Entities
     class Collection
+      extend ActiveSupport::DescendantsTracker
+      
       def initialize(collection)
         @collection = collection
       end

data/lib/horza/entities/single.rb

@@ -3,6 +3,7 @@ require 'hashie'
 module Horza
   module Entities
     class Single < Hash
+      extend ActiveSupport::DescendantsTracker
       include Hashie::Extensions::MethodAccess
 
       def initialize(attributes)

data/lib/horza/errors.rb

@@ -1,6 +1,6 @@
 module Horza
   module Errors
-    class AdapterNotConfigured < StandardError
+    class AdapterError < StandardError
     end
 
     class MethodNotImplemented < StandardError
@@ -24,9 +24,6 @@ module Horza
     class InvalidOption < StandardError
     end
 
-    class NoContextForEntity < StandardError
-    end
-
     class UnknownAttributeError < StandardError
     end
   end

data/lib/horza/shared_config.rb

@@ -0,0 +1,19 @@
+# Helper module to allow other libraries to access the global
+# Horza configuration instance and dispatch methods accordingly. 
+module Horza
+  module SharedConfig  
+    DelegatedMethods = %w(
+      configuration configure reset constant_paths 
+      clear_constant_paths adapter adapter=
+    )
+    
+    DelegatedMethods.each do |_meth_|
+      module_eval <<-RUBY, __FILE__, __LINE__ + 1
+        def #{_meth_}(*args, &blk)
+          Horza.send(:'#{_meth_}', *args, &blk)
+        end
+      RUBY
+    end
+    
+  end
+end

data/lib/horza/version.rb

@@ -0,0 +1,3 @@
+module Horza
+  VERSION = '1.0.0'
+end

data/lib/horza.rb

@@ -1,3 +1,8 @@
+require 'active_support/inflections'
+require 'active_support/descendants_tracker'
+require 'active_support/core_ext/module/delegation'
+require 'active_support/dependencies'
+require 'horza/dependency_loading'
 require 'horza/adapters/class_methods'
 require 'horza/adapters/instance_methods'
 require 'horza/adapters/options'
@@ -10,13 +15,27 @@ require 'horza/entities/collection'
 require 'horza/entities/single_with_active_model'
 require 'horza/entities'
 require 'horza/configuration'
+require 'horza/shared_config'
 require 'horza/errors'
-require 'active_support/inflections'
+require 'horza/version'
 
-module Horza
-  extend Configuration
 
+module Horza
   class << self
+    delegate :constant_paths, :clear_constant_paths, :adapter, :adapter=, to: :configuration
+
+    def configuration
+      @configuration ||= Configuration.new
+    end
+
+    def reset
+      @configuration = nil  
+    end
+
+    def configure
+      yield(configuration)
+    end
+
     def descendants_map(klass)
       klass.descendants.reduce({}) { |hash, (klass)| hash.merge(klass.name.split('::').last.underscore.to_sym => klass) }
     end

data/spec/active_record_spec.rb

@@ -16,139 +16,78 @@ else
     end
   end
 
-  module HorzaSpec
-    class Employer < ActiveRecord::Base
-      has_many :users
-      has_many :sports_cars
-    end
-
-    class User < ActiveRecord::Base
-      belongs_to :employer
-    end
+  class Employer < ActiveRecord::Base
+    has_many :users
+    has_many :sports_cars
+  end
 
-    class Customer < ActiveRecord::Base
-      validates :last_name, presence: true
-    end
+  class User < ActiveRecord::Base
+    belongs_to :employer
+  end
 
-    class SportsCar < ActiveRecord::Base
-      belongs_to :employer
-    end
+  class Customer < ActiveRecord::Base
+    validates :last_name, presence: true
+  end
 
-    class DummyModel < ActiveRecord::Base
-      belongs_to :employer
-    end
+  class SportsCar < ActiveRecord::Base
+    belongs_to :employer
+  end
 
-    class OtherDummyModel < ActiveRecord::Base
-      belongs_to :employer
-    end
+  class DummyModel < ActiveRecord::Base
+    belongs_to :employer
   end
 
-  class SimpleRecord < ActiveRecord::Base
+  class OtherDummyModel < ActiveRecord::Base
+    belongs_to :employer
   end
+end
 
-  module Lazy
-    class LazyRecord  < ActiveRecord::Base
-    end
+class SimpleRecord < ActiveRecord::Base
+end
+
+module Lazy
+  class LazyRecord  < ActiveRecord::Base
   end
 end
 
 describe Horza do
   let(:last_name) { 'Turner' }
   let(:adapter) { :active_record }
-  let(:user_adapter) { Horza.adapt(HorzaSpec::User) }
-  let(:customer_adapter) { Horza.adapt(HorzaSpec::Customer) }
-  let(:employer_adapter) { Horza.adapt(HorzaSpec::Employer) }
-  let(:sports_car_adapter) { Horza.adapt(HorzaSpec::SportsCar) }
+  let(:user_adapter) { Horza.adapt(User) }
+  let(:customer_adapter) { Horza.adapt(Customer) }
+  let(:employer_adapter) { Horza.adapt(Employer) }
+  let(:sports_car_adapter) { Horza.adapt(SportsCar) }
 
   # Reset base config with each iteration
   before { Horza.configure { |config| config.adapter = adapter } }
   after do
-    HorzaSpec::User.delete_all
-    HorzaSpec::Employer.delete_all
-    HorzaSpec::Customer.delete_all
-    HorzaSpec::SportsCar.delete_all
+    User.delete_all
+    Employer.delete_all
+    Customer.delete_all
+    SportsCar.delete_all
   end
 
   context '#context_for_entity' do
-    context 'when model exists' do
-      it 'Returns correct class' do
-        expect(Horza.adapter.context_for_entity(:simple_record).to_s).to eq 'SimpleRecord'
-      end
-    end
-
-    context 'when model exists in namespace' do
-      it 'Returns correct class' do
-        expect(Horza.adapter.context_for_entity(:user)).to eq HorzaSpec::User
-      end
-    end
-
-    context 'when model does not exist' do
-      it 'throws error class' do
-        expect { Horza.adapter.context_for_entity(:not_a_thing) }.to raise_error Horza::Errors::NoContextForEntity
-      end
-    end
-
-    context 'in development mode' do
-      before do
-        Horza.reset
-        Horza.configure do |config|
-          config.adapter = adapter
-          config.development_mode = true
-        end
-      end
-      after do
-        Horza.reset
-      end
-
-      context 'when model exists' do
-        it 'Returns correct class' do
-          expect(Horza.adapter.context_for_entity(:simple_record).to_s).to eq 'SimpleRecord'
-        end
-      end
-
-      context 'when model does not exist' do
-        it 'throws error class' do
-          expect { Horza.adapter.context_for_entity(:not_a_thing) }.to raise_error Horza::Errors::NoContextForEntity
-        end
-      end
-
-      context 'when model exists but has been lazy loaded' do
-        context 'without namespace' do
-          before do
-            Object.send(:remove_const, :SimpleRecord)
-          end
-
-          it 'lazy loads' do
-            expect(Horza.adapter.context_for_entity(:simple_record).to_s).to eq 'SimpleRecord'
-          end
-        end
-
-        context 'within namespace' do
-          before do
-            Lazy.send(:remove_const, :LazyRecord)
-            Object.send(:remove_const, :Lazy)
-          end
-
-          it 'lazy loads' do
-            expect(Horza.adapter.context_for_entity(:lazy_record).to_s).to eq 'Lazy::LazyRecord'
-          end
-        end
-      end
+    it 'Returns correct class' do
+      expect(Horza::DependencyLoading).to receive(:resolve_dependency).with("simple_record")
+      
+      Horza.adapter.context_for_entity(:simple_record)
     end
+  
   end
 
   describe '#adapt' do
-    subject { Horza.adapt(HorzaSpec::User) }
+    subject { Horza.adapt(User) }
     it 'returns the adaptor class' do
       expect(subject.is_a? Horza::Adapters::ActiveRecord).to be true
     end
     it 'sets the model as context' do
-      expect(subject.context).to eq HorzaSpec::User
+      expect(subject.context).to eq User
     end
   end
 
   describe 'Queries' do
-    let(:user) { HorzaSpec::User.create }
+    let(:user) { User.create }
     let(:single_entity_klass) { Horza::Entities::Single }
 
     describe '#get!' do
@@ -182,15 +121,15 @@ describe Horza do
     describe '#find_first!' do
       context 'when users exist' do
         before do
-          3.times { HorzaSpec::User.create(last_name: last_name) }
-          2.times { HorzaSpec::User.create(last_name: 'OTHER') }
+          3.times { User.create(last_name: last_name) }
+          2.times { User.create(last_name: 'OTHER') }
         end
         it 'returns single Entity' do
           expect(user_adapter.find_first(conditions: { last_name: last_name }).is_a? Horza::Entities::Single).to be true
         end
 
         it 'returns user' do
-          expect(user_adapter.find_first!(conditions: { last_name: last_name }).to_h).to eq HorzaSpec::User.where(last_name: last_name).order('id DESC').first.attributes
+          expect(user_adapter.find_first!(conditions: { last_name: last_name }).to_h).to eq User.where(last_name: last_name).order('id DESC').first.attributes
         end
       end
 
@@ -215,8 +154,8 @@ describe Horza do
 
       context 'when users exist' do
         before do
-          3.times { HorzaSpec::User.create(conditions) }
-          2.times { HorzaSpec::User.create(last_name: 'OTHER') }
+          3.times { User.create(conditions) }
+          2.times { User.create(last_name: 'OTHER') }
         end
         it 'returns user' do
           expect(user_adapter.find_all(options).length).to eq 3
@@ -232,7 +171,7 @@ describe Horza do
           let(:total) { 20 }
           let(:offset) { 7 }
           before do
-            total.times { HorzaSpec::User.create(last_name: 'Smith') }
+            total.times { User.create(last_name: 'Smith') }
           end
           it 'offsets response' do
             expect(user_adapter.find_all(conditions: { last_name: 'Smith' }, offset: offset).length).to eq total - offset
@@ -250,7 +189,7 @@ describe Horza do
     describe '#create' do
       context 'when parameters are valid' do
         it 'creates the record' do
-          expect { customer_adapter.create(last_name: last_name) }.to change(HorzaSpec::Customer, :count).by(1)
+          expect { customer_adapter.create(last_name: last_name) }.to change(Customer, :count).by(1)
         end
 
         it 'returns the entity' do
@@ -260,7 +199,7 @@ describe Horza do
 
       context 'when parameters are invalid' do
         it 'does not create the record' do
-          expect { customer_adapter.create }.to change(HorzaSpec::Customer, :count).by(0)
+          expect { customer_adapter.create }.to change(Customer, :count).by(0)
         end
 
         it 'returns nil' do
@@ -278,7 +217,7 @@ describe Horza do
     end
 
     describe '#create_as_child' do
-      let(:employer) { HorzaSpec::Employer.create }
+      let(:employer) { Employer.create }
       let(:parent) do
         {
           id: employer.id,
@@ -289,7 +228,7 @@ describe Horza do
 
       context 'when parameters are valid' do
         it 'creates the record' do
-          expect { action }.to change(HorzaSpec::User, :count).by(1)
+          expect { action }.to change(User, :count).by(1)
         end
 
         it 'returns the entity' do
@@ -307,7 +246,7 @@ describe Horza do
         end
 
         it 'does not create the record' do
-          expect { action }.to change(HorzaSpec::User, :count).by(0)
+          expect { action }.to change(User, :count).by(0)
         end
 
         it 'returns nil' do
@@ -317,7 +256,7 @@ describe Horza do
     end
 
     describe '#create_as_child!' do
-      let(:employer) { HorzaSpec::Employer.create }
+      let(:employer) { Employer.create }
       let(:action) { user_adapter.create_as_child!(parent, last_name: last_name) }
 
       context 'when parameters are invalid' do
@@ -335,7 +274,7 @@ describe Horza do
     end
 
     describe '#update' do
-      let(:customer) { HorzaSpec::Customer.create(last_name: last_name) }
+      let(:customer) { Customer.create(last_name: last_name) }
 
       context 'when parameters are valid' do
         let(:updated_last_name) { 'Smith' }
@@ -359,7 +298,7 @@ describe Horza do
     end
 
     describe '#update!' do
-      let(:customer) { HorzaSpec::Customer.create(last_name: last_name) }
+      let(:customer) { Customer.create(last_name: last_name) }
 
       context 'when parameters are invalid' do
         it 'throws error' do
@@ -375,13 +314,13 @@ describe Horza do
     end
 
     describe '#delete' do
-      let!(:customer) { HorzaSpec::Customer.create(last_name: last_name) }
+      let!(:customer) { Customer.create(last_name: last_name) }
 
       context 'when record exists' do
         let(:updated_last_name) { 'Smith' }
 
         it 'destroys the record' do
-          expect { customer_adapter.delete(customer.id) }.to change(HorzaSpec::Customer, :count).by(-1)
+          expect { customer_adapter.delete(customer.id) }.to change(Customer, :count).by(-1)
         end
 
         it 'returns true' do
@@ -397,7 +336,7 @@ describe Horza do
     end
 
     describe '#delete!' do
-      let(:customer) { HorzaSpec::Customer.create(last_name: last_name) }
+      let(:customer) { Customer.create(last_name: last_name) }
 
       context 'when record does not exist' do
         it 'returns nil' do
@@ -408,9 +347,9 @@ describe Horza do
 
     context '#association' do
       context 'direct relation' do
-        let(:employer) { HorzaSpec::Employer.create }
-        let!(:user1) { HorzaSpec::User.create(employer: employer) }
-        let!(:user2) { HorzaSpec::User.create(employer: employer) }
+        let(:employer) { Employer.create }
+        let!(:user1) { User.create(employer: employer) }
+        let!(:user2) { User.create(employer: employer) }
 
         context 'parent' do
           it 'returns parent' do
@@ -423,7 +362,7 @@ describe Horza do
             result = employer_adapter.association(id: employer.id, target: :users)
             expect(result.length).to eq 2
             expect(result.first.is_a? Horza::Entities::Single).to be true
-            expect(result.first.to_hash).to eq HorzaSpec::User.order('id DESC').first.attributes
+            expect(result.first.to_hash).to eq User.order('id DESC').first.attributes
           end
         end
 
@@ -434,14 +373,14 @@ describe Horza do
         end
 
         context 'valid ancestry with no saved childred' do
-          let(:employer2) { HorzaSpec::Employer.create }
-          it 'returns empty collection error' do
+          let(:employer2) { Employer.create }
+          it 'returns empty collection' do
             expect(employer_adapter.association(id: employer2.id, target: :users).empty?).to be true
           end
         end
 
         context 'valid ancestry with no saved parent' do
-          let(:user2) { HorzaSpec::User.create }
+          let(:user2) { User.create }
           it 'returns nil' do
             expect(user_adapter.association(id: user2.id, target: :employer)).to be nil
           end
@@ -453,8 +392,8 @@ describe Horza do
           let(:conditions) { { last_name: 'Turner' } }
 
           before do
-            turner_total.times { employer.users << HorzaSpec::User.create(conditions.merge(employer: employer)) }
-            other_total.times { employer.users << HorzaSpec::User.create(employer: employer) }
+            turner_total.times { employer.users << User.create(conditions.merge(employer: employer)) }
+            other_total.times { employer.users << User.create(employer: employer) }
           end
 
           context 'limit' do
@@ -478,7 +417,7 @@ describe Horza do
           context 'order' do
             it 'orders response' do
               horza_response =  employer_adapter.association(id: employer.id, target: :users, conditions: conditions, order: { id: :asc })
-              ar_response = HorzaSpec::User.where(conditions).order('id asc')
+              ar_response = User.where(conditions).order('id asc')
               expect(horza_response.first.id).to eq ar_response.first.id
               expect(horza_response.last.id).to eq ar_response.last.id
             end
@@ -488,7 +427,7 @@ describe Horza do
             context 'simple' do
               it 'works as expected' do
                 horza_response =  employer_adapter.association(id: employer.id, target: :users, conditions: conditions, order: { id: :asc }, eager_load: true)
-                ar_response = HorzaSpec::User.where(conditions).order('id asc')
+                ar_response = User.where(conditions).order('id asc')
                 expect(horza_response.first.id).to eq ar_response.first.id
                 expect(horza_response.last.id).to eq ar_response.last.id
               end
@@ -498,9 +437,9 @@ describe Horza do
       end
 
       context 'using via' do
-        let(:employer) { HorzaSpec::Employer.create }
-        let(:user) { HorzaSpec::User.create(employer: employer) }
-        let(:sportscar) { HorzaSpec::SportsCar.create(employer: employer) }
+        let(:employer) { Employer.create }
+        let(:user) { User.create(employer: employer) }
+        let(:sportscar) { SportsCar.create(employer: employer) }
 
         before do
           employer.sports_cars << sportscar
@@ -510,6 +449,13 @@ describe Horza do
           expect(user_adapter.association(id: user.id, target: :sports_cars, via: [:employer]).first).to eq sportscar.attributes
         end
 
+        context 'valid ancestry with no saved :via association' do
+          it 'returns empty collection' do
+            user.update_attribute(:employer_id, nil)
+            expect(user_adapter.association(id: user.id, target: :sports_cars, via: [:employer])).to be nil
+          end
+        end
+
         context 'with eager loading' do
           it 'works as expected' do
             horza_response =  user_adapter.association(id: user.id, target: :sports_cars, via: [:employer], order: { id: :asc }, eager_load: true)
@@ -561,8 +507,8 @@ describe Horza do
 
       context 'without conditions' do
         context 'when one join record exists' do
-          let!(:employer) { HorzaSpec::Employer.create(name: 'Corporation ltd.', boss_email: 'boss@boss.com') }
-          let!(:user) { HorzaSpec::User.create(employer: employer, first_name: 'John', last_name: 'Turner', email: 'email@email.com') }
+          let!(:employer) { Employer.create(name: 'Corporation ltd.', boss_email: 'boss@boss.com') }
+          let!(:user) { User.create(employer: employer, first_name: 'John', last_name: 'Turner', email: 'email@email.com') }
 
           context 'without fields' do
             it 'returns joined record' do
@@ -595,8 +541,8 @@ describe Horza do
           end
 
           context 'complex predicate' do
-            let!(:match_user) { HorzaSpec::User.create(employer: employer, first_name: 'John', last_name: 'Turner', email: 'boss@boss.com') }
-            let!(:match_user2) { HorzaSpec::User.create(employer: employer, first_name: 'Helen', last_name: 'Jones', email: 'boss@boss.com') }
+            let!(:match_user) { User.create(employer: employer, first_name: 'John', last_name: 'Turner', email: 'boss@boss.com') }
+            let!(:match_user2) { User.create(employer: employer, first_name: 'Helen', last_name: 'Jones', email: 'boss@boss.com') }
             it 'returns joined records and the specified fields' do
               result = user_adapter.join(complex_predicate)
               expect(result.length).to eq 2
@@ -610,8 +556,8 @@ describe Horza do
         end
 
         context 'when no join record exists' do
-          let!(:employer) { HorzaSpec::Employer.create(name: 'Corporation ltd.') }
-          let!(:user) { HorzaSpec::User.create(employer_id: 9999, first_name: 'John', last_name: 'Turner', email: 'email@email.com') }
+          let!(:employer) { Employer.create(name: 'Corporation ltd.') }
+          let!(:user) { User.create(employer_id: 9999, first_name: 'John', last_name: 'Turner', email: 'email@email.com') }
 
           it 'returns an empty collection' do
             result = user_adapter.join(simple)
@@ -620,10 +566,10 @@ describe Horza do
         end
 
         context 'when multiple join records exists' do
-          let!(:employer) { HorzaSpec::Employer.create(name: 'Corporation ltd.') }
-          let!(:user) { HorzaSpec::User.create(employer: employer, first_name: 'John', last_name: 'Turner', email: 'email@turner.com') }
-          let!(:user2) { HorzaSpec::User.create(employer: employer, first_name: 'Adam', last_name: 'Boots', email: 'email@boots.com') }
-          let!(:user3) { HorzaSpec::User.create(employer: employer, first_name: 'Tim', last_name: 'Socks', email: 'email@socks.com') }
+          let!(:employer) { Employer.create(name: 'Corporation ltd.') }
+          let!(:user) { User.create(employer: employer, first_name: 'John', last_name: 'Turner', email: 'email@turner.com') }
+          let!(:user2) { User.create(employer: employer, first_name: 'Adam', last_name: 'Boots', email: 'email@boots.com') }
+          let!(:user3) { User.create(employer: employer, first_name: 'Tim', last_name: 'Socks', email: 'email@socks.com') }
 
           it 'returns an empty collection' do
             result = user_adapter.join(simple)
@@ -633,11 +579,11 @@ describe Horza do
       end
 
       context 'with conditions' do
-        let!(:employer) { HorzaSpec::Employer.create(name: 'Corporation ltd.') }
-        let!(:employer2) { HorzaSpec::Employer.create(name: 'BigBucks ltd.') }
-        let!(:user) { HorzaSpec::User.create(employer: employer, first_name: 'John', last_name: 'Turner', email: 'email@turner.com') }
-        let!(:user2) { HorzaSpec::User.create(employer: employer, first_name: 'Adam', last_name: 'Boots', email: 'email@boots.com') }
-        let!(:user3) { HorzaSpec::User.create(employer: employer2, first_name: 'Tim', last_name: 'Socks', email: 'email@socks.com') }
+        let!(:employer) { Employer.create(name: 'Corporation ltd.') }
+        let!(:employer2) { Employer.create(name: 'BigBucks ltd.') }
+        let!(:user) { User.create(employer: employer, first_name: 'John', last_name: 'Turner', email: 'email@turner.com') }
+        let!(:user2) { User.create(employer: employer, first_name: 'Adam', last_name: 'Boots', email: 'email@boots.com') }
+        let!(:user3) { User.create(employer: employer2, first_name: 'Tim', last_name: 'Socks', email: 'email@socks.com') }
 
         it 'returns only the joins that match the conditions' do
           result = user_adapter.join(conditions)
@@ -647,11 +593,11 @@ describe Horza do
       end
 
       context 'limits/offset' do
-        let!(:employer) { HorzaSpec::Employer.create(name: 'Corporation ltd.') }
-        let!(:employer2) { HorzaSpec::Employer.create(name: 'BigBucks ltd.') }
-        let!(:user) { HorzaSpec::User.create(employer: employer, first_name: 'John', last_name: 'Turner', email: 'email@turner.com') }
-        let!(:user2) { HorzaSpec::User.create(employer: employer, first_name: 'Adam', last_name: 'Turner', email: 'email@boots.com') }
-        let!(:user3) { HorzaSpec::User.create(employer: employer2, first_name: 'Tim', last_name: 'Socks', email: 'email@socks.com') }
+        let!(:employer) { Employer.create(name: 'Corporation ltd.') }
+        let!(:employer2) { Employer.create(name: 'BigBucks ltd.') }
+        let!(:user) { User.create(employer: employer, first_name: 'John', last_name: 'Turner', email: 'email@turner.com') }
+        let!(:user2) { User.create(employer: employer, first_name: 'Adam', last_name: 'Turner', email: 'email@boots.com') }
+        let!(:user3) { User.create(employer: employer2, first_name: 'Tim', last_name: 'Socks', email: 'email@socks.com') }
 
         it 'limits the joins that match the conditions' do
           params = conditions.merge(limit: 1)
@@ -673,7 +619,7 @@ describe Horza do
   describe 'Entities' do
     describe 'Collection' do
       let(:members) do
-        3.times.map { HorzaSpec::User.create }
+        3.times.map { User.create }
       end
 
       let(:single_entity_klass) { Horza::Entities::SingleWithActiveModel }
@@ -721,7 +667,7 @@ describe Horza do
 
       context '#singular_entity_class' do
         context 'when singular entity class does not exist' do
-        let(:dummy_model) { HorzaSpec::DummyModel.create }
+        let(:dummy_model) { DummyModel.create }
 
           module TestNamespace
             class DummyModels < Horza::Entities::Collection
@@ -734,7 +680,7 @@ describe Horza do
         end
 
         context 'when singular entity class exists' do
-          let(:other_dummy_model) { HorzaSpec::OtherDummyModel.create }
+          let(:other_dummy_model) { OtherDummyModel.create }
 
           module TestNamespace
             class OtherDummyModels < Horza::Entities::Collection

data/spec/configuration_spec.rb

@@ -0,0 +1,26 @@
+require 'spec_helper'
+
+describe Horza::Configuration do
+  
+  describe "#adapter" do
+    it "not set" do
+      expect { subject.adapter }.to raise_error(Horza::Errors::AdapterError, /No adapter configured/)
+    end
+
+    context "setting adapter" do
+      it "finds adapter class if given" do
+        subject.adapter = :active_record
+
+        expect(subject.adapter).to eq Horza::Adapters::ActiveRecord
+      end
+
+      it "raises if adapter class doesn't exist" do
+        expect { subject.adapter = :missing }.to raise_error(Horza::Errors::AdapterError, /No adapter found/)
+      end
+
+      it "doesn't raise if no name is given" do
+        expect { subject.adapter = nil }.to_not raise_error(Horza::Errors::AdapterError)
+      end
+    end
+  end
+end

data/spec/dependency_loading_spec.rb

@@ -0,0 +1,94 @@
+require 'spec_helper'
+
+describe Horza::DependencyLoading do
+  
+  before(:each) do 
+    Horza.configuration.constant_paths += ["spec"] 
+    ActiveSupport::Dependencies.autoload_paths += ["spec"] 
+  end
+
+  after(:each) do 
+    Horza.clear_constant_paths
+    ActiveSupport::Dependencies.autoload_paths.clear
+  end
+
+  describe "::resolve_dependency" do
+    
+    it "resolves constant by file name" do
+      const = Horza::DependencyLoading.resolve_dependency("test_employer")
+      expect(const.name).to eq "TestConstants::TestEmployer"
+    end
+
+    it "resolves constant by constant name" do
+      const = Horza::DependencyLoading.resolve_dependency("TestEmployer")
+      expect(const.name).to eq "TestConstants::TestEmployer"
+    end
+
+    it "raises if #constant_paths is empty" do
+      Horza.clear_constant_paths
+
+      expect { Horza::DependencyLoading.resolve_dependency("test_employer") }.to raise_error(ArgumentError)
+    end
+
+    it "raises if #constant_paths has nested directory paths" do
+      Horza.configuration.constant_paths += ["spec/test_constants"]
+
+      expect { Horza::DependencyLoading.resolve_dependency("test_employer") }.to raise_error
+    end
+
+    it "returns constant if already loaded" do
+      Object.const_set(:A, Class.new)
+
+      constant = Horza::DependencyLoading.resolve_dependency("a")
+      expect(constant).to eq A
+  
+      Object.send(:remove_const, :A)
+    end
+
+    context "finds multiple matched constant_paths" do
+
+      it "resolves constant for first matched file_path" do
+        
+        with_clashing_file do
+          const = Horza::DependencyLoading.resolve_dependency("test_employer")
+          expect(const.name).to eq "TestEmployer"
+        end
+
+      end
+    end
+  end
+  
+  describe "::search_for_file" do
+    context "constant_paths are given" do
+      it "returns file path if matched" do
+        file_path = Horza::DependencyLoading.search_for_file("test_employer")
+        expect(file_path).to eq "spec/test_constants/test_employer.rb"
+      end
+
+      it "raises if file path is not matched" do
+        expect { Horza::DependencyLoading.search_for_file("employer") }.to raise_error(Horza::DependencyLoading::MissingFile)
+      end
+    end
+  end
+
+
+  describe "::constant_name_for_path" do
+    it "returns a loadable constant name for file path" do
+      name = Horza::DependencyLoading.constant_name_for_path("spec/test_constants/any_constant.rb")
+      
+      expect(name).to eq ["TestConstants::AnyConstant"]
+    end
+  end
+
+  def with_clashing_file
+    file_name = "spec/test_employer.rb"
+    
+    File.open(file_name, "w+") do |f| 
+      f.write("class TestEmployer;end")  
+    end
+
+    yield
+
+    FileUtils.rm(file_name)
+  end
+end

data/spec/horza_spec.rb

@@ -1,52 +1,5 @@
 require 'spec_helper'
 
-describe Horza do
-  context '#adapter' do
-    context 'when adapter is not configured' do
-      before { Horza.reset }
-      after { Horza.reset }
-      it 'throws error' do
-        expect { Horza.adapter }.to raise_error(Horza::Errors::AdapterNotConfigured)
-      end
-    end
-
-    context 'when adapter is configured' do
-      before do
-        Horza.reset
-        Horza.configure { |config| config.adapter = :active_record }
-      end
-      after { Horza.reset }
-      it 'returns appropriate class' do
-        expect(Horza.adapter).to eq Horza::Adapters::ActiveRecord
-      end
-    end
-  end
-
-  context '#configuration #namespaces' do
-    context 'when namespaces are not configured' do
-      before { Horza.reset }
-      after { Horza.reset }
-      it 'returns empty array' do
-        expect(Horza.configuration.namespaces.is_a? Array).to be true
-        expect(Horza.configuration.namespaces.empty?).to be true
-      end
-    end
-
-    context 'when namespaces are configured' do
-      module HorzaNamespace
-      end
-
-      before do
-        Horza.reset
-        Horza.configure { |config| config.namespaces = [HorzaNamespace] }
-      end
-      after { Horza.reset }
-      it 'returns configured namespaces class' do
-        expect(Horza.configuration.namespaces).to eq [HorzaNamespace]
-      end
-    end
-  end
-end
 
 describe Horza::Entities::Single do
   subject { Horza::Entities::Single.new(first_name: 'Blake') }

data/spec/shared_config_spec.rb

@@ -0,0 +1,16 @@
+require 'spec_helper'
+
+describe Horza::SharedConfig do
+  subject(:target_class) { Class.new.send(:extend, Horza::SharedConfig) }
+
+  it "expose same Horza config instance to target class" do
+    expect(subject.configuration).to be Horza.configuration
+  end
+
+  it "delegates config methods to Horza" do
+    [:reset, :constant_paths,:clear_constant_paths, :adapter, :adapter=].each do |_meth_|
+      expect(Horza).to receive(_meth_)
+      target_class.send _meth_
+    end
+  end
+end

data/spec/test_constants/test_employer.rb

@@ -0,0 +1,4 @@
+module TestConstants
+  class TestEmployer
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: horza
 version: !ruby/object:Gem::Version
-  version: 0.5.2
+  version: 1.0.0
 platform: ruby
 authors:
 - Blake Turner
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-17 00:00:00.000000000 Z
+date: 2015-11-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: hashie
@@ -28,70 +28,70 @@ dependencies:
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 2.3.11
+        version: '3.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 2.3.11
+        version: '3.2'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 2.4.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 2.4.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '4.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '4.0'
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 3.2.15
+        version: '3.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 3.2.15
+        version: '3.2'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: Horza is a shapeshifter that provides common inputs and outputs for your
@@ -101,9 +101,6 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- LICENSE.txt
-- README.md
-- lib/horza.rb
 - lib/horza/adapters/abstract_adapter.rb
 - lib/horza/adapters/active_record/active_record.rb
 - lib/horza/adapters/active_record/arel_join.rb
@@ -112,14 +109,24 @@ files:
 - lib/horza/adapters/options.rb
 - lib/horza/configuration.rb
 - lib/horza/core_extensions/string.rb
-- lib/horza/entities.rb
+- lib/horza/dependency_loading.rb
 - lib/horza/entities/collection.rb
 - lib/horza/entities/single.rb
 - lib/horza/entities/single_with_active_model.rb
+- lib/horza/entities.rb
 - lib/horza/errors.rb
+- lib/horza/shared_config.rb
+- lib/horza/version.rb
+- lib/horza.rb
+- LICENSE.txt
+- README.md
 - spec/active_record_spec.rb
+- spec/configuration_spec.rb
+- spec/dependency_loading_spec.rb
 - spec/horza_spec.rb
+- spec/shared_config_spec.rb
 - spec/spec_helper.rb
+- spec/test_constants/test_employer.rb
 homepage: https://github.com/onfido/horza
 licenses:
 - MIT
@@ -130,22 +137,25 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.0.14
 signing_key: 
 specification_version: 4
 summary: Keep your app ORM-agnostic
 test_files:
 - spec/active_record_spec.rb
+- spec/configuration_spec.rb
+- spec/dependency_loading_spec.rb
 - spec/horza_spec.rb
+- spec/shared_config_spec.rb
 - spec/spec_helper.rb
-has_rdoc: 
+- spec/test_constants/test_employer.rb