hoptoad_notifier 2.4.5 → 2.4.6

data/CHANGELOG

@@ -1,3 +1,9 @@
+Version 2.4.6 - Tue Feb 15 15:51:17 -0500 2011
+===============================================================================
+
+Jonathan Yurek(1):
+      Modify the error page's body in-place.
+
 Version 2.4.5 - Wed Feb 02 13:24:29 -0500 2011
 ===============================================================================
 
@@ -402,5 +408,6 @@ Nick Quaranto (3):
 
 
 
+
 
 

data/lib/hoptoad_notifier/user_informer.rb

@@ -9,20 +9,14 @@ module HoptoadNotifier
     end
 
     def call(env)
-      response = @app.call(env)
+      status, headers, body = @app.call(env)
       if env['hoptoad.error_id']
-        new_response = []
-        original_content_length = 0
-        modified_content_length = 0
-        response[2].each do |chunk|
-          original_content_length += chunk.length
-          new_response << chunk.to_s.gsub("<!-- HOPTOAD ERROR -->", replacement(env['hoptoad.error_id']))
-          modified_content_length += new_response.last.length
+        body.each_with_index do |chunk, i|
+          body[i] = chunk.to_s.gsub("<!-- HOPTOAD ERROR -->", replacement(env['hoptoad.error_id']))
         end
-        response[1]['Content-Length'] = modified_content_length.to_s
-        response[2] = new_response
+        headers['Content-Length'] = body.sum(&:length).to_s
       end
-      response
+      [status, headers, body]
     end
   end
 end

data/lib/hoptoad_notifier/version.rb

@@ -1,3 +1,3 @@
 module HoptoadNotifier
-  VERSION = "2.4.5".freeze
+  VERSION = "2.4.6".freeze
 end

data/test/user_informer_test.rb

@@ -4,7 +4,7 @@ class UserInformerTest < Test::Unit::TestCase
   should "modify output if there is a hoptoad id" do
     main_app = lambda do |env|
       env['hoptoad.error_id'] = 1
-      [200, {}, "<!-- HOPTOAD ERROR -->"]
+      [200, {}, ["<!-- HOPTOAD ERROR -->"]]
     end
     informer_app = HoptoadNotifier::UserInformer.new(main_app)
 
@@ -17,7 +17,7 @@ class UserInformerTest < Test::Unit::TestCase
 
   should "not modify output if there is no hoptoad id" do
     main_app = lambda do |env|
-      [200, {}, "<!-- HOPTOAD ERROR -->"]
+      [200, {}, ["<!-- HOPTOAD ERROR -->"]]
     end
     informer_app = HoptoadNotifier::UserInformer.new(main_app)
 

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: hoptoad_notifier
 version: !ruby/object:Gem::Version 
-  hash: 21
+  hash: 19
   prerelease: false
   segments: 
   - 2
   - 4
-  - 5
-  version: 2.4.5
+  - 6
+  version: 2.4.6
 platform: ruby
 authors: 
 - thoughtbot, inc
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-02-02 00:00:00 -05:00
+date: 2011-02-15 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency