hoptoad_notifier 2.4.9 → 2.4.10

data/Rakefile

@@ -158,6 +158,7 @@ RAILS_VERSIONS = IO.read('SUPPORTED_RAILS_VERSIONS').strip.split("\n")
 LOCAL_GEMS = [['sham_rack', nil], ['capistrano', nil], ['sqlite3-ruby', nil], ['sinatra', nil]] +
   RAILS_VERSIONS.collect { |version| ['rails', version] }
 
+desc "Vendor test gems: Run this once to prepare your test environment"
 task :vendor_test_gems do
   old_gem_path = ENV['GEM_PATH']
   old_gem_home = ENV['GEM_HOME']

data/SUPPORTED_RAILS_VERSIONS

@@ -8,3 +8,5 @@
 3.0.1
 3.0.2
 3.0.3
+3.0.4
+3.0.5

data/lib/hoptoad_notifier/backtrace.rb

@@ -5,7 +5,8 @@ module HoptoadNotifier
     # Handles backtrace parsing line by line
     class Line
 
-      INPUT_FORMAT = %r{^([^:]+):(\d+)(?::in `([^']+)')?$}.freeze
+      # regexp (optionnally allowing leading X: for windows support)
+      INPUT_FORMAT = %r{^((?:[a-zA-Z]:)?[^:]+):(\d+)(?::in `([^']+)')?$}.freeze
 
       # The file portion of the line (such as app/models/user.rb)
       attr_reader :file

data/lib/hoptoad_notifier/capistrano.rb

@@ -9,8 +9,9 @@ Capistrano::Configuration.instance(:must_exist).load do
     task :notify_hoptoad, :except => { :no_release => true } do
       rails_env = fetch(:hoptoad_env, fetch(:rails_env, "production"))
       local_user = ENV['USER'] || ENV['USERNAME']
-      executable = RUBY_PLATFORM.downcase.include?('mswin') ? 'rake.bat' : 'rake'
+      executable = RUBY_PLATFORM.downcase.include?('mswin') ? fetch(:rake, 'rake.bat') : fetch(:rake, 'rake')
       notify_command = "#{executable} hoptoad:deploy TO=#{rails_env} REVISION=#{current_revision} REPO=#{repository} USER=#{local_user}"
+      notify_command << " DRY_RUN=true" if dry_run
       notify_command << " API_KEY=#{ENV['API_KEY']}" if ENV['API_KEY']
       puts "Notifying Hoptoad of Deploy (#{notify_command})"
       `#{notify_command}`

data/lib/hoptoad_notifier/shared_tasks.rb

@@ -6,7 +6,8 @@ namespace :hoptoad do
                         :scm_revision   => ENV['REVISION'],
                         :scm_repository => ENV['REPO'],
                         :local_username => ENV['USER'],
-                        :api_key        => ENV['API_KEY'])
+                        :api_key        => ENV['API_KEY'],
+                        :dry_run        => ENV['DRY_RUN'])
   end
 
   task :log_stdout do

data/lib/hoptoad_notifier/tasks.rb

@@ -8,7 +8,7 @@ namespace :hoptoad do
 
     require 'action_controller/test_process'
 
-    Dir["app/controllers/application*.rb"].each { |file| require(file) }
+    Dir["app/controllers/application*.rb"].each { |file| require(File.expand_path(file)) } 
 
     class HoptoadTestingException < RuntimeError; end
 
@@ -63,9 +63,9 @@ namespace :hoptoad do
 
       def exception_class
         exception_name = ENV['EXCEPTION'] || "HoptoadTestingException"
-        Object.const_get(exception_name)
+        exception_name.split("::").inject(Object){|klass, name| klass.const_get(name)}
       rescue
-        Object.const_set(exception_name, Class.new(Exception))
+        Object.const_set(exception_name.gsub(/:+/, "_"), Class.new(Exception))
       end
 
       def logger

data/lib/hoptoad_tasks.rb

@@ -24,6 +24,7 @@ module HoptoadTasks
       return false
     end
 
+    dry_run = opts.delete(:dry_run)
     params = {'api_key' => opts.delete(:api_key) ||
                              HoptoadNotifier.configuration.api_key}
     opts.each {|k,v| params["deploy[#{k}]"] = v }
@@ -35,10 +36,15 @@ module HoptoadTasks
                             HoptoadNotifier.configuration.proxy_user,
                             HoptoadNotifier.configuration.proxy_pass)
 
-    response = proxy.post_form(url, params)
+    if dry_run
+      puts url, params.inspect
+      return true
+    else
+      response = proxy.post_form(url, params)
 
-    puts response.body
-    return Net::HTTPSuccess === response
+      puts response.body
+      return Net::HTTPSuccess === response
+    end
   end
 end
 

data/test/backtrace_test.rb

@@ -20,6 +20,25 @@ class BacktraceTest < Test::Unit::TestCase
     assert_equal 'app/controllers/users_controller.rb', line.file
     assert_equal 'index', line.method
   end
+  
+  should "parse a windows backtrace into lines" do
+    array = [
+      "C:/Program Files/Server/app/models/user.rb:13:in `magic'",
+      "C:/Program Files/Server/app/controllers/users_controller.rb:8:in `index'"
+    ]
+
+    backtrace = HoptoadNotifier::Backtrace.parse(array)
+
+    line = backtrace.lines.first
+    assert_equal '13', line.number
+    assert_equal 'C:/Program Files/Server/app/models/user.rb', line.file
+    assert_equal 'magic', line.method
+
+    line = backtrace.lines.last
+    assert_equal '8', line.number
+    assert_equal 'C:/Program Files/Server/app/controllers/users_controller.rb', line.file
+    assert_equal 'index', line.method
+  end
 
   should "be equal with equal lines" do
     one = build_backtrace_array

data/test/helper.rb

@@ -12,6 +12,7 @@ gem "sham_rack",     "~> 1.3.0"
 $LOAD_PATH << File.join(File.dirname(__FILE__), *%w[.. vendor ginger lib])
 $LOAD_PATH << File.expand_path(File.join(File.dirname(__FILE__), "..", "lib"))
 
+require 'thread'
 require 'shoulda'
 require 'mocha'
 

data/test/hoptoad_tasks_test.rb

@@ -49,7 +49,18 @@ class HoptoadTasksTest < Test::Unit::TestCase
                  HoptoadNotifier.configuration.proxy_pass).
             returns(@http_proxy)
 
-          @options    = { :rails_env => "staging" }
+          @options    = { :rails_env => "staging", :dry_run => false }
+        end
+        
+        context "performing a dry run" do
+          setup { @output = HoptoadTasks.deploy(@options.merge(:dry_run => true)) }
+
+          should "return true without performing any actual request" do
+            assert_equal true, @output
+            assert_received(@http_proxy, :post_form) do|expects|
+              expects.never
+            end
+          end
         end
 
         context "on deploy(options)" do

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: hoptoad_notifier
 version: !ruby/object:Gem::Version 
-  hash: 13
-  prerelease: false
+  hash: 11
+  prerelease: 
   segments: 
   - 2
   - 4
-  - 9
-  version: 2.4.9
+  - 10
+  version: 2.4.10
 platform: ruby
 authors: 
 - thoughtbot, inc
@@ -15,8 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-03-30 00:00:00 -04:00
-default_executable: 
+date: 2011-05-03 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: builder
@@ -177,7 +176,6 @@ files:
 - script/integration_test.rb
 - lib/templates/javascript_notifier.erb
 - lib/templates/rescue.erb
-has_rdoc: true
 homepage: http://www.hoptoadapp.com
 licenses: []
 
@@ -207,7 +205,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.7
+rubygems_version: 1.7.2
 signing_key: 
 specification_version: 3
 summary: Send your application errors to our hosted service and reclaim your inbox.