hoptoad_notifier 2.3.7 → 2.3.8

data/lib/hoptoad_notifier/rails/javascript_notifier.rb

@@ -22,7 +22,6 @@ module HoptoadNotifier
           :use_full_path => false,
           :locals        => {
             :host        => host,
-            :secure      => HoptoadNotifier.configuration.secure,
             :api_key     => HoptoadNotifier.configuration.api_key,
             :environment => HoptoadNotifier.configuration.environment_name
           }

data/lib/hoptoad_notifier/sender.rb

@@ -3,6 +3,14 @@ module HoptoadNotifier
   class Sender
 
     NOTICES_URI = '/notifier_api/v2/notices/'.freeze
+    HTTP_ERRORS = [Timeout::Error,
+                   Errno::EINVAL,
+                   Errno::ECONNRESET,
+                   EOFError,
+                   Net::HTTPBadResponse,
+                   Net::HTTPHeaderSyntaxError,
+                   Net::ProtocolError,
+                   Errno::ECONNREFUSED].freeze
 
     def initialize(options = {})
       [:proxy_host, :proxy_port, :proxy_user, :proxy_pass, :protocol,
@@ -27,7 +35,7 @@ module HoptoadNotifier
 
       response = begin
                    http.post(url.path, data, HEADERS)
-                 rescue TimeoutError => e
+                 rescue *HTTP_ERRORS => e
                    log :error, "Timeout while contacting the Hoptoad server."
                    nil
                  end

data/lib/hoptoad_notifier/tasks.rb

@@ -89,7 +89,7 @@ namespace :hoptoad do
     class HoptoadVerificationController < ApplicationController; end
 
     puts 'Processing request.'
-    request = ActionController::TestRequest.new
+    request = ActionController::TestRequest.new("REQUEST_URI" => "/hoptoad_verification_controller")
     response = ActionController::TestResponse.new
     HoptoadVerificationController.new.process(request, response)
   end

data/lib/hoptoad_notifier/version.rb

@@ -1,3 +1,3 @@
 module HoptoadNotifier
-  VERSION = "2.3.7".freeze
+  VERSION = "2.3.8".freeze
 end

data/lib/templates/javascript_notifier.erb

@@ -1,4 +1,10 @@
-<script type="text/javascript" src="http<%= 's' if secure %>://<%= host %>/javascripts/notifier.js"></script>
+<script type="text/javascript"> 
+//<![CDATA[
+var notifierJsScheme = (("https:" == document.location.protocol) ? "https://" : "http://");
+document.write(unescape("%3Cscript src='" + notifierJsScheme + "<%= host %>/javascripts/notifier.js' type='text/javascript'%3E%3C/script%3E"));
+//]]>
+</script> 
+
 <script type="text/javascript">
   Hoptoad.setKey('<%= api_key %>');
   Hoptoad.setHost('<%= host %>');

data/test/helper.rb

@@ -1,6 +1,11 @@
 require 'test/unit'
 require 'rubygems'
 
+gem "activesupport", "= 2.3.8"
+gem "activerecord",  "= 2.3.8"
+gem "actionpack",    "= 2.3.8"
+gem "nokogiri",      "= 1.4.3.1"
+gem "shoulda",       "= 2.11.3"
 gem 'jferris-mocha', '>= 0.9.5.0.1241126838'
 
 $LOAD_PATH << File.join(File.dirname(__FILE__), *%w[.. vendor ginger lib])
@@ -11,6 +16,7 @@ require 'mocha'
 
 require 'ginger'
 
+
 require 'action_controller'
 require 'action_controller/test_process'
 require 'active_record'

data/test/sender_test.rb

@@ -58,6 +58,32 @@ class SenderTest < Test::Unit::TestCase
     end
   end
 
+  should "not fail when posting and a timeout exception occurs" do
+    http = stub_http
+    http.stubs(:post).raises(TimeoutError)
+    assert_nothing_thrown do
+      send_exception(:secure => false)
+    end
+  end
+
+  should "not fail when posting and a connection refused exception occurs" do
+    http = stub_http
+    http.stubs(:post).raises(Errno::ECONNREFUSED)
+    assert_nothing_thrown do
+      send_exception(:secure => false)
+    end
+  end
+
+  should "not fail when posting any http exception occurs" do
+    http = stub_http
+    HoptoadNotifier::Sender::HTTP_ERRORS.each do |error|
+      http.stubs(:post).raises(error)
+      assert_nothing_thrown do
+        send_exception(:secure => false)
+      end
+    end
+  end
+
   should "post to the right url for non-ssl" do
     http = stub_http
     url = "http://hoptoadapp.com:80#{HoptoadNotifier::Sender::NOTICES_URI}"

metadata

@@ -1,12 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: hoptoad_notifier
 version: !ruby/object:Gem::Version 
+  hash: 19
   prerelease: false
   segments: 
   - 2
   - 3
-  - 7
-  version: 2.3.7
+  - 8
+  version: 2.3.8
 platform: ruby
 authors: 
 - thoughtbot, inc
@@ -14,16 +15,18 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-09-15 00:00:00 -04:00
+date: 2010-09-29 00:00:00 -04:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: activesupport
   prerelease: false
   requirement: &id001 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
         segments: 
         - 0
         version: "0"
@@ -33,9 +36,11 @@ dependencies:
   name: activerecord
   prerelease: false
   requirement: &id002 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
         segments: 
         - 0
         version: "0"
@@ -45,9 +50,11 @@ dependencies:
   name: actionpack
   prerelease: false
   requirement: &id003 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
         segments: 
         - 0
         version: "0"
@@ -57,9 +64,11 @@ dependencies:
   name: jferris-mocha
   prerelease: false
   requirement: &id004 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
         segments: 
         - 0
         version: "0"
@@ -69,9 +78,11 @@ dependencies:
   name: nokogiri
   prerelease: false
   requirement: &id005 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
         segments: 
         - 0
         version: "0"
@@ -81,9 +92,11 @@ dependencies:
   name: shoulda
   prerelease: false
   requirement: &id006 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
         segments: 
         - 0
         version: "0"
@@ -156,23 +169,27 @@ rdoc_options:
 require_paths: 
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement 
+  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 3
       segments: 
       - 0
       version: "0"
 required_rubygems_version: !ruby/object:Gem::Requirement 
+  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 3
       segments: 
       - 0
       version: "0"
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.6
+rubygems_version: 1.3.7
 signing_key: 
 specification_version: 3
 summary: Send your application errors to our hosted service and reclaim your inbox.