hooks 0.1.3 → 0.1.4

data/CHANGES.textile

@@ -0,0 +1,4 @@
+h2. 0.1.4
+
+h3. Bugfixes
+  * An uninitialized @inheritable_attr@ doesn't crash since it is not cloned anymore. Note that an uncloneable attribute value still causes an exception.

data/Gemfile

@@ -1,8 +1 @@
-# A sample Gemfile
-source :gemcutter
-
-gem "activesupport", "~>2.3"
-
-group :test do
-  gem "shoulda"
-end
+gemspec

data/Rakefile

@@ -1,6 +1,5 @@
 require 'rake'
 require 'rake/testtask'
-require 'rake/rdoctask'
 
 desc 'Default: run unit tests.'
 task :default => :test
@@ -11,21 +10,3 @@ Rake::TestTask.new(:test) do |test|
   test.test_files = FileList['test/*_test.rb']
   test.verbose = true
 end
-
-require 'jeweler'
-$:.unshift File.dirname(__FILE__)+"/lib" # add current dir to LOAD_PATHS
-require 'hooks'
-
-Jeweler::Tasks.new do |spec|
-  spec.name         = "hooks"
-  spec.version      = ::Hooks::VERSION
-  spec.summary      = %{Generic hooks with callbacks for Ruby. }
-  spec.description  = "Declaratively define hooks, add callbacks and run them with the options you like."
-  spec.homepage     = "http://nicksda.apotomo.de/category/hooks"
-  spec.authors      = ["Nick Sutterer"]
-  spec.email        = "apotonick@gmail.com"
-
-  spec.files = FileList["[A-Z]*", File.join(*%w[{lib} ** *]).to_s]
-end
-
-Jeweler::GemcutterTasks.new

data/hooks.gemspec

@@ -0,0 +1,21 @@
+lib = File.expand_path('../lib/', __FILE__)
+$:.unshift lib unless $:.include?(lib)
+
+require 'hooks'
+
+Gem::Specification.new do |s|
+  s.name        = "hooks"
+  s.version     = Hooks::VERSION
+  s.platform    = Gem::Platform::RUBY
+  s.authors     = ["Nick Sutterer"]
+  s.email       = ["apotonick@gmail.com"]
+  s.homepage    = "http://nicksda.apotomo.de/tag/hooks"
+  s.summary     = %q{Generic hooks with callbacks for Ruby.}
+  s.description = %q{Declaratively define hooks, add callbacks and run them with the options you like.}
+  
+  s.files         = `git ls-files`.split("\n")
+  s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
+  s.require_paths = ["lib"]
+  
+  s.add_development_dependency "shoulda"
+end

data/lib/hooks.rb

@@ -16,7 +16,7 @@ require "hooks/inheritable_attribute"
 #
 #   cat.run_hook :after_dinner
 module Hooks
-  VERSION = "0.1.3"
+  VERSION = "0.1.4"
   
   def self.included(base)
     base.extend InheritableAttribute
@@ -75,8 +75,7 @@ module Hooks
     def define_hook_writer(hook, accessor_name)
       instance_eval <<-RUBY_EVAL, __FILE__, __LINE__ + 1
         def #{hook}(method=nil, &block)
-          callback = block_given? ? block : method
-          #{accessor_name} << callback
+          #{accessor_name} << (block || method)
         end
       RUBY_EVAL
     end

data/lib/hooks/inheritable_attribute.rb

@@ -24,8 +24,8 @@ module Hooks
         end
         
         def #{name}
-          return @#{name} unless superclass.respond_to?(:#{name})
-          @#{name} ||= superclass.#{name}.clone # only do this once.
+          return @#{name} unless superclass.respond_to?(:#{name}) and value = superclass.#{name}
+          @#{name} ||= value.clone # only do this once.
         end
       }
     end

data/test/hooks_test.rb

@@ -1,6 +1,6 @@
 require 'test_helper'
 
-class HooksTest < ActiveSupport::TestCase
+class HooksTest < Test::Unit::TestCase
   context "Hooks.define_hook" do
     setup do
       @klass = Class.new(Object) do

data/test/inheritable_attribute_test.rb

@@ -1,6 +1,6 @@
 require 'test_helper'
 
-class HooksTest < ActiveSupport::TestCase
+class HooksTest < Test::Unit::TestCase
   context "Hooks.define_hook" do
     setup do
       @klass = Class.new(Object) do
@@ -11,10 +11,16 @@ class HooksTest < ActiveSupport::TestCase
       @klass.inheritable_attr :drinks
     end
     
-    should "provide a reader with inherited attributes, already" do
+    should "provide a reader with empty inherited attributes, already" do
       assert_equal nil, @klass.drinks
     end
     
+    should "provide a reader with empty inherited attributes in a derived class" do
+      assert_equal nil, Class.new(@klass).drinks
+      #@klass.drinks = true
+      #Class.new(@klass).drinks # TODO: crashes.
+    end
+    
     should "provide an attribute copy in subclasses" do
       @klass.drinks = []
       assert @klass.drinks.object_id != Class.new(@klass).drinks.object_id

data/test/test_helper.rb

@@ -5,7 +5,6 @@ require 'bundler'
 Bundler.setup
 require 'test/unit'
 require 'shoulda'
-require 'active_support/test_case'
 require 'hooks'
 
 $:.unshift File.dirname(__FILE__) # add current dir to LOAD_PATHS

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 1
-  - 3
-  version: 0.1.3
+  - 4
+  version: 0.1.4
 platform: ruby
 authors: 
 - Nick Sutterer
@@ -14,35 +14,49 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-10-21 00:00:00 +02:00
+date: 2011-05-16 00:00:00 +02:00
 default_executable: 
-dependencies: []
-
+dependencies: 
+- !ruby/object:Gem::Dependency 
+  name: shoulda
+  prerelease: false
+  requirement: &id001 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        segments: 
+        - 0
+        version: "0"
+  type: :development
+  version_requirements: *id001
 description: Declaratively define hooks, add callbacks and run them with the options you like.
-email: apotonick@gmail.com
+email: 
+- apotonick@gmail.com
 executables: []
 
 extensions: []
 
-extra_rdoc_files: 
-- README.rdoc
+extra_rdoc_files: []
+
 files: 
+- CHANGES.textile
 - Gemfile
-- Gemfile.lock
 - README.rdoc
 - Rakefile
+- hooks.gemspec
 - lib/hooks.rb
 - lib/hooks/inheritable_attribute.rb
 - test/hooks_test.rb
-- test/test_helper.rb
 - test/inheritable_attribute_test.rb
+- test/test_helper.rb
 has_rdoc: true
-homepage: http://nicksda.apotomo.de/category/hooks
+homepage: http://nicksda.apotomo.de/tag/hooks
 licenses: []
 
 post_install_message: 
-rdoc_options: 
-- --charset=UTF-8
+rdoc_options: []
+
 require_paths: 
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement 
@@ -68,7 +82,5 @@ rubygems_version: 1.3.7
 signing_key: 
 specification_version: 3
 summary: Generic hooks with callbacks for Ruby.
-test_files: 
-- test/hooks_test.rb
-- test/test_helper.rb
-- test/inheritable_attribute_test.rb
+test_files: []
+

data/Gemfile.lock

@@ -1,12 +0,0 @@
-GEM
-  remote: http://rubygems.org/
-  specs:
-    activesupport (2.3.9)
-    shoulda (2.11.3)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  activesupport (~> 2.3)
-  shoulda