hoodoo 2.2.2 → 2.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d3cfd418d564c82821044bc2a95cb8d1e194a134027bc9fac61a56f823157b61
-  data.tar.gz: abd1ca2e208d34fbd00146989234daac40611f24e32869fd56debb0b1d0e62a6
+  metadata.gz: b44ab5eb415262a966b85b5745d7babae95bcea72ad1f82dc17d9ba1b0e8aee6
+  data.tar.gz: 7894b8277a7061f9ec1e83ab15fb6f25d92797cf3ad59e2a2d03968ac098b636
 SHA512:
-  metadata.gz: c887163252c009e44267179282e725bcfc4a49ce20e48270ab688f446dd5a03bf29bdaeab692ae4411b0f38dca2a202edd3b7025336963e29f68cd612f12ce3f
-  data.tar.gz: fa52f3e1fdb454022cd24fbdf56cdf25b3355ee0fe3cced729ae2cb73437b14c3d137f1e2958fb7d2d636222b0cf301fa4d356a7226125b31a75a0b797ffafd9
+  metadata.gz: c691cdaf17d8964a04edc102358485047a6b361147f5a14cc8d555772b4709f9dc903ae2d319c5392506330c0686c5cd09ed026bfc0470f923d39bc3d74a1e04
+  data.tar.gz: d2325636825a764be468a6411efec5a9e6bfec2e6d6f5d06f2b404d16a0411b95a23e9499e578600649baadfe65f3069cbdce146367c1acfbbceadef255c2195

data/lib/hoodoo/version.rb

@@ -12,11 +12,11 @@ module Hoodoo
   # The Hoodoo gem version. If this changes, be sure to re-run
   # <tt>bundle install</tt> or <tt>bundle update</tt>.
   #
-  VERSION = '2.2.2'
+  VERSION = '2.2.3'
 
   # The Hoodoo gem date. If this changes, be sure to re-run
   # <tt>bundle install</tt> or <tt>bundle update</tt>.
   #
-  DATE = '2017-11-16'
+  DATE = '2018-02-19'
 
 end

data/spec/logger/writers/file_writer_spec.rb

@@ -4,8 +4,7 @@ require 'tempfile'
 describe Hoodoo::Logger::FileWriter do
 
   before :all do
-    temp_name = Dir::Tmpname.make_tmpname( 'hoodoo_rspec_', nil )
-    @temp_path = File.join( Dir::Tmpname.tmpdir, temp_name )
+    @temp_path = spec_helper_tmpfile_path()
   end
 
   after :all do

data/spec/logger/writers/stream_writer_spec.rb

@@ -3,8 +3,7 @@ require 'time'
 
 describe Hoodoo::Logger::StreamWriter do
   before :all do
-    temp_name = Dir::Tmpname.make_tmpname( 'hoodoo_rspec_', nil )
-    @temp_path = File.join( Dir::Tmpname.tmpdir, temp_name )
+    @temp_path = spec_helper_tmpfile_path()
     @stream = File.open( @temp_path, 'ab' )
   end
 

data/spec/spec_helper.rb

@@ -19,16 +19,14 @@ end
 
 require 'byebug'
 
-# Stubbing Net::HTTP with WebMock - disabled by default; only enable for
-# tests where you need it, as real Net::HTTP connections are used in many
-# other tests and must not be mocked.
+# Stubbing Net::HTTP with WebMock - disabled by default via "before :suite"
+# later; only enable for tests where needed, as real Net::HTTP connections
+# are used in many other tests and must not be mocked.
 #
 # https://github.com/bblimke/webmock
 
 require 'webmock/rspec'
 
-WebMock.disable!
-
 # The ActiveRecord extensions need testing in the context of a database. I
 # did consider NullDB - https://github.com/nulldb/nulldb - but this was too
 # far from 'the real thing' for my liking. Instead, we use SQLite in memory
@@ -90,6 +88,8 @@ RSpec.configure do | config |
 
   config.before( :suite ) do
 
+    WebMock.disable!
+
     # Redirect $stderr before each test so a test log gets written without
     # disturbing the RSpec terminal output; make sure the session system is
     # in "test mode"; make sure we get a unique DRb daemon instance for the
@@ -379,3 +379,23 @@ def spec_helper_count_database_calls_in( &block )
   ActiveSupport::Notifications.subscribed( cb, 'sql.active_record', &block )
   return count
 end
+
+# In Ruby 2.5.0 the Ruby team removed <tt>Dir::Tmpname.make_tmpname</tt>:
+#
+# https://github.com/ruby/ruby/commit/25d56ea7b7b52dc81af30c92a9a0e2d2dab6ff27
+#
+# Instead we must make our best attempt in plain Ruby ourselves, e.g.:
+#
+# https://github.com/rails/rails/issues/31458
+# https://github.com/rails/rails/pull/31462/files
+#
+# Since the above solution uses the process number via "$$" it should be safe
+# for just this test suite, so we use the same approach here. This method
+# returns the full file path for the temporary file, not just a leafname.
+#
+def spec_helper_tmpfile_path
+  time = Time.now.strftime( "%Y%m%d" )
+  name = "hoodoo-tests-#{ time }-#{ $$ }-#{ rand( 0x100000000 ).to_s( 36 ) }-fd"
+
+  File.join( Dir::Tmpname.tmpdir, name )
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hoodoo
 version: !ruby/object:Gem::Version
-  version: 2.2.2
+  version: 2.2.3
 platform: ruby
 authors:
 - Loyalty New Zealand
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-16 00:00:00.000000000 Z
+date: 2018-02-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dalli
@@ -128,14 +128,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '3.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '3.3'
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
@@ -554,7 +554,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.2
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Opinionated APIs