hoodoo 2.2.0 → 2.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 27f8a7c4aed490d7d8e01fb68469c393b094e1d83ab1100a700e330c2288e88d
-  data.tar.gz: ebf5032d0056a507db7bbaf63b51269469350e5e2189b5016d06a1012c88dd7d
+  metadata.gz: 74ed5c7f8e4d541e0fa485aa51d93c35e10e010749e372b1d007ade4550f3ce9
+  data.tar.gz: 236eca0e1da38dce2e63b529f38d7e3d52d75f4685fbaf81341368721f7d4ac7
 SHA512:
-  metadata.gz: 39ffe6dc1b31ff93b3cf5fb6424a253d107d7a9c4c1aeae789d8c04d6e6ebbec06dde7b42f9b411875b55d0722bc6571e9eb3432a148a8ac8b610dc1b96310b2
-  data.tar.gz: 44a537dcdcf8e7b905a4ac933a2497bd2c14598e2017b63b207baed5fcab4fdd511f17117b5a7a99e27f540f6745c5ade28eac50b4acd50d6354ab8a1c5bf5ee
+  metadata.gz: ad755f6aa427b937706e02634b752ec629d6a8ed2c472fb65531eb921d1060d31bbce57a94f20a971a106b681250eb202393135afe9d651f287be47124e5bcca
+  data.tar.gz: a8a3452c1c155825b40696dc7b9f943b28976f2d59255977e94d180bda56b767a670beecd8bf309e327a8bb17c014891614665dd5517e8bbdc0d0794803d0275

data/lib/hoodoo/services/middleware/exception_reporting/reporters/airbrake_reporter.rb

@@ -57,14 +57,8 @@ module Hoodoo; module Services
         def report( e, env )
           opts = { :backtrace => Kernel.caller() }
           opts[ :rack_env ] = env unless env.nil?
-          e    = sanitize_object(e)
-          opts = sanitize_object(opts)
 
-          # Since an ExceptionReporter is already a "slow communicatory",
-          # Hoodoo is using threads for behaviour; we don't need the async
-          # Airbrake mechanism to waste resources doing the same.
-          #
-          Airbrake.notify_sync( e, opts )
+          send_synchronously_to_airbrake( e, opts )
         end
 
         # Report an exception for errors that occur within a fully handled Rack
@@ -83,36 +77,28 @@ module Hoodoo; module Services
             :environment_name => Hoodoo::Services::Middleware.environment,
             :session          => user_data_for( context ) || 'unknown'
           }
-          e    = sanitize_object(e)
-          opts = sanitize_object(opts)
 
-          Airbrake.notify_sync( e, opts )
+          send_synchronously_to_airbrake( e, opts )
         end
 
-        private
+      private
 
-        # Recursive sanitisation method for deeply nested hash objects, returning
-        # the same object in a non frozen state.
+        # Send a report to Airbrake using its synchronous mechanism.
         #
-        # Why do I exist?
+        # Since an ExceptionReporter is already a "slow communicatory",
+        # Hoodoo is using threads for behaviour; we don't need the async
+        # Airbrake mechanism to waste resources doing the same.
         #
-        # Due to an airbrake-ruby issue where client arguments can be mutated when within a hash,
-        # a recursive sanitisation process must therefore take place before our inputs are sent
-        # to Airbrake, ensuring no frozen hash objects are present.
+        # +e+::      Exception (or subclass) instance to be reported.
+        # +params+:: Parameters for <tt>Airbrake#notify_sync</tt>.
         #
-        # https://github.com/airbrake/airbrake-ruby/issues/281
+        # http://www.rubydoc.info/gems/airbrake-ruby/Airbrake.notify_sync
+        # indicates that the +params+ Hash can contain any data of
+        # interest; it will be shown in the Airbrake dashboard.
         #
-        def sanitize_object( object )
-          object = ( object.dup rescue object ) if object.frozen?
-          return object unless object.is_a?( Hash )
-
-          sanitize_hash( object )
-        end
-
-        def sanitize_hash( object )
-          object.each do | key, value |
-            object[key] = sanitize_object( value )
-          end
+        def send_synchronously_to_airbrake( e, params )
+          e = ( e.dup rescue e ) if e.frozen?
+          Airbrake.notify_sync( e, params )
         end
       end
 

data/lib/hoodoo/version.rb

@@ -12,11 +12,11 @@ module Hoodoo
   # The Hoodoo gem version. If this changes, be sure to re-run
   # <tt>bundle install</tt> or <tt>bundle update</tt>.
   #
-  VERSION = '2.2.0'
+  VERSION = '2.2.1'
 
   # The Hoodoo gem date. If this changes, be sure to re-run
   # <tt>bundle install</tt> or <tt>bundle update</tt>.
   #
-  DATE = '2017-11-09'
+  DATE = '2017-11-10'
 
 end

data/spec/services/middleware/exception_reporting/reporters/airbrake_reporter_spec.rb

@@ -96,11 +96,12 @@ describe Hoodoo::Services::Middleware::ExceptionReporting::AirbrakeReporter do
 
       it 'can send frozen data large enough to require truncation' do
         ex       = RuntimeError.new( 'A' )
-        mock_env = { 'rack' => 'request' }
-
-        1.upto( Airbrake::Notice::PAYLOAD_MAX_SIZE + 10 ) do | i |
-          mock_env[ Hoodoo::UUID.generate() ] = i
-        end
+        mock_env = {
+          'rack' => 'request',
+          'long' => {
+            'string' => ( '!' * Airbrake::Notice::MAX_NOTICE_SIZE ).freeze
+          }.freeze
+        }
 
         # See previous test (above) for an explanation of the expectations
         # below.

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hoodoo
 version: !ruby/object:Gem::Version
-  version: 2.2.0
+  version: 2.2.1
 platform: ruby
 authors:
 - Loyalty New Zealand
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-09 00:00:00.000000000 Z
+date: 2017-11-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dalli
@@ -234,6 +234,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.6'
+- !ruby/object:Gem::Dependency
+  name: airbrake-ruby
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.6'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.6'
 - !ruby/object:Gem::Dependency
   name: airbrake
   requirement: !ruby/object:Gem::Requirement