hoodoo 1.2.1 → 1.2.2

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    OWM1YWFkNDAxZGQ1MGUyZTNmNTIyZjk3MGYxMzNmYjRlYzZiYmRmYw==
+    ZDIzZWU2OWE2MmEyY2RiZjRjMDk1OTlmZGFhM2YyNzA3ZTE0NDQ5MA==
   data.tar.gz: !binary |-
-    YjRmZDVjYjk1YzBkMjU2ODczMGU3YTJjYzZhMjdjYTE1ZDgyYzE1NA==
+    MDc4NDgwNjM1MDcwZmE3OWE0NTAzYjExN2Y0MzMxYmJhYzQyZmI0OQ==
 SHA512:
   metadata.gz: !binary |-
-    ZTRiOGNkNjYzOTE3YjJkYWE0N2M4ZjdkZTllM2JhMTkwMTFjMTM1NWJjYTU5
-    YTVkMThjYjZkMmU3ZGJiMTk0NzM1YmRlNWZiZTk4ZTgxYTQwMGNlMTE2YjAy
-    ZTc4OTNiNGY5Mjg3MDc0NGI1MDg5OTg2MmU5YzFlNzczZTM1NTA=
+    M2IyM2U5ZGI3NjBiMzRhYjUyOTBhZDk5ODE4YmY2N2RlOGUyNTA0ODgxODdk
+    N2Y2OGYxNTE0NjYwOWRiMmZkOGJkMTUyMzQ2Yzk1YmE0ZGY0ZTE2ODkyN2Nj
+    MDg3NjQwZjI0NTUxODRhODIzNTFhOTg3Yzg1MzFiYzk0OWYwNTE=
   data.tar.gz: !binary |-
-    ZmFiZTNiZDZhZGI4NzA0NzAyYWM4ZTI3YTAxM2E5OTRlYzNlN2NkZWM4ZDUx
-    Y2NkNmJmZTA4Njg3N2EyNmQwMmY3YThmOGM4NWFiNmI3MTRmMDEzNWQ4MmFj
-    ZjI3NTJmNzVmYTgxOGNkYWEwOTA3OWExNGFlZDkzYzQzMDFmZmI=
+    MGU2ZDA2Yzg3NmRmNGE3MTRiMzczOWU0N2JmZDc0ZmFmNmJlNTc5NGE3ZWJl
+    YmY2Mjk1YWZkNzY2NjEwNjIwYTFiYzhkM2Y0MTExZmVjMmRmOWIxNDRkOGY5
+    OWE3MjZkODUwYjEzZjM4MzU3MWQ1MDNjYTk5ZmNiMTA4YjE2MzI=

data/lib/hoodoo/active/active_record/manually_dated.rb

@@ -310,6 +310,13 @@ module Hoodoo
     #
     module ManuallyDated
 
+      # Rounding resolution, in terms of number of decimal places to which
+      # seconds are rounded. Excessive accuracy makes for difficult, large
+      # indices in the database and may fall foul of system / database
+      # clock accuracy mismatches.
+      #
+      SECONDS_DECIMAL_PLACES = 2 # An Integer from 0 upwards
+
       # In order for indices to work properly on +effective_end+ dates, +NULL+
       # values cannot be permitted as SQL +NULL+ is magic and means "has no
       # value", so such a value in a column prohibits indexing.
@@ -330,14 +337,7 @@ module Hoodoo
       #     ActiveRecord::Base.connection.quoted_date( Hoodoo::ActiveRecord::ManuallyDated::DATE_MAXIMUM )
       #     # => returns "9999-12-31 23:59:59.000000" for PostgreSQL 9.4.
       #
-      DATE_MAXIMUM = Time.parse( '9999-12-31T23:59:59.0Z' )
-
-      # Rounding resolution, in terms of number of decimal places to which
-      # seconds are rounded. Excessive accuracy makes for difficult, large
-      # indices in the database and may fall foul of system / database
-      # clock accuracy mismatches.
-      #
-      SECONDS_DECIMAL_PLACES = 2 # An Integer from 0 upwards
+      DATE_MAXIMUM = Time.parse( '9999-12-31T23:59:59.0Z' ).round( SECONDS_DECIMAL_PLACES )
 
       # Instantiates this module when it is included.
       #
@@ -408,6 +408,10 @@ module Hoodoo
         def manual_dating_enabled
           self.nz_co_loyalty_hoodoo_manually_dated = true
 
+          rounder = Proc.new do | timelike |
+            timelike.to_time.round( SECONDS_DECIMAL_PLACES )
+          end
+
           # This is the 'tightest'/innermost callback available for creation.
           # Intentionally have nothing for updates/deletes as the high level
           # API here must be used; we don't want to introduce any more magic.
@@ -419,6 +423,13 @@ module Hoodoo
             self.updated_at      ||= now
             self.effective_start ||= self.created_at
             self.effective_end   ||= DATE_MAXIMUM
+
+            %i{ created_at updated_at effective_start effective_end }.each do | attr |
+              value   = self.send( attr )
+              rounded = value.to_time.round( SECONDS_DECIMAL_PLACES )
+
+              self.send( "#{ attr }=", rounded ) if rounded != value
+            end
           end
 
           # This is very similar to the UUID mixin, but works on the 'uuid'

data/lib/hoodoo/version.rb

@@ -12,6 +12,6 @@ module Hoodoo
   # The Hoodoo gem version. If this changes, ensure that the date in
   # "hoodoo.gemspec" is correct and run "bundle install" (or "update").
   #
-  VERSION = '1.2.1'
+  VERSION = '1.2.2'
 
 end

data/spec/active/active_record/manually_dated_spec.rb

@@ -643,6 +643,38 @@ describe Hoodoo::ActiveRecord::ManuallyDated do
     end
   end
 
+  context 'inbound date-time rounding' do
+    it 'rounds ActiveRecord-assigned timestamps' do
+      record = RSpecModelManualDateTest.new( {
+        :data => Hoodoo::UUID.generate()
+      } )
+
+      record.save!
+
+      %i{ created_at updated_at effective_start effective_end }.each do | attr |
+        value = record.send( attr )
+        expect( value.utc.round( Hoodoo::ActiveRecord::ManuallyDated::SECONDS_DECIMAL_PLACES ) ).to eq( value )
+      end
+    end
+
+    it 'rounds explicitly assigned timestamps' do
+      record = RSpecModelManualDateTest.new( {
+        :data => Hoodoo::UUID.generate(),
+        :created_at      => Time.now - 2.seconds,
+        :updated_at      => Time.now - 1.seconds,
+        :effective_start => Time.now - 2.seconds,
+        :effective_end   => Time.now - 1.seconds
+      } )
+
+      record.save!
+
+      %i{ created_at updated_at effective_start effective_end }.each do | attr |
+        value = record.send( attr )
+        expect( value.utc.round( Hoodoo::ActiveRecord::ManuallyDated::SECONDS_DECIMAL_PLACES ) ).to eq( value )
+      end
+    end
+  end
+
   # Rapid updates within configured date resolution might not be resolvable
   # as individual history items via API, but they should still exist and
   # things like uuid/start/end uniqueness constraint columns ought to still

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hoodoo
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.2.2
 platform: ruby
 authors:
 - Loyalty New Zealand