honeymaker 0.9.2 → 0.9.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ac4aba6f18266cfffed7dfe3939a60198cb6bdb7361818db8f25f435e19d92f9
-  data.tar.gz: e0e398092c55d7483ac386a94846fd5eff4abf115feb9dffd59a85c59462da37
+  metadata.gz: 8751e8712e47b27bf82073fa2b7de4ec7d7404e9b6195a6cbcd06a2a48749acd
+  data.tar.gz: 414e8fd8e266d7d8cd7acc3abd4b39f18d450fb5ba08ebf0b9121c599fc7ff9f
 SHA512:
-  metadata.gz: aabbbc8fdd2c884c85770fc21a5862fe05c014860775f44e362e59c7db7c841cf92e74494af5028abdf10f4af70d88dc5fe13cc4fdc1838e359dc44f6f5c6dd5
-  data.tar.gz: a6cb39b92b07b6a5d04bb9b5d3adc14f11f7ea045b628c3b7dc09dd7501ddc0b9268bd3b477d8f2aac5072cfd379afe527738899c706b3d60ace82edd91073ad
+  metadata.gz: ccf214595dccd90388f8a77dffca7cb0618047c025531c219c1030d2af821d96b682f67f991ff701de013f847cea045b5c7a9b4f5f1a6a96f19490549c18a6ef
+  data.tar.gz: e724a084bfc8bd6bca47bd6bced65a12eb75818e58b05f31022d549d246bb8fa1920763bbc27179b1d0339938b899309ee8b8be0f8718a96163834b9f8107a8d

data/lib/honeymaker/clients/bitvavo.rb

@@ -7,6 +7,11 @@ module Honeymaker
       ACCESS_WINDOW = "10000"
       RATE_LIMITS = { default: 100, orders: 100 }.freeze
 
+      # Bitvavo requires a mandatory operatorId on every order create/cancel
+      # (errorCode 203). It's a positive int64 the caller sets themselves to
+      # attribute an order to a trader/bot for audit; the value is cosmetic.
+      DEFAULT_OPERATOR_ID = 1
+
       def get_assets
         get_public("/v2/assets")
       end
@@ -51,11 +56,12 @@ module Honeymaker
       end
 
       def place_order(market:, side:, order_type:, amount: nil, amount_quote: nil, price: nil,
-                      time_in_force: nil, client_order_id: nil)
+                      time_in_force: nil, client_order_id: nil, operator_id: nil)
         result = post_signed("/v2/order", {
           market: market, side: side, orderType: order_type,
           amount: amount, amountQuote: amount_quote, price: price,
-          timeInForce: time_in_force, clientOrderId: client_order_id
+          timeInForce: time_in_force, clientOrderId: client_order_id,
+          operatorId: operator_id || DEFAULT_OPERATOR_ID
         })
         return result if result.failure?
 
@@ -71,8 +77,10 @@ module Honeymaker
         Result::Success.new(normalize_order("#{raw['market']}-#{raw['orderId']}", raw))
       end
 
-      def cancel_order(market:, order_id:)
-        delete_signed("/v2/order", { market: market, orderId: order_id })
+      def cancel_order(market:, order_id:, operator_id: nil)
+        delete_signed("/v2/order", {
+          market: market, orderId: order_id, operatorId: operator_id || DEFAULT_OPERATOR_ID
+        })
       end
 
       def get_trades(market:, limit: nil, start_time: nil, end_time: nil, trade_id_from: nil, trade_id_to: nil)

data/lib/honeymaker/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Honeymaker
-  VERSION = "0.9.2"
+  VERSION = "0.9.3"
 end

data/test/honeymaker/clients/bitvavo_client_test.rb

@@ -47,6 +47,36 @@ class Honeymaker::Clients::BitvavoTest < Minitest::Test
     assert result.success?
   end
 
+  # Bitvavo requires a mandatory integer operatorId on every order create/cancel
+  # (errorCode 203). These tests yield the real Faraday request block so we assert
+  # what the client actually sends, not just the stubbed response.
+
+  def test_place_order_sends_default_operator_id
+    req = capture_request(:post, { "orderId" => "123" })
+    @client.place_order(market: "BTC-EUR", side: "buy", order_type: "market", amount_quote: "100")
+    assert_equal @client.class::DEFAULT_OPERATOR_ID, req.body[:operatorId]
+    assert_kind_of Integer, req.body[:operatorId]
+  end
+
+  def test_place_order_operator_id_override
+    req = capture_request(:post, { "orderId" => "123" })
+    @client.place_order(market: "BTC-EUR", side: "buy", order_type: "market", amount_quote: "100", operator_id: 42)
+    assert_equal 42, req.body[:operatorId]
+  end
+
+  def test_cancel_order_sends_default_operator_id
+    req = capture_request(:delete, { "orderId" => "123" })
+    @client.cancel_order(market: "BTC-EUR", order_id: "123")
+    assert_equal @client.class::DEFAULT_OPERATOR_ID, req.params[:operatorId]
+    assert_kind_of Integer, req.params[:operatorId]
+  end
+
+  def test_cancel_order_operator_id_override
+    req = capture_request(:delete, { "orderId" => "123" })
+    @client.cancel_order(market: "BTC-EUR", order_id: "123", operator_id: 42)
+    assert_equal 42, req.params[:operatorId]
+  end
+
   def test_withdraw
     stub_connection(:post, { "success" => true })
     result = @client.withdraw(symbol: "BTC", amount: "0.1", address: "addr")
@@ -102,4 +132,25 @@ class Honeymaker::Clients::BitvavoTest < Minitest::Test
     connection.stubs(method).returns(response)
     @client.instance_variable_set(:@connection, connection)
   end
+
+  # Records what the client sets on the Faraday request. Unlike stub_connection,
+  # this yields the request block (connection.post { |req| ... }) so the real
+  # body/params-building code in post_signed/delete_signed actually executes.
+  class RequestRecorder
+    attr_accessor :headers, :body, :params
+    attr_reader :requested_url
+
+    def url(path)
+      @requested_url = path
+    end
+  end
+
+  def capture_request(method, body)
+    response = stub(body: body)
+    recorder = RequestRecorder.new
+    connection = stub
+    connection.stubs(method).yields(recorder).returns(response)
+    @client.instance_variable_set(:@connection, connection)
+    recorder
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: honeymaker
 version: !ruby/object:Gem::Version
-  version: 0.9.2
+  version: 0.9.3
 platform: ruby
 authors:
 - Deltabadger