honeymaker 0.11.3 → 0.11.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a33b3f43a40a17e8f8655683b4349901db4222a6ec5db4d4a8f82585f0dacdd1
-  data.tar.gz: dde27e04419cb12327dfee7c3ecf69c61f36ddf28c1e9b7e2872c785a726106b
+  metadata.gz: 2367ab9c6994586eb565f383f4b897d7a7bdcfb5cf68c0593da80f6b4d4b0497
+  data.tar.gz: 585589c4bc524266bed905b142913b6072e5ff8824602cdf5691e6ac2046bf39
 SHA512:
-  metadata.gz: f6b7a44553dbc9a413c6df817f4ffbff0f263c077f163e10bce5389d7aba60c108d956c68f9f713ac2b7fef69c699540e3759a1fb5470162146d746ace18a624
-  data.tar.gz: e53261fd199b590b1d23318d5b2689a59a5b6dc2a402e09b6fb3d63010b1bbb79281e4b3cafd8401964315e51f8a7fbe39e45aa250217e0ed9851c35bc7c494d
+  metadata.gz: b4d5824b776181fff4494c1f4fe76e8ff46e21faf198cb23a894ea836fcfb4bc4f3eb8c0eec2315cc072a065ce9de5b4fd9e34d50f52390368069c5fbd091b13
+  data.tar.gz: f63b8235706bc5257bc1710939fc68f315316650966476a55ff4a25c1de35bb3035f42f54a94105fd1e446bcb4c6e684b65b2418bb16db68f7310c5bdb17dd16

data/lib/honeymaker/clients/kraken.rb

@@ -65,9 +65,13 @@ module Honeymaker
         post_private("/0/private/CancelOrder", { nonce: nonce, txid: txid, cl_ord_id: cl_ord_id })
       end
 
-      def get_tradable_asset_pairs(pairs: nil, info: nil, country_code: nil)
+      # aclass_base: "all" also returns tokenized equities (xStocks); omitted, Kraken serves only the
+      # "currency" class. Note the asset-class parameter is spelled differently per endpoint —
+      # aclass_base here, asset_class on Ticker/OHLC/Depth/AddOrder.
+      def get_tradable_asset_pairs(pairs: nil, info: nil, country_code: nil, aclass_base: nil)
         get_public("/0/public/AssetPairs", {
-          pair: pairs ? pairs.join(",") : nil, info: info, country_code: country_code
+          pair: pairs ? pairs.join(",") : nil, info: info, country_code: country_code,
+          aclass_base: aclass_base
         })
       end
 

data/lib/honeymaker/exchanges/kraken.rb

@@ -48,15 +48,25 @@ module Honeymaker
 
       def get_tickers_info
         with_rescue do
-          response = connection.get("/0/public/AssetPairs")
+          # aclass_base=all, not a bare call: the default response carries only the "currency" class,
+          # so Kraken tokenized equities (xStocks) are invisible without it. One request returns both
+          # classes and they are disjoint.
+          response = connection.get("/0/public/AssetPairs", { aclass_base: "all" })
 
           error = response.body["error"]
           return Result::Failure.new(*error) if error.is_a?(Array) && error.any?
 
-          response.body["result"].filter_map do |_, info|
+          # Every tokenized pair is returned TWICE - once under an SPV key (NVDASPVUSD), once under
+          # the x key (NVDAxUSD) - sharing one wsname and altname. Currency pairs are never
+          # duplicated, so keying by wsname collapses exactly the aliases and nothing else.
+          deduped = response.body["result"].each_with_object({}) do |(_, info), acc|
             wsname = info["wsname"]
-            next unless wsname && !wsname.empty?
+            next if wsname.nil? || wsname.empty?
 
+            acc[wsname] ||= info
+          end
+
+          deduped.filter_map do |wsname, info|
             base, quote = wsname.split("/")
 
             {
@@ -71,7 +81,15 @@ module Honeymaker
               quote_decimals: info["cost_decimals"],
               price_decimals: info["pair_decimals"],
               available: true,
-              trading_enabled: info.key?("status") ? info["status"] == "online" : true
+              # Tokenized equities are listed but never tradable through this client: AddOrder needs
+              # an asset_class parameter it does not send, and Kraken closes the tokenized order
+              # books to EEA clients over the API regardless of that. Listing them anyway is what
+              # lets a holding be resolved and valued.
+              trading_enabled: if info["aclass_base"] == "tokenized_asset"
+                                 false
+                               else
+                                 info.key?("status") ? info["status"] == "online" : true
+                               end
             }
           end
         end

data/lib/honeymaker/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Honeymaker
-  VERSION = "0.11.3"
+  VERSION = "0.11.4"
 end

data/test/fixtures/kraken_asset_pairs.json

@@ -10,7 +10,34 @@
       "cost_decimals": 5,
       "pair_decimals": 1,
       "ordermin": "0.00010000",
-      "costmin": "0.50000"
+      "costmin": "0.50000",
+      "aclass_base": "currency"
+    },
+    "NVDAxUSD": {
+      "altname": "NVDAxUSD",
+      "wsname": "NVDAx/USD",
+      "aclass_base": "tokenized_asset",
+      "base": "NVDAx",
+      "quote": "ZUSD",
+      "lot_decimals": 8,
+      "cost_decimals": 5,
+      "pair_decimals": 2,
+      "ordermin": "0.00000001",
+      "costmin": "0.5",
+      "status": "online"
+    },
+    "NVDASPVUSD": {
+      "altname": "NVDAxUSD",
+      "wsname": "NVDAx/USD",
+      "aclass_base": "tokenized_asset",
+      "base": "NVDAx",
+      "quote": "ZUSD",
+      "lot_decimals": 8,
+      "cost_decimals": 5,
+      "pair_decimals": 2,
+      "ordermin": "0.00000001",
+      "costmin": "0.5",
+      "status": "online"
     }
   }
 }

data/test/honeymaker/clients/kraken_client_test.rb

@@ -22,6 +22,36 @@ class Honeymaker::Clients::KrakenTest < Minitest::Test
     assert result.data["result"].key?("XBTUSDT")
   end
 
+  # Without aclass_base Kraken serves only the "currency" class, so tokenized equities are invisible.
+  def test_get_tradable_asset_pairs_forwards_aclass_base
+    captured = nil
+    req = stub("req")
+    req.stubs(:url)
+    req.stubs(:headers=)
+    req.stubs(:params=).with { |p| captured = p; true }
+    connection = stub
+    connection.stubs(:get).yields(req).returns(stub(body: { "error" => [], "result" => {} }))
+    @client.instance_variable_set(:@connection, connection)
+
+    assert @client.get_tradable_asset_pairs(aclass_base: "all").success?
+    assert_equal "all", captured[:aclass_base]
+  end
+
+  def test_get_tradable_asset_pairs_omits_aclass_base_when_not_asked
+    captured = nil
+    req = stub("req")
+    req.stubs(:url)
+    req.stubs(:headers=)
+    req.stubs(:params=).with { |p| captured = p; true }
+    connection = stub
+    connection.stubs(:get).yields(req).returns(stub(body: { "error" => [], "result" => {} }))
+    @client.instance_variable_set(:@connection, connection)
+
+    @client.get_tradable_asset_pairs
+
+    refute captured.key?(:aclass_base), "params are compacted, so nil must not be sent"
+  end
+
   def test_get_ticker_information
     stub_connection(:get, { "error" => [], "result" => { "XBTUSDT" => { "a" => ["50000"] } } })
     result = @client.get_ticker_information(pair: "XBTUSDT")

data/test/honeymaker/exchanges/kraken_test.rb

@@ -9,6 +9,45 @@ class Honeymaker::Exchanges::KrakenTest < Minitest::Test
     @exchange = Honeymaker::Exchanges::Kraken.new
   end
 
+  # Tokenized equities (xStocks) live behind aclass_base and are invisible to a bare AssetPairs call.
+  # aclass_base=all returns currency + tokenized in one request; the two sets are disjoint.
+  def test_get_tickers_info_requests_every_asset_class
+    response = stub(body: load_fixture("kraken_asset_pairs.json"))
+    connection = stub
+    connection.expects(:get).with("/0/public/AssetPairs", { aclass_base: "all" }).returns(response)
+    @exchange.instance_variable_set(:@connection, connection)
+
+    assert @exchange.get_tickers_info.success?
+  end
+
+  # Kraken returns every tokenized pair TWICE - once under an SPV key, once under the x key - with
+  # one shared wsname and altname. Only tokenized pairs are double-keyed; currency pairs never are.
+  # Mapping the raw response would ingest each of them twice.
+  def test_get_tickers_info_deduplicates_the_spv_alias
+    body = load_fixture("kraken_asset_pairs.json")
+    stub_request(body)
+
+    result = @exchange.get_tickers_info
+
+    nvda = result.data.select { |t| t[:base] == "NVDAx" }
+    assert_equal 1, nvda.size, "NVDAxUSD and NVDASPVUSD are one pair"
+    assert_equal "NVDAxUSD", nvda.first[:ticker]
+  end
+
+  # Listed, so a holding can be resolved and valued; not tradable, because AddOrder needs an
+  # asset_class parameter this client does not send, and Kraken closes the tokenized order books to
+  # EEA clients over the API regardless.
+  def test_tokenized_pairs_are_listed_but_not_trading_enabled
+    body = load_fixture("kraken_asset_pairs.json")
+    stub_request(body)
+
+    nvda = @exchange.get_tickers_info.data.find { |t| t[:base] == "NVDAx" }
+
+    assert_equal "online", body["result"]["NVDAxUSD"]["status"]
+    assert nvda[:available], "listed, so balances resolve"
+    refute nvda[:trading_enabled], "we cannot place these orders"
+  end
+
   def test_get_tickers_info_parses_response
     body = load_fixture("kraken_asset_pairs.json")
     stub_request(body)
@@ -68,7 +107,9 @@ class Honeymaker::Exchanges::KrakenTest < Minitest::Test
     result = @exchange.get_tickers_info
 
     assert result.success?
-    assert_empty result.data
+    # Asserts the wsname-less pair is dropped, not that the whole response is - the fixture now
+    # carries a tokenized pair too.
+    refute result.data.any? { |t| t[:ticker] == "XBTUSDT" }
   end
 
   def test_get_tickers_info_uses_real_costmin

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: honeymaker
 version: !ruby/object:Gem::Version
-  version: 0.11.3
+  version: 0.11.4
 platform: ruby
 authors:
 - Deltabadger