honeymaker 0.11.0 → 0.11.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c8386a3ce395f193a10d210d48e62f48ffb5f2c2cf6ab2dbf77cd8a6466700c9
-  data.tar.gz: 9a4bd23725e93deb9a4b8e6aad1f9e86f6b27f13ecf0507031a9fbd53b2f65ba
+  metadata.gz: c0d4a030c628dda5a597efb6ff65b552ce961cfb855e7f6affa668a8f0e6f492
+  data.tar.gz: 43372bdcc5a896dcf83e7f8fcd913d091a1b2c79b61e03e2b1e430dc20821ee0
 SHA512:
-  metadata.gz: 76f414d30b7ae364453bdb8b0522e2c1be01adc6db1126addfc2d0f3fc7111df3d3de41714dab6ec98b25dba8116605f9a9c064a58fe907aba2a4eb24f3f81f5
-  data.tar.gz: b6d38bc14208cadd407faa789607deddba96a9bd0a5c63d0ed5efbbc6fc86bef6fadda21f30814051e0cae5c1ded2a1bba8a8f5e2a99f06074dffb9c545f9229
+  metadata.gz: aabd7c7f6859af5e36fb7bc301a227603683b9505e78a306b3944b8fba8ed6c5df45c05a9846557b18c59f461bfe3601f7492ede5a02c6125a87a1d9d58e76fe
+  data.tar.gz: ef8db9f4be0d5d60aa65a0d9baa41283b20cf44ddf6f624b4c0617cc5fab6449ac77878b190d0dff2ebca848876461a500b95d6b53f39f9b465fa817567ad923

data/lib/honeymaker/client.rb

@@ -70,8 +70,19 @@ module Honeymaker
       status = e.respond_to?(:response_status) ? e.response_status : nil
       Result::Failure.new(error_message, data: { status: status })
     rescue StandardError => e
+      # NOT an exchange error — a bug here, in a vendor gem, or in the caller, and it arrives in the
+      # same Result::Failure as a genuine venue rejection. Callers classify that text to decide "out
+      # of funds" / "bad key" / "safe to retry", so an unlabelled TypeError gets attributed to the
+      # exchange: a hyperliquid-rb signing crash sat in production order history for three months
+      # reading exactly like a venue rejection. Name the class so the true source is unmistakable,
+      # and flag it so a caller can refuse to classify it as the venue's at all.
+      #
+      # The class is a PREFIX, not a replacement: the network failures that also land here
+      # (Net::ReadTimeout, execution expired, connection refused) are matched by substring for
+      # transient retry, and those matches must keep working.
       msg = e.message
-      Result::Failure.new((msg && !msg.empty?) ? msg : "Unknown error")
+      labelled = (msg && !msg.empty?) ? "#{e.class}: #{msg}" : e.class.to_s
+      Result::Failure.new(labelled, data: { client_error: true })
     end
 
     # A business error the exchange returned inside an HTTP-200 envelope (KuCoin's non-"200000"

data/lib/honeymaker/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Honeymaker
-  VERSION = "0.11.0"
+  VERSION = "0.11.1"
 end

data/test/honeymaker/client_test.rb

@@ -41,7 +41,44 @@ class Honeymaker::ClientTest < Minitest::Test
     client = Honeymaker::Client.new
     result = client.send(:with_rescue) { raise StandardError, "boom" }
     assert result.failure?
-    assert_equal ["boom"], result.errors
+    assert_equal ["StandardError: boom"], result.errors
+  end
+
+  # A bug in this gem, in a vendor gem, or in the caller is NOT an exchange error, but it lands in
+  # the same Result::Failure. Callers classify failure text to decide "out of funds" / "bad key" /
+  # "retry me", so an unlabelled TypeError reads as something the venue said and gets filed and
+  # reported as one. Naming the class makes the true source unmistakable, and the flag lets a
+  # caller refuse to classify it at all.
+  def test_with_rescue_names_the_exception_class_for_non_api_errors
+    client = Honeymaker::Client.new
+    result = client.send(:with_rescue) { raise TypeError, "String can't be coerced into Float" }
+    assert result.failure?
+    assert_equal ["TypeError: String can't be coerced into Float"], result.errors
+    assert result.data[:client_error], "a local exception must be flagged, not passed off as the venue's"
+  end
+
+  def test_with_rescue_labels_an_empty_message_with_its_class
+    client = Honeymaker::Client.new
+    result = client.send(:with_rescue) { raise NoMethodError, "" }
+    assert result.failure?
+    assert_equal ["NoMethodError"], result.errors
+  end
+
+  # Network failures reach callers through this branch too, and the transient-retry matchers key
+  # off substrings of them. Prefixing must not break that.
+  def test_with_rescue_keeps_network_substrings_matchable
+    client = Honeymaker::Client.new
+    result = client.send(:with_rescue) { raise Net::ReadTimeout, "Net::ReadTimeout with #<TCPSocket:(closed)>" }
+    assert_includes result.errors.first, "Net::ReadTimeout"
+  end
+
+  # An exchange error is not ours: it must stay unflagged and unprefixed so the venue's own text
+  # reaches the classifiers verbatim.
+  def test_with_rescue_does_not_flag_api_errors
+    client = Honeymaker::Client.new
+    result = client.send(:with_rescue) { raise Faraday::TimeoutError, "timeout" }
+    assert result.failure?
+    assert_nil result.data[:client_error]
   end
 
   def test_hmac_sha256

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: honeymaker
 version: !ruby/object:Gem::Version
-  version: 0.11.0
+  version: 0.11.1
 platform: ruby
 authors:
 - Deltabadger