honeybee-openstudio 2.30.0 → 2.30.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e61c104adc3d8f346115f29cfdc29e268a8668ba11d5bf3e44fdd054f75f95ba
-  data.tar.gz: 1d9b02e466124bbf3c72bb15e54308146ad0076d7e98339929fddac8d3018200
+  metadata.gz: 2d19cafbb87891ad69e1401b0d354038204694d31ea87e8883c9bc68648b07e8
+  data.tar.gz: '09bf5f735d28a95dc4bff708d2334357cffae66674143e147628e1fef53458c5'
 SHA512:
-  metadata.gz: cdf371172756c14205799e1a476517c64587a261e4331828ddce046082d256e70511ab00cb50275f35ee080deb44f1ce4a7f35bb8a04e21bf8fe94a805c21888
-  data.tar.gz: a76dff993fb5fc51ea9d11d1999553d2f8a43fd107cb17864a6c8dc8ceac9999ca00d64b68d0f51261a70e91991952b5fda794d168f98f4f0470a6767dc680e2
+  metadata.gz: 0ed3ecfab3391d7cd09a46c21acc63669c3c1284ba6f41a3e1cf4775ed368c2046f18673331dddfc09c6864d97050767a8b6cb3068f2f7254e268e1941ca3173
+  data.tar.gz: 4428ccaae94c5321085fd1c61b58fa9e784f769ea3e67ee1fac5f41a1be9c18e8e42a377ea7f180cc8212d7dba04f8d68a0ee7c644f750c596706f87c1c7a4cf

data/honeybee-openstudio.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'honeybee-openstudio'
-  spec.version       = '2.30.0'
+  spec.version       = '2.30.1'
   spec.authors       = ['Tanushree Charan', 'Dan Macumber', 'Chris Mackey', 'Mostapha Sadeghipour Roudsari']
   spec.email         = ['tanushree.charan@nrel.gov', 'chris@ladybug.tools']
 

data/lib/to_openstudio/load/service_hot_water.rb

@@ -86,25 +86,38 @@ module Honeybee
         eq_type = shw_hash[:equipment_type]
         if eq_type == 'Default_District_SHW'
           # add a district heating system to supply the heat for the loop
-          district_hw = OpenStudio::Model::DistrictHeating.new(openstudio_model)
-          district_hw.setName('Service Hot Water District Heat')
-          district_hw.setNominalCapacity(1000000)
+          district_hw = OpenStudio::Model::WaterHeaterMixed.new(openstudio_model)
+          district_hw.setName('Ideal Service Hot Water Heater')
+          district_hw.setHeaterFuelType('DistrictHeating')
+          district_hw.setOffCycleParasiticFuelType('DistrictHeating')
+          district_hw.setOnCycleParasiticFuelType('DistrictHeating')
+          district_hw.setHeaterThermalEfficiency(1.0)
+          district_hw.setHeaterMaximumCapacity(1000000)
+          district_hw.setTankVolume(0)
+          district_hw.setHeaterControlType('Modulate')
+          target_sch_name = '22C Ambient Condition'
+          target_sch = create_constant_schedule(openstudio_model, target_sch_name, 22)
+          district_hw.setAmbientTemperatureSchedule(target_sch)
+          district_hw.setOffCycleLossCoefficienttoAmbientTemperature(0)
+          district_hw.setOnCycleLossCoefficienttoAmbientTemperature(0)
           hot_water_plant.addSupplyBranchForComponent(district_hw)
-        elsif eq_type == 'Gas_WaterHeater' || eq_type == 'Electric_WaterHeater' || eq_type == 'HeatPump_WaterHeater'
+          # try to minimize the impact of the pump as much as possible
+          hot_water_pump.setEndUseSubcategory('Water Systems')
+          hot_water_pump.setMotorEfficiency(0.9)
+        else
           # add a water heater to supply the heat for the loop
           heater = OpenStudio::Model::WaterHeaterMixed.new(openstudio_model)
-          if eq_type == 'Electric_WaterHeater' || eq_type == 'HeatPump_WaterHeater'
+          if eq_type == 'Electric_WaterHeater' || eq_type == 'HeatPump_WaterHeater' || eq_type == 'Electric_TanklessHeater'
             heater.setHeaterFuelType('Electricity')
             heater.setOffCycleParasiticFuelType('Electricity')
             heater.setOnCycleParasiticFuelType('Electricity')
           end
-          heater.setName('SHW WaterHeater' + @@sys_count.to_s)
 
           # set the water heater efficiency
           if eq_type == 'HeatPump_WaterHeater'
             heater.setHeaterThermalEfficiency(1.0)
           elsif shw_hash[:heater_efficiency].nil?
-            if eq_type == 'Electric_WaterHeater'
+            if eq_type == 'Electric_WaterHeater' || eq_type == 'Electric_TanklessHeater'
               heater.setHeaterThermalEfficiency(1.0)
             else
               heater.setHeaterThermalEfficiency(0.8)
@@ -159,9 +172,20 @@ module Honeybee
             end
           end
 
-          # ensure that the tank is sized appropriately and add it to the loop
+          # set the capactiy and and controls of the water heater
           heater.setHeaterMaximumCapacity(1000000)
-          heater.setTankVolume(@@shw_rates[shw_hash[:identifier]])
+          if eq_type == 'Gas_TanklessHeater' || eq_type == 'Electric_TanklessHeater'
+            heater.setName('SHW Tankless WaterHeater' + @@sys_count.to_s)
+            heater.setTankVolume(0)
+            heater.setHeaterControlType('Modulate')
+            heater.setOffCycleLossCoefficienttoAmbientTemperature(0)
+            heater.setOnCycleLossCoefficienttoAmbientTemperature(0)
+          else
+            heater.setName('SHW WaterHeater' + @@sys_count.to_s)
+            heater.setTankVolume(@@shw_rates[shw_hash[:identifier]])
+          end
+
+          # add it to the loop
           hot_water_plant.addSupplyBranchForComponent(heater)
           
           # if it's a heat pump system, then add the pump
@@ -196,30 +220,6 @@ module Honeybee
             end
             heat_sys.setName('SHW WaterHeater HeatPump' + @@sys_count.to_s)
           end
-
-        elsif eq_type == 'Gas_TanklessHeater' || eq_type == 'Electric_TanklessHeater'
-          # add a boiler to supply the heat for the loop
-          heater = OpenStudio::Model::BoilerHotWater.new(openstudio_model)
-          if eq_type == 'Electric_TanklessHeater'
-            heater.setFuelType('Electricity')
-          end
-          heater.setName('SHW Tankless WaterHeater' + @@sys_count.to_s)
-          heater.setEndUseSubcategory('Water Systems')
-
-          # set the water heater efficiency
-          unless shw_hash[:heater_efficiency].nil?
-            heater.setNominalThermalEfficiency(shw_hash[:heater_efficiency])
-          else
-            if eq_type == 'Electric_TanklessHeater'
-              heater.setNominalThermalEfficiency(1.0)
-            else
-              heater.setNominalThermalEfficiency(0.8)
-            end
-          end
-
-          # ensure that the boiler is sized appropriately and add it to the loop
-          heater.setNominalCapacity(1000000)
-          hot_water_plant.addSupplyBranchForComponent(heater)
         end
 
         # add all of the water use connections to the loop and total the capacity

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: honeybee-openstudio
 version: !ruby/object:Gem::Version
-  version: 2.30.0
+  version: 2.30.1
 platform: ruby
 authors:
 - Tanushree Charan
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-02-05 00:00:00.000000000 Z
+date: 2022-02-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler