honeybadger 2.0.1 → 2.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2777622bd51f0cf653c5645b57e14934ed27954d
-  data.tar.gz: 1f1a31d68cb68dc2d5737a94136c09fef0c36a25
+  metadata.gz: 7e0e979296b465bccca9fadeecbe5fd8b8987b8c
+  data.tar.gz: e730b640fb9d0bd97232872e0c1a4d8ac274e078
 SHA512:
-  metadata.gz: a3d20098ca94158c51238d7984230a5ca9ad0e05389cd7eb774e7ca82260699d1ab553b5c33419b3d3f2970ee96a0f9c987e18c3104be844e9b5ee01c9b3521e
-  data.tar.gz: 0f5435235c2f78ad38cd762ad819f9312e5fb90e95aa0b73927ade9b2d15fdf1d0fcd7a319a99eae4ab4b50c7db33ef01b809d884d93c734b7e939d432d07ab9
+  metadata.gz: 9546fa7b52d0d2604163c9dae177ea2c7076770424170f265a4f8c8cd4b114f70dd15c1d6daafef1a244551dc28dc194bb6475f43fab07c9ba3404a00c6fca6a
+  data.tar.gz: 47d4b6f6863b7e3f1b9ff6b95667cb0c915a125a569023e69524f49ee323f64b8b023fdc847ad0cecbd5c049b6475f3f61519a4a746f2bcf9c21a99d87d53118

data/CHANGELOG.md

@@ -0,0 +1,17 @@
+* Detect ActionDispatch::TestProcess being included globally, fix issue locally,
+  warn the user.
+
+  *Joshua Wood*
+
+* Fix a nil logger bug when a config error occurs.
+
+  *Joshua Wood*
+
+* Don't instrument metrics and traces in Rails when features are not available
+  on account
+
+  *Joshua Wood*
+
+* Don't send error reports when disabled via configuration
+
+  *Joshua Wood*

data/lib/honeybadger/config.rb

@@ -52,7 +52,7 @@ module Honeybadger
 
     def_delegators :@values, :update
 
-    attr_reader :logger, :features
+    attr_reader :features
 
     def get(key)
       key = key.to_sym
@@ -79,6 +79,10 @@ module Honeybadger
       !!features[feature.to_sym]
     end
 
+    def logger
+      @logger || Logging::BootLogger.instance
+    end
+
     def backend
       Backend.for((self[:backend] || default_backend).to_sym).new(self)
     end

data/lib/honeybadger/notice.rb

@@ -163,6 +163,8 @@ module Honeybadger
       @local_variables = local_variables_from_exception(exception, config, @sanitizer)
 
       @api_key = opts[:api_key] || config[:api_key]
+
+      monkey_patch_action_dispatch_test_process!
     end
 
     # Internal: Template used to create JSON payload
@@ -476,5 +478,36 @@ module Honeybadger
 
       c
     end
+
+    # Internal: This is how much Honeybadger cares about Rails developers. :)
+    #
+    # Some Rails projects include ActionDispatch::TestProcess globally for the
+    # use of `fixture_file_upload` in tests. This is a bad practice because it
+    # includes other methods -- such as #session -- which override existing
+    # methods on *all objects*. This creates the following bug in Notice:
+    #
+    # When you call #session on any object which had previously defined it
+    # (such as OpenStruct), that newly defined method calls #session on
+    # @request (defined in `ActionDispatch::TestProcess`), and if @request
+    # doesn't exist in that object, it calls #session *again* on `nil`, which
+    # also inherited it from Object, resulting in a SystemStackError.
+    #
+    # This method restores the correct #session method on @request and warns
+    # the user of the issue.
+    #
+    # Returns nothing
+    def monkey_patch_action_dispatch_test_process!
+      return unless defined?(ActionDispatch::TestProcess) && defined?(self.fixture_file_upload)
+
+      STDOUT.puts('WARNING: It appears you may be including ActionDispatch::TestProcess globally. Check out https://www.honeybadger.io/s/adtp for more info.')
+
+      def @request.session
+        @table[:session]
+      end
+
+      def self.session
+        @request.session
+      end
+    end
   end
 end

data/lib/honeybadger/rack/error_notifier.rb

@@ -11,18 +11,13 @@ module Honeybadger
     #
     #   require 'honeybadger/rack/error_notifier'
     #
-    #   Honeybadger.configure do |config|
-    #     config.api_key = 'my_api_key'
-    #   end
-    #
     #   app = Rack::Builder.app do
     #     run lambda { |env| raise "Rack down" }
     #   end
     #
     #   use Honeybadger::Rack::ErrorNotifier
-    #   run app
     #
-    # Use a standard Honeybadger.configure call to configure your api key.
+    #   run app
     class ErrorNotifier
       extend Forwardable
 

data/lib/honeybadger/version.rb

@@ -1,4 +1,4 @@
 module Honeybadger
   # Public: The current String Honeybadger version.
-  VERSION = '2.0.1'.freeze
+  VERSION = '2.0.2'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: honeybadger
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 2.0.2
 platform: ruby
 authors:
 - Honeybadger Industries LLC
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-31 00:00:00.000000000 Z
+date: 2015-02-04 00:00:00.000000000 Z
 dependencies: []
 description: Make managing application errors a more pleasant experience.
 email:
@@ -18,6 +18,7 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
+- CHANGELOG.md
 - LICENSE
 - README.md
 - bin/honeybadger