honest_pubsub 0.2.4 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c7c53a089f1fad2b656c8134008f95ce5e4422e7
-  data.tar.gz: 32c4c3e5f5c90697fdc092d81d2f86e22c126ff1
+  metadata.gz: bf7921af321ad1e8d84d9baea70ee538439a7e5f
+  data.tar.gz: 6a503f60a553dd038a09baab0918464b551878a0
 SHA512:
-  metadata.gz: d4740278b6b995f74e69338bd600ef74e4803a67d1e5584179d73412ce894f889093079eabf594b91900cb0f34737eac393d0a43cef2c1664f0c15c179827220
-  data.tar.gz: e6f84c3ded8940652bdf7da0a21a9eb159dc633c75e9ae87da27d28cd74037ebb13ee53a5bffe6a84a9a15998af18e982042c151eb5ba1606df205dcde0b409a
+  metadata.gz: 4cf1256690f3dd50217c72a7cfa9a00af39fa830cad8ae644c3c079e0a376a2a90fcf1c9354f7480649082ed8591da66fd4e9fb236e58253374161c8adc3a4b1
+  data.tar.gz: 9ce9f05eedec207e79e8e0a2354a95374d133ad1c89cd6dca0fdbf32eef455cc3996c390a0e4563e7a6803b4b0dd6624ab1f4a199612681d89e6a7eb25fb8894

data/README.md

@@ -56,13 +56,11 @@ Context is automatically cleared up by the gem for a Rails Application. Otherwis
 You can declare a subscriber class as follows
 
 ```ruby
-class UserWelcomeSubscriber < HonestPubsub::Server::ClientWorker
+class UserWelcomeSubscriber < HonestPubsub::Subscriber
   subscribe_to "user_created" # The message prefix that you're subscribing to
   # subscribe_to "user_created", on: 'welcome_emails_queue' # If you want to specify the queue name
 
-  def perform(context, payload)
-    # context is a hash that was put into HonestPubsub::Context
-    # Payload contains the data that was published
+  def perform(payload)
     # My awesome logic goes here...
   end
 end
@@ -82,6 +80,27 @@ Usage: bundle exec start_subscribers [options]
 
 ```
 
+#### Validations
+
+```ruby
+class UserWelcomeSubscriber < HonestPubsub::Subscriber
+  subscribe_to "user_created" # The message prefix that you're subscribing to
+  validates_payload_with :id_present
+  validates_payload_with do |payload|
+    payload[:email].present?
+  end
+
+  def perform(payload)
+    # My awesome logic goes here...
+  end
+
+  private
+
+  def id_present(payload)
+    payload[:id].present?
+  end
+end
+```
 
 ## Contributing
 

data/lib/honest_pubsub.rb

@@ -10,10 +10,11 @@ require "honest_pubsub/logger"
 require "honest_pubsub/logging"
 require "honest_pubsub/message"
 require "honest_pubsub/publisher"
-require "honest_pubsub/subscriber"
+require "honest_pubsub/server/rabbit_mq_subscriber"
 require "honest_pubsub/version"
 require "honest_pubsub/exceptions/payload_validation_error"
 require 'honest_pubsub/server'
+require 'honest_pubsub/subscriber'
 
 if defined?(Rails::Railtie)
   require "honest_pubsub/middleware"

data/lib/honest_pubsub/cli.rb

@@ -53,7 +53,7 @@ module HonestPubsub
       if subscribers.present?
         subscribers.map(&:constantize)
       else
-        HonestPubsub::Server::ClientWorker.class_variable_get(:@@registered_subscribers)
+        HonestPubsub::Subscriber.class_variable_get(:@@registered_subscribers)
       end
     end
 

data/lib/honest_pubsub/db_logger.rb

@@ -17,7 +17,7 @@ module HonestPubsub
     end
 
     def start_subscribe
-      subscriber = ::HonestPubsub::Subscriber.new("")
+      subscriber = ::HonestPubsub::Server::RabbitMQSubscriber.new("")
       subscriber.start("logger") do |info, properties, contents|
         # Write to mongo the contents and the routing_key, with the routing_key being indexed
         routing_key = info[:routing_key]

data/lib/honest_pubsub/server.rb

@@ -4,5 +4,4 @@ module HonestPubsub
 end
 
 require 'honest_pubsub/server/client_queue_listener'
-require 'honest_pubsub/server/client_worker'
 require 'honest_pubsub/server/subscriber_server'

data/lib/honest_pubsub/server/client_queue_listener.rb

@@ -16,7 +16,7 @@ module HonestPubsub
         @worker_class = worker_class
         @queue_name   = queue
         @durable      = durable
-        @subscriber   = ::HonestPubsub::Subscriber.new(@request_key, @durable, @topic)
+        @subscriber   = ::HonestPubsub::Server::RabbitMQSubscriber.new(@request_key, @durable, @topic)
       end
 
       def start
@@ -35,8 +35,8 @@ module HonestPubsub
 
       def message_received(delivery_info, properties, envelope)
         HonestPubsub.logger.debug("Message received by listener on #{worker_class.name} with payload: #{envelope[:payload]}")
-        worker = worker_class.new(delivery_info, properties)
-        worker.perform!(envelope[:context], envelope[:payload])
+        worker = worker_class.new(delivery_info, properties, envelope[:context])
+        worker.perform!(envelope[:payload])
       rescue => e
         HonestPubsub.logger.error("Failed message for #{worker_class.name}")
         Airbrake.notify("Failed perform for #{worker_class.name}",

data/lib/honest_pubsub/server/rabbit_mq_subscriber.rb

@@ -0,0 +1,72 @@
+module HonestPubsub
+  module Server
+
+    class RabbitMQSubscriber
+      attr_reader :listener
+      attr_reader :exchange
+      attr_reader :channel
+
+      def initialize(routing_key, durable = true, topic="honest")
+        @initial_key = routing_key
+        @durable = durable
+        @topic = topic
+
+        if @initial_key.present?
+          @routing_key = "#{@topic}.#{@initial_key}.#"
+        else
+          @routing_key = "#{@topic}.#"
+        end
+        @logger = ::HonestPubsub::Logger.new
+
+        self
+      end
+
+      # name - used to ensure that certain consumers are actually listening to an exchange
+      # pass in a lambda for this method to work.  We might only want to expose the content instead of
+      # all 3 chunks.
+      def start(name, blocking=false)
+        @connection = Bunny.new(Configuration.configuration[:connection])
+        begin
+          @connection.start
+        rescue => e
+          Airbrake.notify("RabbitMQ unreachable!", params: { message: e.message}, environment_name: ENV['RAILS_ENV'] )
+          raise e
+        end
+
+        @channel = @connection.create_channel
+        @exchange = @channel.topic(@topic, :durable=>@durable, :auto_delete=>false)
+
+        # FIX!!! -thl
+        # Need to ensure that the ids for a server will be reproducible in case a server
+        # goes down and has to get restarted.
+        if @initial_key.present?
+          @queue = "#{@initial_key}.#{name}"
+        else
+          @queue = "#{name}"
+        end
+
+        queue_arguments = {}
+        queue_arguments["x-dead-letter-exchange"] = Configuration.configuration[:dead_letter] if Configuration.configuration[:dead_letter].present?
+        @listener = @channel.queue(@queue, :arguments=>queue_arguments ).bind(@exchange, :routing_key => @routing_key, :exclusive=>false)
+        # Parameters for subscribe that might be useful:
+        # :block=>true - Used for long running consumer applications.  (backend servers?)
+        @consumer = @listener.subscribe(:consumer_tag=>name, :block=>blocking)
+        @consumer.on_delivery do |delivery_info, properties, contents|
+          HonestPubsub.logger.debug( "Message delivery with contents: #{contents}")
+          if delivery_info[:redelivered]
+            Airbrake.notify("PubSub Message redelivery", params: {info: delivery_info, props: properties, contents: contents}, environment_name: ENV['RAILS_ENV'] )
+          end
+          message = ::HonestPubsub::Message.new.parse(contents)
+          @logger.log_receive(delivery_info[:routing_key], message)
+          yield delivery_info, properties, message
+          true
+        end
+      end
+
+      def teardown
+        @consumer.cancel if @consumer.present?
+        @connection.close if @connection.present?
+      end
+    end
+  end
+end

data/lib/honest_pubsub/subscriber.rb

@@ -1,69 +1,99 @@
+require 'rubygems'
+require 'active_support/core_ext'
+
+# This class provders the worker for executing the subscriber. It receives a message from rabbitmq and
+# creates an instance of the subscriber to execute with the message and context
+
 module HonestPubsub
   class Subscriber
-    attr_reader :listener
-    attr_reader :exchange
-    attr_reader :channel
-
-    def initialize(routing_key, durable = true, topic="honest")
-      @initial_key = routing_key
-      @durable = durable
-      @topic = topic
-
-      if @initial_key.present?
-        @routing_key = "#{@topic}.#{@initial_key}.#"
-      else
-        @routing_key = "#{@topic}.#"
-      end
-      @logger = ::HonestPubsub::Logger.new
+    @@registered_subscribers = []
+    class_attribute :payload_validators, :error_handlers, :subscribed_key, :subscribed_queue
+    attr_accessor :delivery_routing_data, :delivery_properties, :context
 
-      self
+    def self.inherited(klass)
+      @@registered_subscribers << klass
     end
 
-    # name - used to ensure that certain consumers are actually listening to an exchange
-    # pass in a lambda for this method to work.  We might only want to expose the content instead of
-    # all 3 chunks.
-    def start(name, blocking=false)
-      @connection = Bunny.new(Configuration.configuration[:connection])
-      begin
-        @connection.start
-      rescue => e
-        Airbrake.notify("RabbitMQ unreachable!", params: { message: e.message}, environment_name: ENV['RAILS_ENV'] )
-        raise e
+    # Specify the routing key that the subscriber class should listen to.
+    # @param [String] routing_key_name The routing key to subscribe to. Must be characters only separated by periods (.)
+    # @param [Hash] options Allowed option is :on to optionally specify a queue. If not provided, queue name is generated from the routing key
+    def self.subscribe_to(routing_key_name, options = {})
+      options.assert_valid_keys(:on)
+      unless validate_routing_key_name(routing_key_name)
+        raise ArgumentError.new("#{routing_key_name} is not supported. Only lower case characters separated by periods are allowed.")
       end
+      self.subscribed_key   = routing_key_name
+      self.subscribed_queue = generated_queue_name(routing_key_name, options[:on])
+    end
 
-      @channel = @connection.create_channel
-      @exchange = @channel.topic(@topic, :durable=>@durable, :auto_delete=>false)
+    # Sets the validator for payload
+    #
+    # @param validator The validator to use for validating the payload.
+    #                  Returns false if the payload is not valid.
+    #                  Proc must accept a payload as an argument.
+    def self.validates_payload_with(*validators)
+      self.payload_validators ||= []
+      self.payload_validators += validators
+    end
 
-      # FIX!!! -thl
-      # Need to ensure that the ids for a server will be reproducible in case a server
-      # goes down and has to get restarted.
-      if @initial_key.present?
-        @queue = "#{@initial_key}.#{name}"
-      else
-        @queue = "#{name}"
-      end
+    # Sets an error handler for the class
+    def self.handle_errors_with(handler)
+      error_handler = handler
+    end
+
+    # @param [Hash] context Context from invocation
+    # @param [Object] delivery_routing_data Contains routing information like originator and routing key
+    # @param [Object] delivery_properties
+    def initialize(delivery_routing_data, delivery_properties, context)
+      @delivery_routing_data = delivery_routing_data
+      @delivery_properties   = delivery_properties
+      @context               = context
+    end
 
-      queue_arguments = {}
-      queue_arguments["x-dead-letter-exchange"] = Configuration.configuration[:dead_letter] if Configuration.configuration[:dead_letter].present?
-      @listener = @channel.queue(@queue, :arguments=>queue_arguments ).bind(@exchange, :routing_key => @routing_key, :exclusive=>false)
-      # Parameters for subscribe that might be useful:
-      # :block=>true - Used for long running consumer applications.  (backend servers?)
-      @consumer = @listener.subscribe(:consumer_tag=>name, :block=>blocking)
-      @consumer.on_delivery do |delivery_info, properties, contents|
-        HonestPubsub.logger.debug( "Message delivery with contents: #{contents}")
-        if delivery_info[:redelivered]
-          Airbrake.notify("PubSub Message redelivery", params: {info: delivery_info, props: properties, contents: contents}, environment_name: ENV['RAILS_ENV'] )
-        end
-        message = ::HonestPubsub::Message.new.parse(contents)
-        @logger.log_receive(delivery_info[:routing_key], message)
-        yield delivery_info, properties, message
-        true
+    # Performs validation if validates_payload_with is defined and then calls the perform method
+    # @param [Object] payload Payload of the message
+    def perform!(payload)
+      if !valid_payload?(payload)
+        HonestPubsub.logger.error("Payload validation failed for #{self.class.name}")
+        raise ::HonestPubsub::PayloadValidationError.new("Invalid Payload for #{self.class.name}")
       end
+
+      perform(context, payload)
     end
 
-    def teardown
-      @consumer.cancel if @consumer.present?
-      @connection.close if @connection.present?
+    # Actual subscribers need to implement perform method. This is the method where the message is actually processed.
+    # @param [Object] payload Payload of the message
+    def perform(payload)
+      raise "Need implementation for your worker."
     end
+
+    # @return [String] The original routing key with which the current message was published
+    def routing_key
+      delivery_routing_data[:routing_key]
+    end
+
+    # Iterates over all the payload validators and returns false if any of them are false
+    # @param [Object] payload The payload/arguments of the message
+    # @return [Boolen] Should return true or false value - If no validators are specified, then returns true
+    def valid_payload?(payload)
+      return true unless payload_validators.present?
+
+      payload_validators.inject(true) { |is_valid, validator|
+        is_valid && (validator.respond_to?(:call) ? validator.call(payload) : send(validator, payload))
+      }
+    end
+
+    private
+
+    def self.validate_routing_key_name(key)
+      return true if key.blank?
+      key.match(/\A([a-z]+\.?)*([a-z]+)\Z/).present?
+    end
+
+    def self.generated_queue_name(routing_key, queue_name)
+      return queue_name if queue_name.present?
+      [HonestPubsub::Configuration.application_name.to_s.gsub(/[^\w\_]/, ''), routing_key.gsub(".", '_')].reject(&:blank?).join('_')
+    end
+
   end
-end
+end

data/lib/honest_pubsub/version.rb

@@ -1,3 +1,3 @@
 module HonestPubsub
-  VERSION = "0.2.4"
+  VERSION = "0.3.0"
 end

data/spec/honest_pubsub/cli_spec.rb

@@ -123,7 +123,7 @@ describe HonestPubsub::CLI do
     }
 
     context "No subscribers passed through CLI" do
-      let(:all_subscribers) { HonestPubsub::Server::ClientWorker.class_variable_get(:@@registered_subscribers) }
+      let(:all_subscribers) { HonestPubsub::Subscriber.class_variable_get(:@@registered_subscribers) }
       it "loads all subscribers" do
         expect(all_subscribers).to include(MyTestSubscriber1)
         expect(all_subscribers).to include(MyTestSubscriber2)

data/spec/honest_pubsub/server/client_queue_listener_spec.rb

@@ -13,7 +13,7 @@ describe HonestPubsub::Server::ClientQueueListener do
 
     before do
       context_before
-      Object.const_set :Klass, Class.new(HonestPubsub::Server::ClientWorker)
+      Object.const_set :Klass, Class.new(HonestPubsub::Subscriber)
       validators.each do |validator|
         Klass.validates_payload_with validator
       end
@@ -30,7 +30,7 @@ describe HonestPubsub::Server::ClientQueueListener do
 
     context "Normal execution" do
       let!(:klass_instance){
-        instance = Klass.new({},{})
+        instance = Klass.new({},{}, {})
         allow(instance).to receive(:perform)
         instance
       }
@@ -48,7 +48,7 @@ describe HonestPubsub::Server::ClientQueueListener do
 
     context "Exception during execution" do
       let!(:klass_instance) {
-        instance = Klass.new({},{})
+        instance = Klass.new({},{}, {})
         allow(instance).to receive(:perform){
           raise StandardError.new("test")
         }
@@ -61,7 +61,7 @@ describe HonestPubsub::Server::ClientQueueListener do
 
     context "Payload error" do
       let!(:klass_instance) {
-        instance = Klass.new({},{})
+        instance = Klass.new({},{}, {})
         allow(instance).to receive(:perform)
         instance
       }

data/spec/honest_pubsub/server/client_worker_spec.rb

@@ -1,11 +1,11 @@
 require 'spec_helper'
 
-describe HonestPubsub::Server::ClientWorker do
-  before(:each) { Object.const_set :Klass, Class.new(HonestPubsub::Server::ClientWorker) }
+describe HonestPubsub::Subscriber do
+  before(:each) { Object.const_set :Klass, Class.new(HonestPubsub::Subscriber) }
   after(:each) { Object.send :remove_const, :Klass }
 
   describe "#routing_key" do
-    subject { HonestPubsub::Server::ClientWorker.new(routing_data, properties).routing_key }
+    subject { HonestPubsub::Subscriber.new(routing_data, properties, {}).routing_key }
 
     let(:properties) { {} }
 
@@ -26,18 +26,18 @@ describe HonestPubsub::Server::ClientWorker do
     context "One validator" do
       let(:validators){ [lambda{|payload| true}] }
       it {
-        expect(Klass.new({},{}).payload_validators.length).to eq 1 }
+        expect(Klass.new({},{}, {}).payload_validators.length).to eq 1 }
     end
 
     context "Two validators" do
       let(:validators){ [lambda{|payload| true}, lambda{|payload| true}] }
-      it { expect(Klass.new({},{}).payload_validators.length).to eq 2  }
+      it { expect(Klass.new({},{}, {}).payload_validators.length).to eq 2  }
     end
   end
 
   describe '#valid_payload?' do
     context
-    subject { Klass.new({},{}).valid_payload?({}) }
+    subject { Klass.new({},{}, {}).valid_payload?({}) }
 
     before do
       validators.each do |validator|

data/spec/honest_pubsub/server/rabbitmq_subscriber_spec.rb

@@ -0,0 +1,5 @@
+require 'spec_helper'
+
+describe HonestPubsub::Server::RabbitMQSubscriber do
+  subject { HonestPubsub::Server::RabbitMQSubscriber.new( routing_key ) }
+end

data/spec/spec_helper.rb

@@ -29,14 +29,14 @@ end
 HonestPubsub::Configuration.configure_with("test", File.join(HonestPubsub.root,"spec/config.yml") )
 
 # Some test subscriber classes to make testing easier
-class MyTestSubscriber1 < HonestPubsub::Server::ClientWorker
+class MyTestSubscriber1 < HonestPubsub::Subscriber
 
   def perform(payload)
 
   end
 end
 
-class MyTestSubscriber2 < HonestPubsub::Server::ClientWorker
+class MyTestSubscriber2 < HonestPubsub::Subscriber
   def perform(payload)
 
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: honest_pubsub
 version: !ruby/object:Gem::Version
-  version: 0.2.4
+  version: 0.3.0
 platform: ruby
 authors:
 - tech@honest.com
@@ -213,16 +213,15 @@ files:
 - lib/honest_pubsub/railtie.rb
 - lib/honest_pubsub/server.rb
 - lib/honest_pubsub/server/client_queue_listener.rb
-- lib/honest_pubsub/server/client_worker.rb
+- lib/honest_pubsub/server/rabbit_mq_subscriber.rb
 - lib/honest_pubsub/server/subscriber_server.rb
 - lib/honest_pubsub/subscriber.rb
 - lib/honest_pubsub/version.rb
 - spec/config.yml
-- spec/honest_pubsub/#subscriber_spec.rb#
 - spec/honest_pubsub/cli_spec.rb
 - spec/honest_pubsub/server/client_queue_listener_spec.rb
 - spec/honest_pubsub/server/client_worker_spec.rb
-- spec/honest_pubsub/subscriber_spec.rb
+- spec/honest_pubsub/server/rabbitmq_subscriber_spec.rb
 - spec/logger_spec.rb
 - spec/message_spec.rb
 - spec/spec_helper.rb
@@ -252,11 +251,10 @@ specification_version: 4
 summary: Pub sub gem for Honest Company
 test_files:
 - spec/config.yml
-- spec/honest_pubsub/#subscriber_spec.rb#
 - spec/honest_pubsub/cli_spec.rb
 - spec/honest_pubsub/server/client_queue_listener_spec.rb
 - spec/honest_pubsub/server/client_worker_spec.rb
-- spec/honest_pubsub/subscriber_spec.rb
+- spec/honest_pubsub/server/rabbitmq_subscriber_spec.rb
 - spec/logger_spec.rb
 - spec/message_spec.rb
 - spec/spec_helper.rb

data/lib/honest_pubsub/server/client_worker.rb

@@ -1,99 +0,0 @@
-require 'rubygems'
-require 'active_support/core_ext'
-
-# This class provders the worker for executing the subscriber. It receives a message from rabbitmq and
-# creates an instance of the subscriber to execute with the message and context
-
-module HonestPubsub
-  module Server
-    class ClientWorker
-      @@registered_subscribers = []
-      class_attribute :payload_validators, :error_handlers, :subscribed_key, :subscribed_queue
-      attr_accessor :delivery_routing_data, :delivery_properties
-
-      def self.inherited(klass)
-        @@registered_subscribers << klass
-      end
-
-      # Specify the routing key that the subscriber class should listen to.
-      # @param [String] routing_key_name The routing key to subscribe to. Must be characters only separated by periods (.)
-      # @param [Hash] options Allowed option is :on to optionally specify a queue. If not provided, queue name is generated from the routing key
-      def self.subscribe_to(routing_key_name, options = {})
-        options.assert_valid_keys(:on)
-        unless validate_routing_key_name(routing_key_name)
-          raise ArgumentError.new("#{routing_key_name} is not supported. Only lower case characters separated by periods are allowed.")
-        end
-        self.subscribed_key   = routing_key_name
-        self.subscribed_queue = generated_queue_name(routing_key_name, options[:on])
-      end
-
-      # Sets the validator for payload
-      #
-      # @param validator The validator to use for validating the payload.
-      #                  Returns false if the payload is not valid.
-      #                  Proc must accept a payload as an argument.
-      def self.validates_payload_with(*validators)
-        self.payload_validators ||= []
-        self.payload_validators += validators
-      end
-
-      # Sets an error handler for the class
-      def self.handle_errors_with(handler)
-        error_handler = handler
-      end
-
-      def initialize(delivery_routing_data, delivery_properties)
-        @delivery_routing_data = delivery_routing_data
-        @delivery_properties   = delivery_properties
-      end
-
-      # Performs validation if validates_payload_with is defined and then calls the perform method
-      # @param [Object] payload Payload of the message
-      # @param [Hash] context Context from invocation
-      def perform!(context, payload)
-        if !valid_payload?(payload)
-          HonestPubsub.logger.error("Payload validation failed for #{self.class.name}")
-          raise ::HonestPubsub::PayloadValidationError.new("Invalid Payload for #{self.class.name}")
-        end
-
-        perform(context, payload)
-      end
-
-      # Actual subscribers need to implement perform method. This is the method where the message is actually processed.
-      # @param [Object] payload Payload of the message
-      # @param [Hash] context Context from invocation
-      def perform(context, payload)
-        raise "Need implementation for your worker."
-      end
-
-      # @return [String] The original routing key with which the current message was published
-      def routing_key
-        delivery_routing_data[:routing_key]
-      end
-
-      # Iterates over all the payload validators and returns false if any of them are false
-      # @param [Object] payload The payload/arguments of the message
-      # @return [Boolen] Should return true or false value - If no validators are specified, then returns true
-      def valid_payload?(payload)
-        return true unless payload_validators.present?
-
-        payload_validators.inject(true) { |is_valid, validator|
-          is_valid && (validator.respond_to?(:call) ? validator.call(payload) : send(validator, payload))
-        }
-      end
-
-      private
-
-      def self.validate_routing_key_name(key)
-        return true if key.blank?
-        key.match(/\A([a-z]+\.?)*([a-z]+)\Z/).present?
-      end
-
-      def self.generated_queue_name(routing_key, queue_name)
-        return queue_name if queue_name.present?
-        [HonestPubsub::Configuration.application_name.to_s.gsub(/[^\w\_]/, ''), routing_key.gsub(".", '_')].reject(&:blank?).join('_')
-      end
-
-    end
-  end
-end

data/spec/honest_pubsub/#subscriber_spec.rb#

@@ -1,9 +0,0 @@
-require 'spec_helper'
-
-describe HonestPubsub::Subscriber do
-  subject { HonestPubsub::Subscriber.new( routing_key ) }
-
-  describe "#start" do
-    
-  end
-end

data/spec/honest_pubsub/subscriber_spec.rb

@@ -1,5 +0,0 @@
-require 'spec_helper'
-
-describe HonestPubsub::Subscriber do
-  subject { HonestPubsub::Subscriber.new( routing_key ) }
-end