home_run 1.0.4-x86-mswin32-60 → 1.0.5-x86-mswin32-60

data/CHANGELOG

@@ -1,3 +1,7 @@
+=== 1.0.5 (2012-12-22)
+
+* Handle DateTime.jd with a single float argument (jeremyevans)
+
 === 1.0.4 (2011-09-02)
 
 * Handle time zone offsets given as strings in the constructors (jeremyevans) (#37)

data/ext/date_ext/datetime.c

@@ -743,6 +743,9 @@ static VALUE rhrdt_s_jd(int argc, VALUE *argv, VALUE klass) {
       minute = NUM2LONG(argv[2]);
     case 2:
       hour = NUM2LONG(argv[1]);
+      if (TYPE(argv[0]) == T_FLOAT) {
+        rb_raise(rb_eArgError, "can't use float for first argument if providing multiple arguments");
+      }
     case 1:
       dt->jd = NUM2LONG(argv[0]);
       break;
@@ -754,7 +757,11 @@ static VALUE rhrdt_s_jd(int argc, VALUE *argv, VALUE klass) {
   RHR_CHECK_JD(dt)
   dt->flags = RHR_HAVE_JD;
   rhrdt__set_time(dt, hour, minute, second, offset);
-  return rdt;
+  if (TYPE(argv[0]) == T_FLOAT) {
+    return rhrdt__add_days(rdt, NUM2DBL(argv[0]) - NUM2LONG(argv[0]));
+  } else {
+    return rdt;
+  }
 }
 
 /* call-seq:

data/spec/datetime/constructor_spec.rb

@@ -72,6 +72,19 @@ describe "DateTime constructors" do
     d.offset.should == 1/24.0
   end
   
+  it ".jd handles a fractional date as first argument" do
+    d = DateTime.jd(2000.5)
+    d.jd.should == 2000
+    d.hour.should == 12
+    d.min.should == 0
+    d.sec.should == 0
+    d.offset.should == 0
+  end
+  
+  it ".jd should raise an error if given a float as first argument and any additional arguments" do
+    proc{DateTime.jd(2000.5, 1)}.should raise_error(ArgumentError)
+  end
+
   it ".jd should have defaults and an optional sg value" do
     DateTime.jd.should == DateTime.jd(0, 0, 0, 0, 0)
     DateTime.jd(0).should == DateTime.jd(0, 0, 0, 0, 0)

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: home_run
 version: !ruby/object:Gem::Version 
-  hash: 31
+  hash: 29
   prerelease: false
   segments: 
   - 1
   - 0
-  - 4
-  version: 1.0.4
+  - 5
+  version: 1.0.5
 platform: x86-mswin32-60
 authors: 
 - Jeremy Evans
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-09-02 00:00:00 -07:00
+date: 2011-11-01 00:00:00 -07:00
 default_executable: 
 dependencies: []