hockey_orgs 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2f55643a4d252c3e771a207f8f5a06396d69c4eaa7ccc6c0fee97e83386a53dd
-  data.tar.gz: eeb4a3dbb6e3f4431b13fc609edfe5549e071e9e34059d3bb5403a0857841381
+  metadata.gz: cf4bed3846f966e744faca8a228947cb7a720ed965a2352e20e6c21f8203aa83
+  data.tar.gz: 536567a1df2961401e8732f7d9ae397cce94ba3be8fc6c4faab938b461362c2f
 SHA512:
-  metadata.gz: 501bb833346797b43a148f2646f75e79961435666c5c02666dd3cc6e9019a1ea1e27a83b9d665ec0ed1807dc13211f68f28ae7cfb055d6397708bb48f800dbc4
-  data.tar.gz: 0e2eea4faefae5734abec3251ef30b123e7daace9ec6e063b72c4bc37f0b6dff2cfbf44bd56b8c9b2614cafa53398ef4942e8395eebf66c957d88783f8e8ed1a
+  metadata.gz: e6845d867583203dff4cb9a2ec47ad5160e6b3bf8c0103dc051cedfdf2513faa1a634f6d9aec0509b851504fae2c9526e5c1691d144dde660224276a7739a2d8
+  data.tar.gz: ffb61a38782191dc7f37feb31b3dccc70561e94a2f57e1a105cd7a712b433934e2284b065dcfb890e9e68e61629520d999b9e30725a186eb9a2a4f5933cafd4a

data/lib/hockey_orgs/cli.rb

@@ -3,13 +3,14 @@ class Cli
 
     def call
         Scraper.create_orgs
+        Cli.hello
         Scraper.list_orgs
         Cli.org_menu
     end
 
     def self.org_menu #top level menu, choose an
         puts ""
-        puts "Enter the number of the team you would like to learn about(type exit to quit)"
+        puts "Enter the number of the team you would like to learn about, or type exit to quit:"
         input = gets.chomp
         @i = input.to_i - 1
         if input.downcase == 'exit'
@@ -17,6 +18,10 @@ class Cli
         elsif @i < 0 or @i >= 31
             puts ""
             puts "invalid input"
+            sleep(1.2)
+            puts ""
+            Scraper.list_orgs
+            self.org_menu
         else 
             puts ""
             self.org_options(@i)
@@ -26,20 +31,19 @@ class Cli
     def self.org_options(i) #provide options for learning about the organization
         name = Org.all[@i].name 
         puts "What would you like to know about the #{name}?(type exit to return to team selection)"
+        puts ''
         puts "1. Arena Name 2. Year of founding 3. What division do they play in?"
         self.org_choice
-        
     end 
     
     def self.same_founding(input) #check if other teams were founded the same year
         teams = []
         arr = []
-        puts "Would you like to see all other teams founded that year?(please type y or n)"
+        puts "Would you like to see all other teams founded that year?(please type Y or N)"
         input = gets.chomp.downcase
         case input 
         when 'y'
             Org.all.each do |o|
-                #binding.pry
                 if o.founding == Org.all[@i].founding && o.name != Org.all[@i].name
                     arr << o.name
                 end
@@ -47,41 +51,52 @@ class Cli
             if arr.size > 0 
                 puts arr
             else
-                puts "The #{Org.all[@i].name} were the only team founded that year"
+                #binding.pry
+                puts "The #{Org.all[@i].name} were the only team founded in #{Org.all[@i].founding}" 
             end
+            self.more_info
         when 'n'
-            self.org_options(@i)
+            self.more_info
         else 
-            "Please type Y or N"
+            puts ""
+            puts "Invalid input"
+            puts ""
+            self.same_founding(@i)
         end
+        
     end
     
     def self.org_choice
         choice = gets.chomp 
-        if choice == "exit"
+        case choice 
+        when "exit"
             puts "" 
             puts "returning you to main menu"
             Scraper.list_orgs
             Cli.org_menu
-        elsif choice == '1'
-            puts ""
+        when '1'
             Org.get_arena(@i)
-            self.more_org_options
-        elsif choice == '2'
             puts ""
+            self.more_info
+        when '2'
             Org.get_founding(@i)
+            sleep(0.8)
             self.same_founding(@i)
-            self.more_org_options
-        elsif choice == '3'
-            puts ""
+        when '3'
             Org.get_division(@i)
-            self.more_org_options
+            puts ""
+            self.more_info
+        else 
+            #binding.pry
+            puts ""
+            puts "Invalid input"
+            puts ""
+            self.org_options(@i)
         end
-       
     end
 
-    def self.more_org_options
-        puts "Would you like more info on The #{Org.all[@i].name}?(Please enter y or n)"
+    def self.more_info
+        puts "Would you like more info on The #{Org.all[@i].name}?(Please type Y or N)"
         input = gets.chomp
             case input 
             when 'y'
@@ -90,12 +105,18 @@ class Cli
                 Scraper.list_orgs
                 self.org_menu
             else 
-                puts "Invalid input! Please enter y or n"
-                self.more_org_options
+                puts "Invalid input! Please type Y or N"
+                self.more_info
             end
         
     end
 
+    def self.hello 
+        puts "Hello and welcome to Hockey Orgs! Below you will find a list of all active NHL franchises:"
+        
+        puts " "
+    end
+
     def self.goodbye 
         puts ""
         puts "Thank you for your interest in the NHL, it was an honor to serve you." 

data/lib/hockey_orgs/org.rb

@@ -18,22 +18,15 @@ class Org
         @@all
     end
 
-    def self.get_arena(input)
-        #binding.pry
-        puts "The #{self.all[input].name} play at the #{self.all[input].stadium} in #{@@all[input].city}."
+    def self.get_arena(input) #these are pretty straight forward i like to think
+        puts "The #{@@all[input].name} play at the #{@@all[input].stadium} in #{@@all[input].city}."
     end
 
     def self.get_founding(input)
-        puts "The #{self.all[input].name} were founded in #{self.all[input].founding}."
+        puts "The #{@@all[input].name} were founded in #{@@all[input].founding}."
     end
 
     def self.get_division(input)
-        puts "The #{self.all[input].name} play in the #{self.all[input].division} Division."
+        puts "The #{@@all[input].name} play in the #{@@all[input].division} Division of the NHL."
     end
-
-    
-
-    
-
-    
 end

data/lib/hockey_orgs/scraper.rb

@@ -4,8 +4,7 @@ class Scraper
 
 
 
-    def self.create_orgs #instantiates the organizations
-        #binding.pry
+    def self.create_orgs #instantiates an "org" for every team in the NHL
         response = RestClient.get(URL)
         data = JSON.parse(response.body)["teams"]
         x = data.sort_by {|o| o["name"]}
@@ -14,10 +13,7 @@ class Scraper
         end
     end
 
-    def self.list_orgs  #numbered list of organizations for selection
-        puts "Hello and welcome to Hockey Orgs! Below you will find a list of all active NHL franchises:"
-        sleep(1)
-        puts " "
+    def self.list_orgs  #prints a numbered list of organizations for selection
         Org.all.each do |o| 
             #binding.pry
             puts "#{o.id}. #{o.name}"

data/lib/hockey_orgs/version.rb

@@ -1,3 +1,3 @@
 module HockeyOrgs
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

data/notes

@@ -49,3 +49,27 @@ the problems right now(order of importance)
 3. clean it up, check out seperation of concerns
 
 just needs to be done sunday night but tomorrow would be great
+
+alright i think we're done here 
+still need to check out seperation of concerns
+maybe move a method around here or there(class to class)
+
+1. get it up on github 
+2. make a video
+3. write a blog 
+4. schedule assessment 
+done 
+
+you messed up two things: 
+didn't screen record half an hour of coding 
+didn't use github like at all the way it was meant to be used and paid a price
+
+you did a few great things: 
+went above and beyond 
+worked through the bullshit(that was your own fault sometimes)
+you have never built a piece of software before and now, here is one
+
+OKAY FORGET ALL THAT OTHER STUFF 
+the organization sub-menu can't handle invalid inputs! fuck!
+OKAY FORGET THAT 
+it can do it now

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hockey_orgs
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Mike Wilder
@@ -85,6 +85,7 @@ files:
 - bin/hockey_orgs
 - bin/setup
 - hockey_orgs-0.1.0.gem
+- hockey_orgs-0.1.1.gem
 - hockey_orgs.gemspec
 - lib/.DS_Store
 - lib/hockey_orgs.rb