hn 0.0.7 → 0.0.8

data/lib/hn/parsers/entry_parser.rb

@@ -1,5 +1,6 @@
 require "nokogiri"
 require "open-uri"
+require "uri"
 require "chronic"
 
 module HackerNews
@@ -38,7 +39,7 @@ module HackerNews
     def parse_entry(trs, i)
       Entry.new do |entry|
         entry.link = trs[i*3].at_css('td.title a')['href']
-        entry.link = site_name + entry.link unless entry.link =~ /^https/
+        entry.link = URI.join(site_name, entry.link).to_s
 
         entry.title = trs[i*3].at_css('td.title a').text
 

data/lib/hn/version.rb

@@ -1,3 +1,3 @@
 module HackerNews
-  VERSION = "0.0.7"
+  VERSION = "0.0.8"
 end

data/spec/hn/parsers/entry_parser_spec.rb

@@ -18,7 +18,7 @@ module HackerNews
         entries.each do |entry|
           entry.id.should > 4000000
           entry.username.should =~ /\w+/
-          entry.link.should =~ /^https/
+          entry.link.should =~ /^http/
           entry.title.should_not be_empty
           entry.num_comments.should >= 0
           entry.site.should_not =~ /^https/
@@ -37,7 +37,7 @@ module HackerNews
         entries.each do |entry|
           entry.id.should > 4000000
           entry.username.should =~ /\w+/
-          entry.link.should =~ /^https/
+          entry.link.should =~ /^http/
 
           if entry.site.nil? # ASK HN
             entry.id.should == entry.link.match(/^https:\/\/news\.ycombinator\.com\/item\?id=(\d+)$/)[1].to_i
@@ -60,7 +60,7 @@ module HackerNews
         entries.each do |entry|
           entry.id.should > 4000000
           entry.username.should =~ /\w+/
-          entry.link.should =~ /^https/
+          entry.link.should =~ /^http/
 
           if entry.site.nil? # ASK HN
             entry.id.should == entry.link.match(/^https:\/\/news\.ycombinator\.com\/item\?id=(\d+)$/)[1].to_i

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hn
 version: !ruby/object:Gem::Version
-  version: 0.0.7
+  version: 0.0.8
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-03-24 00:00:00.000000000 Z
+date: 2013-04-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: !ruby/object:Gem::Requirement
+  requirement: &7288120 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,15 +21,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
+  version_requirements: *7288120
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: !ruby/object:Gem::Requirement
+  requirement: &7287680 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -37,15 +32,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
+  version_requirements: *7287680
 - !ruby/object:Gem::Dependency
   name: simplecov
-  requirement: !ruby/object:Gem::Requirement
+  requirement: &7349000 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -53,15 +43,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
+  version_requirements: *7349000
 - !ruby/object:Gem::Dependency
   name: fakeweb
-  requirement: !ruby/object:Gem::Requirement
+  requirement: &7348560 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -69,15 +54,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
+  version_requirements: *7348560
 - !ruby/object:Gem::Dependency
   name: nokogiri
-  requirement: !ruby/object:Gem::Requirement
+  requirement: &7348100 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -85,15 +65,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
+  version_requirements: *7348100
 - !ruby/object:Gem::Dependency
   name: chronic
-  requirement: !ruby/object:Gem::Requirement
+  requirement: &7347420 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -101,12 +76,7 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
+  version_requirements: *7347420
 description: A tiny gem to fetch Hacker News entries
 email:
 - afu@forresty.com
@@ -158,17 +128,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 1.8.11
 signing_key: 
 specification_version: 3
 summary: A tiny gem to fetch Hacker News entries
-test_files:
-- spec/fixtures/best.html
-- spec/fixtures/comments.html
-- spec/fixtures/home.html
-- spec/fixtures/newest.html
-- spec/hn/engine_spec.rb
-- spec/hn/models/entry_spec.rb
-- spec/hn/parsers/comment_parser_spec.rb
-- spec/hn/parsers/entry_parser_spec.rb
-- spec/spec_helper.rb
+test_files: []