hithorizons 0.4 → 0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ab6f7786aec6d14befefb0c7e4a7086b6eb0ce248c085cac2b7aebc915058cb6
-  data.tar.gz: 47c0fefec0cf906d4bad345e2befeb6060278c15e7c5bd132220f8004b43401c
+  metadata.gz: 0b2a3fdd9358b75537051add7674e7ed684ecaac7c450609c40a02d1cb6b1f96
+  data.tar.gz: 200ba0a9e296e71db76386bdcd3743ea31705efb5157d1eccb026b474246e50b
 SHA512:
-  metadata.gz: b86030d927a6f4733e1548655cdf066c550b56c820691785db60eed26b7ca9e7fc8900ab45a2a66ce90ebaa530759016bddc97fd0c9480289271c244a56311f8
-  data.tar.gz: dc2473e954c543b6f13b1bff27e7323d6ae7ececee12b6c1db116b14fe945e2c6f698ba4ca00ce63071e19eadc2f06468554381ace90f8af3763424a5fcf025d
+  metadata.gz: d5d94eaec4dcc218bed43470719ed78d0cb669756b2c6074a108d70b780797917204629901d68d2caa4eea80158bc891c82b214f50df66b3b122a29184bcaf0d
+  data.tar.gz: e5ec04de3143846cb682b55098124ca4013902b15b601605e6d2aa5a3a3105830cca01cf897e3f9105b70c8270e24b28b9dfd90bc6415a13af3218ea0dbb7b44

data/.rubocop.yml

@@ -8,6 +8,7 @@ AllCops:
   Exclude:
     - 'bin/*'
     - 'tmp/**/*'
+    - 'spec/**/*'
 
 Layout/LineLength:
   Max: 150

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    hithorizons (0.4)
+    hithorizons (0.5)
       faraday (~> 1)
       faraday_middleware (~> 1)
 
@@ -60,8 +60,9 @@ GEM
       unicode-display_width (>= 1.4.0, < 2.0)
     rubocop-ast (1.4.0)
       parser (>= 2.7.1.5)
-    rubocop-rspec (1.42.0)
-      rubocop (>= 0.87.0)
+    rubocop-rspec (2.1.0)
+      rubocop (~> 1.0)
+      rubocop-ast (>= 1.1.0)
     ruby-progressbar (1.11.0)
     ruby2_keywords (0.0.2)
     simplecov (0.21.1)
@@ -85,7 +86,7 @@ DEPENDENCIES
   rake (~> 13.0)
   rspec (~> 3.6)
   rubocop (~> 1.7)
-  rubocop-rspec (~> 1.42)
+  rubocop-rspec (~> 2)
   simplecov (~> 0.21)
   webmock (~> 3.11.0)
 

data/bin/console

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'bundler/setup'
 require 'hithorizons'

data/changelog.md

@@ -14,3 +14,6 @@ Response object fix
 
 ## 0.4
 Helpers, readme
+
+## 0.5
+Better countries API

data/hithorizons.gemspec

@@ -34,7 +34,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rake', '~> 13.0'
   spec.add_development_dependency 'rspec', '~> 3.6'
   spec.add_development_dependency 'rubocop', '~> 1.7'
-  spec.add_development_dependency 'rubocop-rspec', '~> 1.42'
+  spec.add_development_dependency 'rubocop-rspec', '~> 2'
   spec.add_development_dependency 'simplecov', '~> 0.21'
   spec.add_development_dependency 'webmock', '~> 3.11.0'
 end

data/lib/hithorizons.rb

@@ -6,6 +6,7 @@ require 'faraday_middleware'
 require 'hithorizons/version'
 require 'hithorizons/configuration'
 require 'hithorizons/company'
+require 'hithorizons/country'
 require 'hithorizons/countries'
 require 'hithorizons/company_types'
 require 'hithorizons/industry_types'

data/lib/hithorizons/countries.rb

@@ -2,71 +2,71 @@
 
 module Hithorizons
   class Countries
-    MAPPING = {
-      ALB: 'ALBANIA',
-      AND: 'ANDORRA',
-      ARM: 'ARMENIA',
-      AUS: 'AUSTRIA',
-      AZE: 'AZERBAIJAN',
-      BLR: 'BELARUS',
-      BEL: 'BELGIUM',
-      BIH: 'BOSNIA AND HERZEGOVINA',
-      BGR: 'BULGARIA',
-      HRV: 'CROATIA',
-      CYP: 'CYPRUS',
-      CZE: 'CZECH REPUBLIC',
-      DNK: 'DENMARK',
-      GBR: 'ENGLAND',
-      EST: 'ESTONIA',
-      FRO: 'FAROE ISLANDS',
-      FIN: 'FINLAND',
-      FRA: 'FRANCE',
-      GEO: 'GEORGIA',
-      DEU: 'GERMANY',
-      GIB: 'GIBRALTAR',
-      GRC: 'GREECE',
-      GRL: 'GREENLAND',
-      HUN: 'HUNGARY',
-      ISL: 'ICELAND',
-      ITA: 'ITALY',
-      KAZ: 'KAZAKHSTAN',
-      XKX: 'KOSOVO',
-      KGZ: 'KYRGYZSTAN',
-      LVA: 'LATVIA',
-      LIE: 'LIECHTENSTEIN',
-      LTU: 'LITHUANIA',
-      LUX: 'LUXEMBOURG',
-      MKD: 'MACEDONIA',
-      MLT: 'MALTA',
-      MDA: 'MOLDOVA',
-      MCO: 'MONACO',
-      MNE: 'MONTENEGRO',
-      NLD: 'NETHERLANDS',
-      NOR: 'NORWAY',
-      POL: 'POLAND',
-      PRT: 'PORTUGAL',
-      ROU: 'ROMANIA',
-      RUS: 'RUSSIAN FEDERATION',
-      SMR: 'SAN MARINO',
-      SRB: 'SERBIA',
-      SVK: 'SLOVAKIA',
-      SVN: 'SLOVENIA',
-      ESP: 'SPAIN',
-      SWE: 'SWEDEN',
-      CHE: 'SWITZERLAND',
-      TJK: 'TAJIKISTAN',
-      TUR: 'TURKEY',
-      TKM: 'TURKMENISTAN',
-      UKR: 'UKRAINE',
-      UZB: 'UZBEKISTAN',
-    }.freeze
+    LIST = [
+      ['ALB', 'ALBANIA', true],
+      ['AND', 'ANDORRA', true],
+      ['ARM', 'ARMENIA', true],
+      ['AUS', 'AUSTRIA', false],
+      ['AZE', 'AZERBAIJAN', true],
+      ['BLR', 'BELARUS', true],
+      ['BEL', 'BELGIUM', true],
+      ['BIH', 'BOSNIA AND HERZEGOVINA', true],
+      ['BGR', 'BULGARIA', true],
+      ['HRV', 'CROATIA', true],
+      ['CYP', 'CYPRUS', false],
+      ['CZE', 'CZECH REPUBLIC', true],
+      ['DNK', 'DENMARK', true],
+      ['GBR', 'ENGLAND', false],
+      ['EST', 'ESTONIA', false],
+      ['FRO', 'FAROE ISLANDS', true],
+      ['FIN', 'FINLAND', true],
+      ['FRA', 'FRANCE', false],
+      ['GEO', 'GEORGIA', true],
+      ['DEU', 'GERMANY', false],
+      ['GIB', 'GIBRALTAR', true],
+      ['GRC', 'GREECE', true],
+      ['GRL', 'GREENLAND', true],
+      ['HUN', 'HUNGARY', false],
+      ['ISL', 'ICELAND', true],
+      ['ITA', 'ITALY', true],
+      ['KAZ', 'KAZAKHSTAN', true],
+      ['XKX', 'KOSOVO', true],
+      ['KGZ', 'KYRGYZSTAN', true],
+      ['LVA', 'LATVIA', false],
+      ['LIE', 'LIECHTENSTEIN', false],
+      ['LTU', 'LITHUANIA', true],
+      ['LUX', 'LUXEMBOURG', false],
+      ['MKD', 'MACEDONIA', true],
+      ['MLT', 'MALTA', false],
+      ['MDA', 'MOLDOVA', true],
+      ['MCO', 'MONACO', true],
+      ['MNE', 'MONTENEGRO', true],
+      ['NLD', 'NETHERLANDS', false],
+      ['NOR', 'NORWAY', true],
+      ['POL', 'POLAND', true],
+      ['PRT', 'PORTUGAL', true],
+      ['ROU', 'ROMANIA', false],
+      ['RUS', 'RUSSIAN FEDERATION', true],
+      ['SMR', 'SAN MARINO', true],
+      ['SRB', 'SERBIA', true],
+      ['SVK', 'SLOVAKIA', true],
+      ['SVN', 'SLOVENIA', false],
+      ['ESP', 'SPAIN', true],
+      ['SWE', 'SWEDEN', false],
+      ['CHE', 'SWITZERLAND', true],
+      ['TJK', 'TAJIKISTAN', true],
+      ['TUR', 'TURKEY', true],
+      ['TKM', 'TURKMENISTAN', true],
+      ['UKR', 'UKRAINE', true],
+      ['UZB', 'UZBEKISTAN', true],
+    ].map { |country| Country.new(*country) }
 
     def self.find_by_iso3(iso3)
-      MAPPING[iso3.upcase.to_sym] if iso3
+      LIST.find { |country| country.iso3 == iso3 }
     end
 
-    def self.iso3_by_country(country)
-      MAPPING.invert[country]
+    def self.find_by_name(country_name)
+      LIST.find { |country| country.name == country_name }
     end
   end
 end

data/lib/hithorizons/country.rb

@@ -0,0 +1,45 @@
+# frozen_string_literal: true
+
+module Hithorizons
+  class Country
+    attr_reader :iso3, :name
+
+    def initialize(iso3, name, registration_number)
+      @iso3 = iso3
+      @name = name
+      @registration_number = registration_number
+    end
+
+    def vat_id?
+      !@registration_number
+    end
+
+    def registration_number?
+      @registration_number
+    end
+
+    def vat_id(company)
+      return unless vat_id?
+
+      case iso3
+      when 'HUN'
+        "HU#{company['NationalId'][0...-3]}"
+      when 'ROU'
+        "RO#{company['NationalId']}"
+      else
+        company['NationalId']
+      end
+    end
+
+    def tax_id(company)
+      case iso3
+      when 'HUN', 'ROU'
+        company['NationalId']
+      end
+    end
+
+    def registration_number(company)
+      @registration_number ? company['NationalId'] : nil
+    end
+  end
+end

data/lib/hithorizons/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Hithorizons
-  VERSION = '0.4'
+  VERSION = '0.5'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hithorizons
 version: !ruby/object:Gem::Version
-  version: '0.4'
+  version: '0.5'
 platform: ruby
 authors:
 - Lubomir Vnenk
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-01-06 00:00:00.000000000 Z
+date: 2021-01-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -100,14 +100,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.42'
+        version: '2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.42'
+        version: '2'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -166,6 +166,7 @@ files:
 - lib/hithorizons/company_types.rb
 - lib/hithorizons/configuration.rb
 - lib/hithorizons/countries.rb
+- lib/hithorizons/country.rb
 - lib/hithorizons/industry_types.rb
 - lib/hithorizons/version.rb
 homepage: https://github.com/lubosch/hithorizons