hitch 1.0.3 → 1.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 721084c4633f44e81525934e2735712a2fceec8c
-  data.tar.gz: 051501fead1542702313d084357f11e0772713c4
+  metadata.gz: e31466745b18c78b3065e2ce0fb9ef2ac902f1fe
+  data.tar.gz: 161bd434fdcd957688805804e6a8d2b64498e96e
 SHA512:
-  metadata.gz: 551fdf140bea3acd13681fcb2821932bebfe1b784b9b869b4c6adf4fc4b1984a2d7c0d02795a3e2ae83102dc7f817a385846a13dca69de1db2df1f3c1242b117
-  data.tar.gz: cde32aaf43b1471c7692d9e3a88f1852e4e092da01044480f8bdc9c6425fb49974baf5ab6e054091115d5adf9360fe35bbb2de4f967e94088ce59dbf0dd788a2
+  metadata.gz: b1fbfe1d1ec0f90441f444ae85f66d7fe2e595841258dcdec552ddb7c45373213df446020996a95f5ac7f533718acf349b07933a11c8f7f433d59cc1888f84e5
+  data.tar.gz: 348ad63679b1173ff0a0418b091d666deca5efe9fdf3019ed64e4f43c5c7c9efe70077a0348233691560e30af386cdabba3a2eeaceebb9bb456aae68dd155b61

data/hitch.gemspec

@@ -4,8 +4,9 @@ Gem::Specification.new do |s|
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.rubygems_version = '1.3.5'
 
+  s.license = "MIT"
   s.name = %q{hitch}
-  s.version = '1.0.3'
+  s.version = '1.0.4'
   s.date = Time.now.strftime('%F')
 
   s.description = %q{Git author attribution helper for pair programmers.}

data/lib/hitch.rb

@@ -6,7 +6,7 @@ require File.expand_path(File.join(File.dirname(__FILE__), %w[.. lib hitch ui]))
 
 module Hitch
 
-  VERSION = '1.0.3'
+  VERSION = '1.0.4'
 
   def self.print_info
     if Hitch.pairing? && STDOUT.tty?

data/lib/hitch/ui.rb

@@ -6,7 +6,7 @@ module Hitch
     def self.prompt_for_group_email
       Hitch.group_email = highline.ask("What is the group email? e.g. dev@hashrocket.com will become dev+therubymug+leshill@hashrocket.com") do |q|
         q.case = :down
-        q.validate = /\A[a-zA-Z0-9_\.\-]+@[a-zA-Z0-9\-]+\.[a-zA-Z0-9\-\.]+\z/
+        q.validate = /\A[a-zA-Z0-9_\.\-\+]+@[a-zA-Z1-9\-]+\.[a-zA-Z0-9\-\.]+\z/
       end.to_s
     end
 

data/spec/hitch/ui_spec.rb

@@ -4,20 +4,40 @@ describe Hitch::UI do
 
   describe '.prompt_for_group_email' do
 
+    let(:question_message) { "What is the group email? e.g. dev@hashrocket.com will become dev+therubymug+leshill@hashrocket.com" }
+
     it 'prompts for group email' do
-      Hitch::UI.highline.should_receive(:ask).with("What is the group email? e.g. dev@hashrocket.com will become dev+therubymug+leshill@hashrocket.com")
+      Hitch::UI.highline.should_receive(:ask).with(question_message)
       Hitch::UI.prompt_for_group_email
     end
 
     it 'returns the given group email' do
-      Hitch::UI.highline.stub(:ask).with("What is the group email? e.g. dev@hashrocket.com will become dev+therubymug+leshill@hashrocket.com").and_return('dev@hashrocket.com')
+      Hitch::UI.highline.stub(:ask).with(question_message).and_return('dev@hashrocket.com')
       Hitch::UI.prompt_for_group_email.should == 'dev@hashrocket.com'
     end
 
-    it 'sets Hitch.group_email' do
-      Hitch.should_receive('group_email=').with('dev@hashrocket.com')
-      Hitch::UI.highline.stub(:ask).with("What is the group email? e.g. dev@hashrocket.com will become dev+therubymug+leshill@hashrocket.com").and_return('dev@hashrocket.com')
-      Hitch::UI.prompt_for_group_email
+    context 'when group email contains a `+` in it' do
+      let(:group_email) { 'dev+hitch@hashrocket.com' }
+      it 'sets Hitch.group_email' do
+        question = double({:case= => nil, :validate= => nil})
+        question.should_receive(:case=).with(:down)
+        question.should_receive(:validate=).with(/\A[a-zA-Z0-9_\.\-\+]+@[a-zA-Z1-9\-]+\.[a-zA-Z0-9\-\.]+\z/)
+        Hitch.should_receive('group_email=').with(group_email)
+        Hitch::UI.highline.stub(:ask).with(question_message).and_yield(question).and_return(group_email)
+        Hitch::UI.prompt_for_group_email
+      end
+    end
+
+    context 'when group email does not contain a `+` in it' do
+      let(:group_email) { 'dev@hashrocket.com' }
+      it 'sets Hitch.group_email' do
+        question = double({:case= => nil, :validate= => nil})
+        question.should_receive(:case=).with(:down)
+        question.should_receive(:validate=).with(/\A[a-zA-Z0-9_\.\-\+]+@[a-zA-Z1-9\-]+\.[a-zA-Z0-9\-\.]+\z/)
+        Hitch.should_receive('group_email=').with(group_email)
+        Hitch::UI.highline.stub(:ask).with(question_message).and_yield(question).and_return(group_email)
+        Hitch::UI.prompt_for_group_email
+      end
     end
 
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hitch
 version: !ruby/object:Gem::Version
-  version: 1.0.3
+  version: 1.0.4
 platform: ruby
 authors:
 - Rogelio J. Samour
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-12 00:00:00.000000000 Z
+date: 2015-10-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -65,7 +65,8 @@ files:
 - spec/hitch_spec.rb
 - spec/spec_helper.rb
 homepage: http://github.com/therubymug/hitch
-licenses: []
+licenses:
+- MIT
 metadata: {}
 post_install_message: 
 rdoc_options: