historyable 0.1.2 → 0.2.0

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    YTk1ODJjMGVlYmQ3YzJmYWFjNzU2MjQ2YzM5MDRiMGJmOGZlZThkYQ==
+    NzU1M2JlMTY5YjkyMjUyMmI1NTVmZDgwNTA1NDY5MmViYTQ2YjJiOA==
   data.tar.gz: !binary |-
-    OGY2N2QzYzhkMWZkOTZjNTlhNGMyOTY3YTFkODc3ZGFlMjk3ZjdiYQ==
+    MGEyNzQyY2JlMWMyMzU3NTI0NGJkNTVhMTNiNmU2MzAxYzA2M2IxMw==
 SHA512:
   metadata.gz: !binary |-
-    YmFhNjhlMTY1YjFlNGI1ZjhiMTA1NjRjMmExZjYzYTlkNmM5Mjc5OTI2MTM5
-    YjY1OGExNDcyMTUxMWM1YjdiYmYyNzg4Y2RmM2IzNDM3MmQxZTllYzFiOTk4
-    ZDZiMGU4OGNjMGVhOGZkNThmZDYwZjE0NTg1YjhkNTQwZjc0YTQ=
+    ZjU4NmFmMGVjODIyYWI1YTNjYTRiZDA4OWI0NDBhZTkzNjFjZTNlMWVmOTM5
+    ZjY5MTY0Zjc3M2U3MDdjMjg3OGRhYmMzZjNmY2VjMzdiODllY2IzMzcwYzI2
+    N2E3NWE3ZTM2NjQ3OGQ4OTJiMWEwZDljZDRlMDViMWM1ZTkwYTE=
   data.tar.gz: !binary |-
-    NGE5OWQ4NzI3Y2RiODg3YmZkNDM0NTkzY2Y4NTUwNDJjNGZmYTU5MzRjZTk0
-    OTc0OTUyMGQyYmZjZmRkMGQ5NzI3MzZkMGEwOGM3M2Q3M2Y2MzAzODAwOWFh
-    YmJlYzYxMWUyMGU1NDU3ZDE4MzhmYWYzOWQxMjM2N2JhMzI1NWM=
+    MzUyZjJmNmYwMGI4NmVhZmVmMGEzODVmYTNlZTM5N2JkYjE5ZDM4Y2JjMTUx
+    YTU5MGIxYjgxZmQ5ZmM0OTc3ZTZkNTY3YjQzZDkzOGJhOWFlNWE0OGUwYWEy
+    NGQyZGUyMmMxYTkwNmNlNGQzODI4NDg2YmQ2M2Q1YzRiMjNlMDA=

data.tar.gz.sig

@@ -1,3 +1,2 @@
-E:�]�a�]s�b�4����-H�����D0���&Å-��
-���h�C�v�I��[M^Nr��;�ڵ%S�~��NGGaQ�K�
-ƙ
+a�~�rk`��C�W�;�}{��N�w����3*f�Dz��*��7��ZH�m_7{wn,�t�#ut��zӬ��X�dq��y�J������g��h��U��������µ4"wL�3��t�ƿ���jq�߸+��6��A�������ѻ����ZΜ����J
+;�

data/lib/historyable.rb

@@ -4,24 +4,28 @@ require 'active_record'
 require 'historyable/change'
 
 module Historyable
-  Item = Struct.new(:attribute_name, :association_name)
-
   extend ActiveSupport::Concern
 
+  Item = Struct.new(:attribute_name, :association_name)
+
   included do
-    class_attribute :historyable_items, instance_writer: false
+    class_attribute :historyable_items, :historyable_cache, instance_writer: false
   end
 
 
   module ClassMethods
 
+    # Define
+    #
+    #
     # @param attributes [Array, Symbol]
     def has_history(*attributes)
+      self.historyable_cache = ActiveSupport::Cache::MemoryStore.new
       self.historyable_items = attributes.map do |attribute|
         attribute_name   = attribute.to_sym
         association_name = attribute.to_s.insert(-1, '_changes').to_sym
 
-        Historyable::Item.new(attribute_name, association_name)
+        Item.new(attribute_name, association_name)
       end
 
       # Associations
@@ -58,7 +62,7 @@ module Historyable
         send(historyable.association_name)
           .where(object_attribute: historyable.attribute_name)
           .order('created_at DESC')
-          .select(:object_attribute_value, :created_at)
+          .select([:object_attribute_value, :created_at])
       end
     end
 
@@ -71,24 +75,19 @@ module Historyable
     # @return [Array]
     def define_historyable_attribute_history(historyable)
       define_method("#{historyable.attribute_name.to_s}_history") do
-        unless instance_variable_get("@#{historyable.attribute_name.to_s}_history".to_sym)
+        historyable_cache.fetch(historyable.attribute_name) do
           collection = []
 
           records = send("#{historyable.attribute_name}_history_raw")
-                       .pluck(:object_attribute_value, :created_at)
-          records.map do |attribute_value, created_at|
+          records.each do |record|
             item = HashWithIndifferentAccess.new
-            item[:attribute_value] = attribute_value
-            item[:changed_at]      = created_at
+            item[:attribute_value] = record.object_attribute_value
+            item[:changed_at]      = record.created_at
 
             collection << item
           end
 
-          # Sets attribute_history cache
-          instance_variable_set("@#{historyable.attribute_name.to_s}_history".to_sym, collection)
           collection
-        else
-          instance_variable_get("@#{historyable.attribute_name.to_s}_history".to_sym)
         end
       end
     end
@@ -122,7 +121,7 @@ module Historyable
       send(historyable.association_name).create(object_attribute: historyable.attribute_name,
                                                 object_attribute_value: send(historyable.attribute_name))
       # Expires attribute_history cache
-      instance_variable_set("@#{historyable.attribute_name.to_s}_history".to_sym, nil)
+      historyable_cache.delete(historyable.attribute_name)
     end
 
     true

data/lib/historyable/version.rb

@@ -1,3 +1,3 @@
 module Historyable
-  VERSION = "0.1.2"
+  VERSION = "0.2.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: historyable
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.2.0
 platform: ruby
 authors:
 - Philippe Dionne
@@ -45,85 +45,29 @@ dependencies:
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: 3.2.14
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: 3.2.14
   type: :runtime
   prerelease: false
   name: activerecord
-- !ruby/object:Gem::Dependency
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '1.3'
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '1.3'
-  type: :development
-  prerelease: false
-  name: bundler
-- !ruby/object:Gem::Dependency
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  name: rake
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.2.14
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  name: rspec
-- !ruby/object:Gem::Dependency
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  name: sqlite3
-- !ruby/object:Gem::Dependency
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
+        version: 3.2.14
+  type: :runtime
   prerelease: false
-  name: database_cleaner
+  name: activesupport
 description: A simple and solid concern to track ActiveRecord models attributes changes.
 email:
 - philippe.dionne@hooktstudios.com

metadata.gz.sig

@@ -1,4 +1 @@
-��wV!!k��D)�N�ɣ@�p3�\U��W���JW�����`�e5�F���|"���#w�
-��_�1���sNO���VdK�*�b(#�('J�ٙ��M�<�qa��:�(�Cd;n��P���W�)Ǚܔ"a���=I�I�:vRt`a��3
-7u�O����u���=�I�KA�BKc)(�>.�c~xz�䒛؅8�u��j���,pLQU2�&��g��E{�E�y����k?�o�
-"^�lYCa�.�'M��ݰ�
+��|I;Z�