historiographer 1.4.0 → 1.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e2c323e0b16003b066c298e281147b86e810ee0f2b7cc5bc859bfad1c861795b
-  data.tar.gz: 04b81492d7a2a24a8aa46935f64874f77521884dec9cd9aa2fd568785b399847
+  metadata.gz: cb038b8ee2ab30ab82ee72f3191328bf6dfbd895f1052d7023e75ccc4beb7189
+  data.tar.gz: 73e36c7f2576b916666ca4ecf43e8041f098faf6e0a8ed003db37f78b1515e48
 SHA512:
-  metadata.gz: 8716822fb73b440fedb427ea732d87e15a4ffb4bc3ca902bfa57e4cbf5e9303fbc6a25482eadcbc9d00830eede9664685db8d05b05438a5fe08c32fa79c8e3ee
-  data.tar.gz: 86ce1d84a483a5384aea9e0d043911edc0f1cb3f3bf6f970d1dccee22d3369a2ef6437f65e2de6e46f9df4ec68a76b189411805ba98cca4874b39513c1162b69
+  metadata.gz: 06b64598ac55f5c011f3e58bca504eaf270430b913e2eb00e74234d19b6601aeed4f4de75463d15a74e979effb3dcc0062f26273f46e021145a21eb9c7357ac9
+  data.tar.gz: c619f5a42db6e3fc8521445ed8c0d8517ce211591ffe440fdd08507e776b0e45b9dbbfa5962f11073c68bdad26a33593c538f4817ee2e2b48dd494eb5f162403

data/VERSION

@@ -1 +1 @@
-1.4.0
+1.4.1

data/historiographer.gemspec

@@ -2,11 +2,11 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: historiographer 1.4.0 ruby lib
+# stub: historiographer 1.4.1 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "historiographer".freeze
-  s.version = "1.4.0"
+  s.version = "1.4.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]

data/lib/historiographer.rb

@@ -91,7 +91,9 @@ module Historiographer
     end
 
     alias_method :destroy_without_history, :destroy
-    def destroy_with_history(history_user_id: )
+    def destroy_with_history(history_user_id: nil)
+      history_user_absent_action if history_user_id.nil?
+
       current_history = histories.where(history_ended_at: nil).order("id desc").limit(1).last
       current_history.update!(history_ended_at: UTC.now) if current_history.present?
 

data/spec/historiographer_spec.rb

@@ -10,6 +10,7 @@ end
 
 class SafePost < ActiveRecord::Base
   include Historiographer::Safe
+  acts_as_paranoid
 end
 
 class SafePostHistory < ActiveRecord::Base
@@ -445,6 +446,30 @@ describe Historiographer do
       expect(PostHistory.where.not(deleted_at: nil).count).to eq 1
       expect(PostHistory.last.history_user_id).to eq 2
     end
+
+    it "works with Historiographer::Safe" do
+      post = SafePost.create(title: "HELLO", body: "YO", author_id: 1)
+
+      expect {
+        post.destroy
+      }.to_not raise_error
+
+      expect(SafePost.count).to eq 0
+      expect(post.deleted_at).to_not be_nil
+      expect(SafePostHistory.count).to eq 2
+      expect(SafePostHistory.current.last.deleted_at).to eq post.deleted_at
+
+      post2 = SafePost.create(title: "HELLO", body: "YO", author_id: 1)
+
+      expect {
+        post2.destroy!
+      }.to_not raise_error
+
+      expect(SafePost.count).to eq 0
+      expect(post2.deleted_at).to_not be_nil
+      expect(SafePostHistory.count).to eq 4
+      expect(SafePostHistory.current.where(safe_post_id: post2.id).last.deleted_at).to eq post2.deleted_at
+    end
   end
 
   describe "Scopes" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: historiographer
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.4.1
 platform: ruby
 authors:
 - brettshollenberger